For unit test we need to break every dependency to the TextEditor
Widget etc.. With an abstract interface we can implement it in clang
without relying on unwanted dependencies. It makes it also easier to
compute the values deferred.
Change-Id: I1b313a1625f4e80bd324ab4bf1a7c4f6b690abe9
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>
Output a proper usage message instead of a cryptic "wrong argument
count" when launching it from the shell for testing.
Change-Id: Iedb6b1062c9d246a514aefb05220942e4a6341df
Reviewed-by: Marco Bubke <marco.bubke@theqtcompany.com>
...by explicitly checking for the dot in the source.
Task-number: QTCREATORBUG-15654
Change-Id: I4172e88a7fbb3015ef391daf13ded1f0002aab9c
Reviewed-by: Marco Bubke <marco.bubke@theqtcompany.com>
This simplifies UnsavedFiles and makes TemporaryModifiedUnsavedFiles
useless.
Change-Id: I1896f971215ed22ce7aa7bf21b16381862b7469d
Reviewed-by: Marco Bubke <marco.bubke@theqtcompany.com>
Check the standard installation location of the Microsoft
Visual C C++ Build Tools introduced with MSVC2015 for the
presence of the bat file and add the toolchains.
Change-Id: Ia2b7770ed50c51132c88330ff1448900b0b06c1e
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
The one in the base class is completely sufficient.
Change-Id: I6e39ef856fb73377318df28e373f27d0a1c2c977
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
This also removes caching from parser and the respective test info
files are gone now as well.
Change-Id: Ibcea68e446dea532d6addd2f16863738e497bca4
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>
Actually they are not used, this is a preparation for later patches.
Change-Id: I25f43dd7dba06068ca9e39ccd4153361a7746304
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>
This duplicates (temporarily) the information for referencing files,
but the cache inside the parser will be removed within a later patch.
Change-Id: I7377864547f0d9ce074fa409b9c12067c4329d40
Reviewed-by: Niels Weber <niels.weber@theqtcompany.com>
We only need the referencing file in some cases.
First step for refactoring the code parser and the test tree model.
Change-Id: I713212461e4992863ef11a0a634c5d8d786a72a9
Reviewed-by: Niels Weber <niels.weber@theqtcompany.com>
It has the wrong path, doesn't work at all...
Change-Id: I28a5fbb599e4b2c696898ca0260102e3f69ed92a
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>
This is covered now be the debuggee member.
Change-Id: Id2983e2b8d74236249263fdd4b867bd310bf20cc
Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>
Lots of stuff is still horribly broken due to the weird confusion
between local/remote and "has project"/"does not have project" that
crept in at some point, but this at least makes remote, project-specific
memcheck work again.
Still broken:
- Remote callgrind
- All remote valgrinds for external projects.
- Local remote valgrind is not even available (anymore), as
the respective menu entries have disappeared at some point.
Change-Id: Iae6b60a0508d1b1b64fd0e0e5f776ea2c2e23598
Reviewed-by: hjk <hjk@theqtcompany.com>
Sprinkle overrides over code derived from classes in ProjectExplorer
Change-Id: Ia4cc25649f7dc00b0ea126d8176a59afbc5ed574
Reviewed-by: hjk <hjk@theqtcompany.com>
Using the AndroidRunnable is easy for other plugins to run custom adb
commands before intent is started and after it's stopped.
Change-Id: I012ae87c92cea16aa8074dce2dc6f2b0c4ebeb30
Reviewed-by: hjk <hjk@theqtcompany.com>
If the current instance of Creator is crashing, it might not be a good idea to
use it for debugging...
Change-Id: I4c28b3960c0722184fc92a6d20fbff8badb1fea3
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>
deleteLater schedules the event in the current thread, so we
may not use it directly on a thread from within the thread itself...
Instead connect the threads finished signal to its deleteLater slot.
To avoid problems if runAsync is not run from the main thread,
move the thread to the main thread before starting it.
Task-number: QTCREATORBUG-15688
Change-Id: Iea003d00c58d1f921fb0b4ddf9cf67dcb1379833
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
These re-implementations are conceptually "too specific". Rather let
the indiviual tools handle there expectations themselves.
Change-Id: I0bbea407b2241816a40d19eb1dbb0a7589cbda7b
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
...if possible. If passing tests had output beside the result
it had been omitted so far.
Change-Id: I37fd14714d00fe6a28f079f3fe2ca6e82606fa31
Reviewed-by: Niels Weber <niels.weber@theqtcompany.com>
The TextEditor settings do not remember a global Color Scheme setting,
anymore, but rather a Color Scheme ber Theme. A .creatortheme can define
a default TextEditor Color Scheme (overridable in the settings). This
makes switching of schemes more pleasant.
Taks-number: QTCREATORBUG-15229
Change-Id: I3bd36a4dfa23feea2254be2df50fce064e8fe2af
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@theqtcompany.com>
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>
No worries, this is not supposed to stay as default. I just enabled falt
icons in the default theme in order to get feedback about technical
issues as-well as comments about the look-and-feel. Send feedback to the
patch author's email.
The plan so far is to revert this mid-February, and just have flat mode
icons enabled for some alternative themes.
Change-Id: I371f4ede432597ad7f1bc4b9ae661c9f2bc8df3e
Reviewed-by: Alessandro Portale <alessandro.portale@theqtcompany.com>
Timers/singleShot etc can only be used in QThreads (they require the
event dispatcher). So we have to use QThreads instead of std::threads to
nicely interoperate with Qt features.
Task-number: QTCREATORBUG-15681
Change-Id: I851e2f102e15ccd3347d455cc9d8b7df935c2d5e
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
This is a mechanical replacement for the former executable, processArgs,
inferiorEnvironment and workingDirectory members.
Change-Id: I4160e01427ed801df9b729f1f31d0a2ca48159b5
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
Using a global thread pool does not really make sense, since we do not
want to block any completely unrelated task. But the qmake project
manager still wants to limit the number of simultaneous threads without
managing that itself. A shared thread pool in project explorer sounds
like a sensible middle ground.
Change-Id: Ide6fd546a56e8f4896c387168513b608dfe7e3e8
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
To be used as type safe wrapper around a 16 bit port number.
Change-Id: I20a26be69e8b6b7dc9a7975fbe41c76ef89afbea
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
QTimer::singleShot with a member function pointer or a lambda does
not schedule the invocation directly on the receivers event loop,
even if the timeout is 0. It actually creates a timer in the thread
where QTimer::singleShot is called, which requires an event dispatcher
to be available. Only the timer's timeout() signal then schedules the
invocation on the receivers thread.
We do not want to actually run an event loop here until a timer fires.
Even if a timer with timeout 0 might directly schedule the timeout
event on the event dispatcher without involving actual timers, and
even if that event dispatcher makes sure all events are handled before
deleting itself, it would feel like relying on an implementation
detail.
This reverts commit a2e19ba1be.
Task-number: QTCREATORBUG-15681
Change-Id: I19846ce089d72c971d3cc5927c2ddf563e06de14
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
...mainly to not show the old zoom factor anymore.
Change-Id: I01c3050ff38b0b328774e6d05bcc2fe913ee4f56
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
Instead, use the one in its (Standard)Runnable.
Change-Id: I14dbe91c50d083d11e18d514ec391875c64e3851
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
...since that's
1. easier to handle (see e.g. QTCREATORBUG-15630, where a "&" was
not properly auto-detected).
2. consistent with the tooltip that is used for function signatures
(FunctionHintProposalWidgetPrivate)
Change-Id: I66aab253e13c5c7f63a0d9ddaf297b890567f335
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>
