Add the necessary contructor to TriStateAspect, too.
Change-Id: Ieb0f19cdf95f7492380d7c4e5663f455e4da3452
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Get back to the originally intended behavior
for StopOnDone and ContinueOnDone workflow policies.
By default, these policies report an error until
at least one child task finished with success.
Since the group is empty, no child finished with success,
so the group should report an error.
Change also the return result for the StopOnFinished policy
when placed in an empty group. The policy is meant to
report the finished child's result. Since no task finished,
report an error in this case.
Fix tests accordingly.
Amends c9638ff642
Change-Id: Idc449e8c68a658755bf566df56844126167f1751
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Make it available for Group or CustomTask items.
Note, that when withTimeout() is used, the total
number of tasks grows by one.
Change-Id: Idc71737ba66b92bdc4bf17599c793b1127d22f5e
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Ensure the timeout tasks preserve the right order of
their done signals.
Change-Id: I62508d0710eb2324d7c347a9907a899c97d3975d
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
By default, when finished, it returns success.
In order to convert it into failing task,
enclose it inside a Group with finishAllAndError.
Reuse it in tasking tests.
Task-number: QTCREATORBUG-28741
Change-Id: Ic81203203e0b139d4f9bfd553279ecb01cd303f4
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
The passed text is an output from the ag command,
but, as seen from the parser point of view, that's
the input data for the parser.
Change-Id: Ic5d42406fd5ff1f52969fde3c2d44aaa34b9133b
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This looks more consistent with the results reported by the internal engine.
Change-Id: I1f5a405bcfd7b32c01ef6d4db0324985e657f6a3
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
It's a preparation step for the incremental parsing.
Change-Id: I98268abd6d3e0210f218663a6c2bb701c3bfc070
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
If there is no device qmlRunCommand even though it is a remote device
QmlProjectRunConfiguration uses a desktop path and on windows
that results in wrong file separators ->
"\usr\bin\appcontroller ..."
Task-number: QDS-9994
Change-Id: I054addf86922b50bc2e2f620d536953b72ee3331
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
"Qml JS Code Style" is wrong (consistent would probably be "QML/JS Code
Style"), and since this is already with "Qt Quick > Code Style" with
another group box titled "Tabs and Indentation", it is also weird (the
other group box is also about the QML/JS code style).
Change-Id: I61d5f273b91aebf95f0e5f5913e160195dcd7a11
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
... to projectexplorersettings.cpp and merge
projectexplorersettingspage.h into projectexplorersettings.h.
A preliminary step on the path to aspectification.
Change-Id: Id482c0e8e03a2d37b07b9c1d810825afcede91b6
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
... and qml runtime. Useful on Mac and Windows where there'd be
a native but local chooser dialog otherwise.
Change-Id: I6361c6f6067c86dd7cca15ce1dd02150136cf3f7
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
That's going to replace FileIterator.
Benefits over FileIterator:
1. The FileContainer is a value type which may be
freely copied.
2. Much faster iterating, especially for SubDirFileContainer
with a big number of dirs / files (over 500000).
The FileContainer has begin() and end() functions returning
FileContainerIterator. The FileContainerIterator, when it's
not an end() iterator, contains the Item's value itself.
Whenever the iterator advances, the Item's value changes,
while the reference to Item's value remains unchanged inside
the iterator.
The SubDirFileContainer doesn't keep the references to all
visited Items anymore, contrary to the corresponding
SubDirFileInterator. The values of the individually visited
Items are kept only inside FileContainerIterator instances.
The progress information is available through the
FileContainerIterator's progressValue() / progressMaximum().
Task-number: QTCREATORBUG-28892
Change-Id: If89ac1121c21fa2fb7355aa12438dce3e85e465d
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
And ~175000 directories.
Distribute the generation and cleanup on all available cores.
With this patch I get the following config / measurements (linux):
Generating on 24 cores...
Generating 698881 files...
Generating 174721 dirs...
Generating inside "/tmp/tst_manual_subdirfileiterator-eHVKTL" dir...
GENERATING TEMPORARY FILES TREE stopped with timeout: 1777ms
ITERATING with SubDirFileIterator stopped with timeout: 92744ms
ITERATING with manual iterator stopped with timeout: 7905ms
ITERATING with QDirIterator stopped with timeout: 4706ms
CLEANING UP stopped with timeout: 1969ms
Amends 686a40d199
Change-Id: I7838e9cf73eae731a4dc3be02eeefa5caae8613d
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Avoids the attempt to start the client if nodejs cannot be
found.
Change-Id: I3783280120ca754291a92b3308c1192906facd08
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Fixes tst_build_new_project, tst_CCOM02 et al.
tst_tasks_handling fails which might be an actual issue, reported in:
Task-number: QTCREATORBUG-29209
Change-Id: I5eae54df27d8ba8f441e5b9c4acdaa2b41716245
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Inserting the name for the "commit" operation into messages relies on a
certain sentence structure and doesn't work with translations. Same for
"optional" error messages. Use different complete messages for the
different cases instead.
Avoid explicit line endings, use automatic word wrap instead.
Add some quotes and full stops.
Fix message with plural.
Don't use %n for constant number (inline in message with assert).
Improve confusing tool tip for instant blame.
Change-Id: Ic8453763279753ebd5898858951acddcf311e6e4
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: André Hartmann <aha_1980@gmx.de>
The stored container iterator, after container is modified,
may be already invalidated. Avoid storing the iterators and
do the search again after potential container modification.
Use QHash instead of QMap for faster insertions / lookups.
Amends 0135c47849
Change-Id: I0a4641d3b410836a5b3b9be252059e4e37fa94e3
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
