Commit Graph

81484 Commits

Author SHA1 Message Date
hjk
569e73c5ed Perforce: Some more direct FilePath use
Change-Id: I78e28714fef577a9129e39b03273f3651de8adcc
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2023-06-29 12:52:41 +00:00
hjk
a998456338 Perforce: Use a FilePathAspect for the p4 binary
Change-Id: I9bdb04192887f72d37bee04d13450cb9f85f9bc2
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2023-06-29 12:45:42 +00:00
David Schulz
3cfa1902c6 AutoTest: simplify TestVisitor::visit
Change-Id: I26e8eb8788da80afbfbd266f01828b860fc0622a
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-06-29 12:41:06 +00:00
Christian Kandeler
bcd49bafdd CppEditor: Add test case for quickfix formatting
Also fixes an off-by-one error in the formatting code that was uncovered
by the test.

Change-Id: I013194e21cf37f318bb806bb60ea659b91b99fbf
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-06-29 11:51:19 +00:00
hjk
379e7f906e Utils: Rework aspect implementation
This avoids some repetition and could be a step towards
having type storage in (or rather accessible from) the base,
so we can have aspects for more complex data (treemodels...)
that are not easily converted to QVariant.

Change-Id: I9797b3d5646195705212db1830d2b415291ac651
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-06-29 11:25:44 +00:00
hjk
900ea82fd1 Core: Don't save settings on startup anymore
Amends a68352f013.

This is getting in the way, it does not look needed, and it is lost
in history why it ever was.

Change-Id: I68ebdafc78e3259c73c64364607aef6eb74d2869
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-06-29 06:46:05 +00:00
hjk
5867d986a8 Core: Drop Q_OBJECT from OptionsPopup
Not needed.

Also slim down header a bit.

Change-Id: I6ac828fdfc42173e0b5aeca5d92e920745b424c9
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-06-29 06:08:25 +00:00
Christian Kandeler
0406f543eb ProjectExplorer: Allow users to remove all run configurations
Change-Id: Ib70bb1a658edcd6996e98e391b9b938618747ed3
Reviewed-by: hjk <hjk@qt.io>
2023-06-28 14:43:38 +00:00
Jarek Kobus
176ada90a8 BaseFileFind: Get rid of getAdditionalParameters()
Remove recheckEnabled() and introduce setupSearch()
virtual method. The latter is called just once per
SearchResult instance (on first search), so we may
store the additional parameter (current project
file path) in lambda capture.

Change-Id: I7683e818bec8f1d787bdb33c573248b252b47c78
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-06-28 12:17:03 +00:00
Christian Kandeler
b12ba08de0 Build systems: Do not put qbs plugins under the qtcreator plugins dir
Otherwise, the extension system will unnecessarily try to load them at
start-up.

Change-Id: I7a932904835cb387e3cf10924ca79a58e5f92b33
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-06-28 11:22:59 +00:00
Jarek Kobus
b5564b5820 FileSearch: Add tests for findInFiles() taking FileContainer
Change-Id: I752e8b443ac8a9c12b1fb209091727da6054a916
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-06-28 11:10:47 +00:00
Christian Kandeler
9f6878ddab CppEditor: Format code inserted by quickfixes
Task-number: QTCREATORBUG-10807
Task-number: QTCREATORBUG-19158
Change-Id: Ieac52e1a1a10afad91fea56290e7dcfd1d302e7f
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-06-28 09:18:15 +00:00
Jarek Kobus
4a51f57aa2 SearchResult: Get rid of requestEnabledCheck()
Change-Id: Ide2cbda86caf28b41b6a2c7413f9a36ae4a8282d
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-06-28 06:12:21 +00:00
Christian Kandeler
ee143e0923 ProjectExplorer: Do not forbid removal of the last run configuration
The presence of a run configuration is not technically required: E.g. if
you disable auto-creation of run configurations in the settings, you
won't have any in the first place. It therefore makes little sense to
force users to keep at least one of them once they are there.

Change-Id: I2ce0379ebc43f44326db53d324d4db9e9b92ef03
Reviewed-by: hjk <hjk@qt.io>
2023-06-27 15:45:06 +00:00
Eike Ziller
3e65778d66 Merge remote-tracking branch 'origin/11.0'
Change-Id: I8be5a00000a6699346ed1c44c0711d1f017462a7
2023-06-27 15:20:18 +02:00
Christian Stenger
372e2ba615 AutoTest: Fix layout of settings
..and re-add the ui for some lost GTest setting.

Change-Id: I0ec2c655fa9579a69b32a776736abfa7e23f53c9
Reviewed-by: hjk <hjk@qt.io>
2023-06-27 13:19:34 +00:00
Eike Ziller
d1649b060b QmlDesigner: Disable warnings-as-errors by default
for everyone that doesn't explicitly set the BUILD_DESIGNSTUDIO CMake
variable or the corresponding environment variable or CMake option.

Fixes: QTCREATORBUG-29238
Change-Id: Ie1959a468fc7bee0fed790b025ecdb3f49ab8f08
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2023-06-27 12:33:15 +00:00
Marco Bubke
94a704bb87 QmlDesigner: Only enable error on warnings as you compile with tests or in debug
There is no advantage for an enduser to get errors on warnings because
he cannot do much about it. It is still nudging the developers to fix
the warnings.

Task-number: QTCREATORBUG-29238
Change-Id: If9f73f2766d686b119cd264ee7b3c3c9afa2c70d
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
(cherry picked from commit ff2a14917f)
Reviewed-by: hjk <hjk@qt.io>
2023-06-27 12:32:56 +00:00
Alessandro Portale
a8cab6f5a1 QmlEditorWidgets: Use LayoutBuilder in PreviewDialog
Change-Id: Ic00c724e0787b51b3757b92d0d87dff8a6074c52
Reviewed-by: hjk <hjk@qt.io>
2023-06-27 11:51:13 +00:00
Leena Miettinen
d70089485e Doc: Autogenerate better breadcrumbs in topics
Currently, you can only get back to the front page. This
change adds the whole navigation path from the front page
to the current page, based on the lists in the All Topics
topic.

Change-Id: If0f6a6ceee70d452cec4d414a286ef093235c3de
Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
2023-06-27 11:42:31 +00:00
Artem Sokolovskii
646eb5118b ClangFormat: Fix missing label in project settings
Fixes: QTCREATORBUG-29323
Change-Id: Ia8c89ec6b8c745cac2bcb13a149667d9c3e08496
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-06-27 10:51:02 +00:00
Artem Sokolovskii
0720042e1c ClangFormat: Make the behavior of the braces tab clearer
Fixes: QTCREATORBUG-29069
Change-Id: I078b7fbb6f98088f615d74a189cce00f8e5fa5fe
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-06-27 10:50:50 +00:00
hjk
41fcca5cdd Python: Hide some internals from PythonRunConfiguration API
Change-Id: Ibed21265bf7099b06ea61751fb487b78e8071f34
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-06-27 09:09:32 +00:00
Christian Stenger
65b1088a17 AutoTest: Delay expansion request
Do not directly expand an item directly after it had
been added to the model as its internal mappings need
to get updated.

Fixes: QTCREATORBUG-29302
Change-Id: If70d209074d97e0598bcbce061e176148751705a
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-06-27 08:16:35 +00:00
David Schulz
150ca56067 ClangTools: replace some QStrings with FilePaths in tests
Change-Id: Ica351e8ebb67689cab43cb54ee7d82a307f9ed97
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-06-27 07:37:39 +00:00
Semih Yavuz
012f984c27 Restrict M16 warnings
Do not warn out invalid property name if the property starts with an id
in the same component scope.

Small refactoring: Move early-return-likely elements up before any
calculations done.

Fixes: QTCREATORBUG-28468
Change-Id: I2cbdbc24af42f126db0bbd6027ebe4f96d9c199f
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2023-06-27 07:21:58 +00:00
Christian Stenger
3664a62f98 QtSupport: Fix compile with Qt6.2
Amends d2b61bf3f0.

Change-Id: Ieeac8f24b4472ae802aadbcf9667419d2af52453
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-06-27 06:34:25 +00:00
Christian Kandeler
5bb49d4308 qbs build: Consider IDE_SETTINGSVARIANT in app_version_header
Amends ac32f790f3.

Change-Id: Ifeb571daeb3006d6bea7c46a52e3f9526f33c3d0
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-06-26 15:35:27 +00:00
Eike Ziller
d2b61bf3f0 Examples: Order categories
According to hard-coded list. This should come from the manifest file in
the future.

Follow-up of qtdoc/4e38729111989dbb738042d4a8beb35d01b77fe1

Change-Id: If46383e1cf8e44c2a52ca5a458c497495e132639
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-06-26 15:03:04 +00:00
Jarek Kobus
152d543cdf TaskTree: Document GroupItem and subclasses
Adapt some type and argument names accordingly.

Change-Id: I1b127eacfd0a71574ee9e9a7628ec572620798cb
Reviewed-by: hjk <hjk@qt.io>
2023-06-26 14:59:24 +00:00
Eike Ziller
ac32f790f3 Qbs build: Fix app_version generation
Amends 6836caa14c

which added a variable to app_version.h.cmake, but not to
app_version.h.in. Fix by porting qbs to use app_version.h.cmake, which
is the truth nowadays, instead of the app_version.h.in which originated
from the qmake build.

Change-Id: Ia9be53377a0bfded91ccd6ea1637eeda7fe9d5c8
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-06-26 11:32:22 +00:00
Eike Ziller
68bc213644 Move app logo to main executable
Moves more branding information out of the plugins.

Change-Id: I71575f268dd8f2860f4da56101b0e3d9442df367
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-06-26 11:29:41 +00:00
The Qt Project
e07e8b5c78 Merge "Merge remote-tracking branch 'origin/11.0' into work" 2023-06-26 11:25:55 +00:00
Christian Kandeler
29ade7d682 Wizards: Speed up JsonSummaryPage::initialize()
The summarySettingsHaveChanged() slot takes a (too?) long time, so at
least make sure we don't call it repeatedly while setting up the page.

Task-number: QTCREATORBUG-29290
Change-Id: Id010c41739a1381212731bb7638d6db87081c3b6
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-06-26 10:53:55 +00:00
hjk
691c8148a3 ProjectExplorer/RemoteLinux: Consolidate X11ForwardingAspect handling
Change-Id: I7e74f58ab50c84c74ba65f9f64aaa4d0ea73bbb6
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-06-26 10:48:08 +00:00
Eike Ziller
606be1f69f Merge remote-tracking branch 'origin/11.0' into work
Conflicts:
	cmake/QtCreatorIDEBranding.cmake
	qbs/modules/qtc/qtc.qbs

Change-Id: Ib4653a1ce75c7cce658f4bb843481de014d0fcf7
2023-06-26 12:12:58 +02:00
Marcus Tillmanns
456a019f2d Debugger: Don't spam app output
Only errors should be displayed in the App output.
Everything else is just noise.
To keep the information for debugging purpose we log it to the
Debugger Output View instead.

Fixes: QTCREATORBUG-27160
Change-Id: I37301edd2f6638e2b4152d1bf7b89a40c9c3c0af
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-06-26 07:40:58 +00:00
Alessandro Portale
42a62a3a5d Android: Obtain values for AndroidRunnerWorker from settings data
The members of AndroidRunnerWorker are supposed to be initialized with
aspect values from the AndroidRunConfiguration. But they were instead
unsuccessfully obtained from the RunControl's aspects.

This obtains the values from the RunControl's settings, instead.

Fixes: QTCREATORBUG-29160
Change-Id: I124184c32d158e0648a0ee1d23dfe8707d18eab8
Reviewed-by: hjk <hjk@qt.io>
2023-06-26 07:34:57 +00:00
Eike Ziller
6836caa14c Do not compile PROJECT_USER_FILE_EXTENSION into plugins
Set it in the app info in the main application and read it from there.
Moves more branding information out of the plugins.

Change-Id: I2f2e9fc96900793be15ac1907df70dda31c1b9c1
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-06-26 06:58:36 +00:00
Eike Ziller
dff9e1463b Reduce usage of app_version header
Most information is available via Q(Core|Gui)Application.
Add an AppInfo structure for the things that are not.

This avoids that the information ends up duplicated and
hardcoded in the plugins, which is not needed or desired.

Change-Id: I4d565e75c42a7b8facafa90c27096ea49359215d
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-06-26 06:57:46 +00:00
Leena Miettinen
ae85af34be Doc: Describe the "Use customized static analyzer" option
In Preferences > Qt Quick > QML/JS Editing.

Task-number: QTCREATORBUG-28996
Change-Id: I0e6945ac7fe82e3c8125438772214fe362da89c8
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-06-26 06:47:00 +00:00
Leena Miettinen
9edb1f524e Doc: Update change log
- Added paths to new options
- Added links to documentation
- Added some articles
- Rephrased an entry

Change-Id: Ifeea256714f307963789535f199a2e2733f56276
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-06-26 06:46:38 +00:00
Leena Miettinen
7642ce34b0 Doc: Mention qmake support for building apps in Docker containers
Task-number: QTCREATORBUG-28996
Change-Id: I0f5394fa7a4e7ba986c66df8dc73c098186903a9
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-06-26 06:46:23 +00:00
Leena Miettinen
12bcdee809 Doc: Fix instructions for previewing QML files
Change-Id: Ifbc0df8d64ab84adc05d427c0c925221533ea973
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-06-26 06:46:09 +00:00
Jarek Kobus
fdf3feaf0b TaskTree: Readd networkquery.h into the SOURCES section
In this way the networkquery.h is still reachable from
the project explorer.

Change-Id: I49646a077a5a6fe72bf81234c6111cdf0f371699
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-06-26 06:22:25 +00:00
Leena Miettinen
41c3a4aad6 Doc: Describe the "Default array size" field
In Preferences > Debugger > Locals & Expressions.

Task-number: QTCREATORBUG-28996
Change-Id: I5a54e7a33aa65dc63d91ec0bf977e60e96314a58
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-06-23 13:19:52 +00:00
Jarek Kobus
27302694ab BaseFileFind: Reuse FileContainer
Reuse it in BaseFileFind::files() and in
InternalEngine::executeSearch().

Change-Id: I2fed4e6af37e83d76deaa8d847564aa4950fc223
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-06-23 13:04:05 +00:00
Jarek Kobus
8c9683a627 FileSearch: Introduce oveload for findInFiles() taking FileContainer
Handle gracefully pausing the search after exceeding the 200000 hits
limit and continuing on user request.

Change-Id: I4e9ea92cfdb5fa54706c862a654edb6169fce84a
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-06-23 12:38:26 +00:00
David Schulz
4da2d288d8 Editor: avoid relayouting of annotation text for each paint event
Change-Id: Icabf033a43922bb9ebafd1a7973dcac851e9369e
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-06-23 12:30:09 +00:00
hjk
a62fcb73ce ProjectExplorer: Remove IDevice::createProcessListModel
All re-implementations are the same nowadays.

Change-Id: I954b3c9ca296967a99ea548ade6282fba188249f
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-06-23 12:27:03 +00:00