No need to set args just to delete them again.
Change-Id: Ib97d327329a25cb907227feb22db2334908ef089
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
ensureReachable for a path on the same device must return true.
Change-Id: I5b6924795997758ec0ad31520fa971ecd2a9615c
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
... when generating doxygen comments.
Otherwise, we will not properly parse declarations such as
void f(int i = {});
or
int m_member{};
Fixes: QTCREATORBUG-29198
Change-Id: I744041d2cd5438e4b64161bba04a088a8910024b
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Introduce and make use of Utils::insert() for QSet with a return value
that indicates whether insertion actually happened.
Change-Id: I655e4bc3553b74fea5ae8956205e4d8070118d63
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
When the onSetup() handler returns StopWithError,
the group stops immediately with an error, regardless of
its workflow policy.
Our intention is to report an error only if the initial
onSetup() handler returned StopWithError. Otherwise,
regardless on how the subgroup execution went, we want to
report success to the parent. That's why the
finishAllAndDone is an appropriate policy for the top group.
In case the ProcessTask fails, we don't want to continue
executing AsyncTask, that's why the finishAllAndDone got
removed from the subgroup, leaving it with the default
workflow policy of stopOnError.
Change-Id: I86ac18f062cd431e5138f87cdb01ef59e3d77d7e
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
To allow more complex actions in the command line,
like parsing $SSH_CLIENT.
Change-Id: Ifc48a74f1fe4e42cd7ceddfd3c308bd1636212a7
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Instead of three different deploy steps we use only the RSyncDeployStep
which can be configured to each of the three file transfer methods.
The SupportsRSync constant is moved to projectexplorer so that it can be
used by all devices.
The RSyncDeployStep checks which transfer method is available based on
source and target devices. An option is added for the user to force
a different method in case of issues.
Change-Id: I2b1eb39b5bd4a30d0f879d18317b7677d127f48f
Reviewed-by: hjk <hjk@qt.io>
error: operands to '?:' have different types 'QStringBuilder<const QString&, QString>' and 'QStringBuilder<QString, QString>'
Caused by af8f9a2a6e3dbc8.
Change-Id: Ib3dfca2cb5f1cb1855f25d178f63898eb6745c46
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
"QGuiApplication::setDesktopFileName: the specified desktop file name
ends with .desktop. For compatibility reasons, the .desktop suffix will
be removed. Please specify a desktop file name without .desktop suffix"
Change-Id: I84fa4d6dbed9ab95f9f90b452915bdce290743f3
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
In order to not overwrite errors reported by clangd lower the priority
of clang tool marks if they only contain a warning.
Change-Id: Ida1c39ab11aaeb0c70f674c53762fa2707bec766
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Also, trigger build button re-check the hard way
This should not really be necessary, but the code paths on the
core side are still quite twisted. The extra notification here
is harmless in price, and removes the showstopper of not getting
a buildbutton.
Change-Id: If4bec892b4ebea533a95033629df60fa564985f3
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Goal is to make option setup more similar to the other "simple" pages.
The GdbOptionPage is now separated in the setup code, but aggregated
into the old place and accessed there.
The per-backend separation seem quite weak, a full split would currently
need to have include gdb/* in several places now is an indication
that the gdb/non-gdb split in the options is dubious at best.
Change-Id: Iad210016739aa4a63645731e16825f546bdd5e8a
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Most aspect containers end in a widget at some time. Let them declare
how.
The optionspages don't need a layouter anymore when using their
settings' one. There was only one case where there was none, fix
that one (perforce).
Change-Id: Ibd39bcd4af98c3eae1daafa59f6c1d6e7a571989
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
... and other special toolchains not in PATH.
Amends cacc4aeede.
Change-Id: I300f7d719c9e101c24e3750dd7afd54dd338b58d
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
FilePath::searchInDirectories handles absolute paths on devices
better unlike Environment::searchInPath() which requires
a QString argument.
Previously the device:// part was dropped when trying to run
remote tests.
Fixes: QTCREATORBUG-29183
Change-Id: Idd04cdb8798d04abf88ab6cb4b68eb73d890a482
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
error: operands to '?:' have different types 'QStringBuilder<const QString&, QString>' and 'QStringBuilder<QString, QString>'
Caused by af8f9a2a6e3dbc8.
Change-Id: Ia3dfca2cb5f1cb1855f25d178f63898eb6745c46
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This is not a proper fix but prevents a crash and is otherwise
harmless.
Some tree traversal seems to be able to hit non-leaf KitNodes
that don't have m_kit set.
Change-Id: I4328069ba9b82bb66dfa2c1e0d148a717d594a4b
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Codesigning is done implicitly when using e.g. build.py
but sometimes doing it explicitly is convenient.
Add a main() to common.py and add arguments for triggering
codesigning:
python3 common.py codesign -s identity app_bundle
Change-Id: I8b0f766cfae0ea9d8173f331792a14964993d705
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
