Commit Graph

81484 Commits

Author SHA1 Message Date
hjk
79ad71a9de QmlJSTools: Use IOptionPage::setWidgetCreator() for settings
Change-Id: I57442416da54acd49cfcfd172fc67f28fee4f7b8
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-04-21 11:05:39 +00:00
Leena Miettinen
60f6ff5147 Doc: Replace Manual front page icons with Qt Creator icons
To create connections between the UI and the different chapters
of the manual.

Remove the SVG source files for the old front page icons.

Task-number: QTCREATORBUG-28996
Change-Id: I9bd977df1005a4f8d6d60b438a66ec02ebb2bfb3
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-04-21 11:03:52 +00:00
David Schulz
e7e063fda5 Debugger: Add automatic source path mapping for Qt Packages
Change-Id: Iae2a02fc134ac05a30241d7a69302294137d3844
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-04-21 10:57:59 +00:00
Eike Ziller
30bd12d8dc Build: Add SOURCES_PROPERTIES to extend_qtc_target
This way the check if the target is enabled and the condition is met
doesn't have to be done manually.

Change-Id: If490a84fd5f1ede2d032c3800f69ede4f755bc2c
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2023-04-21 10:55:16 +00:00
Eike Ziller
54177ebccd Locator: Fix opening of remote files
Opening remote files can pop up a ssh prompt, and before that happens we
need to hide the locator popup, which otherwise can stay on front of
that ssh prompt window, preventing the user from entering their password
and opening the file.

Otherwise for example modal error dialogs could also be shown.

So, delay the EditorManager::open call to after the popup is hidden.

Amends 07b1e1c5fe and
7f49d93fc1

Change-Id: If2dd9e745d5d98615b851ee4315e7de9a75afb00
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-04-21 10:37:52 +00:00
hjk
4acffc7cce TextEditor: Use IOptionPage::setWidgetCreator() for snippets settings
Change-Id: I9aa91edef20f325f1a2fc93388aecb5776b970d6
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-04-21 10:25:32 +00:00
hjk
498bad56b2 Qbs: Use IOptionPage::setWidgetCreator() for settings
Change-Id: Idae8c17a8922b60ad9dee3595176d11e0b96fee8
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-04-21 09:24:04 +00:00
Christian Stenger
55d51e8b5e QmlJS: Improve QtQuick Controls completion
Fixes: QTCREATORBUG-28648
Change-Id: I14c402c8a486d5afa7ee500b2d8a06951540e1bd
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2023-04-21 09:16:40 +00:00
hjk
977689b4a9 QmlProfiler: Use IOptionPage::setWidgetCreator() for settings
Change-Id: If9371820abf4e86e7041a7a5555c0a043de5ae3f
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-04-21 09:09:37 +00:00
Jarek Kobus
16100acdc9 JsonFieldPage: Fix collecting the results from all matchers
Connect to LocatorMatcher::done() signal instead of to
serialOutputDataReady() in order to get all the results
available (not just 1st partial results).

Give locator matcher a parent to avoid possible leak.

Amends 1cc7342ef1

Change-Id: Ie4a73a5b2dd25f22616bd30a13eb7393c96a890f
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-04-21 08:55:05 +00:00
Jarek Kobus
f21e2ff65c LocatorMatcher: Add more comments, do some renaming
Rename:
OutputDataProvider -> ResultsDeduplicator
OutputFilter -> ResultsCollector

Change-Id: If29ae29a2fa6895ad36d94577824fbb2e6b65a4d
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-04-21 08:27:54 +00:00
Jarek Kobus
0ab1eaa31c LocatorMatcherTask: Refactor the storage class
Considering the case that a locator task is running
its task in a separate thread, at least 3 threads are
involved:
1. Main thread
2. Task's thread
3. OutputFilter's thread (the thread that removes
   duplicates from tasks' results)

State before this patch:

The task (2) was always delivering the results into
the main thread (1), and when main thread received
the result it was passed to the OutputFilter's thread (3).
The drawback is that we needlessly block the main thread
for intermediate handling.

State after this patch:

The task (2) is delivering the results directly to
the OutputFilter's thread (3), without blocking
the main thread (1).
Currently the common object shared between all 3
threads is OutputDataProvider.

Rename addOutput() into reportOutput().
Make ILocatorFilter::matchers() private.

Change-Id: Ie8ad7d82ae02825e232f65b82fe329e780f58626
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-04-21 08:27:35 +00:00
Christian Kandeler
8ac826a1a0 qbs build: Fix pluginjson module
The "product" qualification was missing for "sourceDirectory". This
currently happens to work due to scope pollution in the qbs
implementation.

Change-Id: I61758023d39d00505c586c1e5ad78185a69c0db1
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-04-21 08:16:35 +00:00
hjk
61aef4aba5 Core: Use IOptionPage::setWidgetCreator() for mime settings
Less boilerplate for the implementation add user code access to
IOptionPage::{apply,finish} is planned to be removed.

Change-Id: I75c9ca893f49d66b72f6108f2451f3b0cb46722a
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-04-21 08:15:08 +00:00
hjk
214742e943 Haskell: Use IOptionPage::setWidgetCreator() for settings
Change-Id: I4565cfca2bc58fd78e4c35fa1abda43532c113b6
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-04-21 08:14:58 +00:00
hjk
69d53245f2 Python: Avoid IOptionPageWidget::widget() in settings
This is planned to become inaccessible for user code.

Change-Id: I2530a6ccf9f46cedff68ae62e8ac3d42d6792e0a
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-04-21 08:14:49 +00:00
hjk
8d1307552b Copilot: Take advantage of IOptionPage::setWidgetCreator()
Less boilerplate for the implementation add user code access to
IOptionPage::{apply,finish} is planned to be removed.

Change-Id: I03bbde071fdf673bee0568baa9ae9fab8d816590
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-04-21 07:21:48 +00:00
David Schulz
8745813721 Editor: add option to switch markdown viewer panes
Task-number: QTCREATORBUG-27883
Change-Id: I18daa688ff7751f984a95132737cfcc219b92108
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-04-21 06:54:24 +00:00
Jarek Kobus
38d4f3fef3 LocatorFilter: Introduce LocatorMatcherTasks
Change-Id: I775c88b8ac7d7bb0719a6b20d1e5171dbd62a94d
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-04-21 06:45:28 +00:00
Jarek Kobus
422d422deb LocatorMatcherTask: Get rid of Input/OutputData typedefs
Introduce LocatorFilterEntries instead.

Change-Id: I082e0405441aa4b70a5e8fb796aa5c4fa3879265
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-04-21 06:45:04 +00:00
Eike Ziller
44aaad4c2f COIN/GitHub: Bump to Qt 6.5.0
Change-Id: I8c2122b7f35d049f0249631fc6e045b79dff9fbc
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-04-21 06:37:23 +00:00
Orgad Shaneh
28c20b24aa VCS: Fix jumping to last line on some editors
I'm still not sure what causes this.

Fixes: QTCREATORBUG-29063
Change-Id: I861d91f1aa9a2fb36054d9f0a8e5e8e2f8fae872
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-04-21 06:30:52 +00:00
hjk
ce7b99bc88 RemoteLinux: Honor working directory setting again
Fixes: QTCREATORBUG-28900
Change-Id: I163877a749f378b2aa7579c1985e58f8a9d87e2c
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-04-21 06:10:07 +00:00
Leena Miettinen
c6a98002fd Doc: Remove info about manually adding files to CMakeLists.txt
It is now done automatically.

Task-number: QTCREATORBUG-28996
Change-Id: I25844b087575eba11cdce1c8a2f5040c92dae80e
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-04-21 05:47:35 +00:00
Christian Stenger
128d40e179 CMakePM: Fix qbs build
Change-Id: I96ea5f4130c9a5449ad7c0f97f63494ecf5b0e01
Reviewed-by: hjk <hjk@qt.io>
2023-04-21 05:29:08 +00:00
Ali Kianian
151423ab16 QmlDesigner: Remove transient scrollbars
The concept of the transient scrollbar still exists, but all used cases
are removed.

Task-number: QDS-9735
Change-Id: I16c57635a5eeb114b906ab74bbf24a8693897557
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-04-21 05:21:20 +00:00
Cristian Adam
039baab6e7 CMakePM: Add new / existing files for QtQuick projects
Fixes: QTCREATORBUG-28904
Fixes: QTCREATORBUG-28985
Change-Id: Id05f13cc69b8afffafba1b956ee1c90dc88c6d57
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-04-20 17:28:14 +00:00
Thomas Hartmann
924149e515 QmlDesigner: Use simplified name for Connections
Task-number: QDS-9737
Change-Id: I1883632cf3029263b28095cc481e45a41c0d89d1
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2023-04-20 17:03:24 +00:00
Thomas Hartmann
9ac4cd4e4a QmlDesigner: Add more checks for kit when adding import paths
Especially if developing we do not want to parse all kits to slow down
startup time.

Change-Id: If49624941b611b7e8b19864bdd3f31b884c04514
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-04-20 17:03:11 +00:00
Thomas Hartmann
22f08280f5 QmlDesigner: Launch feedback dialog only from design mode
Task-number: QDS-9641
Change-Id: I1d2523c8cd019092b4c64fdefeb326e0751bbb37
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2023-04-20 17:01:02 +00:00
Knud Dollereder
3387c68ff2 Add MCU build step to the QmlBuildSystem
If a qml project is marked as qtForMCU the buildstep will
run the qmlprojectexporter on the currently active qmlproject
when pressing the "Run" button. The output messages of the tool
will then show up in the "Compile Output" panel.
The build step itself can be seen when switching to "Projects"
mode under "Deployment".

Change-Id: I5ac31d5655e3b4b6137aaf541839776f144a09c4
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Burak Hancerli <burak.hancerli@qt.io>
2023-04-20 16:51:39 +00:00
Henning Gruendl
43bf597611 QmlDesigner: Fix leak in FileDownloader
Fix QNetworkReply in FileDownloader not being deleted.

Change-Id: I037a00b4351029e28b887ecbd4205b743284a6f7
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2023-04-20 16:45:58 +00:00
Jarek Kobus
97ee619876 ProjectExplorer: Drop known namespaces
Change-Id: I969a7f6c8e54c89b047611890a7ba80f4829d73b
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-04-20 16:02:46 +00:00
hjk
4e847cfb49 QbsProjectManager: Fix warning
"this statement may fall through [-Wimplicit-fallthrough=]"

Change-Id: I3497a25834b77a2266e9b46d1f7365b5fdf72239
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-04-20 15:29:07 +00:00
Fabian Kosmale
50aa8fedd2 FileDownloader: Do not assume existence of QQmlData
QQmlData::wasDeleted returns a sensible result, even when the QQmlData
has not been created (for instance because the object was not
instantiated by the QML engine). Checking the result of
QQmlData::get is counterproductive, as FileDownloader objects are for
instance created by ContentLibraryMaterialsModel::fetchBundleIcons,
without going through the QML engine.

Moreover, try to log some information about why we ended up with a
network error.

Task-number: QDS-9687
Change-Id: Icf7fba94a8a0552305ac39f2caa32426e58972a0
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-04-20 15:27:53 +00:00
Miikka Heikkinen
35582ffcb5 QmlDesigner: Render main scene in information puppet
Upcoming changes in quick3d require rendering of the main scene
at least once to resolve rendering context corretly.

Task-number: QDS-9699
Change-Id: I77520309029730f306adf24694ee357d29d27209
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-04-20 14:55:36 +00:00
Thiago Macieira
d1d893f098 Fix dangling references, found by GCC 13
Lifetime extension via const-ref only applies to functions that return
by value. For those that already return by reference (such as
QList::constLast()), no extension happens and we end up with a dangling
reference.

cmakebuildconfiguration.cpp:1473:25: warning: possibly dangling reference to a temporary [-Wdangling-reference]
cmakebuildconfiguration.cpp:1473:61: note: the temporary was destroyed at the end of the full expression ‘ProjectExplorer::BuildStepList::steps() const().QList<ProjectExplorer::BuildStep*>::constLast()’

Change-Id: I3b169860d8bd41e9be6bfffd1757167b7348be9b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Ville Voutilainen <ville.voutilainen@qt.io>
2023-04-20 14:29:31 +00:00
Cristian Adam
ea94891f6b CMakePM: Only parse CMake files with the CMake parser
Change-Id: Ifc962a54ec9bf6ba0db4ec7813cb81d7c81a7d2c
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-04-20 14:03:08 +00:00
Jarek Kobus
c09951d1b7 LocatorFilterEntry: Get rid of filter field
Remove also c'tor taking a pointer to filter.

Change-Id: Ic0fe62daeb6e79a729bee24d07d7eb77559e19c4
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-04-20 13:46:03 +00:00
Miikka Heikkinen
b1f55d5a6a Fix binding assignment failing sometimes
Change-Id: Ic94cc911411d3162cd840feba86a445a4bc76c8e
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-04-20 13:34:28 +00:00
Jarek Kobus
f13c39c912 ILocatorFilter: Get rid of accept() method
Change-Id: I3ad3c2cd5cb7a08b7539918b7713bfcd27fde297
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-04-20 13:26:06 +00:00
Marco Bubke
ece03f55ac QmlDesigner: Add import difference
In some cases we want to use only a sub set of imports. In that case we
compute the differences on demand. To compute the differences the
imports have to be sorted.

Task-number: QDS-9542
Change-Id: I8b3e501b7657522317847b0b788cd3ff5b47b003
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-04-20 13:22:40 +00:00
Miikka Heikkinen
9817df63fb QmlDesigner: Fix puppet build after quick3d private API changes
Change-Id: I3668853886306fe00d5da916aa458559964a9af0
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-04-20 13:16:12 +00:00
hjk
fc8181672c Gitlab: Use IOptionPage::setWidgetCreator() for settings
Change-Id: If5e0cead9092836f23bc8551bb0f1495fe41a400
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-04-20 13:10:20 +00:00
hjk
7e919a07b6 CMake: Remove odd but unused assignment
Change-Id: I052baddc82b7bef24e656c35be1a4edd97a85007
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-04-20 13:09:53 +00:00
Jarek Kobus
900dc154be RunConfigurationLocatorFilter: Use Acceptor for LocatorFilterEntry
Change-Id: Ia48aa149ee2c4cd3653ba7a4313f1578034ad9d8
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-04-20 13:01:56 +00:00
Marco Bubke
017c57c7a1 QmlDesigner: Disable unsupported QmlPrivate versions
We can fix that later.

Task-number: QDS-9734
Change-Id: I04f8ec055505ec187127f0a41927f0343cc72a2f
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-04-20 12:58:58 +00:00
Marco Bubke
d530d39dd3 QmlDesigner: Remove std::filesystem usage
Change-Id: I2282052a92e13744bceec3e5597670a68ba6db4c
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-04-20 12:58:45 +00:00
Semih Yavuz
21ca06fc7c Codeformatter: Support indenting of type annotated function
Fixes: QTCREATORBUG-29046
Change-Id: Ie4a4d85b7aa00ddf4dd3ea4bade6ffa57af7b4e0
Reviewed-by: Mikołaj Boc <Mikolaj.Boc@qt.io>
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2023-04-20 12:55:40 +00:00
hjk
c0bbd29933 Git: Use IOptionPage::setWidgetCreator() for gerrit settings
Change-Id: I7402f3342bb11726ec7383c807fa98052cb38bd8
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2023-04-20 12:54:38 +00:00