Commit Graph

81484 Commits

Author SHA1 Message Date
Eike Ziller
c72c2cbf19 UpdateInfo: Start maintenancetool with low priority
Reflect that it is supposed to be a background activity.

Fixes: QTIFW-3024
Change-Id: I799552016c96e896992dd505cbfd86fa744c9502
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-06-09 06:51:58 +00:00
hjk
ebb2b9b73a QmakeProjectManager: Avoid endless loop on self-referencing mkspec links
Change-Id: I2b8fda49931c2f133f96c6e1c8001757d926af9e
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-06-09 06:49:41 +00:00
Alessandro Portale
c1b7d23e56 Terminal: Fix string typo
send -> sent

Change-Id: I7a4658f316023206f716b856027f93414013d6b8
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-06-09 06:39:23 +00:00
Marcus Tillmanns
1647968b92 Terminal: Don't always open default terminals
If a "Run in Terminal" app is started, or the user
selects "Open Terminal here" we don't want to
open another terminal when the pane becomes visible.
So we move the check after we added the terminal.

Change-Id: Idd90d6e9dbba513dd020d91ffebb594fd90d688a
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-06-09 06:16:43 +00:00
Alessandro Portale
335b70de5d Application Templates: Fix QDS compatible project
This adds the newly introduced insight file to the file list.

Fixes: QTCREATORBUG-29234
Change-Id: I1d10e48a03d1147c4633b77e2a7384a073b5c1de
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-06-09 05:00:56 +00:00
Orgad Shaneh
4c90e09553 Find: Remove "Filtering" placeholder text
Added by mistake in f48a6bb826.

Change-Id: I843c39a1cec3cd25ef1c6e52784f82d1e5ab68cf
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-06-08 20:24:49 +00:00
Jarek Kobus
39a419c801 DiffEditor: Move some methods into protected section
They are used only in subclasses.

Task-number: QTCREATORBUG-23242
Change-Id: I0aa037c7499a9a552e351fbd36885ce9b736656b
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-06-08 16:38:58 +00:00
Alessandro Portale
fb724ec38b Terminal: New keyboard lock icon
Change-Id: Ie3964d599fb15def190c51dd33351fa0224cacfc
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-06-08 14:15:20 +00:00
Eike Ziller
27a61d482f ClangFormat: Fix that formatting was wrongly disabled
After starting Qt Creator with the Beautifier plugin, turning its
automatic format on save option on, and restarting Qt Creator _without_
the Beautifier plugin, clang format was no longer formatting on save.

The clang format based formatting is supposed to be disabled if

- the Beautifier plugin is enabled, and
- its automatic format on save option is enabled.

Fix the check for the first condition, the plugin can be present but
disabled, explicitly check if it is enabled.

Change-Id: I5c9c270dd47ceec665aebca5b613f0c4a5357d72
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-06-08 13:52:31 +00:00
hjk
69d1f24316 ProjectExplorer: Handle more Qt deprecations
Change-Id: I12895e65c14ca2723f6aea02c33b30659c30735a
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-06-08 13:47:05 +00:00
Robert Löhning
f939f19b9d SquishTests: Update tst_opencreator_qbs for Python3
Change-Id: If0e03204c49e80eb2bfca6e0d14413aad9d790f4
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-06-08 13:44:44 +00:00
Marcus Tillmanns
2039880e75 ProcessStub: Don't block main thread while waiting for keypress
Otherwise the request to exit from Qt Creator would be missed,
making QtC hang on exit while waiting for the stub to exit.

Fixes: QTCREATORBUG-15749
Change-Id: I26dfa2c8aa358c8d7ad662ef806f459d1bbb6ec2
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-06-08 12:37:42 +00:00
Leena Miettinen
d11b50ec35 Doc: Describe setting the toolbar style
In Preferences > Environment > Interface > Toolbar style.

Task-number: QTCREATORBUG-28996
Change-Id: Ia382f506432bf1b0a499df5c168d5bc3b69477bc
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-06-08 12:23:56 +00:00
hjk
362772442a All: Fix some more Qt 6.7 induced deprecation warnings
Change-Id: I4f3fc9c34ff664ab153d4a9a641ec84a11e555a9
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-06-08 11:40:23 +00:00
Eike Ziller
b6c452d59d Terminal: Clean up settings
Qt Creator <= 10 accidentally wrote the default terminal into the
settings on macOS instead of leaving the values empty. So the change
from "openTerminal.py" to just "Terminal.app" might not be correctly
reflected in the settings.

Make sure that the terminal setting is removed in all cases, if it is
set to the default.

Amends f003234510

Change-Id: I9d099999f55b4003ac6e7f4a4b679b893eaffc90
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-06-08 11:33:20 +00:00
hjk
9dabb9d0aa ImageViewer: Proliferate FilePath use
Get rid of a few .toFileInfo() and related calls.

Change-Id: I85a384848294e045fe07f621f06ebb17e567b444
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-06-08 11:32:28 +00:00
Jarek Kobus
003b43aee7 TaskTree: Rename setupRoot into setRecipe
The passed Group root element is a recipe with
a full description on how to execute the tasks
and how to handle finished tasks.

We have already virtual methods / setters called like:
deployRecipe, refreshRecipe, reloadRecipe. So, the
common "recipe" is kind of consistent.

Fix typos in warnings.

Addresses the 11th point in the task below.

Task-number: QTCREATORBUG-28741
Change-Id: I1c80f4838b6a3e5ed113eaf8e42b59746d098efe
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-06-08 11:31:57 +00:00
hjk
cab81a5d03 QMakeProjectManager: Proliferate FilePath use a bit
Task-number: QTCREATORBUG-29140
Change-Id: I66511871789cd7428695eba8720e7ef6a2236497
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-06-08 11:30:24 +00:00
Marcus Tillmanns
8c381c719b Terminal: Fix painting multi char preedit
Preedits on linux can often contain more than one character.

Also changes the painting from white on black to painting with
just an underline.

Change-Id: I6769217ca80cf131aa3fb96b20e23b717f591467
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-06-08 11:14:19 +00:00
David Schulz
04ba4dd4fe TextEditor: clear suggestion when moving in front of it
Change-Id: Ifcb2265e198120078f7ee6fe7dcebcd7777b3df8
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-06-08 11:13:33 +00:00
hjk
bd818c7f0c ProjectExplorer: Inline mapFromBuildDeviceToGlobalPath
... into its only users. Wasn't so useful as originally thought.

Task-number: QTCREATORBUG-29168
Change-Id: Ic10bc29d829f4abfb7bfa6e6d0aecff82ba4538e
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-06-08 11:12:13 +00:00
Christian Kandeler
f0a1591035 ClangCodeModel: Adapt to new "inactiveRegions" notification in clangd
See https://reviews.llvm.org/D143974.

Change-Id: Iff6cc39f7c567feee1953fde1ca96a9aefec75d4
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-06-08 11:06:15 +00:00
Semih Yavuz
114c92acb7 Show qmllint errors on issues pane
Some warning / error messages of qmlsc/qmllint tools were not handled
by any of the output parsers and hence no CompileTask were created to
handle those output, like pushing those warnings into Issues pane. This
was also causing incorrect formatting of CompileOutput messages.This is
not an issue for MsvcParser because there a fallback task is created for
"Error" and "Warning" lines.

Introduce a fallback mechanism in QtParsers to handle qmltooling output
and add test.

Fixes: QTCREATORBUG-28720
Change-Id: I6d0de6bc8b6869c6ea80b72018a4acb7decc8b6d
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-06-08 10:51:33 +00:00
hjk
6243c302d1 iOS: Proliferate FilePath a bit
Unlikely to make a difference in practice, but removes so unwanted
.toString/.exists.

Change-Id: I32c037aa87bb13cecb5b783fe0b36850e163f9c5
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-06-08 10:16:25 +00:00
Joni Poikelin
4e1ff9ed8f Fix issues with project tree node expansion
In CMake projects, initially the project name is the directory name
that is later changed to the name defined in the project file. If
the user had expanded the project when it was still in its original
name, it would be left in the expand data as is, causing the project
to be expanded every time it is re-opened.

Fixed by checking if the name had changed and then re-inserting
possible expanded data with the new name.

Fixes: QTCREATORBUG-28681
Change-Id: I3b914fd0ae916205c86a6bd79cab5d57499d4d33
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-06-08 09:55:36 +00:00
Marcus Tillmanns
9925bae16b Copilot: Disable by default
Its no longer experimental

Change-Id: I62d8dbbcb1eeb2c1a4e60b6356a09f28e670140f
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-06-08 08:58:27 +00:00
Leena Miettinen
1e1eba1a1a Doc: Describe new Qt for Python support features
Add an overview page for Developing Qt for Python applications.
It contains links to Python-related information in the manual
and some sections about setting up the development environment.

Task-number: QTCREATORBUG-28996
Change-Id: If5a442415bad65aa94aa78183d44c6e0f78e317e
Reviewed-by: Shyamnath Premnadh <Shyamnath.Premnadh@qt.io>
2023-06-08 08:54:20 +00:00
Christian Kandeler
6500a250fc ClangCodeModel: Suppress more clang warnings about unknown arguments
E.g. some instances of drv_unknown_argument have now become
drv_unknown_opt_for_target.

Change-Id: I5df7f25c4efcaaa38ac0d9ffcd53f3467798a604
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-06-08 08:30:06 +00:00
Christian Kandeler
8e75381fce CppEditor: Give C++ file name settings a per-project variant
Fixes: QTCREATORBUG-22033
Change-Id: If37517bb091438e70c5af5102bf833ed46d0c951
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-06-08 08:23:01 +00:00
hjk
19a6428f54 More deprecation induced busywork
QString::count() will vanish.

Change-Id: I65672fa648c0969930e9398ec4e541a0771c8a57
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-06-08 07:00:01 +00:00
Marcus Tillmanns
f83fb72af8 Terminal: Fix assert
ShortCutMap::addShortCut did assert if the keysequence was empty.

Changed Q_ASSERT to QTC_ASSERT to not crash.

Change-Id: Ib03e21bb00ab989e00d5c3de68b52b84c6eb2360
Reviewed-by: David Schulz <david.schulz@qt.io>
v11.0.0-beta1
2023-06-08 06:24:33 +00:00
Eike Ziller
4e000b8731 Change log: add some documentation links
Change-Id: If0cb436f459559ff03510185332506d2c42006d3
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2023-06-08 06:00:30 +00:00
Christian Stenger
38cc6e533d SquishTests: Fix expected clone output
The working directory is quoted nowadays.

Change-Id: I8b4abc5d21a3adb4b07b7582c2e5f74f11da51d0
Reviewed-by: Robert Löhning <robert.loehning@qt.io>
2023-06-08 05:06:45 +00:00
Tim Jenssen
f09598de43 QmlProjectManager: fix import FilePath
Deployment was not working for subdirectories.
Path was not correct in projectInfo.importPaths.maybeInsert.

Change-Id: I4fd8a08ef6182c52963d6d76a700f4687abd9730
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2023-06-07 18:03:05 +00:00
Alessandro Portale
5d0aab9eb3 Tasking: Fix linker error on Windows
Change-Id: Id95fa55c2dd3d42c335b2c6c5269e18653268e64
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-06-07 16:08:45 +00:00
hjk
097ed66cc5 Qml2Puppet: Replace a few deprecated QVariant::type() calls
... by typeId().

Change-Id: Ib617db774cec2c23ac58bcd39d99a59f9820f443
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2023-06-07 15:30:53 +00:00
Jarek Kobus
6cc325f845 AndroidSdkDownloader: Move private static methods into cpp
Adapt their API, when needed.

Change-Id: I2fd0a5673f5b0e83442cb800299980dc0f28832e
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-06-07 14:39:53 +00:00
Alexey Edelev
d06df3b547 Remove '-flto' from clangd compiler command line by default
Linker-time-optimization flag should not have any effect on clangd,
so we may remove it from the compiler command line by default when
feeding clangd with the source files. gcc supports the
optimization level that should be applied for the relative binaries.
The level can be specified as the number N following by the -flto=[N]
argument. clangd meanwhile doesn't know about this option and throws
the 'Unsupported argument '1' to option '-flto=' error.

Task-number: QTMCU-163
Change-Id: I540438d8f4d006261e4cfda2bbba91984352db9d
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-06-07 14:39:06 +00:00
hjk
49e17591ea ProjectExplorer: Use aspects as direct members in MakeStep
Less indirection.

Change-Id: Ie0086f7f2365512694fb3de77d3efc838e6e95ed
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-06-07 14:17:40 +00:00
Christian Kandeler
24df1f1183 ClangCodeModel: Support new clangd semantic token for labels
See https://reviews.llvm.org/D143260.

Task-number: QTCREATORBUG-27338
Change-Id: I26eb3688f311d93c966901a6639931fec944dd49
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-06-07 14:00:37 +00:00
Christian Stenger
d0bf83f86a Axivion: Change dashboard icon
We are not opening a webbrowser, so the old icon
might be misleading.

Change-Id: Ib782c80474b8d669684695a86913dfb4fbb84b49
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-06-07 13:54:24 +00:00
Alessandro Portale
365d6bce5c QtSupport: Use LayoutBuilder for "Link to Qt" dialog
Change-Id: I0e497ad7eca680ff6ea913bd6a8c6224273f3809
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-06-07 12:13:43 +00:00
Marcus Tillmanns
f003234510 Utils: Convert openTerminal.py to Terminal.app
Qt Creator 10.0 may have saved "openTerminal.py" in its settings.
We don't used that anymore, so we convert it to Terminal.app.

Fixes: QTCREATORBUG-29246
Change-Id: Ifc67e6e7bbc7af5dfaf6703b3bd34ded847c5013
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-06-07 12:11:28 +00:00
Marcus Tillmanns
b2364923e6 Terminal: Fix compile with Qt < 6.5.0
Change-Id: I23a95eb598e5bcba43621b2beb5a82b056bf5e83
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-06-07 10:59:14 +00:00
Marcus Tillmanns
dd99b83e62 Terminal: Fix tooltip
Fixes: QTCREATORBUG-29260
Change-Id: I6bde92e0caaa62598f25d1af7f7a69548b8fa4d3
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-06-07 10:51:28 +00:00
Jarek Kobus
34ef7d4150 AndroidSdkDownloader: Use Utils::NetworkAccessManager
Change-Id: Idd245f578ead0f22e457f9571441a4d9c9a1ce40
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-06-07 10:36:47 +00:00
Jarek Kobus
abb85b073a QScopeGuard: Make all usages of QScopeGuard consistent
Change-Id: Icfc35ecbdbdee8dadbb1b17789694093427c3ed9
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-06-07 10:35:01 +00:00
Jarek Kobus
aefd4d759e Utils: Get rid of ExecuteOnDestruction
Change-Id: I6c93e665268df16d10d899743052e698a421e0f5
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
2023-06-07 10:34:54 +00:00
Jarek Kobus
f1c04035a6 CPlusPlus: Reuse QScopeGuard instead of ExecuteOnDestruction
Change-Id: Ifb2cf839777c18b4f66a88b7f5106f05148b0c20
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-06-07 10:34:48 +00:00
Jarek Kobus
deb74751fb Various plugins: Reuse QScopeGuard instead of ExecuteOnDestruction
Change-Id: I3341342bc763fade5ad9dcb854928e5499287472
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-06-07 10:34:41 +00:00