Commit Graph

80529 Commits

Author SHA1 Message Date
Eike Ziller
c7bf77ae72 CheckableMessageBox: Make semantics of bool value clearer
Change-Id: I06a43ab986e6f028cf07ea5e9700c831a591cbf2
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-05-17 10:58:02 +00:00
Christian Stenger
a468bc2f02 Fix Qbs build
Amends f84199f8b7 and
reverts 796cfceb3a.

Change-Id: I7eb686c012bd99cddf36aa16219e3f33de2b15b2
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-05-17 10:36:29 +00:00
Alessandro Portale
3fc461e712 CppEditor/QmlJSTools: Remove settings migration from Qt Creator 2.3
This removes settings migration from Cpp Code Style Settings migration
from Qt Creator <= 2.3 to 2.3+

Let's assume that most active Qt Creator users launched a Qt Creator 2.4
or later in the last decade if they still work with their decade-old
installation.

Change-Id: I9c49dd9c1c0bd85e2b8c58a0d4eb6c393abf94a1
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2023-05-17 10:15:48 +00:00
Eike Ziller
cbeac777a6 Move restoring startup session to SessionManager
It needs to be done after the delayed restoring of kits, so this now
implicitly depends on ICore::coreOpened coming after restoring kits has
triggered on the event loop before, which is ugly, but works (and is at
least guarded by a warning).

Change-Id: Ie8676b1c7f4d099fb83f0f2a0f2e5677c4a0b999
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-05-17 10:09:00 +00:00
Eike Ziller
667d5a8f91 Remove include of projectmanager.h from session.h
Users need to include that themselves if needed.

Change-Id: I90f8fe2784ee395cc6a4fc43e62eedebf9f05b76
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-05-17 10:08:52 +00:00
Eike Ziller
c3334cd1af Session: Move some settings saving to session itself
Change-Id: I306bb86f1fda03f9b34efd7101d405ed64076711
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-05-17 10:08:44 +00:00
Marcus Tillmanns
c59f3102a1 CrashHandler: Fix missing update
The change to CheckableMessageBox was missed.

Change-Id: I8b7fe1230bcf483f9e5371b878d862aff422d925
Reviewed-by: hjk <hjk@qt.io>
2023-05-17 08:31:41 +00:00
hjk
8f5703a7b9 Tests: Add a test to feed shells via stdin
Change-Id: I7e19537d0a3015aeb329849758cc92da17a67606
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-05-17 08:21:09 +00:00
Christian Stenger
db2b09f4eb Valgrind: Do not start valgrind if it does not exist
...and print a warning with some user hint inside the application
output instead.
Drive-by fix: silence a soft assert in case of a failed start of
callgrind.

Fixes: QTCREATORBUG-28988
Change-Id: I4fd0253e1f18489031e2f6cfa276c4df5ea4483a
Reviewed-by: hjk <hjk@qt.io>
2023-05-17 08:17:19 +00:00
Christian Stenger
796cfceb3a Tests: Fix Qbs build
Amends f84199f8b7.

Change-Id: I6a233aca13f9908451748c20c1804fa2851043aa
Reviewed-by: hjk <hjk@qt.io>
2023-05-17 08:17:12 +00:00
Marcus Tillmanns
1fc2459b62 Utils: Unify CheckableMessageBox and make it look more native
Change-Id: I5690c16f38cfd2058e01441283bec28d44cadf75
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-05-17 08:01:13 +00:00
Andre Hartmann
29371dc2f3 Git: Cache author and encoding for instant blame
Querying both may be expensive and is only
necessary when the repository is changed.

Fixes: QTCREATORBUG-29151
Change-Id: I1d37f8b8708c02a8c3dc2d89fe7e331f0f416818
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2023-05-17 07:06:05 +00:00
Andre Hartmann
ac0f273081 Git: Fix missing instant blame with line folding
When lines are folded (e.g. the license header),
the editors lineCount() is smaller than its
blockCount(). That resulted in missing blame marks
for the last document lines. E.g. if 10 lines were
folded, the last 10 lines did not have blame marks.

Change-Id: I502afb09697fd3d6a062d3ae2321357a3e565a0e
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-05-17 07:05:33 +00:00
Jarek Kobus
f84199f8b7 Solutions: Long live Solutions!
Short live Tasking in Solutions!

Add src/libs/solutions/README.md with the motivation and hints.

Move TaskTree and Barrier from Utils into Tasking object lib,
the first solution in Solutions project.

Tasking: Some more work is still required for adapting auto and
manual tests. Currently they use Async task, which stayed in Utils.
For Qt purposed we most probably need to have a clone of
Async task inside the Tasking namespace that is more Qt-like
(no Utils::FutureSynchronizer, no priority field,
global QThreadPool instead of a custom one for Creator).

Change-Id: I5d10a2d68170ffa467d8c299be5995b9aa4f8f77
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-05-17 06:29:03 +00:00
hjk
520412d147 CPaster: Use PagedSettings
Change-Id: I826030f9a691c9e9c929deb1624d9705d3222e23
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-05-17 06:07:54 +00:00
Christian Stenger
0672199de8 Squish: Provide object picker
Provide the object picker. Currently only partial functionality
and limited for a debug run of a squish test.

Change-Id: Ic6f765d3c76b29c732684879c2459f1e0f732978
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-05-17 06:07:17 +00:00
hjk
a21b96f4b6 Utils: Allow a BoolAspect to adopt an external button
This will be used by the apply machinery and allows more
complex setups than the automatically generated internal
CheckBox button.

Change-Id: I237a9283253f11bcb76e0366a0b6c5a0346fdfd8
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-05-17 05:51:30 +00:00
hjk
337497d990 Vcs: Use new FilePathAspect in a few places
Change-Id: Idc23616dd3b7bc21301471cb48e2893116b83f0d
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2023-05-17 05:51:17 +00:00
Leena Miettinen
330a30aa5b Doc: Hide text and links that only apply to Qt Creator Manual
...from the QDS manual.

Change-Id: I24be3b656922b1c10643f6ef274f1fa91c8330df
Reviewed-by: Mats Honkamaa <mats.honkamaa@qt.io>
2023-05-17 05:34:28 +00:00
hjk
6c5fb656d6 Utils: Make PagedSettings::readSettings() calls shorter
Ideally, this would not be needed on the user code side at all, but
there's no way to ensure the settings are read timing before sibling
constructors might need it. So keep the 'poor man's two-phase
initialization', but make it less intrusive.

Change-Id: Ica7f6510cd05072d7286f4e85cd72c494e8f10f8
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-05-16 16:36:25 +00:00
hjk
824de3046c CppCheck: Rework settings handling
Change-Id: Id9c9b316c5e0d39bc5fcba14951664e72d947a71
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-05-16 16:03:37 +00:00
hjk
77c19ae213 Utils: Add minimal Flow layout support to layout builder
It will be used in the CppCheck option page.

The de-facto copy of utils/flowlayout.{cpp,h} is intentional
to keep the layout builder usable stand-alone.

Change-Id: Ibda3ece2aeb3cbb1badaf6083b52ebb63b6524ac
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-05-16 15:03:41 +00:00
Marcus Tillmanns
7e5ba6c993 Terminal: Fix CellIterator again
The updateChar() was only called when m_pos == 0. It needs to be called
unless m_state == End though.

Change-Id: I2c9a7c151420395d18f2846705d57129d7afc5f3
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-05-16 13:37:20 +00:00
hjk
671621d79b Utils: Introduce a FilePathAspect
A shallow wrapper around a StringAspect with a suitable operator().

Change-Id: I0a5e121565d03573faa5c3f4085d72db2b9c3774
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-05-16 12:59:44 +00:00
Cristian Adam
1e595c6afe Terminal: Fix exiting of conpty terminals
QMetaObject would complain about not knowing about the HANDLE type.

Change-Id: Iae240bed37c892561eaacdc1d22cf4ae0173df29
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-05-16 12:57:07 +00:00
hjk
d6111f2e1d ProjectExplorer: Remove some pointerage around KitOptionsPage
Change-Id: Ib1736a80739c6052372896bac03aa324fd807151
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-05-16 12:45:24 +00:00
Marcus Tillmanns
3416ccd7ec Terminal: Fix selection
When moving the mouse left or right out of the viewport
the selection would grow into the previous/next line
without the bounding.

Change-Id: Ica38eac3b306338ef24aa4abace66f110edb2aef
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-05-16 11:50:18 +00:00
hjk
22fa5f2d3a Haskell: More compact settings/manager setup
Use PagedSettings, move related parts Manager interface there, too.

Change-Id: I079dad8bbbea39d2424a25867b08c34ab0234ad5
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-05-16 11:19:14 +00:00
hjk
21cb45e665 App: Remove workaround for crash in regexp jitting in Rosetta
The relevant Qt bug was fixed upstream.

This effectively reverts ab16f2984b

Task-number: QTBUG-97085
Change-Id: I2ccf50f83b42111bbeaa26dfd95b1eb69a62c3bf
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-05-16 11:08:26 +00:00
Christian Stenger
39f27a8eb8 Squish: Fix layout of server settings dialog
Broke with the overhaul of the layout builder.

Change-Id: I94da9c8f6b2a67b43b8bfe08e838dbd38400c2f4
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-05-16 10:53:56 +00:00
hjk
b91f234c7d ExtensionSystem: Start reworking initialization order system
Allow specifying object creation without immediate creation
(but create them nevetheless very soon).

Change-Id: I01b91f7cf753ced61705d3f26352548b268be6b5
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-05-16 10:51:14 +00:00
Christian Kandeler
7869c4e810 CppEditor: Add quickfix for creating a member function from use
Fixes: QTCREATORBUG-10356
Change-Id: If7376e766f2817949259591560c74bd6fb0e0cd6
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-05-16 10:32:04 +00:00
David Schulz
9758e71458 Utils: add tests for Position::fromPositionInDocument
Change-Id: I2b530cf62a4defe0292c51834b1e5093a7d5e55f
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-05-16 10:30:15 +00:00
Jarek Kobus
00d8e9d717 SpotlightLocatorFilter: Remove no-op call to setConfigurable(true)
Change-Id: Iafc9b1f3f7e0e5e214b44ab29bbd2537a0bbb569
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-05-16 10:12:24 +00:00
Jarek Kobus
b8a56abb22 LocatorWidget: Drop Utils namespace qualifier
Change-Id: Ife0fb3a5908326136531801c6d8e372ed10827a4
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-05-16 10:11:34 +00:00
Orgad Shaneh
1512aaa0cd Build: Avoid passing unsupported flag to MSVC linker
Change-Id: Ia73aeccb824bca10ce928cb82d5ad77033521527
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-05-16 09:45:46 +00:00
Christian Stenger
2bf5cc81b5 Haskell: Build with Qbs as well
Change-Id: Ia8f9fd3c22acc50c149594859a0471b0e58fc027
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-05-16 09:25:37 +00:00
David Schulz
479d7e3732 Utils: remove duplicated test
Change-Id: I0391feb848af09295afd9d3e84e25337023c24b6
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-05-16 08:55:21 +00:00
Marco Bubke
8b2d7977ca Utils: Make CTAD work with std::unexpected
Aliases are not working with CTAD before C++ 20. Instead of aliasing
some types we simply importing the namespace tl into the namespace
Utils. This enables some not aliased things too.

Change-Id: Ic61a50bedbbf7253ecb5bb1f6dc0624dcc704aa0
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-05-16 08:45:43 +00:00
Jarek Kobus
4195b4e7e2 ILocatorFilter: Remove calls to setDefaultIncludedByDefault(false)
By default, setDefaultIncludedByDefault() is set to false, so
no need to repeat it now in direct subclasses.
Leave it only inside the AllProjectFilesFilter,
as the DirectoryFilter superclass sets it to true.

Change-Id: Ib66d112a3bfeed52315663f6898148cf5c5d88b1
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-05-16 08:34:02 +00:00
Jarek Kobus
c8c48d899f Locator: Fix style and reuse LocatorFilterEntries
Fix names of private members of LocatorModel to have
one common style.

Reuse LocatorFilterEntries where possible.

Change-Id: Icca1e396b9fafd165adf35939dd7859032f90c0c
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-05-16 08:33:36 +00:00
Jarek Kobus
23f7352834 ILocatorFilter: Remove prepareSearch() and matchesFor()
Implement matchers() instead.
Make matchers() a pure virtual method.

Change-Id: I931cb9a5787bc796968cd2123e14d33002169588
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-05-16 08:32:39 +00:00
David Schulz
b4734ff727 Utils: add tests for Position::fromFileName
Change-Id: I321b91567e47e08883c7b991cd24d02bb8a9b9c6
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-05-16 08:24:28 +00:00
Jarek Kobus
e2df60abc2 BaseFileFilter: Remove me - I'm not needed anymore
Change-Id: I19effcb846f57838b47352c19aec0d521e1c3ecd
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-05-16 08:13:02 +00:00
hjk
318ac76339 QMakeProject: Use PagedSettings page for options
Also adapt to a few recent usage changes.

Change-Id: I33f45fe7c2b8738280a7c81ddb9110cb8714c45a
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-05-16 08:10:08 +00:00
Jarek Kobus
bc11440256 RunConfigurationFilter: Remove the old matchesFor() implementation
Since the base class vanished, rename the filters so that they have
the common prefix now.

Change-Id: I21c8d1f3ea3c3ad22063d7db8be72e66d449e701
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-05-16 07:57:06 +00:00
Jarek Kobus
ef0cc8a1d9 ExecuteFilter: Remove the old matchesFor() implementation
Change-Id: Ib1f001f366ef78f359d7c04cf8861ae59b9d22a9
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-05-16 07:56:54 +00:00
Eike Ziller
8bd5c67ea8 German translation: CVS
Change-Id: Iac295e700edf365b06b01bbb3a20c2f2f190a5ab
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Robert Löhning <robert.loehning@qt.io>
2023-05-16 07:17:50 +00:00
Marcus Tillmanns
a3e9fc37ba Terminal: Fix assert
Trying to fetch a cell outside the valid range did trigger an
assert.

Change-Id: I5ac3d78aa2249d1559e7603c9e4a9bcea4d0b563
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-05-16 05:01:49 +00:00
Cristian Adam
9ff0cf7306 CMakePM: Add action to reload CMake Presets
The CMake presets will be reloaded. The preset kits will get the CMake
configuration cleared (no more CMakeCache.txt)

All the kits will be removed from the project, so that the Kit
configuration wizard will be displayed at the end.

If a normal Qt Kit was configured, the user will get the chance to
import the existing configuration (the initial configuration will be
lost though).

Change-Id: Ieda83098d7716913d7870b67ab522705da4ed93b
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2023-05-15 15:13:23 +00:00