Hopefully the last structural change for a while.
Settings lifetime is again tied to the plugin private.
Change-Id: I221e8b8baa69422306191b48a9f034ef5b1a0dc2
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
The close signal of the conpty process needs to be delayed
as it otherwise might arrive before the last output of
the process.
This should be fixed in the future by using overlapped io
for the pipes.
Change-Id: I49fe4863672a0b14f5766bbe5ee7b1d8894594ca
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Use PagedSettings, make setup more local, remove Q_OBJECT
Change-Id: I9e91f9e63ed8ad15749323bd039d118562dba1a6
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Currently the process stub does not support starting / debugging
processes on remote devices. To reflect this the "Run In Terminal"
aspect is disabled for remote targets.
Fixes: QTCREATORBUG-29058
Change-Id: I9b3bcd65d4db468c683f2743a49227bfbecaf3d3
Reviewed-by: hjk <hjk@qt.io>
I am still not sure how the final pattern may ideally look like
but it looks like some kind of singleton access to a plugin's
settings helps with clarity.
Change-Id: I6a6a5f5b7cfdfb062f5b5231a79086f34e09487f
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This fixes the issue that no copilot suggestion were shown after
switching documents.
Change-Id: Ic81bfbe266877964eeaf688d9915a7937607118b
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
It's sometimes not so easy to trigger the volatileValue() != value()
branch, so create a way to be explicit when needed.
Change-Id: I322508a33c935077038d730fd09c819419901353
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Rename some workspace filter classes to conform to
the names for cpp filters.
Remove some unneeded intermediate classes now.
Change-Id: I1ec0dbb7ed91944e9dd8b1b0f4878b826191a020
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Changed settings had been taken into account only after
an explicit Apply and this may be rather confusing.
Change-Id: I344ddf18a3cb15b0bc2d2b41a38587395b592e46
Reviewed-by: hjk <hjk@qt.io>
The process could be not set up correctly or at all if
we exit the start function early.
Avoids a soft assert.
Change-Id: I9f0d71acc4a440b85dbb26fa656e0b551ae685f4
Reviewed-by: hjk <hjk@qt.io>
In file included from .../src/plugins/debugger/registerpostmortemaction.cpp:6:
.../src/shared/registryaccess/registryaccess.h:26:21: warning: 'RegistryAccess::autoRegistryValueNameC' defined but not used [-Wunused-variable]
26 | static const WCHAR *autoRegistryValueNameC = L"Auto";
I don't think using static in a header is a nice thing, inline would
work, but we have constexpr which implies inline.
Change-Id: I7b872e65a554a9a9feb39845717c5dba7ba6777c
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Use it consistently inside ILocatorFilter subclasses, instead
of FuzzyMatcher.
Drop repeated default arguments from the caller.
Change-Id: I53762f27216a30ed0281f3d0ddc5e50c7452559a
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
In contrast to applied() only emitted if anything was dirty before.
Ideally, applied() would not be needed, but I am not sure about
downstream uses.
Change-Id: Ie0c293b8730c503fc4409884a33207ee9ca5f129
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
This can make the user code look a bit nicer.
Change-Id: I98867114810ede2f04342144f600682ff3c261b4
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Plan is to eliminate AbstractSettings as much as possible and
use Aspect functionality instead.
Change-Id: Idb71fb4df0893ffa4713b0182c21725f0c71089e
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
This also uses the "Enable auto format on file save" bool directly
for the now-checked group box.
Change-Id: I7f3f392828f6ccfda99fa1d757f49cb9e3b6bc1b
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
add_qtc_library would have set the POSITION_INDEPENDENT_CODE property
for STATIC libraries on UNIX based systems.
The OBJECT libraries need the same treatment.
Change-Id: Ia333a36ea0f35d7db3ed876cdde5b895b47644c7
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Script location is changed from qtsdk.git to tqtc-qtsdk.git.
Adjust the coin instructions to use the new location.
This change should be picked to all the branches in use.
Task-number: QTQAINFRA-5506
Change-Id: I78abb36781cfaaff72870c297ba152066ac5f385
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Makes sure that the CMake parameters columns are properly stretched when
Qt Creator window is being resized or maximized / restored from
maximized state.
Fixes: QTCREATORBUG-27257
Change-Id: Ifb4d439fb758dcc5b2593be917ba35e9c79f2840
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Calling toCaseFolded is expensive if the same filepath is hashed
often, so we calculate the hash value once and cache the result.
One such case was found to happen when parsing tests,
as the cpp parser is queried a lot and it uses hash maps / sets
with filepaths.
Change-Id: Ic3ca7f09e8f108f5a89b3fdb17743ae7c3258001
Reviewed-by: hjk <hjk@qt.io>
Those functions are based on the assumption that the passed text starts
at the begin position, which was good enough for search results, but if
used in other parts of the codebase it might give unwanted results.
Calculate the length of the range now as expected and subtract the
beginning lines.
In order to still got the correct results for the text result texts
modify the result range to always start at the first line before
calculating the length of the range.
Also add tests for the modified functionality
Change-Id: I7ccd75b642dda6dd4f738877cbe3543d46c03652
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
