Commit Graph

80529 Commits

Author SHA1 Message Date
Samuel Ghinet
907a64ac32 Fix bug: drag state remain on after dragging asset to texture
Task-number: QDS-8341
Change-Id: If9bc7c0e3f2e017df4fde2cf94e7ffc168644eef
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2022-11-25 14:27:03 +00:00
Jarek Kobus
133099aa81 AbstractRemoteLinuxDeployService: Simplify internals
Change-Id: Ib24c00405f863788f3b72107891193b566feb3e7
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-11-25 13:35:34 +00:00
hjk
49d6456b66 CppEditor: Remove WorkingCopy::get(QString) overload
... and fix fallout.

Change-Id: I8fe67616f8f327428b1c166ae69ec34c2924ee9f
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-11-25 13:34:34 +00:00
hjk
9ceaf39929 CppEditor: Remove WorkingCopy::{revision,source}(QString) overloads
... and fix fallout.

Change-Id: I3748d0f90345c0d92321d465abfc3d324ee49a0c
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-11-25 13:34:17 +00:00
Jarek Kobus
f2f1b7c2d7 AbstractRemoteLinuxDeployService: Refactor API
Instead of implementing two virtual methods:
- doDeploy
- stopDeployment
provide just one to be implemented:
- deployRecipe

The new method returns task tree description enclosed in
Group recipe. The abstract deploy service constructs the
TaskTree when needed, applies the recipe and starts the tree.

Change-Id: I36e52935f98736dafeea6be32fde5595410db077
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-11-25 13:33:47 +00:00
Jarek Kobus
bec3b9279b CustomCommandDeployService: Reuse TaskTree
Change-Id: I9ed0a9279bbbf88b810331e100c7799191d93602
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-11-25 13:24:42 +00:00
Jarek Kobus
c01ab460c8 QdbMakeDefaultAppService: Reuse TaskTree
Change-Id: I03ee1935e7b0b0cc82f139f7f435d3194ff29f01
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-11-25 13:21:41 +00:00
Jarek Kobus
9e810acfbe QdbStopApplicationService: Reuse TaskTree
Change-Id: I6086ccda3b3b5489f9553fbd2cb7c7b8950e17f9
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-11-25 13:18:39 +00:00
Jarek Kobus
2853d39065 KillAppService: Reuse TaskTree
Change-Id: I250542724d537219a8c1ce222d7e941474671adf
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-11-25 13:18:16 +00:00
Jarek Kobus
0c18fbc31f ProjectExplorer: Provide task tree adapter for DeviceProcessKiller
Change-Id: I45133dcba07d5fc5fa721c0af13ba86f75985a5e
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-11-25 13:17:48 +00:00
Jarek Kobus
c99dd6650d UpdateInfoPlugin: Readd vanished comment
Amends d4871731bd

Change-Id: I34288f977ac913a77c98a201873783d3d879369d
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-11-25 13:08:45 +00:00
Jarek Kobus
c38a00513e ProjectExplorer: Introduce DeviceProcessKiller
It will be much easier to integrate it into TaskTree,
comparing to hierarchical DeviceProcessSignalOperation.

Change-Id: I6bc9580a3d88d7bfd01e641b09094c6fa8fb94d3
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-11-25 13:03:52 +00:00
Jarek Kobus
d4871731bd UpdateInfoPlugin: Reuse TaskProgress
Change-Id: I35ad1005adb269d016b35fabfbccf27e92d3dfb9
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-11-25 13:03:36 +00:00
Jarek Kobus
7afe536a5c AdvancedDockingSystem: WorkspaceDialog: Use Layouting
Change-Id: I998147908941b4390c810983a5676628f07b1250
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-11-25 12:56:15 +00:00
Jarek Kobus
bcdfe1cedc TaskProgress: Add missing features needed by UpdateInfoPlugin
Change-Id: Iabfbebd07699fbe45da6007347ed45517d593cfd
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-11-25 12:49:19 +00:00
Jarek Kobus
d90b1946d4 TaskProgress: Improve fluency of progress
Change-Id: I8efb0242c035223bb52cb2684a30b57f44b489f2
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-11-25 12:49:14 +00:00
Eike Ziller
cb8742ccab Make it possible to select default session from menu
when we are in the limbo state where no session has been loaded, and the
default session has not been explicitly created or loaded yet.

Fixes: QTCREATORBUG-28393
Change-Id: I66d69561e18b5073a477d90c1926074e3cd97cee
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-11-25 12:37:40 +00:00
Jarek Kobus
16f671874f BuildStep: Remove unused runInThread() and cancelChecker()
Change-Id: I9d4a858a25ab93b17f1018cecc785b42dd76ecc0
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-11-25 12:15:32 +00:00
Jarek Kobus
1e632d0c25 AndroidDeployQtStep: Make it cancelable
And use QFutureInterface for it.

Change-Id: I1145b70b119d92af7316977c813f4f29b1f20b74
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2022-11-25 12:15:18 +00:00
David Schulz
3cd3bba720 Debugger: update thread selector after setting current thread manually
The issue is only reproducible when interrupting a running inferior with
cdb.

Change-Id: I336413d7f36aad28108623eb1bf8015b42f3dbb4
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-11-25 12:13:45 +00:00
Thomas Hartmann
21c659400a StudioPlugin: Use custom openOpenProjectDialog() to only allow qmlproject
Task-number: QDS-2549
Change-Id: I7393877b5f0306eafc6dbd5b5919e6592e664c16
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2022-11-25 11:59:40 +00:00
Thomas Hartmann
caccbe8377 QmlDesigner: Rename setting to avoid any interference
Rename setting to avoid any interference
with old installations.

Change-Id: Id8cb3ad4a3be6e416c4ad935856c57fc29c07503
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2022-11-25 11:59:25 +00:00
Orgad Shaneh
4225f475a4 FilePath: Do not strip macros when normalizing path
Fixes: QTCREATORBUG-28484
Change-Id: Id6bcd2aef048bd355c196013c54799e4944135bd
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
2022-11-25 11:57:04 +00:00
Samuel Ghinet
056165d071 Use double underscores instead of single ones in QML
Also, fixed some QML errors -- they didn't have any real consequence,
so they could be considered warnings. Also, AssetsView._modelIndex()
was being called with two arguments instead of one -- this didn't
result in any warnings.

Change-Id: I08274a49531a4082fa94fb89e4230fdac5b1b658
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2022-11-25 11:57:02 +00:00
David Schulz
ead1b7aa4a Editor: extend visual whitespace documentation
Tell users where the color of the visual whitespace can be configured.

Task-number: QTCREATORBUG-28501
Change-Id: I9c12cbe9d7be61dd96ad27c1eaa1a2daf69cf31d
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2022-11-25 11:51:44 +00:00
Samuel Ghinet
afc7cd2c98 QmlDesigner: Use a vertical scrollbar for "Confirm Delete Files"
Also, replaced the widgets code with QML.

Task-number: QDS-8033
Change-Id: I29f4e0bc02294e839e352096c3d4394a764cfe76
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2022-11-25 11:50:42 +00:00
hjk
038771051d CppEditor: Switch to FilePath in IndexItem
... and fix fallout.

Change-Id: I45d27146806bdcb5ceb728b710eca51c7cd32ee2
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-11-25 11:16:38 +00:00
Mahmoud Badri
6747e666b9 QmlDesigner: Open TextureEditor by double-clicking a texture
Change-Id: I58645f31f244cf4e5909b35f1cae224a55f4e9a4
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Samuel Ghinet <samuel.ghinet@qt.io>
2022-11-25 11:02:42 +00:00
Samuel Ghinet
45c7a6b8e6 Implement drag-and-drop from Assets View to Texture Editor
The asset (i.e. image) can now be dragged to the "Source" property of
the Texture Editor.

Task-number: QDS-8341
Change-Id: I2d30bdf245a8328a864c116c727d3faaaad347cc
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-11-25 10:57:55 +00:00
Christian Kandeler
0f202ea724 ClangCodeModel: Restrict opening non-project files to headers
We cannot tell clangd to opt out of indexing for certain files, so we
must prevent "foreign" sources from ever getting opened, or we will have
strange effects in the case of non-unique symbols.
Note that there are more (upstream) problems in this area, but this
patch limits the damage at least.
Amends 8ad7ab2d2a.

Fixes: QTCREATORBUG-28452
Change-Id: I131be699a35da8eacea6415c630e9012cc905a47
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-11-25 10:21:21 +00:00
Jarek Kobus
dbdabf9c27 Use M_PI for 3.14
Change-Id: I19078a791afa1c74cd34e59b033525e029755d7e
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-11-25 10:10:37 +00:00
Leena Miettinen
1966591c7f Doc: Use fixed links to Qt 5 Graphical Effects
To suppress qdoc errors.

Change-Id: I48556e98c7f58d9f0b59ad47051bf166edf50387
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-11-25 10:02:52 +00:00
Eike Ziller
a0e74ce3e0 UpdateInfo: Fix wrong properties for progress info
It was no longer showing "No updates found." in the status bar if the
progress details are off, and the progress details were no longer
directly hidden if updates were found.

Amends 93401c9c81

Change-Id: I53c441a990c9cbda1a49969f57eb76128ab020c1
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2022-11-25 09:40:19 +00:00
Eike Ziller
2605639144 German translation: Clang*
Change-Id: I7712ea38738448d9e017fb805d7adba11ae13c04
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-11-25 09:39:26 +00:00
Jarek Kobus
0a925009a1 RemoteLinux: Fix const correctness
Amends c88a829059
Amends f9b4bcd3d8

Change-Id: Ia9817d4f7ba7df495e55e8729ba34258c907a545
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-11-25 09:28:41 +00:00
hjk
4ad9f53989 Core: Rename DocumentModel::fileName() to filePath()
That's what it returns nowadays.

Change-Id: Ia5b8b643ad37e773db9788d8391edbb021844aec
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-11-25 09:25:12 +00:00
hjk
40ba25b691 CPlusPlus: Return FilePaths from Document::includedFile
... and fix fallout.

Change-Id: Ieaad57700fa48d0c4a0dd9bf2c284315579b9473
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-11-25 09:23:39 +00:00
hjk
ef97774122 Core: Rename ExternalTool::fileName() to filePath()
Also, setFilePath(), and some code cosmetics.

Change-Id: If24aa2d75276eafac4d7494153c5fc223be1ee8b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-11-25 09:09:48 +00:00
hjk
67e9c2d7a0 CppEditor: Proliferate FilePath use
Remove SnapShot::{find,contains}(QString) overloads and fix fallout.

Change-Id: I50c415826939e09ac111f33def611c7478fa5d97
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-11-25 09:01:05 +00:00
Henning Gruendl
3321261cf3 QmlDesigner: Fix DragHandler being disabled
The blockDragHandler property got broken when a menu item triggered a
model reset as the popup close signal wasn't triggered from the delegate
anymore.

Task-number: QDS-8133
Change-Id: If135b12a127f5fea8f3f392e0fd6475c4e188e67
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-11-25 08:59:30 +00:00
Jarek Kobus
74ba41f82c Qnx: Reuse setExtraTasks()
Change-Id: Ia392015a7a410a1920e8e79637ac6ac51c988b74
Reviewed-by: hjk <hjk@qt.io>
2022-11-25 08:57:06 +00:00
Jarek Kobus
fbe8d85401 Qnx: Reuse setExtraCommandsToTest()
Change-Id: I09e6160c1cbff9d74ac1ad3e824a0137d5964aae
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-11-25 08:56:33 +00:00
Jarek Kobus
6dc1a1e98f LinuxDeviceTester: Avoid non-trivial global variables
Change-Id: I1c3cf646ecbd6619f7c5a6eb117a0aca43d78534
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-11-25 08:55:44 +00:00
Jarek Kobus
b34fc8a420 LinuxDeviceTester: Make it possible to add extra tasks
Change-Id: I8e1308aef73a6f81fcff092ba75c1c88479c2207
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-11-25 08:55:34 +00:00
Henning Gruendl
dd2c4cc6ea QmlDesigner: Fix cloning of extended states
* When cloning an extended state add the new state after the extended
  group
* When cloning a state that extends another one also copy the extends
  property
* Fix two "call to a temporary is a no-op" clang warnings

Task-number: QDS-8412
Change-Id: I1e8595ddc69f210a27c04fc91869df3beb4ba980
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-11-25 08:52:34 +00:00
Henning Gruendl
fd1864d678 QmlDesigner: Fix disappearing plus states editor
* Fix issue the plus (Canvas) in the states editor is not drawn when
  the view was hidden before and comes back on
* Improve paint method

Task-number: QDS-8419
Change-Id: I959b4b6a418deba95380d8f5cafc7af09a0362e8
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-11-25 08:52:02 +00:00
Jarek Kobus
658c9f6f06 LinuxDeviceTester: Make it possible to test extra commands
Change-Id: I1920457a4d97bf23865ad6c4842fbdbb40c2db23
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-11-25 08:51:48 +00:00
Henning Gruendl
ccbda4655e QmlDesigner: Fix wrong initial render type quality
Task-number: QDS-8334
Change-Id: I3b79093c67fbde94504277a669448c19911ce97b
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-11-25 08:51:40 +00:00
Henning Gruendl
2388caa544 QmlDesigner: Fix wrong state group shown
Fix an issue were the wrong state group is shown when switching modes
e.g. Design > Edit > Design. It is caused by the model being attached
and the indices not forwarded to QML.

Task-number: QDS-8418
Change-Id: Ie9a99182b0230757a043397d9b906ba1bb15bed9
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-11-25 08:51:13 +00:00
Jarek Kobus
7582b62ddf TextEditor: Remove unused findFallbackDefinitionsLocation()
Change-Id: Ib5c02562087c2ee11b5aa1c19c823cf8fd2af828
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-11-25 07:25:38 +00:00