Commit Graph

80529 Commits

Author SHA1 Message Date
Jarek Kobus
dc3a4f0002 QMakeStep: Remove unneeded override
Change-Id: Ib91ee608673c6a2b33ebfe704c8f31b647ab897e
Reviewed-by: hjk <hjk@qt.io>
2022-11-30 16:14:49 +00:00
hjk
82ecd3910b QmlProjectManager: Use a PathChooser for the fallback qmlscene
Allows to browse for binaries on the target instead of having to
specify a proper fully qualified remote path manually.

Change-Id: Iaf9dc5c4fe921a7188ef2178f10403fa01e69d03
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
(cherry picked from commit 50f6afe4d0)
Reviewed-by: hjk <hjk@qt.io>
2022-11-30 14:47:56 +00:00
Amr Essam
c7f9d9af24 QmlDesigner: adjust caller code to new binary name QQEffectMaker -> qqem
Task-number: QDS-8450
Change-Id: I8a82a31158e3c44903126b12d430b8563dde7f26
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2022-11-30 13:34:13 +00:00
hjk
7e9d50a2c9 Remove a few now-unnecessary cleanPath in conjunction with resolvePath
Change-Id: I05ee0116183a30e907fbd8e0b4faae9e6e58723d
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-11-30 13:32:05 +00:00
David Schulz
69fef7480e LanguageClient: prevent nullptr access
Change-Id: Id0dc46d3775d5e765d1e7d2c2eac0d7f807f34ce
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-11-30 13:11:09 +00:00
Alessandro Portale
76804a0839 Android: Link directly to command line tools download
Change-Id: I6a5d4321a0d6c0b854730615aa33acfe4986c9b6
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
2022-11-30 12:30:13 +00:00
Jarek Kobus
a038ca5fcb AdvancedDockingSystem: Add const reference into range-for loops
Change-Id: I623e6d315180596c0dcd5bf09982e27428b4674a
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2022-11-30 11:57:05 +00:00
hjk
4eee8a12fb Utils: Clean path in FilePath::resolvePath
Change-Id: I27e34e21c2922db4d7598c77688133aebf6ce893
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-11-30 11:47:33 +00:00
hjk
8679138f73 QMake: Fix building of remote projects
Task-number: QTCREATORBUG-28355
Change-Id: I7e4a5b1b74fe7c95f8c56eb512a1714d2afb0a70
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-11-30 11:41:52 +00:00
Alexander Pershin
5e50b9d604 CMake: Checkbox for showing advanced options by default
Change-Id: I32f6ca068de60adf90eb0d9bc5eb7cfadc613e2d
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2022-11-30 11:28:04 +00:00
Jarek Kobus
d701cd5dbe AdvancedDockingSystem: Add context objects into connections
Change-Id: I564b9ffe6c7809a6d50a172062c52558f3023fc1
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2022-11-30 11:23:04 +00:00
Jarek Kobus
4080f31d25 AdvancedDockingSystem: Fix dropWidget()
I believe the original intention was to pass dockWidget
into notifyWidgetOrAreaRelocation(), otherwise the whole
"if (!dockWidget)" condition above would be no-op.

Change-Id: I0b809ec6587489eaf5e4f79c5c16f26bbb8346c2
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2022-11-30 11:22:36 +00:00
Alessandro Portale
6f7837e5e9 Android: Remove gradle.properties file handling
The modification of gradle.properties files was originally a feature of
the Android plugin which eventually moved over to androiddeployqt.

Moreover, this code got accidentally disabled in Qt Creator 4.10 and was
appartently not missed till now. I only noticed it while "FilePath-
ifying" code in the Andsroid plugin.

This change removes the gradle.properties file handling code from Qt
Creator.

Fixes: QTCREATORBUG-28494
Change-Id: Id4f2722f4965c877a065386b34a71d8368147b08
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
2022-11-30 10:53:56 +00:00
Christian Stenger
9731945788 PE: Fix compile without tests
Change-Id: Id1e4daa7eec3860d833cd0b97148d5dea74e44ef
Reviewed-by: hjk <hjk@qt.io>
2022-11-30 10:52:40 +00:00
Aleksei German
0c31cc475b QmlDesigner: Categorize slot actions
Task-number: QDS-8447
Change-Id: Ibc96bfcb7c87f0888e15f2533cab2567098a3760
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-11-30 10:45:21 +00:00
Alessandro Portale
65f27c765a Android: FilePath-ify certificate handling
Change-Id: Ic7bf25567ac74555926d105c03cdac5a9e49b5a6
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-11-30 10:29:29 +00:00
hjk
d743770493 ProjectExplorer: Code cosmetics
Change-Id: Idf96413b2fc70418efe14db5f581624028e29dcd
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-11-30 09:57:49 +00:00
Jarek Kobus
1dbf3ad120 TaskTree: Fix some clazy warnings
Change-Id: Ibd0931d1298489345f4055b43610f3a0747e05bc
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2022-11-30 09:11:42 +00:00
Amr Essam
aa69465ecf QmlDesigner: drag effects from assets view to navigator
Effects can be dragged from the assets panel to the navigator,
also effects can be dragged between components in the navigator.
There were lots of transformations because the way navigator works in not suitable with effects

Task-number: QDS-8235
Change-Id: I378a70b5586fa95d0890bda4fbe53191c7ab0bc4
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2022-11-30 09:05:43 +00:00
hjk
aad99ea408 QMake: Fix remote paths handed to the file cache
Task-number: QTCREATORBUG-28355
Change-Id: I8fe2fe5ea5bb4cdc49547a191ddf1f4af36696ba
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2022-11-30 08:42:12 +00:00
Marcus Tillmanns
fd829240ed Utils: Fix addCommandLineWithAnd for Windows
Also enable more unittests on windows

Change-Id: I241b77c640949cf622dc8138991036bb066ce3cf
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
2022-11-30 08:02:53 +00:00
David Schulz
7373193584 Debugger: map reported breakpoint file locations
Fixes: QTCREATORBUG-28521
Change-Id: I8229483df7fb0c51750e19d4558e81f5320e7f33
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-11-30 07:45:33 +00:00
Jarek Kobus
f3ce23230e TextEditor: Init markWidth variable
Otherwise some overrides of extraAreaWidth() may leave passed
value unmodified and we may end up with uninitialized value.

Change-Id: Ica89019fc2cff93f0bc7d784624730ec9d8c0224
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-11-30 07:22:09 +00:00
Jarek Kobus
05189a676f Squish: Init token variable
Otherwise it may be uninitialized when while loop finishes
immediately.

Change-Id: I7638025813d4353abc864e106ef0e09c7c218409
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-11-30 07:15:01 +00:00
Jarek Kobus
7bc86a8b8d Utils: Fix clazy "Mixing iterators with const_iterators" warnings
Change-Id: Iab29d57459713e107d7e74908df347955b9f50a0
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2022-11-30 07:14:09 +00:00
hjk
5c03387c13 QMake: Remove some dead code
Change-Id: If78e579d777a329603cc77d94e1ec98741c1ad37
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-11-30 07:12:23 +00:00
Jarek Kobus
ccb2317a16 Android: Fix clazy "Mixing iterators with const_iterators" warnings
Change-Id: I90fd2c10240a367ef546f9b48b2a2f784f00f4e0
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-11-30 07:09:10 +00:00
hjk
4417c48e7b Utils: Remove FilePath::operator+()
This was a alias for .stringAppended(), but can be used too easily
when .pathAppended() is meant.

Change-Id: Ia3b64d39828d4074b43d87c923ce3a6a87038948
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-11-30 06:57:02 +00:00
Tim Jenssen
5d9cb68a36 qml2puppet: fix include when building against linux Qt5
Change-Id: I17401443a1e099b9c63d0de2e6f8bf5c3e9cfcb3
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2022-11-29 20:17:32 +00:00
Jarek Kobus
72a01bd00e ClangTools: FilterDialog: Capture by copy
A reference to buttonBox gets vahished after c'tor of FilterDialog
finished. Capture by copy the buttonBox.

Amends b72ae58629

Fixes: QTCREATORBUG-28524
Change-Id: Id6eaf826243e307f26a91c4bd6386cf836bce111
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-11-29 19:41:09 +00:00
Tim Jenssen
036948c628 qml2puppet: remove unnecessary flexibility
standalone builds are doing:
cmake --install . --prefix <something_with_bin>

Change-Id: I61c0743c00f96c0505e2fa383e4bee41c2b6ceb9
Reviewed-by: Burak Hancerli <burak.hancerli@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2022-11-29 17:04:00 +00:00
hjk
b183efc94a ProjectExplorer: Append paths, not strings
For qbs.

Change-Id: Ifc183794baf16d51a0e6ed1c52da797b037c69c2
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-11-29 17:03:12 +00:00
hjk
3d158d73ca QMake: Constify some accessors
Task-number: QTCREATORBUG-28355
Change-Id: I25d168934da7bbc1aa6e22ac7c6bdbbfe3c3ed61
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-11-29 16:36:43 +00:00
Jarek Kobus
8fdbbccf3f SubChannelProvider: Pass PortsGatherer
I've cut a bit too much in the previous commit. Bring back
passing ports gatherer into SubChannelProvider.

Amends 302268c4d4

Change-Id: I5bf79300c7930348495757e3f9e4ab164512860e
Reviewed-by: hjk <hjk@qt.io>
2022-11-29 16:12:56 +00:00
Jarek Kobus
d29fa0f3ba TaskTree test: Detect test timeout
Detect, if test has timed out before checking other results.
When the test timed out, the task tree may still be running.
This helps in analyzing the test failures inside precheck
button.

Change-Id: Iccad85dbb8b3d621165ab8b0c5a1b82a1d6808cb
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-11-29 15:23:30 +00:00
Mahmoud Badri
b5befc6945 QmlDesigner: Fix content library sections not collapsing after search
Also enabled the auto expand for textures and environments tabs

Fixes: QDS-8443
Change-Id: I190f919ccb2cff90c7cd151e65b77ebd52f0a87c
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2022-11-29 14:55:31 +00:00
hjk
d1c7fbcb1a Core: Remove QString overload for GeneratedFile
Adapt the only remaining user.

Change-Id: Iddd8b3a51e4eccbf04272bfb2db4cab44aa6e106
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-11-29 14:48:02 +00:00
Thomas Hartmann
be97b35959 QmlDesigner: Add tool tips for animations
Task-number: QDS-8312
Change-Id: Ic580dd43c4fdb0d7f33c937c1bbe1ecfb963250a
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Mats Honkamaa <mats.honkamaa@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-11-29 13:51:50 +00:00
Thomas Hartmann
19f1c6c32f QmlDesigner: Add tool tips for positioners
Task-number: QDS-8311
Change-Id: Ie981d3a7806381237844707f6018278d5bb05354
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Mats Honkamaa <mats.honkamaa@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-11-29 13:51:17 +00:00
Jarek Kobus
302268c4d4 ProjectExplorer: Remove ChannelForwarder
It seems it didn't do anything useful.

Change-Id: I7a3cfb7b98734d7bc2d39243559b9cfc34952186
Reviewed-by: hjk <hjk@qt.io>
2022-11-29 13:35:38 +00:00
Jarek Kobus
ac966d7bb9 IDevice: Provide default implementation for signalOperation()
Don't repeat implementation returning nullptr in derived classes.

Change-Id: I437f5d206464bf92706cd135d793438f46455ad6
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-11-29 13:34:31 +00:00
Christian Kandeler
ac760f8e4a Core: Properly consider text codec when rewriting header files
The code blindly assumed the current locale's codec when reading files,
potentially breaking the content.

Fixes: QTCREATORBUG-28164
Change-Id: I390b3d4e615e5ca853faef2c6159988cc6246337
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-11-29 13:17:20 +00:00
hjk
9dc5a9ec00 CPlusPlus: Code cosmetics
Rename a few 'fileName' into 'filePath'. Remove unneeded includes.

Change-Id: I850e06cb4f58ec8dc70aa389f2521be8f5247b5c
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-11-29 13:00:11 +00:00
Tim Jenssen
cdbdde7d37 QmlDesigner: crash fix on shutdown
Change-Id: I6e20a99189c81fcb8ec0b0474a219ac1056731bc
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-11-29 12:51:27 +00:00
Jarek Kobus
bb34f507dc ChannelForwarder: Remove unused private fields
Change-Id: I25a34f6ba0a88b95b798f928940dfbf094c2ac34
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2022-11-29 12:49:34 +00:00
Jarek Kobus
ef6020ae0f QtcProcess: Set Starting state a bit later
To avoid resetting it back again to NotRunning
in case an assert triggered.

Change-Id: I4ba52bb64fd3b782013cf47d9149bef7f8a231af
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
2022-11-29 12:49:24 +00:00
Jarek Kobus
b31249d753 CrashHandlerDialog: Use Layouting
Change-Id: I6579c05b20e598c28c0ef68bd6f4f76d160ee950
Reviewed-by: hjk <hjk@qt.io>
2022-11-29 12:42:20 +00:00
hjk
83720540a1 CppEditor: Convert parts of ModelManagerInterface to FilePath
Change-Id: If7503b6d6732e1735eb8d48ece6e80886d10c647
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-11-29 12:27:10 +00:00
Jarek Kobus
9a32aae706 ChannelForwarder: Remove unused m_fromUrlGetter field
Amends 19d93d29a9

Change-Id: I8b693a4e70210365415ebf8c6ed55742cf20d594
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2022-11-29 12:15:54 +00:00
Christian Kandeler
2f8e962f83 Debugger: Do not force cdb when no toolchain is configured
... in the kit settings widget.

Fixes: QTCREATORBUG-28458
Change-Id: I75907bfeeff56173fb9d92045345ba0ca15584b4
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-11-29 12:11:37 +00:00