Commit Graph

80529 Commits

Author SHA1 Message Date
Christian Kandeler
89453faffe ClangFormat: Fix qbs build
Change-Id: I871a0606ab87bcdb5c554b37ac1a2887bb52acdc
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-12-07 14:51:38 +00:00
Jarek Kobus
ecf83d667c AutoTestUnitTests: Remove TestStringTable scenario
Instead, we should provide tst_StringTable that would
run GC, make a sleep inside GC being run in other thread
and execute destructor of StringTable in main thread.
In this case the test should ensure that destructor of
StringTable waits for its internal thread to finish.

Amends 7a02b39f26

Change-Id: I017b5a8f98b41ef6884c43d319858dcb16f17fba
Reviewed-by: hjk <hjk@qt.io>
2022-12-07 14:46:24 +00:00
Christian Stenger
ea01c74d50 Squish: Ensure using correct case while debugging
Especially on non-casesensitive OS we may get the information
regarding break point locations with a wrong case which would
try to set a break point and silently fail as the files are
internally used with their correct case.

Change-Id: I32a780629e1b10ea075d669b8eca812fbd994600
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-12-07 14:42:06 +00:00
Mats Honkamaa
4b6c1c9f14 Doc: Add missing views to overview page
Task-number: QDS-8404
Change-Id: I071ee72d01f7bdf007fd4eee27e6e17f35f8b5e0
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2022-12-07 14:28:12 +00:00
Christian Stenger
e620299fda McuSupport: Fix tests on Windows
Change-Id: I465fa2dc93ddeed2b3ef3d754b3992f88973862f
Reviewed-by: Yasser Grimes <yasser.grimes@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2022-12-07 14:06:35 +00:00
hjk
9a8d34ecf8 CplusPlus: Pass FilePath to Preprocessor::run()
... and update caller sides.

Change-Id: I6a107e4a7fd9f7123cdc6f141da202845bcbbb66
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-12-07 12:58:31 +00:00
Jarek Kobus
89f4381964 StringTable: Switch off debug printouts by default
Amends 7a02b39f26

Change-Id: Ie5ee3cd6119adf47149dcfaf4a6847474dcf4dbd
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2022-12-07 11:45:37 +00:00
Jarek Kobus
0c9706ada9 CppTypeHierarchy: Don't keep pointers to temp objects
When building type hierarchy the pointers to list
elements were put into queue. Later, the list was
modified and it was possible that list detaches
causing stored pointers to be invalid.

Simplify building type hierarchy by adding helper recursive
methods.

Fixes: QTCREATORBUG-28529
Change-Id: I240513fc097536d2175e2242766127b92aaa6a82
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-12-07 11:28:15 +00:00
Jarek Kobus
c5a27770f4 InfoBar: Always order buttons in the same order
Change-Id: Ic95aa15ba770b6c75eb3a48bdfabdb7420f8d6ae
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-12-07 11:26:10 +00:00
Jarek Kobus
e2155a91df CppTypeHierarchy: Don't create/store QIcon in non-GUI thread
Store Utils::CodeModelIcon::Type enum instead.
Drop unneeded CPlusPlus::Symbol *declaration from CppDeclarableElement.
Remove unused CppClass::operator==().

Task-number: QTCREATORBUG-28529
Change-Id: Ie3487fa5f73d714ef375c42f1e64023ccc4194ee
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-12-07 11:24:34 +00:00
David Schulz
8c8f3e30b5 LanguageClient: Fix handling of defective language server
If the language server cannot be started, the client might be already in
an error state before the language server gets initialized.

Change-Id: Ib6c9df13b381e7854806714c07f4830796bb2cd3
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-12-07 10:58:31 +00:00
The Qt Project
b7e70592d6 Merge "Merge remote-tracking branch 'origin/9.0'" 2022-12-07 10:53:46 +00:00
Marcus Tillmanns
bd716a16bb languageclient: Write errors to log file
Helps the user to better understand why his language server might
have a problem.

Change-Id: I9440a28cb5d0d35808b497bcdcd545d7b10597a0
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-12-07 10:30:10 +00:00
David Schulz
d011733131 Core: never disable the replacement edit of search results
We need to be able to change the replacement text after a failed clangd
replacement request.

Change-Id: I0e97af18c6cbfd4bc4e4f8705a7b760dd97bd960
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-12-07 09:53:32 +00:00
Eike Ziller
b4fed03c27 Merge remote-tracking branch 'origin/9.0'
Conflicts:
	src/plugins/cppeditor/cppeditorplugin.cpp
	src/plugins/docker/dockerdevice.cpp

Change-Id: I41747ff9490e4ab20340d4d4acb4655100aaa3d2
2022-12-07 10:47:47 +01:00
Jarek Kobus
36ffacabe7 ExtensionSystem: Fix some clazy warnings
Fix use multi-arg.
Add a context object to lambda connections.

Change-Id: I02711c9ecc55188fb174895f7df59f25effd0834
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-12-07 09:28:32 +00:00
Artem Sokolovskii
0b9711b9c5 ClangFormat: Get rid of ui files
- new clangformatchecks files are generated based on
utils/layoutbuilder

Change-Id: Ie376755abc632083898e44ea57d2ff8600e47f34
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2022-12-07 09:26:11 +00:00
Eike Ziller
d8343b4b46 Fix crash after closing preferences opened from indexing progress
The preferences dialog is modal and creates an event loop that would be
running within the mouse event handler of the widget. When the dialog is
closed after the widget is destroyed (i.e. after indexing finished),
control would be passed back to the destroyed widget, and crash.

Fixes: QTCREATORBUG-28566
Change-Id: I71efa683822b5682ad1b38c39ce8f73c89bdd610
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-12-07 09:26:10 +00:00
Artem Sokolovskii
e58c60ec9d ClangFormat: Remove without margins layouting from script
Change-Id: Iddf69e73ca5df48541e83030b2a09e7833f9fa64
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2022-12-07 09:25:56 +00:00
Miikka Heikkinen
a5fb9fc95f QmlDesigner: Add "Apply as light probe" option to material browser
Textures in material browser can now be applied as light probes to
the active SceneEnvironment node.

Also changed the logic for resolving the active SceneEnvironment node
to prefer a currently single-selected SceneEnvironment node over
the SceneEnvironment node associated with currently active 3D scene.

Fixes: QDS-8472
Change-Id: I9a3a7b9c2fad3c8120e85ade507a7ea66de19f1d
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2022-12-07 09:20:50 +00:00
Artem Sokolovskii
76568d8232 ClangFormat: Create new generateclangformatchecks file
- new generateclangformatcheckslayout file generates two
clangformatchecks files .cpp and .h, which contain UI Layout
based on utils/layoutbuilder

Change-Id: I4a83e542f089618d0cbd552dc99485b9428b4106
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2022-12-07 08:39:48 +00:00
Marcus Tillmanns
89b81b6046 Docker: Don't show auto detect controls
When a docker device is auto-detected (created by the installer)
we do not want to show the auto-detect controls.

Change-Id: I31f07f4fbb595bb52787e358a8467e46c862ee48
Reviewed-by: hjk <hjk@qt.io>
2022-12-07 07:56:03 +00:00
Jarek Kobus
ebe708c1a3 AbstractProcessStep: Remove processStarted() virtual method
Add concealedParameters / setConcealedParameters instead, to be
used in AndroidBuildApkStep.

Use concealed parameters also on start failure and on done.

By default, concealedParameters() equals processParameters()
(i.e. no sensitive data to hide) unless the implementation decides
to replace some sensitive data (e.g. password) with asterisks.
In this case the reimplementation needs to store separate instance
of ProcessParameters and redirect the pointer of
concealedParameters() into own structure.
This is being done through a call to setConcealedParameters().

Change-Id: I8b1573b007c0f8a10c9592ccaf25e6f088f04691
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-12-06 22:45:40 +00:00
Tim Jenssen
c9f7d893f4 Merge remote-tracking branch 'origin/9.0' into qds/dev
Change-Id: I7f394c76256d1d24fbc2d40937f3f7a63fb854c1
2022-12-06 16:31:58 +00:00
Jarek Kobus
216f3dd243 AdvancedDockingSystem: Add context objects into connections
(cherry picked from commit d701cd5dbe)
Change-Id: I564b9ffe6c7809a6d50a172062c52558f3023fc1
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2022-12-06 15:58:58 +00:00
Jarek Kobus
8a7b1d7a00 AdvancedDockingSystem: Add const reference into range-for loops
(cherry picked from commit 0a8c1d6e85de2ac4d73145886cf8a593f90de171)
Change-Id: I623e6d315180596c0dcd5bf09982e27428b4674a
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2022-12-06 15:56:07 +00:00
Jarek Kobus
c7eb6b8ae6 AdvancedDockingSystem: Fix dropWidget()
I believe the original intention was to pass dockWidget
into notifyWidgetOrAreaRelocation(), otherwise the whole
"if (!dockWidget)" condition above would be no-op.

(cherry picked from commit 4080f31d25)
Change-Id: I0b809ec6587489eaf5e4f79c5c16f26bbb8346c2
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2022-12-06 15:54:28 +00:00
Miikka Heikkinen
fb24f791b8 QmlDesigner: Fix texture source path for newly created textures
Fixes: QDS-8448
Change-Id: Ibaf51444f2dff8d3de95edd4c8afbc7bc2cd2241
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-12-06 15:49:27 +00:00
Jarek Kobus
7cf6d9c97b CMakeBuildStep: Get rid of m_waiting field
Change-Id: Iea737960f57e93fa1e688ed43eedf1bf44204709
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2022-12-06 14:24:46 +00:00
Alessandro Portale
6d63430611 Android: FilePath-ify RunnerWorker
Change-Id: If8e8c2ba94047bbb48a2ae5fee68d4c12d952fd6
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2022-12-06 14:24:38 +00:00
Alessandro Portale
fe294fb00d Android: Remove extra margin from AndroidDeployQtStep widgets
Change-Id: I7e91d6b5405c30c4af3a1b19e836b1a19bb5f90b
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2022-12-06 14:24:22 +00:00
Artem Sokolovskii
f93404d405 CodeStyle: Fix loading settings at the start in codestylesettingspage
Fixes: QTCREATORBUG-28450
Change-Id: I578c6cd102e4753d3af562986dad62e10e54d06d
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-12-06 12:44:45 +00:00
Christian Stenger
538b77e376 CompilationDatabasePM: Fix test on Windows
Change-Id: Id771d3fbcb111ef3b8c4177981794c3bd841cedc
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-12-06 12:30:04 +00:00
Marcus Tillmanns
7bb63f5b21 Clangd: Change the Log target to "Ui"
If the error messages of clangd are not shown in the Ui, it is very
difficult / impossible for the user to analyze problems when they
occur.

Change-Id: I81e2fc9aa999332147837adf54dfac49233e6f99
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-12-06 12:20:10 +00:00
Marcus Tillmanns
46eccf229c Docker: Add clangd executable option
Change-Id: I93fbd9a7a6b0189ca31cc05b35df9d1636da29a3
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-12-06 12:19:57 +00:00
Marcus Tillmanns
79c2984222 Docker: Make hostname valid for Urls
Change-Id: I026aee70503699fcada30948195a7ebd4c76aeb0
Reviewed-by: hjk <hjk@qt.io>
2022-12-06 12:02:04 +00:00
Marcus Tillmanns
0f4430ca05 Docker: Don't try to mount empty folder
Change-Id: I90479d21dd29a291e7d391464efaf40d6a50b662
Reviewed-by: hjk <hjk@qt.io>
2022-12-06 11:41:17 +00:00
hjk
7a02b39f26 Utils: Promote CppEditor::StringTable
It's useful on a more general level, and it's only useful as
real singleton.

Change-Id: I1da38a8eb6f9332a36261288d1b088ca6204eb7a
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2022-12-06 11:40:11 +00:00
Jarek Kobus
9d5d350f8f StringAspect: Fix setting readOnly
Change-Id: Ie8060052c04aec23dfb2b68d127c323dc017844e
Reviewed-by: hjk <hjk@qt.io>
2022-12-06 10:53:03 +00:00
hjk
5c7d842975 Utils: Compile fix after SiC change in Qt Core
__/__/libs/utils/filepath.cpp.o -c /data/dev/creator-bisect/src/libs/utils/filepath.cpp
/data/dev/creator-bisect/src/libs/utils/filepath.cpp: In static member function ‘static QString Utils::FilePath::calcRelativePath(const QString&, const QString&)’:
/data/dev/creator-bisect/src/libs/utils/filepath.cpp:1121:26: error: ambiguous overload for ‘operator+=’ (operand types are ‘QString’ and ‘const char [3]’)
 1121 |             relativePath += "..";
      |             ~~~~~~~~~~~~~^~~~~~~
In file included from /data/dev/qt-6/qtbase/include/QtCore/qstring.h:1,
                 from /data/dev/qt-6/qtbase/src/corelib/time/qdatetime.h:8,
                 from /data/dev/qt-6/qtbase/include/QtCore/qdatetime.h:1,
                 from /data/dev/qt-6/qtbase/include/QtCore/QDateTime:1,
                 from /data/dev/creator-bisect/src/libs/utils/filepathinfo.h:6,
                 from /data/dev/creator-bisect/src/libs/utils/filepath.h:8,
                 from /data/dev/creator-bisect/src/libs/utils/filepath.cpp:4:
/data/dev/qt-6/qtbase/src/corelib/text/qstring.h:708:21: note: candidate: ‘QString& QString::operator+=(const QString&)’
  708 |     inline QString &operator+=(const QString &s) { return append(s); }
      |                     ^~~~~~~~
/data/dev/qt-6/qtbase/src/corelib/text/qstring.h:711:14: note: candidate: ‘QString& QString::operator+=(q_no_char8_t::QUtf8StringView)’
  711 |     QString &operator+=(QUtf8StringView s) { return append(s); }
      |              ^~~~~~~~

Change-Id: I7da443cc6070f406252106a26179afb36fa24eee
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-12-06 09:43:49 +00:00
Jarek Kobus
b009eff301 TaskProgress: Add setHalfLifeTimePerTask()
Make it possible to specify expected half-life time per task.
Make TaskProgress more fluent (50 Hz).
Use exponential interpolation for TaskProgress.
Set 30 seconds half-life time for UpdateInfoPlugin.

Change-Id: I1b8a147f259caf6a11fbe06afd8cfe6d4606bb02
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2022-12-06 06:45:12 +00:00
Ulf Hermann
d6484109b7 Add missing Q_OBJECT to PerfRunConfigurationAspect
Without this we cannot identify the aspect when trying to retrieve the
settings. Therefore, we always run without any settings, and in
particular with an empty command line for perf.

Fixes: QTCREATORBUG-28545
Change-Id: Ia419c939d57ff65eca4992faff02c121ca20c83f
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2022-12-05 16:47:05 +00:00
Christian Kandeler
36ebb4bf22 CppEditor: Move "Show Preprocessed Source" action further down
... in the menus.

Fixes: QTCREATORBUG-28537
Change-Id: I51b4a258da8d654521d0e32256a7143960898227
Reviewed-by: hjk <hjk@qt.io>
2022-12-05 15:27:11 +00:00
Mats Honkamaa
0e0a196b7f Doc: Add documentation for new particle components
Add documentation for Dynamic Burst, Line Particle,
Repeller, and Scale Affector.

Task-number: QDS-8005
Change-Id: I31402641db4ee717bd1f19995d1ebb50c838a007
Reviewed-by: Antti Määttä <antti.maatta@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
(cherry picked from commit 8352418ef6)
Reviewed-by: Mats Honkamaa <mats.honkamaa@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-12-05 14:02:33 +00:00
Mats Honkamaa
aa8b9572b4 Doc: Fix typo
Task-number: QDS-8196
Change-Id: I1316ba5fa54070950b6277c0f234ff8e2d36d9f8
Reviewed-by: Esa Törmänen <esa.tormanen@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
(cherry picked from commit 20ee8a5b4b)
Reviewed-by: Mats Honkamaa <mats.honkamaa@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-12-05 14:00:55 +00:00
Mats Honkamaa
69c042b6fd Doc: Add content library, texture view docs
- Document content library
- Document texture library
- Update Material browser docs

Task-number: QDS-8369
Change-Id: I162a3f105dc227a93b9cea3566996d0ab7c51eaf
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2022-12-05 13:36:05 +00:00
Mahmoud Badri
2987f5a96c QmlDesigner: Show content library material + button only on hover
Fixes: QDS-8486
Change-Id: I2207e6558d2124bd9f602e6571ac3958da3c9cdf
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2022-12-05 12:14:47 +00:00
Henning Gruendl
e1fce66f38 QmlDesigner: Remove unnecessary function
Change-Id: I3a8c29ba7e24b10df957b4cb8fdb9f6e3acd6855
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-12-05 10:33:13 +00:00
Marcus Tillmanns
88728a414c ProjectExplorer: Fix builtin header path query
Change-Id: Iad8883cef88ac605f5ef3bc7e9922a02e4da5bd3
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-12-05 07:52:57 +00:00
Jarek Kobus
55284ba124 CMakeBuildStep: Don't use stdError
Emit addOutput() signal directly. This will add a newline after
the message. Use OutputFormat::ErrorMessage instead of
OutputFormat::Stderr.

Change-Id: Id5e95dd00dca5e57b67c583a1b11071bf4101880
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2022-12-02 16:38:25 +00:00