The SquishControlBar becomes unexpectedly parent of the
critical error message box.
If the runner stops e.g. with a broken connection to the
server due to license issues the stop triggers a shutdown
of the server which in turn destructs the control bar, but
this crashes due to the message box.
Use the "real" main window instead which also corrects the
positioning of the message box.
Change-Id: I8ec3a100a51761169d8820175196dfc84b092410
Reviewed-by: David Schulz <david.schulz@qt.io>
Different runner modes get different handlings, so reflect
this in code and have easier maintenance.
Change-Id: Ia879a0e2db1d99dd50e43dfbe439dc6d679d7da6
Reviewed-by: David Schulz <david.schulz@qt.io>
And also collect global actions from the ActionManager.
Change-Id: Ia22374a709a0cb15b314d33009e15562d226cc7b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This already has been implemented in change
dc64f3207b, but was reverted with
change f220cb0e23) because this does not
work with text wrapping rendering, due to internal limitations of Qt.
Since this is a highly requested feature (e.g. QTCREATORBUG-13727), but
an internal change within Qt is not in sight, the approach taken here
is to offer the text wrapping feature in the settings only when the
line spacing is set to 100%. Additionally, a change has been made to
the layout of the display settings page to reflect this.
Fixes: QTCREATORBUG-13727
Change-Id: Ib233cf90a5f336bc591fa1bf860e162fa774dfe3
Reviewed-by: David Schulz <david.schulz@qt.io>
This is done to avoid recursive writes to model.
Change-Id: Ie7cdd9c38fc54276a2c6617ba51137fd78946f4a
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
This replaces lots of custom painting/animating code with a simplified
implementation and cross-platform visual unification.
Task-number: QTCREATORBUG-27801
Change-Id: I18b12e8c7f0bba4ba5d8a05271ab1e757769dc5f
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Separate states and modes according to their use.
Remove state handling from perspective, let tools switch
the perspective mode, and reflect perspective mode
immediately on the perspective.
Change-Id: Ibb0338974b90fcc099517c13d685f800d9774a7d
Reviewed-by: David Schulz <david.schulz@qt.io>
Most IDEs support the "filename:linenumber" format to create shortcuts
to locations in code. This changes QTC_ASSERT() to output this format,
to make it easier to understand the reported issues.
Change-Id: I74f3f121c04ba262628ab73c457fa3e5fa760a04
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Output statistics on removed duplicate messages and merged contexts.
List remaining duplicate messages with identical source but different
translation.
Change-Id: If06f5cfc898c6261863cc53a3c464efead1d9890
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Converted old auxiliary properties usage in material preview to
the new API. Since most properties need to be both persisted to the
document and used by puppet, those properties had to be duplicated.
Fixes: QTCREATORBUG-28085
Fixes: QDS-7624
Change-Id: Idf51c773a2d49d44413bfaf69d4a683692ea8a0d
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Due to high frequency of re-usage of the processes we may clash
with the destruction of a formerly running process using the same
QtcProcess object. Explicitly closing it before (re)starting
cleanly destructs the former process.
Change-Id: Id26e55ac3aaf5c24178d168c6391ae0c51139684
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
In case of calling execute() the fully or not fully
synchronous setting is no-op now, as we execute
always in the caller thread and don't use blocking
API of QtcProcess and don't create nested event loop.
Behave the same regardless of these flags and always
setup std callbacks if needed.
Rename setupSynchronous() into installStdCallbacks()
to better reflect the current intention.
Change-Id: I93642c61d98a26c16298725f0d910d0dd80414b1
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Turn helper function to return QPixmap instead of QIcon and
scale existing resources to the desired size and take the
device pixel ratio into account.
Change-Id: I1cf73b3dd91ce1c62da8bdd8e81e04a7b0854f1d
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
The toolbar is wrapped around QScrollArea.
Because the height of toolbar (=25px) is 1px bigger than the height of
the scroll area (=24px), widgets on the toolbar move up/down 1px by
mouse wheel.
Fixes: QTCREATORBUG-28107
Change-Id: I83dc9c6d7b0916f31d5f0f15f310be3b0d149bec
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
This move the subWidget title a bit closer to its content in order to
render their relation more visible.
Change-Id: I8cb8e7967db05021a20007dc4165f132b2213326
Reviewed-by: hjk <hjk@qt.io>
The default popup of QCompleter turns off scroll bars, and it looks like
turning on scroll bars leads to the wrong size at first show if
horizontal scrollbars are needed. Turn scroll bars off and also
otherwise set the same flags on the list view as QCompleter does.
Fixes: QTCREATORBUG-11811
Change-Id: I0f013bb7c0c49d399968572cc67b939410ce7f3b
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
Also fixes an issue where "Open Shell In Container" would fail if
the container has not been started yet.
Previously only "An Error occurred" was displayed to the user if
starting the terminal failed.
With this fix it gives more info about what went wrong, and a
specific error message is created if the openTerminal.py script
is not executable.
Change-Id: I49ae0d9b2aa7d5a27a9b100830b4fdefa5a279b8
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Skip the outline update in the initialize callback since no documents
are opened at that point in time and
LanguageClientOutlineWidgetFactory::supportsEditor will always return
false. The update will be triggered in
Client::activateDocument instead.
Change-Id: Ib26115c2344f7a424c31ce09b751a1d711a93aae
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
It is easy to pick the wrong directory for FreeRTOS sources when
configuring an MCU device. This commit adds a check that the
supplied path contains tasks.c, which probably means the given
directory is correct.
Task-number: QTCREATORBUG-27180
Change-Id: Iff1242e8970e59bf334d50829dd1d5bdd8164d47
Reviewed-by: Yasser Grimes <yasser.grimes@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Piotr Mućko <piotr.mucko@qt.io>
Reviewed-by: hjk <hjk@qt.io>
Inform the user about occurred exceptions and stop ignoring them.
Fixes: QTCREATORBUG-28131
Change-Id: I24b2677aead06ea32ce8ac6a01bab68b0c4eb592
Reviewed-by: David Schulz <david.schulz@qt.io>
This will not catch all possible aliasing problems (e.g. drives mounted
into a project subdirectory), but it's still helpful.
Change-Id: Ieb1729f77887dc18df568e1ef81b093b27dacf53
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
