This was quoting them into a single argument, failing if there was more
than one.
Change-Id: Idc099970f3b747918adf7559b95e749940aad11a
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Don't delete the old ClangToolRunner directly from its signal
handler when calling runNext().
Change-Id: I55e72c1cced9ecbce492d00896d6fa161df02fd0
Reviewed-by: David Schulz <david.schulz@qt.io>
LLDB 12.0.8, which is included in NDK 23.1, hesitates to termiate when
being told to. Calling QtcProcess::stop() and using CtrlCStub on Windows
helps with that.
Amends: 17ff9317cd
Fixes: QTCREATORBUG-27723
Change-Id: Ie9d4ed23a833019f445c1517983c90ae899fbf39
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Setting / triggering breakpoints is only possible
if the target application was started with the
"block" argument.
Fixes: QTCREATORBUG-27515
Change-Id: Idafdaa87c38c8c452771897d4d845c4398d55fc4
Reviewed-by: hjk <hjk@qt.io>
Use the URL that shows all release blog posts, which increases chances
for the user to find the right one without hassle.
Change-Id: Ia34b4de031223dd8b856be3cf1596fe1db274e54
Reviewed-by: hjk <hjk@qt.io>
ExternalProject_Add runs CMake not during the CMake run of the toplevel
project, but instead it runs CMake for the external project during the
build step. And while ExternalProject passes the CMAKE_COMMAND on to the
external project, it does not do so for the CMAKE_MAKE_PROGRAM.
Make sure that the make program is also found when configuring the
external project during the build step, by adding the path to ninja to
the build environment, instead of just the CMake process.
Fixes: QTCREATORBUG-27495
Change-Id: I672ec04881387a7411836ab94655176b7a5fb681
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
When adding the .ui files from qmldesignercore.cmake to
tst_assetsImport and tst_merge in the qtquickdesigner repository,
AUTOUIC for some reason gets the output location for the
generated ui_*.h headers from: It puts them into
qtquickdesigner/tests/qtcreator/src/plugins/qmldesigner/designercore/
instances/
instead of into the corresponding *_autogen directory.
That leads to both tests wanting to generate the same file, and
ninja complains with
ninja: error: build.ninja:78635: multiple rules generate
qtquickdesigner/.....
Do not use AUTOUIC for these .ui files, but instead add them manually
with qt_wrap_ui.
Change-Id: I1d60fae95739335a87f8196ed2a686a0633165b2
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
The iostool did always deploy the whole bundle, without taking
into account whether anything has actually changed. This meant
that for big bundles anytime the user starts the application
on his device, a full deployment was done.
For a ~1GB bundle this would take around a minute on a recent
Mac and iPhone 12.
This fix uses a new function from the mobiledevice framework
called AMDeviceSecureInstallApplicationBundle.
This function takes a new parameter "ShadowPathKey" which points
to a directory where the last deploy state is captured temporarily.
Before deploying to the device, the function compares
what is to be deployed against the last deploy state and
only deploys the parts that actually changed.
QtCreator provides a temporary folder for this. Due to this,
the initial deployment still does a complete deployment as
no state is available yet. All subsequent deployments
take the captured state into account.
For backwards compatibility, the old deployment method is left intact.
Fixes: QTCREATORBUG-24371
Change-Id: I4df6aa79d41b34c326d78be7952d7eeb23774648
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
In order to help lldb locate libpython3.9.so, we need to point
LD_LIBRARY_PATH to the right lib/ path inside the NDK.
Amends: b54bf8ad86
Reason for amend: The "prepend" use-case of Environment::prependOrSet
failed due to the undefined separator. Now, use
Environment::prependOrSetLibrarySearchPath instead, since that handles
the separator and knows the environment variable name.
Fixes: QTCREATORBUG-27297
Change-Id: I770a6335a7a26c65d23c930f7d6f9795b3dc52b5
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
This makes sure that any processes started by the debugged project in
cdb are also closed when the debugger should be stopped.
It happened to me in the past that while debugging Qt Creator in Qt
Creator and closing the debugging session tens of uic.exe were left as
zombies. And for some reason they started consuming CPU time.
taskkill /f /im uic.exe was the needed command to handle the situation.
Change-Id: I498381e793405854f7c02e9fec6b6e4718c75c25
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Add local declaration function add "auto " incase
cxx11 features are enabled.
Fixes: QTCREATORBUG-26004
Change-Id: I10da77e8baa52740b1c4df5a21d78ac5f0d1c5d6
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This is now taken care of in the desctuctor of QtcProcess itself.
Change-Id: I51e65344e6d2cae4498e292e4ad6a586c68b0539
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
... or nothing, if the process object is destroyed immediately.
Change-Id: I6a1e1928bc49fc20a1c0e0ee9b8f4f723276bbca
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Less synchronous in cases where it is not needed.
Change-Id: Ia07e6d293c7f5e6dfb81b06c0ffb6d5d651b88b3
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
This step was of very little use out of the box, as it required the user
to pass sensible values for e.g. the required disk space. Making it
smart enough would require non-trivial effort for very little gain, in
particular as the concept hardly makes any sense at all in conjunction
with deployment via rsync.
Fixes: QTCREATORBUG-27081
Change-Id: I586fceb59947334eba19b10fcc94ecedc661908f
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
This is more consistent with many other tools.
Visual Studio is one of the few tools that
have the options under tools.
and allows to hide tools in the context of Qt Design Studio.
Renaming options to preferences.
Change-Id: I4bb554f00005eb415a203faa8bf7340d047b5a84
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Wrong variable used in the template's CMakeLists.txt resulted
in errors when configuring.
Amends db2cc2ba27
Fixes: QTCREATORBUG-27725
Change-Id: Id644ba83e118de1f12f4cdb4caa6368bd418419d
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
