Commit Graph

74059 Commits

Author SHA1 Message Date
Artem Sokolovskii
40d2c283c2 QmlDesigner: Remove foreach / Q_FOREACH usage in designercore
Task-number: QTCREATORBUG-27464
Change-Id: Ib1e693df7e3690b7cf3e6dc42e1d18a05a8f46d6
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-05-13 09:31:11 +00:00
Artem Sokolovskii
427c26d900 QmlDesigner: Remove foreach / Q_FOREACH usage in componentcore
Task-number: QTCREATORBUG-27464
Change-Id: I89d78d131a11b84b592d3d10577fe1ea4c7a6b4c
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-05-13 09:31:05 +00:00
Artem Sokolovskii
597a9dccb3 QmlDesigner: Remove foreach / Q_FOREACH usage in formeditor
Task-number: QTCREATORBUG-27464
Change-Id: Ib477df666eb798b302b7a6915bb98f798b7a04ed
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-05-13 09:30:59 +00:00
David Schulz
59a77a4965 TextEditor: add text cursor to assist interface
This will allow us to request assistance for a specific selection
instead of just the position.

Change-Id: Ib8e5b32d4a8f2936e5a6f1b7ac968d7f1d8d9de6
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-05-13 09:18:53 +00:00
Eike Ziller
1402b16451 Sqlite: Disable compiler warnings for 3rdparty sources
Change-Id: Id4fb3ca1c051b54d4bf449a11adff8c1492fc980
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2022-05-13 09:02:06 +00:00
Eike Ziller
b4caecae3e Ios: Fix compiler warnings
- avoid deprecated API
- remove unused variable

Change-Id: I33850ea2dda523900ead191542eadf65338d5210
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-05-13 09:01:55 +00:00
Eike Ziller
3791d732f0 Perforce: Fix compiler warning
Remove unused lambda capture

Change-Id: I4beeba43bbb9edab3dcbe70c97e0e6c666d023c4
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-05-13 09:00:49 +00:00
Eike Ziller
55951a6ca0 MSVC: Disable bogus warning
MSVC incorrectly warns when using a static method in a lambda that
has non-static overloads, and not capturing 'this' in the lambda.
That wouldn't be a big issue if other compilers wouldn't then
warn about 'this' being captured and not used.

Simply disable the warning.

Change-Id: I40b96c4758f7468c1e6f3577119123e0c7abf241
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-05-13 08:59:33 +00:00
Christian Stenger
9be10225cc Dumper: Fix Environment dumper
Change-Id: I48349ca550981d19cf0087bccd38e4d2677d1897
Reviewed-by: hjk <hjk@qt.io>
2022-05-13 08:53:55 +00:00
Miikka Heikkinen
0334d4886b QmlDesigner: Fix puppet crash when property animation has no target
Fixes: QDS-6935
Change-Id: Ib6dae3a6c39a12e9e62bd494d5a27917d7f97048
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2022-05-13 07:32:50 +00:00
Eike Ziller
f29c53b4f6 Help: Fix compiler warnings
Some unused arguments

Change-Id: I2b2794971840b70ae013bbf1de93970dd75ceeb1
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2022-05-13 07:31:22 +00:00
Christian Kandeler
db1f2c8dd9 LSP: Do not copy a message before sending it out
Change-Id: I58cc1f50b504bf21ea4ee9f99edba2ae8dc1ca1c
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-05-13 07:19:15 +00:00
Henning Gruendl
e703ee97d6 QmlDesigner: Add FilterComboBox
* Add FilterComboBox and SortFilterModel
* Use FilterComboBox in UrlChooser
* Add group attribute to UrlChooser model in order to sort according to
  groups (default items) and alphabetically
* Add escape to cancel modification after editing text
* Fix accepted and activated signal endpoints

Task-number: QDS-6397
Change-Id: I8fd1371d01d86fbbf5fc74ca9f20677d4ea49587
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-05-13 07:09:42 +00:00
Henning Gruendl
d027c5855b QmlDesigner: Align UX of ComboBox with FilterCB
* Change trigger signal for CheckIndicator
* Change edit state color for ComboBox

Change-Id: I7fa16ccc5cf33161ae3287cd64f481a675403670
Reviewed-by: Brook Cronin <brook.cronin@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-05-13 07:09:33 +00:00
David Schulz
fa577eb049 ClangCodeModel: pass ClangdClient to text mark constructor
Change-Id: Ie7b9c23365648fcf6034175e0e18970d342e25e6
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-05-13 05:06:46 +00:00
Ihor Ivlev
04f1a0d6ab Remove unused local variable in LookupContext::fullyQualifiedName
Change-Id: Icbec0969eab0651481ca752541dbee98fb363630
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-05-12 20:10:48 +00:00
Fawzi Mohamed
82b2878fac qmljseditor: preserve state when reformatting
Only editing position was preserved (and incorrect column) when
reformatting qml, preserve also scoll position (and correct column
position).

Fixes: QTCREATORBUG-25507
Change-Id: Ieaec2c5390e437f32b4b97b2bbb47975895f96d8
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2022-05-12 15:20:08 +00:00
Orgad Shaneh
086b47afee Git: Fix compilation with Qt5
Change-Id: Ib35095ccdacd13eaf2f599c9b47f7934c5d02591
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-05-12 12:41:11 +00:00
Artem Sokolovskii
51be3be2ea ProjectExplorer: Remove foreach / Q_FOREACH usage part 2
Task-number: QTCREATORBUG-27464
Change-Id: Ibfacf5a3b9789a3cf0ea229d1b0d22639101bf9a
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-05-12 11:12:03 +00:00
Eike Ziller
ff83642681 ClangCodeModel: Use Utils::runAsync instead of QtConcurrent::run
That works the same with Qt 5 and Qt 6.

This reverts commit c1fcaa2877.

Change-Id: I603e50c793c2477454253a57bfe01eb25ecab6e3
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-05-12 11:00:51 +00:00
Christian Kandeler
35963fd2b8 ClangCodeModel: Fix issue pane management for clangd diagnostics
We basically forgot to implement this. A task in the issues pane was
created for every text mark, but there was no code to deal with handling
editor switches, resulting in seemingly random behavior.

Fixes: QTCREATORBUG-27260
Change-Id: Ifcc1e04db4c37dde7e80f0e1646dc7c557cd7481
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-05-12 10:29:31 +00:00
Tim Jenssen
839502650c qds: ENABLE_CRASHPAD on macos (universal builds)
using a newer crashpad version build with:

git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git
export PATH=$PWD/depot_tools:$PATH
mkdir crashpad
cd crashpad
../depot_tools/fetch crashpad
cd crashpad
gn gen out/Default --args='target_cpu="mac_universal"'
ninja -C out/Default

Change-Id: I782c09cb564aff725652cd1419a8dec78bc04fc5
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2022-05-12 10:06:03 +00:00
Thomas Hartmann
bf3c3b624a QmlDesigner: Fix 3D formeditor preview
I remember testing this and ContentUpdateMask seemed to work.
This might have changed with Qt 6.3 and using AllMask instead, which
works for all cases I tested should not have any negative impact.

Task-number: QDS-6896
Change-Id: I648c10fe75df813ae25a54a13a862cad0228bfdb
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2022-05-12 09:11:29 +00:00
Thomas Hartmann
442f4cd723 StudioWelcome: Add import path for dataImports
This will be the im[port path for the data driving tutorials
and examples.

Change-Id: I358de354565e9670fefeb7a4194af4aec5182184
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-05-12 09:10:48 +00:00
Eike Ziller
7881a49e7d ProjectExplorer: Fix compiler warning
warning: local variable 'task' will be copied despite being returned by
name [-Wreturn-std-move]

NRVO doesn't happen because "CompileTask" isn't the same type as the
return value "Task".

Change-Id: Ic9c6388d4667cd68dbbba98b6b98721c4d4fb557
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-05-12 08:23:04 +00:00
Orgad Shaneh
78b08f57a2 Git: Make git show more async
git describe --tags can take very long when there are many tags.

Run all the describe commands in parallel, and let the user work while
they are running.

Change-Id: Iee56a5d51f93e9c799521bb0b06ba08bb45cb237
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: André Hartmann <aha_1980@gmx.de>
2022-05-12 08:04:16 +00:00
Orgad Shaneh
5d14d127d7 VcsBase: Add a convenience function execBgCommand
Creates and executes a command asynchronously, passing its stdout to a
callback function.

Change-Id: I6be7e803fadf708ca7dc587b612a5a63e9bf09c3
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: André Hartmann <aha_1980@gmx.de>
2022-05-12 08:03:37 +00:00
Orgad Shaneh
71ba0b8853 VcsBase: Remove unused argument in enqueueJob
Change-Id: Ib295b9add526025f0f24c6e1463b7fe3e19d5d08
Reviewed-by: André Hartmann <aha_1980@gmx.de>
2022-05-12 08:03:30 +00:00
Christian Kandeler
48abae97b6 ClangCodeModel: Fix handling of code actions in diagnostic tooltip
We need to create a sub-diagnostic for every clangd code action.

Task-number: QTCREATORBUG-27514
Change-Id: I9a12bcb390c9cc157ba7bca5015bbf51d31263da
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-05-12 07:49:48 +00:00
Christian Kandeler
031fe30260 ClangCodeModel: Update build system files
There is no compile-time dependency to libclang anymore.

Change-Id: I3b07977ba037a9c39c54d95c39f0505ae934cb02
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-05-12 07:49:10 +00:00
Christian Kandeler
e0ab8ad258 ClangCodeModel: Fix check for whether clangd should be used
Change-Id: I789c12b1b4098e6f11f190cf1ada6de9429c6101
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-05-12 07:48:45 +00:00
Artem Sokolovskii
2be4e8c5d5 CppEditor: Remove foreach / Q_FOREACH usage part 3
Task-number: QTCREATORBUG-27464
Change-Id: Icbe620a83b6c2cf6b6166b76d01ca5f3c65ea87a
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-05-12 07:42:02 +00:00
Christian Kandeler
f03868bd6b ClangCodeModel: Another clangd cursor adjustment
QVector<QString|> should go to QString, not QVector.

Fixes: QTCREATORBUG-27524
Change-Id: Iceab3d9a796bbe974a13cea3fa91de9b4aaaee7a
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-05-12 07:39:54 +00:00
Eike Ziller
3784f69c9e Debugger: Fix compiler warnings
Remove unused lambda captures

Change-Id: Ibe3cc4477442ea77a86045666b629fee8f27d084
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-05-12 07:15:08 +00:00
hjk
7f2288d9cc ProjectExplorer: Avoid need to fix up portsgatherer command lines
... by creating them with the right device to start with.

Change-Id: Ib2f0f10b67322fe66a609287a629d3d720d83c93
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2022-05-12 06:23:45 +00:00
Eike Ziller
da0f0ac523 Utils: Fix compile warning
unused variable

Change-Id: I84523cf221029d3a43b698f941e230441338d916
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-05-12 06:01:17 +00:00
Eike Ziller
b3dfcfd3b7 McuSupport: Fix compiler warnings
- override missing for mock methods
- remove unused variable

Change-Id: If703b60dece417fc7dc004d67966f2b6b8281990
Reviewed-by: Piotr Mućko <piotr.mucko@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-05-11 18:20:14 +00:00
Eike Ziller
7ee0da5107 QmlProjectManager: Fix compiler warning
Remove unused lambda capture

Change-Id: I4b17b8330f8ed4f5463f36689366d314e0159046
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-05-11 14:04:01 +00:00
Cristian Adam
bef1ace116 CMakePM: Use CtrlC stub for the CMake process
This makes sure that the CMake process is terminated.

Fixes: QTCREATORBUG-27518
Change-Id: Ibe227f6336be312abbe2517af421856463e9c9e8
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-05-11 12:38:05 +00:00
Cristian Adam
8be05ca745 Utils: Remove Debug restriction for useCtrlCStub
process_ctrlc_stub doesn't generate a Ctrl+C event sent via
GenerateConsoleCtrlEvent for the child process to terminate.

So the Debug restriction to workaround QTCREATORBUG-11995 is
no longer needed.

Change-Id: Iafc8b51bce17432c80b0be0c4084978abc1c909f
Reviewed-by: Jörg Bornemann <joerg.bornemann@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-05-11 12:35:15 +00:00
Cristian Adam
d1ff9b8ffb process_ctrlc_stub: Remove Ctrl-C child termination mechanism
Since 537ba23fff we have on Windows a method
that lets the operating system kill child processes when the ctrlc_stub
starter process dies.

Previously process_ctrlc_stub would generate a Ctrl+C event sent via
GenerateConsoleCtrlEvent for the child process to terminate.

This had a sideeffect of terminating also Qt Creator when ran in debug
mode since it shared the console. See QTCREATORBUG-11995 for all
the details.

Change-Id: Ia6fd6240927f95895a4c977e742714f959d3fab7
Reviewed-by: Jörg Bornemann <joerg.bornemann@qt.io>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-05-11 12:34:56 +00:00
Robert Löhning
9d5512b137 Squish: Retire Qt4
It can't be built with current compilers anymore and there
are no more binary packages publicly available.

Change-Id: I906789bbcca053690f39246ff7c3e602703ada37
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-05-11 12:10:06 +00:00
Jarek Kobus
49ddf8434f LinuxProcessInterface: Fix kill command
Amends f62a4d6315

Change-Id: Ib4efa3e0b9e0f4f945e338a85463b3e26fd056a1
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-05-11 11:06:27 +00:00
David Schulz
371c5da99c TextEditor: Fix local rename off by one
Fixes: QTCREATORBUG-27531
Change-Id: Iaca7db227b9cbd563ac03260d668b93ea7328883
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-05-11 10:24:29 +00:00
Christian Stenger
8479cb1514 McuSupport: Fix tests
Note, this also changes how the CMAKE_TOOLCHAIN_FILE is stored
inside the settings.

Change-Id: I018cc44be37deef36d685eb856bb706f47274017
Reviewed-by: Piotr Mućko <piotr.mucko@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-05-11 10:23:01 +00:00
hjk
dfe0776002 RemoteLinux: Avoid two explicit uses of IDevice::mapToGlobalPath()
Change-Id: I5e1e3f3de1118234dcaf1faa5690662876e85b4c
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2022-05-11 10:21:23 +00:00
hjk
e2df7b7f6b Qdb: Avoid some direct IDevice::mapToGlobalPath use
Change-Id: I701ccaa0e563f9cc040625ac34d0b4d8b7229c5b
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-05-11 09:01:07 +00:00
Jarek Kobus
257abc627c SftpTransfer: Get rid of FileTransferErrorHandling enum
FileTransferErrorHandling::Ignore wasn't used anywhere.

Change-Id: I5826fc9f7871b06cd8f423d7e3b1d01a5b6cbdff
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-05-11 08:16:59 +00:00
Henning Gruendl
e33923ccd5 QmlDesigner: Fix compilation
Change-Id: I683ec452e8346486dd3c55fd27832245279404a5
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2022-05-11 08:07:33 +00:00
Marcus Tillmanns
44a5d25f16 CMake: add defaults from environment for PCH and Tests
Change-Id: I7881c483f8c6f35463cff70ee1dbe91f2e6f810b
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-05-11 08:04:37 +00:00