Commit Graph

74059 Commits

Author SHA1 Message Date
Thomas Hartmann
f378245b6c QmlDesigner: Rename UseDefaultPuppet to UseDefaultQml2Puppet
This ensures that this is not accidently set, by older QDS versions.

Change-Id: I36690eee62a21c949d59edcdcf09fc507e5bf69d
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2022-05-05 09:39:06 +00:00
Jarek Kobus
c056c5c4b4 LinuxDevice: Don't include sshremoteprocessrunner.h
The SshRemoteProcessRunner is going to be removed soon.
Replace this include with what we are using currently.

Change-Id: I0d13586390b60ca9545f124a4db24eb90f4369d7
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2022-05-05 08:59:15 +00:00
Jarek Kobus
aa4695e76f PublicKeyDeploymentDialog: Don't use SshRemoteProcessRunner
Use QtcProcess with a path on device instead.
Get rid of SshKeyDeployer, inline its functionality inside
PublicKeyDeploymentDialog.

Change-Id: I01b9fecb06b459f93e8eefaf889ef0dea9f69f1d
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-05-05 08:58:59 +00:00
hjk
2095dbdd17 Valgrind: Compile fix
Amends 32845e86f3.

Change-Id: I19d2e7c70cd29894953189b93d3881fa5efd007c
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2022-05-05 08:56:50 +00:00
hjk
32845e86f3 Valgrind: Use QtcProcess in callgrind
Change-Id: I033f856e8b391e741124a136d875bc80255eeac7
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2022-05-05 08:47:21 +00:00
Christian Kandeler
23fceb9ef3 CppEditor: Allow to retrieve clangd's internal include path
The code model will need to use this one instead of the one hardcoded at
build time.

Change-Id: Ibd89d32f99b9250c909473f9a4a66f9a8a5f4f07
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-05-05 08:38:33 +00:00
Jarek Kobus
70e8e1b530 LinuxDevice: Fix error reporting from shared connection
If the master ssh connection can't start, e.g. because
no public key was uploaded to the remote device, report the
standard error of master process as error string.

Fix the "if" condition in handleDisconnected().

Change-Id: I9ba821136a1755d3460e47ce6f25d3684445890f
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-05-05 07:46:17 +00:00
Christian Stenger
1346ffc159 Dumper: Fix offsets for QFile members
Change-Id: I890b3f387505cf5acc8783e3dc7088515d6934cc
Reviewed-by: hjk <hjk@qt.io>
2022-05-05 07:42:09 +00:00
David Schulz
4a3c4dec09 ClangCodeModel: fix setting clangd to the fallback client
When manually defining clangd to the fallback clangd in the settings the
setting was not saved and after a restart the previous clangd was setup
again.

Change-Id: I6ce71d20d510c0cf6c605247563349b38c204e56
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-05-05 04:17:14 +00:00
Cristian Adam
cf8a2e6589 CMake: Fix configuration for the system KSyntaxHighlighting usage
extend_qtc_target() fails when a target doesn't exist,
extend_qtc_library() does check if the target exists.

Amends 88781a003f

Change-Id: I76858f8a395d1b0f3735a8a74a36cf89703aa7f6
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-05-04 16:59:55 +00:00
hjk
40ba92c371 ProjectExplorer: Remove now unused ApplicationLauncher members
Change-Id: I54530571114b8dbc13e50432b8331427e845215b
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2022-05-04 15:39:41 +00:00
hjk
adeaa01d85 Debugger: Use QtcProcess instead of ApplicationLauncher
... to start the QmlEngine

Change-Id: Id283a1f5d100cd65fe1f3b900114b86aca288e91
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2022-05-04 15:39:36 +00:00
hjk
79301deea2 Valgrind: Use QtcProcess instead of ApplicationLauncher
Change-Id: I653435dbf44a44cb5baddb58f471693fc73b2e63
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2022-05-04 15:14:00 +00:00
Artem Sokolovskii
f4e943bda3 CorePlugin: Remove foreach / Q_FOREACH usage mostly in dialogs
Task-number: QTCREATORBUG-27464
Change-Id: Iad47e9cb0b2fa7590dba2d26d0a33a83d2909bb7
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-05-04 14:18:24 +00:00
hjk
33a385c4d6 CMake: Shift multiconfig storage from build config to build system
Change-Id: I6f9b6c590975caeea4ad92c61f354d81d4d90431
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-05-04 13:35:30 +00:00
hjk
fdf008a37e ProjectExplorer: Use QtcProcess as direct member
... in ApplicationLauncherPrivate.

Its lifetime is the same as the owning object's nowadays.

Change-Id: If3a47d625f7903f680780f2d5663df474e5812b2
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2022-05-04 13:19:05 +00:00
hjk
268a8efa74 RemoteLinux: Merge remotelinuxcheckforfreediskspaceservice
... into build step files

Change-Id: Ice63c24d9076486ba46a7b9429a01f803a6f6103
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2022-05-04 13:08:39 +00:00
hjk
4a38d6088e RemoteLinux: Merge remotelinuxcustomcommanddeployservice
... into build step files. Not worth a separate translation unit anymore.

Change-Id: Id7b33c1ea1ef4c7dc91512e8478d49fbdead4dde
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2022-05-04 13:08:31 +00:00
Christian Kandeler
780f89b377 ClangCodeModel: Bump minimum clangd version
We need clangd >= 14 to get rid of the cumbersome compile_commands.json
creation.

Change-Id: I30c19a385e2d76e478985f3df64968d1cb3efe87
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-05-04 12:55:03 +00:00
Eike Ziller
eec77fa67a Remove leftover code for header diagnostic info bar
ClangCodeModel used to show an info bar about errors in headers in the
editor, but that was removed. Remove the remaining infrastructure that
was used to show them.

Amends b52fac7148

Change-Id: Id89f2bcb7778245f468923d29c577bf1ca68ee75
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-05-04 12:13:45 +00:00
Thomas Hartmann
59161e22f2 QmlDesigner: Remove debug output
Change-Id: I2f4195b642febfff06bb9f79f94652d0edd4aacf
Reviewed-by: Knud Dollereder <knud.dollereder@qt.io>
2022-05-04 12:09:30 +00:00
Thomas Hartmann
a904a85100 QmlDesigner: Remove <cpp> prefix for property types
Since Qt 6 in some cases also literal properties like float have
this prefix.

Change-Id: I580099569c5c865b4f42e97aaf07d101c973a456
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Knud Dollereder <knud.dollereder@qt.io>
2022-05-04 12:05:21 +00:00
hjk
2b9ec0c3d9 Boot2Qt: Merge qdbmakedefaultappservice into build step files
Not worth a separate compilation unit and pimpling.

Change-Id: Ie7649938bc8c97061ccac0a37c075a6bd7900c97
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2022-05-04 11:40:20 +00:00
Jarek Kobus
a1b9619b5e RsyncDeployService: Don't use SshRemoteProcess
Use QtcProcess with a path on device instead.

Change-Id: I0b5f3160926287112b7fe53dea19d54ca5c07232
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-05-04 11:37:57 +00:00
Jarek Kobus
e9fb604812 LinuxProcessImpl: Buffer standard error until started() is emitted
Change-Id: I1ee469a918ff95eeeb5038a4c2021469c429a269
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-05-04 11:37:44 +00:00
Marcus Tillmanns
441488dd52 Docker: fix find arguments, support outputForRunInShell called from non-main thread
* Added -mindepth 1 to not return the directory that is being searched in.
* Added parenthesis around -type options to correctly express that files OR directories
  should be searched, without affecting the following parameters.
* Added parenthesis around -readable, -writeable and -executable and added -o between them,
  to correctly indicate that any of the selected type should be searched for.

Change-Id: Ibc77a2a99826663b88015e8f43b5664563384127
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2022-05-04 11:03:50 +00:00
Jarek Kobus
450a7754c3 RemoteLinuxCustomCommandDeployService: Don't use SshRemoteProcessRunner
Use QtcProcess with a path on device instead.
Make the RemoteLinuxCustomCommandDeployService class internal
and don't export it.

Change-Id: Iac02f3a8ab5a5f2e3647c95c6710dbe3f9b4994f
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-05-04 10:06:20 +00:00
Christian Kandeler
969b1f711f CppEditor: Remove RefactoringEngine
Another useless indirection.

Change-Id: Icfcc0704a1056d8002a674edbe74b946cb56ff27
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-05-04 10:05:31 +00:00
Jarek Kobus
da0f950821 RemoteLinuxSignalOperation: Don't use SshRemoteProcessRunner
Use QtcProcess with a path on device instead.

Change-Id: I14a557f61414a12dabc19e3b2f8c9c277ecfb52d
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-05-04 10:05:00 +00:00
Christian Kandeler
5f9cbe7fe8 Remove clangbackend
Change-Id: I5f4f9a2fc5469c4eeb112a46626791ffb9a57a85
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-05-04 10:04:17 +00:00
Christian Kandeler
4b0b3e9e35 ClangCodeModel: Move fix-it tests into plugin
Change-Id: If53df602a42d8c1ffde5db6c8cb1e7fc269bb272
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-05-04 10:03:47 +00:00
Miikka Heikkinen
ae30e3073c QmlDesigner: Do not assume QmlBuildSystem is current build system
It's possible to open qml files for visual editing from qmake/cmake
based projects as well.

Fixes: QDS-6836
Change-Id: I15840dbe0f67711b162f7f7f492f7ab813ea7fca
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-05-04 09:11:06 +00:00
Jarek Kobus
d79b34d39a QdbMakeDefaultAppService: Don't use SshRemoteProcessRunner
Use QtcProcess with a path on device instead.

Change-Id: I4ce6d5d1cf42a678de8cc9695c7db782a81b34f9
Reviewed-by: hjk <hjk@qt.io>
2022-05-04 08:37:06 +00:00
Jarek Kobus
0eea55926f ApplicationLauncher: Get rid of m_useTerminal field
Change-Id: Iab77cf695c1d21cf0e89a230f76ad129757ffb5b
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-05-04 08:36:45 +00:00
Jarek Kobus
272fbe82d0 ApplicationLauncher: Get rid of m_processChannelMode field
Use QtcProcess::processChannelMode() getter instead.

Change-Id: I9e66f6e5ec8dd90d55f843328f02032351c802ac
Reviewed-by: hjk <hjk@qt.io>
2022-05-04 08:36:34 +00:00
Jarek Kobus
85cb7d2b71 Get rid of IDevice::createProcess()
And most of QtcProcess subclasses.

Change-Id: Ic891defbf49736442243f9ee0f9d28d140e0ba9d
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-05-04 08:28:15 +00:00
Jarek Kobus
a6940abc29 Implement QdbProcessInterface
It's going to replace QdbDeviceProcess.

Change-Id: I88d7dc110b71986462894f10ecb18632dcf02669
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-05-04 08:28:02 +00:00
Jarek Kobus
340b61889d SshProcessInterface: Remove pidArgumentForKill()
This interface method wasn't really sensible.

Change-Id: Ia47c893886ec06a2263b96d161578d46d2df5ffa
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-05-04 08:27:26 +00:00
Artem Sokolovskii
54628488a4 CorePlugin: Remove foreach / Q_FOREACH usage
Task-number: QTCREATORBUG-27464
Change-Id: I0d0257bbd46f3eec9b11b386d1987156e83a9dac
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-05-04 07:42:45 +00:00
David Schulz
71b84417b3 LanguageClient: allow generating specialized extra selections
for LanguageClient Diagnostics

Change-Id: Ib7226aaaa420d4c7531b9c534ab193d1b22b467d
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-05-04 07:35:53 +00:00
hjk
61c6f532b2 Debugger: Use Qt 6,2 as fallback version
Change-Id: I0787d212f2a98b3aa2c2f1eda28b93731c81de08
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-05-04 06:12:38 +00:00
Jarek Kobus
910dd04bf7 GenericLinuxDeviceTester: Don't use SshRemoteProcess for uname
Use QtcProcess with a path on device instead.

Change-Id: If38731f0648412874ebb1319ec53627f65f69108
Reviewed-by: hjk <hjk@qt.io>
2022-05-03 19:32:59 +00:00
Jarek Kobus
9402841d99 QtcProcess: Fix runBlocking() on remote
There is no need for special handling when running on remote.

Change-Id: If30245d2ece475cb72df2be4390210d6b8c0c1aa
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-05-03 19:31:50 +00:00
Cristian Adam
19f5b835de CMake: Ensure qtcreatorcdbext is a shared library for all cases
qtcreatorcdbext.dll is being loaded by cdb.exe and needs to be a
shared library always.

Change-Id: I13582f295744d350907284ea02e08ce1e8055dbe
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-05-03 14:56:02 +00:00
Jarek Kobus
8e931838ef Get rid of SshConnectionInfo
It's not used anymore.

Change-Id: Ie77c9d9bc8eb82c1f74cfdac2304bc6c2f92ee93
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-05-03 14:38:23 +00:00
Jarek Kobus
de4f71b2cf MemcheckTool: Don't use SshConnection::connectionInfo()
Use QtcProcess with a path on device instead. Invoke directly
echo -n $SSH_CLIENT command and parse the output locally.

That was the only usage of SshConnection::connectionInfo()
in the whole Creator codebase.

Change-Id: I23a548e8dcfdff370d5db4c7ef10a560d5adc57e
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-05-03 14:34:36 +00:00
Jarek Kobus
23cc03b470 GenericDirectUploadService: Don't use SshRemoteProcess
Use QtcProcess with a path on device instead.

Change-Id: I61c6b2cf042a223a037109b56418dbf76dbad161
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-05-03 14:34:19 +00:00
Jarek Kobus
ece39c7c2f QtcProcess: Use generic waitFor...()
Task-number: QTCREATORBUG-27430
Change-Id: I34ecc8a5937204875c235eee285c32d9cb0a0a86
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-05-03 14:32:41 +00:00
Jarek Kobus
221414c5e8 QtcProcess: Implement waitFor...() in general way
Task-number: QTCREATORBUG-27430
Change-Id: I34aff44258d2c7cabae0b63fe4e9ec55aa7b3b7d
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
2022-05-03 14:32:29 +00:00
Cristian Adam
15611ee822 CMake: Fix static build with a reduce number of plugins
This changeset allows building Qt Creator statically with a reduced number
of plugins, especially without QmlDesigner.

Change-Id: I0050c72d3959fe43edae60bd47ecab9c0ee544b3
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-05-03 09:43:12 +00:00