This method is used from multiple thread inside
most of methods in DeviceFileHooks.
Change-Id: I152fa983c48cb72f8ed2f99da0e7f73b1b8b9a5e
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
By reducing the height of the editors for the items. At least shows 10
instead of 9 items in the same space on macOS now, and looks less
wasteful.
Change-Id: I422a772cad52a2fcc8223d188b32d8d8adf9bf95
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
If a signing identity is given, create a signed install, and zip it up
(if zip files are wanted).
Can be used to directly add a signed app to an installer.
Change-Id: Ib575d7c907eea74c247407107884f29a526d5d1c
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
The proxy action was updating from the actual action delayed by a
QueuedConnection. This was introduced in
c3772bfd4c to avoid disconnecting and
reconnecting to QAction::changed while handling that same
QAction::changed.
This introduces a delay between the actual action's change and when it
is reflected in the proxy action.
ProxyAction::update only needs to disconnect signals that would trigger
because of the changes done to the ProxyAction. So it doesn't need to
disconnect/connect from the actual Action's changed signal. Only
disconnect/connect the signals that we really need, and get rid of the
QueuedConnection again.
Fixes: QTCREATORBUG-26363
Change-Id: I2b851af35fcb4a3931b645896dd77477cee79812
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: hjk <hjk@qt.io>
- fix "continue" button state (was always disabled after filtering)
- do not loose focus on every key press in filter input
Fixes: QTCREATORBUG-26779
Change-Id: I16960e65b32b5ddfa0e4e5b1acd160492b1c995d
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Adding an already existing rpath is an error for install_name_tool.
Not completely failing in that case makes local testing easier.
Change-Id: I22d94225af2375af4e397212b2a7500315f25882
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
As is used for the Qt 5 based prebuilt binaries.
std::optional is only fully supported out of the box since
10.14.
Change-Id: Ide8bd9ac8b66b05e1bb6e9b350edf3e7ffdaf97e
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Do not use QQuick3DObject when disallowing recursive component complete
check so that the animations get added to the instance server.
Fixes: QDS-5731
Change-Id: Iff8e39f74d68b312b66d68adaf6ab79d625f88f8
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Added description of the functionality in the Translation view as well
as a tutorial.
Task-number: QDS-5639
Change-Id: I839739058ce899c86080cf3dce7c26dc6fb83d64
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
The socket/name for QLocalServer must be a path that is short enough for
unix sockets (<= 104 chars).
QLocalServer already ensures that the "name" is an absolute path, by
prepending QDir::tempPath() if it isn't. For Qt Creator that worked, but
the temporary directory set up for the unittests resulted in a too long
combined path.
Also, we should avoid directly using QDir::tempPath() and use
Utils::TemporaryDirectory to keep all our temporary files at one place.
So, make the "name" explicitly an absolute path in our specific
temporary directory, and make the name shorter for the test.
See 6feed6e656 for a similar issue.
Change-Id: I07dc4233db1c9d353cd6977da43850256057ba55
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
Previously the only way to stop the CMake run was to click on "x"
button of the "Configure" progress bar.
Now you can click in Settings on "Stop CMake".
Change-Id: I167b86ba62679f197c194148b122ff0c87e87162
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
If the image is update but null we still generate a new image. This
is a ugly workaround for the flaky generation process. Hopefully
we can fix it after all hidden dependencies are removed.
Change-Id: I0e344002a1952fb849393d3e245e31612c69d7bd
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Currently the macOS job runner is failing sporadically and since the
tests are only 99% passing and they are only informative only if the
developer actively checks a test in the output log.
Change-Id: Id75d8d05c5fd45f2cc15e08b20973646a06ff6bd
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Use the new tool from the prior commit to recolor the icons from black-
on-white or black-on-transparent to grey-on-transparent in order to
ensure a proper visible contrast against dark and bright background of
the online docs.
Fixes: QDS-5693
Change-Id: Ia6cf378501f3ea526d1c35c089817cd34fa2c62f
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
There are black-on-white and black-on-transparent icon images in the
documentation. With the new dark theme for the online documentation, the
former variant looks odd, and the latter one is not visible.
The docs team chose to use switch to grey-on-transparent icons, so that
they have enough visible contrast against bright and dark backgrounds.
This change adds a python based tool that converts the existing icons to
grey-on-transparent via ImageMagick, and then optimizes the pngs via
optipng.
Task-number: QTCREATORBUG-26644
Change-Id: Ib14c5a68235b6b906600dcaa1c5094c9cc6ab9b7
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Amends 13789ce2f9.
Drop superfluous toStdString() conversions when operating on
QByteArrays.
Change-Id: I90d9a3617036063dc1276a130dd4a5056e12eb28
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
In the long run we have to use a value class of the target pointer which
will be simply copied to the thread and cannot get dangling.
Change-Id: Ib99a69aa9697038887a24300eb234c3baf4eb1b2
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
This reverts commit d65e47b5c6.
Reverts the quickfix for the performance regression of code completion.
Followed by a minimal fix.
Task-number: QTCREATORBUG-26829
Change-Id: I1afe71c24ee94caadd4fa849c29f6fc030fb1a8b
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: hjk <hjk@qt.io>
The headers were not actually used, and by removing them the
MinGW 8.1.0 build is back to green.
Change-Id: I38572696a3c1abc15ec79c1cfd0f7c68ba1fc6b0
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Use the new tool from the prior commit to recolor the icons from black-
on-white or black-on-transparent to grey-on-transparent in order to
ensure a proper visible contrast against dark and bright background of
the online docs.
Fixes: QTCREATORBUG-26644
Change-Id: Ie48b9da269426e3a98a9d70bdf9950cdd924b64d
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
To match the files generated by the application wizards.
Change-Id: If749a6dcc25eacb9daef451fec6abbc879bbc8a8
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Replace the Utils::FileWatcher with a connection to the ProjectExplorer
fileListChanged signal.
Change-Id: Ia2d3a6d239451ed979bbfb654fe5258aadd3c686
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
* Left align the headers of connection, binding, dynamic properties and
backend view.
* Add left padding to give some space between text and separators.
Task-number: QDS-5851
Change-Id: I8f5981e6636fa2f3d6a0c4b9d9abd4e9f54603ed
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
We now do it on document change to work around puppet and codemodel
problems.
Change-Id: Ifd1f6835cc5c0abd3430d5d26685e838dc561ae2
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Added tests for WizardFactories class and for StyleModel class.
Task-number: QDS-5690
Change-Id: I08f51c2b6cf628a265286ddb8056bd049a64ff0b
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
The "Clear selection" button doesn't add much value in the list
of buttons.
If you have a selection it doesn't really matter, and you can
simply click on an item an the new item will be the new
selection.
Change-Id: Ie64bc379773219392c12da4c256afd462d4081a9
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Add defaultItems property to UrlChooser in order to add default items
to the ComboBox model
* Add StudioControls.ComboBox deselect after editing finished
* Replace the simple model by a ListModel
* Fix UrlChooser tool tip
* Use function with changed handlers for parameter proper access
Task-number: QDS-4966
Change-Id: I109e1787b6be06657b22cedca1cd9210d974a23d
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>