Commit Graph

74059 Commits

Author SHA1 Message Date
Samuel Ghinet
8c139603a1 QDS: shrink the right margin of the project view for small sized dialog
This also allows a bit smaller minimum width for the dialog.

Also, did a bit of cleanup.

Task-number: QDS-5500
Change-Id: I3660190ac0a73dd1da1c7d6f8ee76660b1fba6be
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2021-12-08 13:05:55 +00:00
Sergey Levin
44ff85cb1b Change QLabel from StringAspect to ElidingLabel
ElidingLabel with elided mode set other than Qt::ElideNone will not show
in case QFormLayout has QFormLayout::ExpandingFieldsGrow field growth
policy

Change-Id: I26db57fbeb2c921e054cf7dc18229ebddcb04530
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2021-12-08 12:53:19 +00:00
Leena Miettinen
e545e8fdbb Doc: Add info about integrating wizards into CMake builds
Add CMake to the example of creating a selection list for
choosing build systems in a custom wizard.

Task-number: QTCREATORBUG-26616
Change-Id: I0bb7e59b8a2f6d42d139de7a24c033dabbe6da6a
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2021-12-08 11:51:24 +00:00
BogDan Vatra
187f0f21eb Fix get_filename_component usage
get_filename_component called with incorrect number of arguments

Change-Id: I4f1c8dbc185c2e53bc596bf02a48f72b76ac6955
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2021-12-08 11:45:54 +00:00
Alessandro Portale
5e77303b57 Android: Turn SDK manager from QTabWidget into QGroupBox
Since the AVD manager moved into the "Devices" option page, the SDK
manager tab was left alone in the QTabWidget. One single tab looks
strange and uses more space than needed.

This change turns the SDK manager area into a QGroupBox, which is
consistent with the rest of the Android Options page. This patch also
adjusts the margins and spacings of the SDK manager widget to fit to the
rest of the options page.

Change-Id: Id1ed38862e8f9e984f53cdfb59492e30902162a7
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
2021-12-08 11:45:45 +00:00
Leena Miettinen
d81f48964d Doc: Mention that lupdate and lrelease integration is qmake-only
Add a link to information about using the tools with CMake.

Task-number: QTCREATORBUG-26616
Change-Id: I44c3701703e8831dcb4a89f3bd1ecb14fb3c4853
Reviewed-by: Lucie Gerard <lucie.gerard@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2021-12-08 10:50:56 +00:00
Leena Miettinen
e2b40333fe Doc: Mention that SUBDIRS are only used for qmake projects
Task-number: QTCREATORBUG-26616
Change-Id: I359846f21bcf234fe1d804bc9e7916092f7dd939
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2021-12-08 10:50:17 +00:00
Kai Köhne
a50cf058d1 Wizards: Use CMake by default
We focus on CMake as the preferred build system in Qt 6. qmake
is still supported, but we shouldn't advocate for using it anymore
for new projects.

[ChangeLog][Wizards] The wizards by default now use CMake
instead of qmake.

Fixes: QTCREATORBUG-25685
Change-Id: Ifa2a6a046d65015124229bbb278ec5dd317afa35
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2021-12-08 10:27:45 +00:00
Christian Kandeler
67cf7c08d0 LanguageClient: More verbose logging when clearing token data
Change-Id: I3f9883858fa2f23dff00cda9f556f0f4bbff127a
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2021-12-08 09:46:25 +00:00
Petar Perisin
0b736c3f7a GTest: do not change arguments order of testRunner
transforming list of args to set can change order
of arguments as well as count, which can make
application unable to run

Change-Id: Ib8164e0b7661511f738bdc3b21e74fbaaa6a5252
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-12-08 09:06:00 +00:00
Assam Boudjelthia
e3fb97b5ce Android: give a visual indication when sdkmanager is reloading packages
Add an info message when sdkmanager is reloading the packages, and also
don't expand the summary widget when the widgets are not active,
which can be when the packages are being reloaded or when the licenses
are being reviewed, this will give more space for reviewing the licenses
instead of having the summary take most of the settings page space.

Change-Id: I6acf3f6edc3b3d3fa78f0ba00308a21f8bb4fa72
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
2021-12-07 18:07:57 +00:00
Youri Westerman
9575c45cf5 Update screenshot in appdata
The old screenshot no longer exists and results in a 404.

Change-Id: Iabae251b6441b0cf25ee94856c03113b16d6faf6
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2021-12-07 16:49:31 +00:00
Christian Kandeler
92e3eb722a ClangCodeModel: Another clangd cursor adjustment
This time for the case where we are after the last character of a
function call argument.

Fixes: QTCREATORBUG-26638
Change-Id: I634fa91e87103a7ae82e3a43246dfbc7069dbbdc
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2021-12-07 16:08:28 +00:00
Assam Boudjelthia
ca9742e2a1 Android: Merge Java settings into Android settings
... to save some space.

Change-Id: I68d7cae1b007eff0624f2c0993e191c64fb415fc
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2021-12-07 15:44:57 +00:00
Assam Boudjelthia
53d5bc5a08 Android: Add channel and include_obsolete UI filters to SDK Manager
Allow to filter channels and obsolete packages from the UI.

Change-Id: Ifcaa2a1c3421a15e60f92b7a9b86cc9ab3554885
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2021-12-07 15:44:39 +00:00
Christian Kandeler
7ffaa89f02 ClangCodeModel: Work around clangd cursor issue, part 2
Amends 825c9ea64f to work also for member access via pointer.

Change-Id: I8ee68d0f6d93c65c2f82a63bce5baef2aa2159de
Reviewed-by: David Schulz <david.schulz@qt.io>
2021-12-07 14:00:18 +00:00
David Schulz
2405ccb271 clangd: Assert on generating tooltip for deleted client
Text marks for diagnostics should be deleted when the client dies. If
they somehow survive assert when creating a tooltip for those text
marks.

Task-number: QTCREATORBUG-26585
Change-Id: Iaebf0d2aba66d2a6c250f8dad7856ef03b1dcacd
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2021-12-07 13:54:34 +00:00
Miikka Heikkinen
a4c2f2fb8c QmlDesigner: Fix Qt5 compilation
QQuick3DViewport::pickAll was introduced in Qt 6.2.
Checking against version 6.2.1 because that's when the global picking
API was taken into use in QmlDesigner.

Change-Id: Id69ff9d958da89ba9e043dfb082a99f640884a4e
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2021-12-07 12:57:42 +00:00
Marco Bubke
c22c22c3d6 UnitTests: Disable some ClientServerOutsideProcess tests
It seems QtcProcess introduced a really long timeout in the tear down
function. This makes the unit test unusable. So long it is not fixed the
tests are disabled.

Change-Id: Ibdac92f6e5cef7b5866f7e64cc163fd1052c272b
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2021-12-07 11:55:54 +00:00
Christiaan Janssen
fd98dbaeab McuSupport: fix cmake var mapping for cypress flash tool
Task-number: UL-5094
Change-Id: Ib87eb39d54c1677ed4c130054d0a9f01ca6a8ec4
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2021-12-07 11:05:39 +00:00
Maximilian Goldstein
3d47a0ef09 qmljsmodelmanager: Add additional directories to find qmltypes
This works around the issue that we only looked for qmltypes in the
directory the binary ends up being stored in. This did not work
for macOS and Windows as those are stored in subdirectories due
the platform specific ways binaries are stored there.

Now we also look in the directory where the qmltypes should be located
on these platforms.

Task-number: QTCREATORBUG-24987
Change-Id: I23d46e68f8fad0b4e2e8a01fc7c41360f1e6961e
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2021-12-07 10:15:11 +00:00
Christian Kandeler
49c421e5c4 ClangCodeModel: Prevent duplicate "/Tx" options
Those trigger code model warnings.

Fixes: QTCREATORBUG-26664
Change-Id: I0ed6b9edeeb94c8597b30c0be514d2b34dbedc49
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-12-07 10:08:09 +00:00
David Schulz
655e64b2da clangd: fix saving clangd settings
amends 6cf6f1c230

Change-Id: Ib9007805783cfac258a73b81b7e1a401f9fbc2df
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2021-12-07 10:06:58 +00:00
Aleksei German
e8b471dc8e QmlDesigner: Fix for states delegate behavior
Task-number: QDS-5649
Change-Id: Id5d936c29fc832f3df8fa163c607562bc0983ed3
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2021-12-07 09:58:11 +00:00
Vikas Pachdha
5052c2e415 Docs: Add instructions to run Qt-Bridge plugin on Apple silicon
Task-number: QDS-5684
Change-Id: I5be5b3c7fd9d1c2490b5b4adf3f6d587860ba8c5
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2021-12-07 09:07:42 +00:00
Miikka Heikkinen
9c15b5b16d QmlDesigner: Update _pickTarget of Repeater3D created objects
The objects Repeater3D creates are created after handleInstanceHidden
is called for the repeater instance, so the _pickTarget of the created
children doesn't get properly updated. Added signal handler to
make sure handleInstanceHidden is called again after all objects have
been created.

Fixes: QDS-5643
Change-Id: I8b63614fca0be3956b6896028e3f3a0f49bfe397
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2021-12-07 09:00:25 +00:00
Jarek Kobus
b6a996a8d5 DiffEditor: Assert that we are operating on non-null documents
Task-number: QTCREATORBUG-26594
Change-Id: I4331c457a6360682229dbbbfd8ac3d50b44b8ead
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-12-07 08:36:56 +00:00
Miikka Heikkinen
eba2a0520b QmlDesigner: Fix picking issues
We now check also the parent chain for pickability, because
a node is not pickable if one of the ancestors is not pickable,
as all properties picking depends on (visibility, locked state)
are implicitly inherited by descendants.

Rotate gizmo rings default to regular View3D picking when the angle
is so steep that the plane intersection is not reliable. With new
global picking enabled handling we need to check all hits instead
of just the first one.

Change-Id: Ib1aa604b06f7db1041f5d4c3019cc2badf29a20f
Fixes: QDS-5679
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2021-12-07 08:18:35 +00:00
Leena Miettinen
9b4e68dd84 Doc: Describe creating GUI apps and app bundles using CMake
The default behavior is opposite from when using qmake.

Task-number: QTCREATORBUG-26616
Change-Id: I9ec0f1a961e8d0cb25957dddcceec79cffbf292b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2021-12-07 08:13:55 +00:00
Christian Stenger
e158bfe618 FakeVim: Improve handling of content changes
..when indenter or auto completer may interfere.

Task-number: QTCREATORBUG-26195
Change-Id: Iaf0eefd74344423409fa0c22f8e3ea618b4c9930
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2021-12-07 07:10:46 +00:00
hjk
104ea4accc Make some qHash and comparison operators overloads hidden friends
Restricts lookup scope more to necessary bits.

Change-Id: Ia42c95aaa70534843b7f6a90bfc56d2a1202c612
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2021-12-06 17:10:49 +00:00
hjk
8cb5c3cfdd Ssh: Use base QtcProcess' useTerminal for SshRemoteProcess
Still trying to ramp down non-QtcProcess interfaces.

Change-Id: I6b4ae6788f5021959ff3eb35bbade2157a6d67fa
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2021-12-06 15:30:00 +00:00
Christian Kandeler
02f93f68d6 QbsProjectManager: Consider "c++23" for cpp.cxxLanguageVersion
Fixes: QTCREATORBUG-26663
Change-Id: Ie22ce49cb724c434121c3d4b62b4580139a4706b
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-12-06 14:44:35 +00:00
Christian Stenger
db1c6f5b08 TextEditor: Fix compile with Qt 5
Amends 8d08196a21.

Change-Id: I8f67ee0549c621d168bacb57cd4ce0ad226cf852
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-12-06 13:44:28 +00:00
hjk
e64ce914f9 Utils/Ssh: Move SshRemoteProces::isRunning() to QtcProcess base
... and use it on a few places.

Change-Id: Id2cea709e355a46821a720e593740ac032888ced
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2021-12-06 13:44:23 +00:00
Thomas Hartmann
1ee33048a8 QmlDesigner: Fix crash
Task-number: QDS-5535
Change-Id: I7e568efb39637faf8cd17255440e06d98b768f1e
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2021-12-06 13:20:38 +00:00
hjk
9c0bc16e94 TextEditor: Simplify BehaviorSettingsPage implementation a bit
ICore::settings() lives longer than anything in TextEditor.

Change-Id: I67df38f291f43763bdd236ea611db614ac515c97
Reviewed-by: David Schulz <david.schulz@qt.io>
2021-12-06 12:31:43 +00:00
Christian Stenger
41b8e302ef CppEditor: Fix compile with Qt5.14
Amends ef30831213.

Change-Id: I3c8a962c558114bd64e8e07d7212e4f14ecffa90
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2021-12-06 11:47:46 +00:00
Orgad Shaneh
6cf6f1c230 CppEditor: Save Clangd settings in human-readable form
in the global settings.

Change-Id: I2f90388c138c92f03f78044e225574ded640d4b9
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2021-12-06 11:42:18 +00:00
Christian Kandeler
180200be66 ProjectExplorer: Handle "requested here" in GccParser
See also 4dd0537d4b.

Change-Id: If6fae31716ca8ec5e23e0159d6dd7ddfdb042bb3
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
2021-12-06 10:34:00 +00:00
Cristian Adam
5e8fd8d0f8 GitHub Actions: Limit the number of cores to 75% for testing
Hopefully this will help with the macOS host which tends to fail
at running tests with:

 The hosted runner: GitHub Actions X lost communication with the server.
 Anything in your workflow that terminates the runner process, starves
 it for CPU/Memory, or blocks its network access can cause this error.

Change-Id: I2ead1efd1526332cc2045fee7db4a76831f2e333
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2021-12-06 10:32:36 +00:00
Christian Kandeler
366c6fde89 CppEditor: Run the built-in "local uses" code even with clangd enabled
The built-in code model treats the "local uses" result state as an
indicator of whether to provide quickfix operations. It's unclear what
kind of side effects would result from removing this condition, so we
always run the built-in variant of the "local uses" code, and only
refrain from actually updating the selections in the clangd case.
Amends 0c53c2daef.

Fixes: QTCREATORBUG-26649
Change-Id: I9e1a3e3ad08bf13bcb35efe996a61aa34302b166
Reviewed-by: David Schulz <david.schulz@qt.io>
2021-12-06 10:31:52 +00:00
Eike Ziller
7d948b0c5d Do not link packages against libGLX and libOpenGL
Work around QTBUG-89754

Fixes: QTCREATORBUG-26652
Change-Id: I9fb7ba2127a93460184154a9eb2d4c053f8fc22d
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
2021-12-06 10:31:35 +00:00
Eike Ziller
8d08196a21 Fix crash when removing built-in snippets
Snippets collection managed the snippets with persistent iterators to
the "end" of the active snippets. Qt 5's QList was nicely updating
iterators even on non-const operations, but that has changed in Qt 6.

Don't use iterators, simply work with the count of active items.

Fixes: QTCREATORBUG-26648
Task-number: QTCREATORBUG-24098
Change-Id: Icc13274daf0e87d0562d80d7bc763c863d5da075
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: David Schulz <david.schulz@qt.io>
2021-12-06 10:30:47 +00:00
Orgad Shaneh
ef30831213 Utils: Simplify from/toSettings API
Change-Id: I591b6f833342ba9bd1a282332de5bb620d7f8c76
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2021-12-06 10:02:20 +00:00
hjk
64ac719ff8 Utils: Slim down private ProcessReaper interface
Change-Id: Idd5669b9ed525148426b85bbbc9a2818877f2707
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2021-12-06 09:26:19 +00:00
Fawzi Mohamed
ce82c058df add .mjs as extension for javascript files in defaultLanguageMapping
Change-Id: I40d43193ba9b7dac38d7a474aad2d739e6c39dc6
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2021-12-06 09:16:22 +00:00
Leena Miettinen
4a37833803 Doc: Improve FAQ answer about QML imports
Even though CMake was mentioned, the text could be made more
general.

Task-number: QTCREATORBUG-26616
Change-Id: I6ff59e96559579c773d8ae1313f96800597e0ccc
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2021-12-06 08:31:50 +00:00
Alessandro Portale
4aea270790 Debugger: Set Python env also for ndk-lldbs outside the SDK
When using an NDK installation which was not installed via an Android
SDK manager, we cannot presume that the included lldb binary has a path
containing "ndk" or "ndk-bundle".

Looking for "/toolchains/llvm/prebuilt/" in the path should detect any
ndk-provided lldb.

Change-Id: Icbaab0915f5877ca37ee44cbca6cc37360363b5c
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-12-06 06:38:16 +00:00
David Schulz
02d6dfdfec TextEditor: fix delete(Start/End)OfWord without camelcase
Fixes: QTCREATORBUG-26646
Change-Id: I0f9a4ad56ef96632fbf5de490f089bf7ff3b12ee
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-12-06 06:30:22 +00:00