... which we get from clangd's textDocument/references.
This works around https://github.com/clangd/clangd/issues/935.
Fixes: QTCREATORBUG-26574
Change-Id: I3933f30fdaca024a6e240bd0962de3d97acd0dbf
Reviewed-by: David Schulz <david.schulz@qt.io>
This way master, which now is version 7 won't interfere with 6.0 branch
which will have version 6.
When branches share the same cache the ccache hit rate is now ~40%,
which is too low.
Reduce the ccache size so that the 5GB would host multiple branch
versions.
Change-Id: If29c917fb47f4e1fdab4b4257af8b0625f6f219e
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
QDir::cleanPath() doesn't work well with the scheme://... syntax.
Change-Id: I2d2a86e416251ea2396b67ab1e5831444d4a979a
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
If we remove a hover handler from the editor we have to reset the last
cached hover result in the runner to prevent using this removed and
potentially deleted hover handler.
Change-Id: I2bbdbee9d018aac426832552d036926be9ff198e
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
LanguageClient::updateEditorToolBar() contained the static
hashes that were keeping raw pointers to different
objects. However, the lifetime of these objects wasn't
controlled, so it could happen that we were operating
on dangling pointers.
In fact, like in the bugreport, some text editor widget could have
been deleted (together with his outline action), while later another
one (coincidently with the same address) could have appeared.
The old mapped widget still pointed to the removed action
so we crash.
Instead of keeping a static hashes we attach the custom
child object to the widget and keep there QPointers to all objects
we are interested in.
Fixes: QTCREATORBUG-26588
Change-Id: I335d9848ea85372baf3328772f0a249cee242dcd
Reviewed-by: David Schulz <david.schulz@qt.io>
Changed node position and layout context menu enabled checks to
correspond to checks that are used to determine the enabled
state of their contents.
Fixes: QDS-5483
Change-Id: I71a26ffce9cc12036397b62658a08d9895f7cb63
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Restructure the message handling in the client, so if we get a message
with an id always send a response to the server either with the result
or with an error. Also make sure to not send responses to unreachable
server.
Change-Id: Ie74128069c1678af60871896d5dce45c08e71b05
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This also prevents assigning a client to a nullptr document.
Change-Id: Iacefe141a08fd47e69faacd4b0cd156c264ac19b
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
And add alt text for them.
Task-number: QTCREATORBUG-26278
Change-Id: Ibe40f284e3162a77982fc3731313a6f2bc9492b5
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
If we have more than one render in queue for 3D edit view, we know the
current render is not good, so do not send it to creator side but
instead wait until we have just one render in the queue.
Also changed the timeout for queued renders to closely correspond to
60fps frame time as there is no point rendering any faster than that.
This also means we never need to queue more than two frames to ensure
correct results.
Fixes: QDS-5467
Change-Id: I49a3a7aeaff24484f48784d0391414165ce50748
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
When selecting transparency in the qt quick toolbar, the text inserted
is missing quotes around transparent.
Add missing quotes around transparent.
Fixes: QTCREATORBUG-10769
Change-Id: Ibc5d10b2276b44aee8afad60c33f0394a7d75ba7
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
The plugin has been disabled by default in 6.0, and
some users have already asked us about it.
Task-number: QTCREATORBUG-26278
Change-Id: I6085b17b0e78592eff285d2d0fc55107593202da
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
The installation has been temporarily removed from Qt Installer.
Task-number: QTCREATORBUG-26278
Change-Id: I8de557045857ddaa73e984cce37f31f3d93690bd
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: hjk <hjk@qt.io>
The index in the backend wizard's combobox was not loaded when
initializing the QML combobox.
Task-number: QDS-5523
Change-Id: I48583ff1ca85f840e9b7314a4e0ed734364c326a
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Use Qt styled enum values to avoid clashing global defines.
Amends 06a6549075.
Change-Id: I85d3ec4192c1c55f231b6e2e81ec114480c03a5c
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Instead of telling the user that the project name does not match a
complex regular expression, we can tell him in English words what the
rules are.
Also, updates the icon of the status message so that, when the status is
multiline, the icon appears at the top, rather than vertical center, on
the left side of the text.
Change-Id: I848b3858f5f92a09588b9646c56cbf743b06ea09
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Do not look up windows network paths in profile editor when looking for
links under the cursor. The QFileInfo::exists check can take up to a
minute here if this network path does not exists.
Fixes: QTCREATORBUG-26579
Change-Id: I2648bc398e25bcc660f1161a187c4d92c3def28e
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
When the locator popup gets focus on Windows, we need to handle the
escape key explicitly and also need to make sure that it isn't
considered as a "base window" when requesting locator again.
On other platforms the locator popup never gets focus, so the issue
doesn't appear.
Fixes: QTCREATORBUG-22119
Change-Id: I1e1a74332c174bc20f961ebe0709c591f82f2829
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: André Hartmann <aha_1980@gmx.de>
... passed to macros defined in a different file.
This amends e77e57420a. Contrary to our expectation, it is possible that
AST nodes that are marked as belonging (only) to a header file can
contain child nodes that belong to the main file.
Fixes: QTCREATORBUG-26553
Change-Id: I4d1d877d8e1e2dcf7d81b63aa98e1149b5514e3f
Reviewed-by: David Schulz <david.schulz@qt.io>
Recommendation of Designer is the artifact from an earlier solution
for adding code of .ui files to the code model. The refactoring of
extra compilers made that superfluous, this change removes the
left-over traces.
The CMake build of Qt Creator breaks because of the recommendation
if the qttols module is not installed.
Amends: 78d3191363
Change-Id: I64827492d79a9238dc8512047abd581f9da3189e
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Visible in the O and <> buttons of the Callgrind toolbar.
Change-Id: I1016f853335bfc243f7e934e7a0cd430922c8af6
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Add play button state to the scene state.
Task-number: QDS-5499
Change-Id: Id3035de439aa80fd782348cf89a1d8456a7dd006
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
The new QtQuick application wizard for Qt 6.2-based applications now
uses different names for the project and for the main target.
The WebAssembly plugin cannot construct the html file name for launching
like <projectname>.html, anymore. It instead would need to use
<targetname>.html for that.
The author of this patch did not manage to programmatically retrieve the
target name or buildkey. So, as a hack, we simply chose the first html
file that we find in the build directory.
Fixes: QTCREATORBUG-26562
Change-Id: I7e929fe265a15501c7275e2c76b7f5fa4ed1e6b5
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Similar to the qmake make build step, so build issues are parsed for iOS
builds.
Task-number: QTCREATORBUG-26541
Change-Id: Ie71a3087feab2720f6d8b4974d221a70c3fe76fa
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
The output of xcodebuild changed, and no longer contains
"BUILD (AGGREGATE ...)". Instead it prints various "note:"s.
Use "note: Build preparation complete" to trigger parsing the following
output on stdout for error messages.
Task-number: QTCREATORBUG-26541
Change-Id: I9dabcc30389352aa5f78dae31104a8c9cf56eb19
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
