Commit Graph

82976 Commits

Author SHA1 Message Date
hjk
f16f09c390 ProjectExplorer: Use aspects more directly in customexe runconfig
Change-Id: I0c68c3a3b5fcaa0b25f12b9feed5023400e0bd00
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-07-13 04:55:59 +00:00
hjk
f31007f40a Meson: Remove unnecessary MesonBuildSystem::kits
Base is good enough.

Change-Id: I3f9f1007336b8ae9a03c8e75da64a8eb5b73a8af
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-07-12 15:39:16 +00:00
hjk
38c3abb774 Meson: Move MachineFileManager near build system
Closely related

Change-Id: Id561dccd909bb4dc53e1a55d6ee77d008e5c4078
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-07-12 15:38:33 +00:00
Jarek Kobus
ae01e13d32 AbstractProcessStep: Move process done handler from QMakeStep
The done handler is going to be used for other processes, too.

Change-Id: I3c60ec75656aa45bd57ec3ca8336cf310c78bd3e
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2023-07-12 14:57:34 +00:00
hjk
8ba6f11e9c Boot2Qt: Use aspects more directly in QdbRunConfiguration
Change-Id: I8a199f449824ff973f5278f39172307be0e11438
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-07-12 14:01:57 +00:00
Cristian Adam
ba755e50a3 Utils: Fix inverted logic for checkableDecider (continued)
Amends 6b6b1198dd

The commit above made sure that the display of the dialog was in sync
with the checkbox in the settings dialog.

Now also the "Do not show again" checkbox in the messagebox will be
reflected in the settings dialog.

Change-Id: Ieb186b134adac09c9846a64144056b3b89d297d8
Reviewed-by: hjk <hjk@qt.io>
2023-07-12 13:12:40 +00:00
hjk
323f29a3bd AutoTest: Merge settings and tools hierarchies [2/2]
Renaming files to match class names.

Change-Id: I3d75a79a5ad8e9d1c132530cbcc6973efc6dbadf
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-07-12 13:08:28 +00:00
hjk
0b83f110f4 CppEditor: Make a few CppModelManager functions static
... to simplify code using it.

Change-Id: Ib2bfbb5a17a1d48088a9cf4973d4c3f006cd34e4
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-07-12 13:08:09 +00:00
hjk
8f82e76ba1 ProjectExplorer: Centrally disable X11 forwarding aspect on windows
That's only the default value, but basically what all user code
occurrences do.

Change-Id: I2997744cf069455294ac35871109edc4328a1996
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-07-12 13:06:55 +00:00
hjk
90ba140545 CplusPlus: Use plainer callbacks to interact to the CppEditor
Lets us remove a few explicit CppModelManager::instance() call
in user code later.

Change-Id: Id8d846d06a0715b3d609cc5d52cc031e1d025fb1
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-07-12 13:00:48 +00:00
Christian Kandeler
1d59a37acb ClangCodeModel: Fix outdated message
... after applying a clangd warning suppression.

Change-Id: I6b6605edd80080dcfd070b4a2f4219463674421b
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-07-12 12:57:06 +00:00
hjk
14e18fc92f AutoTest: Merge settings and tools hierarchies [1/2]
Currently living in the settings files to keep changes small,
will be renamed in a second step.

This allows the settings aspects to be used in their short form
and overall removes some indirections.

Change-Id: I099369b62239aed8192613a04bca958a660c36c7
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-07-12 12:12:17 +00:00
hjk
345c946255 ProjectExplorer: Use direct aspect registration in ProcessStep
Task-number: QTCREATORBUG-29168
Change-Id: If83acc092689a935cf81c8133d6a07d802a07177
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-07-12 11:42:34 +00:00
Ali Kianian
c3dee68573 QmlDesigner: Unmark the reflection flage for valid Qml property changes
The reflection flag is unmarked for valid Qml property changes in order
to be updated in the puppet side.

Task-number: QDS-9881
Change-Id: Ibd36fb1ee844f08efa256d28514a3f0debd467e2
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-07-12 09:49:18 +00:00
Christian Stenger
6ef4bd0a65 Revert "SquishTests: Adapt test for Qml debugging"
This patch had been valid when there had been another different issue
of using qmlpuppet instead of qmlviewer or qmlscene.
The other issue is fixed, so this patch is obsolete and now wrong.

Change-Id: I291651256db2da1763d918c34811f03950cdb322
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-07-12 09:02:17 +00:00
Eike Ziller
9e8bdc9836 Fix order of session vs recent files/projects menu
Got mixed up when moving the session manager to Core

Change-Id: I729dd505c0b58bbbe46ddee423c76ab21c6f1b25
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-07-12 08:59:09 +00:00
Alessandro Portale
f3654b8fd2 Autotest: Use LayoutBuilder in ProjectTestSettingsWidget
Change-Id: If9f67564323835334e123178806467a999ab73a1
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-07-12 07:44:14 +00:00
Marco Bubke
fb9a7e2d3a QmlDesigner: Fix missing project storage include
Change-Id: Ifb7439e5998ef8d9fb89f3d21a20ed49c46cbe35
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2023-07-12 07:23:58 +00:00
Marco Bubke
e7a7914aa8 QmlDesigner: Fix skip auto moc
Actually the syntax was wrong.

You can use

SKIP_AUTOMOC foo.cpp

or

PROPERTIES SKIP_AUTOMOC ON

SKIP_AUTOGEN is skipping AUTOUIC and AUTORCC too.

Change-Id: Id4afdc2572fc287ae66368ba0fd70b3ce7fc04ba
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Burak Hancerli <burak.hancerli@qt.io>
2023-07-12 07:15:50 +00:00
Marco Bubke
98cff9e097 QmlDesigner: More test for NodeMetaInfo
Task-number: QDS-10055
Change-Id: I23a9d7ea87dff9f3e07f5beeb734cea7d01d2e94
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-07-12 07:13:39 +00:00
Leena Miettinen
3224743a1c Doc: Move Qt Designer keyboard shortcuts to their own section
They were mixed with Editor shortcuts.

Fixes: QTCREATORBUG-29399
Change-Id: I5f81e1c32cabd7f94bb0d2adef29ff8a0d5ca748
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-07-12 07:10:24 +00:00
Eike Ziller
9144706000 Make showing tool tips for menu items more widely available
Change-Id: Ic9fcb61917c955a2b114c3a355dbdf5c291d75f3
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-07-12 06:34:51 +00:00
Eike Ziller
5b79efd0d6 Tasks: Save TaskCategory objects in the model
So data can be accessed more directly, instead of going through
individual methods categoryIds and categoryDisplayName.

Change-Id: Idb36050762e507480ba69de6a32b5f6f9bec8b75
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-07-12 06:34:40 +00:00
Eike Ziller
cd1b6a669b Tasks: Create a container class for category data
Reduce the number of arguments that need to be passed around.

Change-Id: I9fbfdcdf7b20f8f26e35f435bf8d65ba483e4114
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-07-12 06:34:25 +00:00
Alessandro Portale
918978ce89 Android: Remove unused androiderrormessage.h/.cpp
These have been added 10 Years ago with the plan to use them soon after,
but that did not happen.

Amends: db78293e7f

Change-Id: Ic916eafba56cbb5e4d1dadfb63222fa2870fbd2c
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
2023-07-11 19:15:12 +00:00
Marco Bubke
8ab4968278 QmlDesigner: Introduce origin flags
metaInfo.isProjectComponent() is signaling if a file component is
directly part of the project. metaInfo.isInProjectModule() otherwise
shows if a type is inside of the project as a qmldir module. Both cannot
be true. If a type is not part of either it is a system type.

Task-number: QDS-10251
Change-Id: Iae2270827a500ad6393e3751b3af276f9b030679
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-07-11 15:42:48 +00:00
Marco Bubke
e1171359ab QmlDesigner: Disable auto moc for non-qobjects
Change-Id: Ibca60ac262a4d43f8963b23ab6c2de5fa0098b27
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-07-11 15:42:41 +00:00
Marco Bubke
a3f990d713 QmlDesigner: Add type lookup
Task-number: QDS-10246
Change-Id: I607f72e29734a3c59b7b5b33d96735d708cd18ec
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-07-11 15:42:06 +00:00
Eike Ziller
409591e6f9 MCU: Fix missing files in list of project files
MCU projects contain subnodes for the contents of QmlProject files, which
get populated after the project tree was already added to the tree.

To make sure that the added files are also listed in
`Project::files(...)`, and therefore be considered for e.g. Locator and
project searches, the code must trigger `Project::handleSubTreeChanged`,
so the cached list of nodes is updated. This doesn't happen with
`addNode` (which is for construction before the tree is added to the
`ProjectTree`), and forcing the `ProjectTree::emitSubtreeChanged` signal
is also not sufficient.

Use `FolderNode::replaceSubtree` which was made for this usecase and
triggers all the relevant code.

Fixes: QTCREATORBUG-29297
Change-Id: I3a1c4c1aebf978e2788de905231b83355db75030
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Yasser Grimes <yasser.grimes@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-07-11 14:03:00 +00:00
hjk
200ae0b40b Qnx: Use Aspects more directly in QnxRunConfiguration
Change-Id: I450144e91842792cc5841b2fb61e8fc39b0daa1e
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-07-11 12:42:33 +00:00
hjk
cf7b2fb822 RemoteLinux: Add auto-registration ability to RemoteLinuxEnvironmentAspect
Change-Id: Ifec10445427c2f8125c29cdb4db44d45a99e6453
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-07-11 11:48:21 +00:00
Marcus Tillmanns
abf2234e4f Utils: Add ToolBar to layoutbuilder
Change-Id: I26ce85f73e625508d816c0e361a6afc65adf65ff
Reviewed-by: hjk <hjk@qt.io>
2023-07-11 11:37:23 +00:00
Christian Stenger
b5fa6be362 AutoTest: Retrigger scan if active frameworks change
...if the code parser is scanning for tests.
Otherwise we have the canceled state of the running scan.

Change-Id: Ief493c0bf66825e57c44c79193d5e8085ee98acd
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-07-11 11:10:52 +00:00
Christian Stenger
4f50b6b791 AutoTest: Postpone removal of root node
If a root node should get removed while scanning we may end up
crashing when still getting results.
As there is currently no mechanism to stop a certain parser
postpone the removal of the root node until the parsing is done.

Change-Id: I3766f9e67780e241801166339fa67f39536314b4
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-07-11 11:10:40 +00:00
Cristian Adam
c914e5f9c2 Wininterrupt: Add explicit stdlib.h include statement
strtoul is found in stdlib.h and with the llvm-mingw toolchain it
fails to compile due to the stdlib.h header not being indirectly
included.

Change-Id: I85fc5e5828c859572ff1ce2c050556bc087de277
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-07-11 10:35:50 +00:00
Cristian Adam
80196abd6f CMake: Remove Windows 8 WINVER / _WIN32_WINNT defines
This was required for older MinGW toolchains.

Change-Id: I89e048adf01fa2b04c52715f71bf266cbd65c44e
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-07-11 10:35:46 +00:00
Ali Kianian
f7a7f55df5 QmlDesigner: Handle placeholder color for navigator line edit
Task-number: QDS-10099
Change-Id: Ieede8ffc7ef6251c32cd78f7a90fb6f56f3c0824
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2023-07-11 10:15:13 +00:00
hjk
ed93cff3ba ProjectExplorer: Allow to specific target device for EnvironmentAspects
Similar to what is done for ExecutableAspect.

The device related part is here not used yet, as only run related
setups are affected. This might change with an attempt to unify
EnvironmentAspect and RemoteLinuxEnvironmentAspect.

Change-Id: I6a620ad1d3443f0e8201c2572689edda1f84593c
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-07-11 09:40:27 +00:00
hjk
e1ca7cf53f Utils: Let registered aspects know about their containers
Will help to set up macroexpanders with less boiler plate.

Change-Id: I521af3dc9d49524cf855e82eecc0132d1bcc40db
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-07-11 09:37:17 +00:00
hjk
6346952380 Beautifier: Make sure version update process finishes
Change-Id: Ifd6fcee56d03f2853c7b196e8dade650f4e60e55
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-07-11 09:29:12 +00:00
Ali Kianian
c3f3f85354 QmlDesigner: Prevent showing background contents for widget comboboxes
A rectangle filled with the same brush as the parent widget makes
a blank cover just behind the combobox to prevent showing the contents
of the behind widget.

Task-number: QDS-6298
Change-Id: I4b2014a60282e109086351d3bd4694ae7c519e8d
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2023-07-11 09:21:59 +00:00
Ali Kianian
8f3fd958ef QmlDesigner: Escape button press clears the search boxes
Task-number: QDS-7838
Change-Id: I1ed283846ba87eb2dbd786a560aaf940cb6f8132
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2023-07-11 09:20:49 +00:00
Alessandro Portale
dbfc2a3242 Core: Use LayoutBuilder for FancyTabWidget
Change-Id: I01905732563807715eec21879e5a1c8c6fc2b5fe
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-07-11 09:12:13 +00:00
Jarek Kobus
d171e6da69 AbstractRemoteLinuxDeployStep: Make some overrides final
Move some methods into protected section.
Do some cleanup.

Change-Id: Ica6f6fd181334c450666049c10d9ecc1ea16ea5c
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-07-11 09:10:52 +00:00
Christian Stenger
0c40bd3e99 McuSupport: Denoise McuBuildStep
Change-Id: I519984d7bbdb84b1436184dc0bbd04be0967c3e5
Reviewed-by: hjk <hjk@qt.io>
2023-07-11 08:39:56 +00:00
Jarek Kobus
ed86673e84 AbstractProcessStep: Hide some methods in protected section
Change-Id: Ibc306288c35c4826123b6146e568d55d533e07a9
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-07-11 08:33:19 +00:00
Jarek Kobus
06a57f8c42 BuildStep: Store the BuildStepList field
Don't rely on qobject hierarchy casts.

Change-Id: I7152252c882805fea0bc82e8f1205a964bfdfd93
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-07-11 08:26:51 +00:00
Jarek Kobus
6a8fe161cb BuildStepList: Pass ProjectConfiguration into c'tor
Instead of relying on parent-child qobject hierarchy.
Add explicit BuildStepList::projectConfiguration() getter.
Add explicit Target arg into ProjectConfiguration c'tor
and avoid qobject_cast.

Change-Id: I0b3105f7f8aea950e9679857887baffe9b321a33
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-07-11 08:24:15 +00:00
Jarek Kobus
02ffee322b AbstractRemoteLinuxDeployStep: Make recipe return GroupItem
There is no need for extra nested Group item in deployRecipe()
overloads, as sometimes it's just one task, like in case of
QdbStopApplicationStep or CustomCommandDeployStep.

Change-Id: I89cdb703c24198f3cbdfb17d0317e40f1929c376
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-07-11 08:02:46 +00:00
Leena Miettinen
31386c3fa0 Doc: Add a Reference topic
For listing reference topics.

Task-number: QTCREATORBUG-29361
Change-Id: I1d0463c4bfcd826464535a377da533509d838435
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-07-11 07:58:51 +00:00