This is a preparation step toward making the recipe more general.
Add a runRecipe() method (private for now) which
describes the whole step's execution. Later, when
virtual BuildStep::runRecipe() is added, we just
make this newly added method virtual.
Make deployRecipe() pure virtual.
Change-Id: Ic9c4e3eea7d4a3eb95fd419575f4f747224d0499
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
... by introducing "proper" FilePathAspect::value() (and therefore
hiding the inherited StringAspect::value(() and a temporary stringValue()
for the transition period for the remaining users of the QString value.
Change-Id: I40cf4238a09a9009cda0decba1acac82bd730233
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Partially reverts 91bdbb61ec as
the symbol lookup will update the snapshot's cache. As there
are concurrent threads accessing the snapshot we may end up in
a crash.
Change-Id: I2aaf5e403b10cba2b26915cbe7b4712c43c4957b
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Also fix use of a the potentially remote conanfile by using
only the .path() when passing to the (remote) install step.
Change-Id: If588dc8e2777a9c6515845886d9f3a9ab881c97f
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
If the selected package already exists as dependency in the project, the
dialog shows an info label and prevents re-adding of the package bz
disabling the OK button.
Task-number: QTCREATORBUG-29333
Change-Id: Icd368bb2b0bde72ebe5efaea6a81e3cf96830ce3
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Instead of just inserting the package name at the cursor position, Qt
Creator now attempts to append the package name in the dependencies
array.
With auto tests.
The "interesting" effect of this is that the order of values inside
a Json object may change. Qt seems to enforce an alphabetical order
on the key names.
Also the indentation becomes 4 after the modification.
Task-number: QTCREATORBUG-29333
Change-Id: I803ca6a19ee32aeba95640726ac8d8e477750bc0
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
This is a preliminarily renaming files to keep diffs small.
Change-Id: I5fc25bd2435a48f1ac3e2f22287004a0f2c8dd16
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
The !isEmpty check is actually redundant, but currently cheaper than the
diversion through FilePath::fileAccess().
Change-Id: I44e6ec128c78cccf57c7276da70577a87b8c2f96
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Settings are created on first access now, even though this
doesn't matter much here as this happens unconditionally in
AutotestPluginPrivate ctor via m_frameworkManager.synchronizeSettings()
Change-Id: I340927cf107d7e4b2268e842d23f1a89898e8a92
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
... to prepare moving the "unusual" functions off the settings/
AbstractSettings base.
Change-Id: I4875bae9f3cec2105eb6d29493d6a6e706c414a7
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
In order to limit the verbosity: add using namespace Utils instead.
Remove some unneeded includes.
Change-Id: I446da2324803fd4ac6fb854ce7626d497f9797f3
Reviewed-by: hjk <hjk@qt.io>
Don't keep 3 separate lists for build steps, enabled
states and build step names. Use just one list with
BuildItem struct. This quarantees the lists don't get
out of sync.
This fixes a possible issue in case when
abortBuildAllOnError is false. It could happen that
the front build step was removed from the m_buildQueue,
but the front items from the m_enabledState and m_stepNames
lists stayed there.
Change-Id: I9dc27a94b2961d3a190f1acfb6241bcdd1c41d1c
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Mostly namespaces, but also centralize access to the factory list
for better debugging.
Change-Id: Ic8b19b8c110dc925e0f7ae27af1da2b9e1ec6086
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
None of this had any affect after switching to clangd.
Change-Id: I806682fecff84bf6eb0b0eb382e096fc9a25fa3d
Reviewed-by: David Schulz <david.schulz@qt.io>
- Move some information from "Viewing Output" to the "View output"
how-to topic
- Add the output view topics to \ingroup creator-reference-output-views
and \ingroup studio-reference-output-views
Task-number: QTCREATORBUG-29361
Change-Id: Ib91373015f416bf4eb6f5f5123a4ae6e5ebe8d8e
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Silences a soft assert and re-allows to type paths
containing more than one directory separator.
Change-Id: I36c400e32b39206669278b89ab4bb033a1f0b6f6
Reviewed-by: hjk <hjk@qt.io>
