While doing we must take care that we do not remove documentation that
is used by other, still registered Qt versions (since for example
desktop & mobile Qt versions share the same documentation).
Fixes: QTCREATORBUG-16631
Change-Id: I77a38c89698cb3050d4a0a6963ab12d3238e2068
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
Only used by the options page and generally needs knowledge of help
namespaces, which requires querying QtHelp.
Change-Id: Id8eda86e5b373ab3214e8eff6e2e3ce92c1239ba
Reviewed-by: David Schulz <david.schulz@qt.io>
The CreationDate field was set to hardcoded date of 2012 year
during generation of qch files (from inside qhelpgenerator).
There was no other place in any code which would modify
this field value. So having this field didn't make much sense.
In meantime setting of this field has been removed from
qhelpgenerator, so this field is not being set anymore.
The code which is being removed here, has never been doing anything
which would make much sense, since the compared dates should
always be the same.
Change-Id: I5a628235018223f61f0cbe814e92e1dcd7d34614
Fixes: QTCREATORBUG-20253
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
We don't want various plugins to depend on the Help plugin,
but we also do not want Core to depend on QtHelp.
For example when turning the Help plugin off, documentation should
actually no longer be registered through QtHelp. So we need
parts of the interface in Core, which must then be delegated
to the actual implementation in Help.
As positive side-effects the interface in Core will be slimmer,
and the code in the Help plugin can later be simplified, too,
because then we don't have the "Core" and the "Gui" help engines
separated in different plugins anymore, which should remove the
need for some setup indirections.
Task-number: QTCREATORBUG-20381
Change-Id: I634c5811c45d6a3dfd6ddc682cae270e38384cbf
Reviewed-by: hjk <hjk@qt.io>
We now do as much as possible lazy initialisation, e.g only start the
full text search indexer if we really access the search widget. Also
moved the QFutur progress into the search widget. Changed all ctors to
be called without an argument, since we share the help engines from
help manager all over the place. Make use of the fact that we only need
to call setupData on the gui engine if we access the help mode, otherwise
all data is fetched thru the core engine whichs setupData is really fast.
In case of split mode we did not check if the actual requested doc
exists and thus did fail to open the browser if it could not be found.
Reviewed-by: Daniel Molkentin
