feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity
76,023 Commits 108 Branches 368 Tags
8a645e8a1debfb1c94e05fe5173f097e0ffd16fe
Commit Graph

76023 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jarek Kobus
8a645e8a1d GitPlugin: Limit the usage of qMakePair 
Change-Id: I9a164d951c43a9fc30bbdfffada22d9876d35e3f
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
 2022-09-30 12:27:12 +00:00
Marcus Tillmanns
34dc092642 Docker: Improve File contents read speed 
Change-Id: Ic94715d2c362ac3aa75dabf4f95c74737abd6264
Reviewed-by: hjk <hjk@qt.io>
 2022-09-30 12:13:52 +00:00
Marcus Tillmanns
8d67bc36a7 ToolChain: Cache validity 
Checking the validity of a toolchain can involve a call to
a remote device.

We cache the status now to speed up places that repeatedly
check the validity like opening the Toolchain Settings Page

Change-Id: I2b1d8aeba99fb9761d60d4710806bf4b767eaac9
Reviewed-by: hjk <hjk@qt.io>
 2022-09-30 12:13:43 +00:00
Christian Stenger
b3890d1b7c Squish: Fixup initial generated suite.conf 
Change-Id: I217b2e6a1d89356b0482b91af53a1dd313f4efdd
Reviewed-by: David Schulz <david.schulz@qt.io>
 2022-09-30 12:13:16 +00:00
Marcus Tillmanns
b29c7bc4a6 FSEngine: Fix engine to handle root path correctly 
Change-Id: Idd5b75875a87e624675ed40cba668caf5013e6a9
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
 2022-09-30 12:13:08 +00:00
David Schulz
4f9a5ea896 LanguageClient: Inform user of failed prepareRename request 
Also instantiate the search result window if we get an error and use it
to display errors.

Change-Id: I49dcdcc5ad2ace64391f8d2d849995b046032957
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
 2022-09-30 11:59:52 +00:00
Christian Kandeler
9e27ea3bb3 Fix some compiler warnings 
Change-Id: I67135a49c7bc8169dd159cdab381c21f27be02f3
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
 2022-09-30 11:53:11 +00:00
Christian Stenger
9ac0ac9ca1 Squish: Store opened suites into session 
Opened test suites will now be stored into the session
and re-opened automatically when the session is loaded.

Change-Id: I5b7e55bf511918cb2e9eeec6f943cc7baced0a8f
Reviewed-by: David Schulz <david.schulz@qt.io>
 2022-09-30 11:37:17 +00:00
Jarek Kobus
4c1f410881 TextEditorPlugin: Limit the usage of std::make_pair 
And qMakePair.

Change-Id: Id92a662fa0674b9e9f835280bb9378c8d00549e8
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
 2022-09-30 11:25:19 +00:00
Jarek Kobus
3885b936b6 CorePlugin: Limit the usage of qMakePair and std::make_pair 
Change-Id: Ibf96ca29d2570841955366371f1bab11198b3e67
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
 2022-09-30 11:23:54 +00:00
hjk
5d7c5e21c0 GenericProjectManager: Remove two uses of QFileInfo::exist 
Change-Id: Ibfa64783ecd7150200683126b432abc8703debc8
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
 2022-09-30 10:46:58 +00:00
Christian Stenger
ade4c33afc Core: Delay setting tab order a bit 
Must happen after the respective widgets have been attached to a parent
widget.
Amends 38f88f6310.

Change-Id: Ib0841afb09cd12791422903c3bf38de2d0bd580c
Reviewed-by: hjk <hjk@qt.io>
 2022-09-30 10:23:36 +00:00
Jarek Kobus
d1e521d223 Utils: Limit the usage of qMakePair 
Change-Id: I93eba395ddc580950a7eeb908555736ff48a3e3d
Reviewed-by: hjk <hjk@qt.io>
 2022-09-30 10:17:56 +00:00
Jarek Kobus
738803a4da Various plugins: Limit the usage of qMakePair 
Change-Id: I9113dd47fb4f9026f3a732aebbd0aee31651b727
Reviewed-by: hjk <hjk@qt.io>
 2022-09-30 10:17:47 +00:00
Jarek Kobus
00741a7216 ModelEditor: Replace QQueue with QList 
No QQueue's specific API was used anyway.

Change-Id: I6ac2d02c43ce4e3700589a4df97dd3f0983d23b9
Reviewed-by: hjk <hjk@qt.io>
 2022-09-30 10:13:12 +00:00
hjk
63f3921334 CPaster: Convert to Tr::tr 
Change-Id: I00242638e483aa9cb5b54473982eed137e859ff6
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
 2022-09-30 10:13:08 +00:00
Christian Stenger
c42ae96ba8 Squish: Move wizard into plugin 
Avoids a soft assert when parsing the wizards without having
the Squish plugin enabled.
As the Squish wizard is using customized wizard generators
that are only available if Squish is loaded we should limit
the presence of the wizard file to this case.

Change-Id: I091c1e429f28b07679245abdc9a638135af84761
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
 2022-09-30 09:31:34 +00:00
Christian Stenger
1c8a1b9d82 Squish: Fix script generation 
Handle whitespaces inside the application's name and
arguments correctly.

Change-Id: I5f3fc7c83e7b1e694e9f2a4583c6ac06b7528ff6
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
 2022-09-30 08:37:55 +00:00
Cristian Adam
ee4c998ff3 CMakePM: Add supprot for CMakePresets version 3 
This includes Condition and toolchainFile

https://cmake.org/cmake/help/v3.21/manual/cmake-presets.7.html

Task-number: QTCREATORBUG-24555
Change-Id: I1026390af67b2be1aa0c3b02b654fc19442d3c89
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
 2022-09-30 08:34:07 +00:00
Cristian Adam
45a275e054 CMakePM: Use architecture and toolset for project import 
This fixes issues with Visual C++ generator, which needs the right
parameters to pinpoint the right compilers.

Also use CMAKE_TOOLCHAIN_FILE for qmake detection.

Change-Id: I6edc84c7ed1a892fbc5545ff61dc06ac20720f0a
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
 2022-09-30 08:34:00 +00:00
Jarek Kobus
d2820ccdd3 ModelingLib: Limit the usage of qMakePair 
Change-Id: Ic89f2a9598faadbda964f71dbe84bfd5400aec4f
Reviewed-by: hjk <hjk@qt.io>
 2022-09-30 08:20:16 +00:00
hjk
dda16c3abc Cvs: Move to Tr::tr 
Change-Id: Iba6cfa75745ec2644c1a3dd20949971d16f6dba7
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
 2022-09-30 08:18:24 +00:00
David Schulz
08a7dbd046 TextEditor: reorder TextEditorWidgetPrivate member initialization 
Change-Id: I369a0856c787873f2272cda92878f413648bad8d
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
 2022-09-30 08:13:19 +00:00
Eike Ziller
88e9b14ca6 Merge remote-tracking branch 'origin/master' into 9.0 
Change-Id: Ib6902407c879a840b927be9a545cb7c5b26c9ff8
 2022-09-30 09:52:35 +02:00
Jarek Kobus
1359557f77 DiffEditor: Limit the usage of qMakePair 
Change-Id: I0f7f4235cba4e1f6df4245cb51a37ff82a8e5109
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
 2022-09-30 07:42:00 +00:00
Jarek Kobus
38316079f3 UnifiedDiffEditor: Early return inside jumpToOriginalFile() 
Change-Id: Ib397c316296db494b81a08214049884c45a3f5e5
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
 2022-09-30 07:41:54 +00:00
hjk
191815e974 BinEditor: Clean up translation contexts 
Change-Id: Ibeb8c93ad1dfa816ccf1160abae8aac6781157d9
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
 2022-09-30 07:32:49 +00:00
hjk
479403e320 Bookmark: Clean up translations 
Some unusual contexts went unnoticed so far.

Change-Id: I6017d8ae92310ee3b56538d1fa5c52f0de0a4c8a
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
 2022-09-30 07:14:57 +00:00
Leena Miettinen
65d6c663e3 Doc: Describe the Help > Change Log option 
Task-number: QTCREATORBUG-27876
Change-Id: I484070f77695652642c6b2a12a57b2d0ec691708
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
 2022-09-30 07:14:43 +00:00
Christian Stenger
58a4cd0804 CMakePM: Fix nullptr access 
Amends 1b1fc43954.

Change-Id: Idfcf5bb2c58f37f366cb739475c7ba2d56d76e48
Reviewed-by: hjk <hjk@qt.io>
 2022-09-30 07:11:24 +00:00
hjk
685cc1a2fc AutoTools: Move to Tr::tr 
Change-Id: I605c2b5c812b500c1db2bdbfab26882ee55249d2
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
 2022-09-30 07:09:50 +00:00
Christian Stenger
bbd516f262 Core: Remove unused member 
Amends 847d853055.

Change-Id: Iae28f7a7dbfd0fe3623cddaf6342c82964e435e6
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
 2022-09-30 07:09:45 +00:00
Eike Ziller
a0f008b8e1 Merge remote-tracking branch 'origin/9.0' 
Change-Id: I4d1954622e28ff292ed7699268c5572102869d56
 2022-09-30 09:04:25 +02:00
hjk
ab4c9b9679 CMake: Move to Tr::tr 
Change-Id: I169da93b5184351cb915d4c198fd33318fcfe06f
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
 2022-09-30 06:56:21 +00:00
Jarek Kobus
9f25c2dedf DiffFileInfo: Export it back again 
It should be still exported as it's a part of
FileData class, which is also exported.

Amends b677fbe992

Change-Id: I0d53dff2c355cddf7d1f3d001cb7b71210c75223
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
 2022-09-30 06:49:24 +00:00
hjk
38f88f6310 Core: Inline findwidget.ui 
A lot of unusual stuff where LayoutBuilder doesn't shine...

Change-Id: I06259e0913fade2d70ebfbab3f438cb8f7e96bf3
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
 2022-09-30 06:34:08 +00:00
David Schulz
01ddb61ab7 Editor: Fix reassigning a document to an editor 
Moving all initializations that are not influenced by the document to
the TextEditorWidget(Private) constructor. So we do not reinitialize or
double connect unintendedly.

Change-Id: I42f4e8166c21aec9c8b780033b12eb8dae5f72a6
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
 2022-09-30 04:19:17 +00:00
David Schulz
2710e68610 LanguageClient: guard client access in formatter 
Change-Id: I76bd41b3a786b1893bc159e0363f90494fd14b9f
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
 2022-09-30 04:07:57 +00:00
Jarek Kobus
99589a7572 UnifiedDiffEditor: Move some methods into UnifiedDiffData 
Like it's done in case of SideDiffData.

Change-Id: I27af423e50277c81e596006c960daecc6a51145f
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
 2022-09-29 18:46:15 +00:00
Jarek Kobus
b677fbe992 DiffUtils: Introduce DiffChunkInfo 
Avoid code repetition.

Change-Id: Iea9acef8f8b27793528fa7eaf7044e12dcd21d10
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
 2022-09-29 18:46:10 +00:00
Jarek Kobus
daa942393a DiffEditorPlugin: Introduce DiffFileInfoArray 
Change-Id: I884d72e6c500e41969f379d969bcf1f46be8fd5c
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
 2022-09-29 16:14:04 +00:00
Jarek Kobus
835b278c00 DiffEditor: Use namespace Utils 
Change-Id: I0869c6ed0e2173ce46ebde7deebe5352034daedb
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
 2022-09-29 15:53:50 +00:00
Jarek Kobus
aacf25ebb6 SideBySideDiffEditor: Fix context 
Suffixed are meant to be different for both editors.

Amends 2d360db2c3.

Change-Id: I4bf8f2b066dbf420eba38a56301d6e24a685caf3
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
 2022-09-29 15:53:44 +00:00
hjk
847d853055 Core: Inline mimetypemagicdialog.ui 
Change-Id: Iedc66b6915028af3551e3ac910e417fce3f0466d
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
 2022-09-29 15:33:15 +00:00
hjk
f376b06648 Core: Inline mimetypesettingspage.ui 
Needed to keep the QCoreApplication::translate for now as the class
has a Q_OBJECT creating a different context.

Change-Id: I1b1d836be675bdcd2802070032a7ace92838498c
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
 2022-09-29 15:31:20 +00:00
hjk
bb6847e3ec QbsProjectManager: Proliferate the use of FilePath 
Also use path() instead of toString(). While this doesn't change
anything as long as there is no remotely running QbsSession,
path() would be the better choice then.

Change-Id: Ief98536b34fe615f6b0be03cb3072df7b69f293b
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
 2022-09-29 15:27:24 +00:00
Jarek Kobus
460f347757 VcsBaseEditor: Get rid of diffChunkApplied() 
Drop unused arg from diffChunkReverted().

Change-Id: I5531645d317d62ae92cd0e63dadd583f8ab8996d
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
 2022-09-29 15:15:38 +00:00
Jarek Kobus
b67c868f75 PatchTool: Introduce PatchAction enum 
Add static PatchTool::confirmPatching() and reuse it
in two places.

Use Tr::tr() inside PatchTool.

Change-Id: I70779619dbb58ab6e46a585bbeff51588ccb2f53
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
 2022-09-29 15:15:30 +00:00
Jarek Kobus
2d360db2c3 SideBySideDiffEditor: Avoid code repetition 
Change-Id: Ie49834a4896dbf32a87329345e52dc99ca2f86bd
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
 2022-09-29 15:15:21 +00:00
Jarek Kobus
38b19bfae6 DiffEditor: Cleanup includes 
Change-Id: Id8127b9b0c99ee2a0d5d367cb551a1d5779c5d38
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
 2022-09-29 15:15:12 +00:00