Commit Graph

86026 Commits

Author SHA1 Message Date
Jarek Kobus
c86a19a56e Process: Fix stopping the process while message box is visible
When process finished while the message box querying for
a process to be stopped after a timeout was visible,
don't try to stop it and don't report a hang.

Change-Id: I74a819244a96d9e0209cabc6d58c0a1c4fe1ac31
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2024-01-20 20:10:12 +00:00
Jarek Kobus
767e11aa5d Process: Simplify timeout related internals
Get rid of two internal fields: m_hangTimerCount and m_waitingForUser.
Rename m_maxHangTimerCount into more meaningful m_timeoutInSeconds.
Fire single shot timers instead of a timer with interval.

Change-Id: I10890101273719f55a591eaecf818067aa5c503c
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2024-01-20 20:10:06 +00:00
Jarek Kobus
9aa37ee9d9 CMake: Omit a call to setTimeOutMessageBoxEnabled(false)
The false is a default value.

Change-Id: I94eb7c58ed591171de677f1dfc0d80a0c751d36d
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-20 19:04:48 +00:00
Andre Hartmann
95aa370b69 Git: Remove now outdated function comment
Amends 98c0e9764a

Change-Id: I9f7bf520bb5ead83d883a554c97400d183f6fcee
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2024-01-20 17:41:50 +00:00
Andre Hartmann
6f665c26a5 Git: InstantBlame: Init m_cursorPositionChangedTimer in ctor
Needs to be done only once, and fixes a dangling
pointer if setup() was called twice.

Change-Id: I02722daf5dffdfb2d4bb70de77436eb8d930806d
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2024-01-20 17:32:38 +00:00
Andre Hartmann
7493b3a630 Git: InstantBlame: Fix multiple blame after file save
* Move document changed to slot and make sure it is a
  unique connection to prevent multiple slot calls
* Still we get two changed signals after save, which
  caused two blame calls, avoid this with a marker

Change-Id: I8f09ebc8c3cf9f9832fe2725c69acbea9a6b8c28
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2024-01-20 17:32:28 +00:00
Andre Hartmann
e071a2d0ed Git: InstantBlame: Add categorized logging
Change-Id: Ic0e6e30a969fa4908d280e3dbb5c2395972d962d
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2024-01-20 17:32:21 +00:00
Jarek Kobus
a475d89b5a Process: Get rid of debug enums
They are either not used or not usable.

Change-Id: Ib0e75624a3bd0d1fa98e45ffe1f5e15ef4db1217
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2024-01-20 17:31:36 +00:00
Jarek Kobus
cbec5438b4 GitClient: Change synchronousStashList() signature
Get rid of unused errorMessage arg.
Return the stash list directly.

Change-Id: I9bf156c5ecda476a5def3c3490d6cb13d011a3cd
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2024-01-20 16:40:40 +00:00
Jarek Kobus
ee09a28e83 GitClient: Make stashNameFromMessage() a static local function
Get rid of unused errorMessage arg.
Return the stash name directly.

Change-Id: I11e7b0ef4dcaa38293cbf5d20b7213cc06850257
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2024-01-20 16:40:34 +00:00
Jarek Kobus
2d54995622 GitUtils: Get rid of unused Stash::clear() method
Make parseStashLine() a local static method returning optional Stash.

Change-Id: If702a4485ce87336ab829b522258e62a930589bf
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2024-01-20 16:40:28 +00:00
Jarek Kobus
98c0e9764a Git: Use QVersionNumber for git version
Parse the version string with base 10 now.

Amends abee98b44817d1aee63b5cd9b673d0c3aa1733ba

Change-Id: I2f0b47380a9714b3f3de475ddabe78875db3b608
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2024-01-20 16:30:51 +00:00
hjk
cd4f62ebf8 Valgrind: Move test object creation closer to tested code
Change-Id: I896c7f7c1d99a62bc869f3511c036123a78afc29
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-19 17:00:02 +00:00
hjk
eea8f42ea4 VcsBase: Move listening to closing submit editors into plugins
Change-Id: Iaab385621f84bcb6e1f6e79cffc198fbd0554c30
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-19 16:59:47 +00:00
hjk
dbac3e9225 Vcpkg: Move test creation closer to tested code
Change-Id: Id135a9225bcc8806d89c7589d68f9c21200d9374
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-19 16:57:35 +00:00
hjk
6e595d63a0 QmlPreview: Move test creation closer to test code
Change-Id: I7d44c332cd1fedf28854953d7bd649fbd6176fbf
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-19 16:20:08 +00:00
hjk
e845a551a4 PerfProfiler: Move resource counter test creation closer to test code
Change-Id: Ie4fb52d171eabfa4440ed937ea57003a152f7338
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-19 16:19:21 +00:00
Dominik Holland
295e4373fe AppMan: Allow the user to change the deploy steps
Change-Id: I972967c5b6f00712c687cc687f89f277be9d97da
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-19 16:18:42 +00:00
Jarek Kobus
52305ae1ae QnxDevice: Set SourceProfile to true by default
Task-number: QTCREATORBUG-30193
Change-Id: Ia55ad575bc4e62f7ff9e71263c467c089eb092ed
Reviewed-by: hjk <hjk@qt.io>
2024-01-19 16:16:04 +00:00
hjk
225762dbe5 ClangFormat: Move ClangFormatGlobalConfigWidget definition to .cpp
Not needed outside anymore.

Change-Id: If5dc3e8b3eddaea59d2633f480abeadda140f564
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
2024-01-19 15:10:13 +00:00
hjk
fddbb0e2d9 ClangFormat: Move ClangFormatStyleFactory creation closer to its code
Change-Id: I2378846e1dd9076b62e5d68cb75b7e0d9e4d65b0
Reviewed-by: hjk <hjk@qt.io>
2024-01-19 15:10:04 +00:00
hjk
5193ab0d37 ClangFormat: Code cosmeticcs in indenter base
Change-Id: Ibbc65d1d42de1d501adfcf31825ee95ef55328b2
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-19 14:56:27 +00:00
hjk
fc706838ef ClangFormat: Hide plugin class definition in .cpp
Change-Id: I37017641a55287b5049d99064a2ca77c6a7dc201
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-19 14:49:12 +00:00
hjk
3f4dc07aea ExtensionSystem: Collect test objects centrally
Change-Id: I60cd128f0514116ef85c3f7fb040cf13ea82be66
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-19 13:39:00 +00:00
hjk
7ff6e555e3 ResourceEditor: Use ActionBuilder
Change-Id: Ibc6c114555d7b31f0a87a9727543313f50ab91d0
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-19 13:38:51 +00:00
hjk
f2fb88df2e ClangFormat: Move test creation out-of-sight
Change-Id: I6403f5e0ab4783075ff6e87299317dc1988140db
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-19 13:38:30 +00:00
hjk
5f9b36b45a ClangFormat: Pimpl ClangFormatBaseIndenter
This avoids the large-scale exposure of #include <clang/Format/Format.h>
which otherwise confuses moc.

Change-Id: I1d48174bd5f940e03986b58a7efa5e537cc99781
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-19 13:38:26 +00:00
Leena Miettinen
62c0e5024e Doc: Split "Modeling" into several topics
Task-number: QTCREATORBUG-29361
Change-Id: Iaffaf6d148d05738d92d9ccd8fe634c4b2be063d
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-19 12:50:41 +00:00
David Schulz
15a1fd6afc TextEditor: reduce complexity of bookmark requests
Since the book mark support is nowadays part of the text editor plugin
we can directly access the bookmark manager from within the editor
without the indirection over the TextEditorPluginPrivate.

Change-Id: I5c04679d6583c06d615d489d3891431adcb64834
Reviewed-by: hjk <hjk@qt.io>
2024-01-19 12:45:16 +00:00
hjk
45bb4a5f76 Autotest: Move unit plugin test creation closer to the tested code
The current pattern.

Change-Id: I52354584734755b3b0f3d2c9596801dc050300fc
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-19 12:33:33 +00:00
Christian Kandeler
f9f43f7492 ProjectExplorer: Let KitAspect pre-select a settings page item
... when the "Manage" button is clicked.
Make use of this in the device settings page.

Fixes: QTCREATORBUG-25077
Change-Id: I1173a72d4c538c839c3e8df278a698b74bd6fca2
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2024-01-19 11:47:26 +00:00
Christian Kandeler
3fc1b5f57b Core: Let callers specify which part of an options page to pre-select
... and use it for the "Manage kits" functionality.
We will make use of this in other contexts as well.

Task-number: QTCREATORBUG-25077
Change-Id: I79c622075b9385b060aed73534d39acc23fd765e
Reviewed-by: hjk <hjk@qt.io>
2024-01-19 11:27:11 +00:00
Friedemann Kleint
b9cce1a0ba Brush up task file conversion scripts
Modernize them by using f-strings and print out the issue count.
Make flake2tasks.py include the error number in the warning text.

Change-Id: I2d736c27dd3b2356e2b0d0d20f95112e7c37d3f9
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Shyamnath Premnadh <Shyamnath.Premnadh@qt.io>
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
2024-01-19 11:02:34 +00:00
Eike Ziller
73475480f7 iOS: Do not decorate the iOS Simulator device with "ready to use" icon
The iOS Simulator device is always there, and always usable, it never
can be unavailable. Since now the device state leads to a decoration in
the device selector(s), always having a "connected" bubble there looks
confusing. Remove it.

Change-Id: Ia218e05367a18841e966ea8566e16ad859a09597
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-01-19 10:32:36 +00:00
hjk
3f224291e6 Debugger: Move plugin tests to extra file pair
Change-Id: I1ce7c9e9b2b680ea8f5a80a3b9556916e7d3d180
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-19 10:29:43 +00:00
hjk
d234e71643 All: More ToolChain->Toolchain renamings
And removal of one unused function declaration.

Change-Id: I594e23401d8f247d3be081ce850005574951899d
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-01-19 10:29:33 +00:00
Artem Sokolovskii
bb88c8c9be ClangFormat: Separate ClangFormat and Standard Indenter UI
The combined UI was a bit misleading for the user and cause
bunch of synchronization problems.

The synchronization between old CodeStyle settings and ClangFormat
settings was removed. Corresponding classes and functions
were also cleared.

The behavior now:
When "Indenting only" or "Full Formatting" modes are chosen then
The ClangFormat settings page is visible and the ClangFormat indenter
is used.
For "Disable" mode standard CodeStyle pages are shown and standard
indenter respectively.

Change-Id: Idb4974c68ceb16ef2e55b108043cc6f56f859840
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-01-19 10:26:09 +00:00
Jarek Kobus
2ff533b499 CppProjectUpdater: Reuse TaskTreeRunner
Change-Id: I204041d44bce386b75c43b5d6686671e04bd2b30
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-19 10:21:16 +00:00
Christian Kandeler
b34a8130bb ProjectExplorer: Show device status when displaying lists of devices
Fixes: QTCREATORBUG-20941
Change-Id: Ibc24785ae2afc174d13c22231f2c8e7e6923d64c
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2024-01-19 10:07:47 +00:00
Christian Kandeler
37d3c4ed78 CppEditor: Fix ModelManagerTest
Amends 69571427a3.

Change-Id: I07fa0acb34b8277a6790bbd529a7d39190ce846f
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-01-19 10:04:50 +00:00
Eike Ziller
2865f6eae0 Examples: Read and handle "documentation dependencies"
Some examples are defined in a Qt module (and therefore examples-
manifest), but have dependencies on other modules.

The example-manifests contain a `module` attribute for their
`instructionals` tag, and examples can contain "docdependencies" items
in their meta data, which are comma-separated lists of these module
names. Read the `module` attributes (the meta data is already
generically read) and check if the current set of examples-manifest
contains all required ones for an example. Hide it, if not.

Task-number: QTBUG-120759
Change-Id: Ib8ff80cf8a13965e57b5c4317e5d121c4127278b
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Kai Köhne <kai.koehne@qt.io>
2024-01-19 09:44:53 +00:00
The Qt Project
716c68ac5a Merge "Merge remote-tracking branch 'origin/12.0'" 2024-01-19 09:02:32 +00:00
Jarek Kobus
604ccf4e23 NavigationWidget: Use find() instead of contains() + value()
In this way we lookup just once.

Change-Id: I8eb9e98980acc3f3b7f6734b04dd4c6b06ec40e1
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-19 08:50:28 +00:00
Jarek Kobus
bd21612816 UpdateInfoPlugin: Reuse TaskTreeRunner
Change-Id: Ifc6ab7d17b2cb9569675e19e7493eacc35c8b9a5
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-19 08:50:01 +00:00
Jarek Kobus
3a252ef86c PluginInstallWizard: Reuse TaskTreeRunner
Change-Id: I66e7909d1ec0ce04ca250f4bda42bf9b2630966f
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-19 08:37:22 +00:00
Jarek Kobus
a94c4dc1fd Locator: Reuse TaskTreeRunner for running locator filters
Change-Id: I4bbbab0905a235df5601064b115edaaa73da047e
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-19 08:36:09 +00:00
Jarek Kobus
0ac4e7f55f Locator: Reuse TaskTreeRunner for filters refreshing
Change-Id: I9db6c24491ce5f972707160bf84da01fce67657b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-19 08:35:53 +00:00
Jarek Kobus
61a8128512 TaskTreeRunner: Add setup and done handlers
They might be more convenient than runner's signals.

Change-Id: Ie50afd12f8db6a7f125b1b728a59297d85a48f34
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-19 08:35:43 +00:00
Eike Ziller
4936a89f16 Merge remote-tracking branch 'origin/12.0'
Conflicts:
	src/plugins/cmakeprojectmanager/cmakebuildsystem.cpp

Change-Id: I7a2cfa35b5bc9070c66561bfba3e4b5a8e26917f
2024-01-19 09:33:04 +01:00
Christian Stenger
491b24de70 Ios: Fix qbs build
Amends 0ecab7e0d8.

Change-Id: I28c29fbe761e2d61861252e468484bc883a7575b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-19 08:16:25 +00:00