Commit Graph

86026 Commits

Author SHA1 Message Date
David Schulz
8b78eb2d22 CMake: report project issues if the CMakeKitAspect is irrelevant
This disables python kits when opening cmake projects in the target
setup page.

Change-Id: I205edd865c0eb6c499368f1d5e9f2c4b4bc8237a
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-30 08:27:16 +00:00
The Qt Project
c0a008957d Merge "Merge remote-tracking branch 'origin/12.0'" 2024-01-30 08:22:30 +00:00
Eike Ziller
30d048a256 Merge remote-tracking branch 'origin/12.0'
Conflicts:
	src/plugins/cppeditor/cppfilesettingspage.cpp
	src/plugins/haskell/haskellplugin.h

Change-Id: I880693c2e4986853b7aa600a5b7d6c09ad14634e
2024-01-30 09:19:06 +01:00
hjk
8adbb1ddab Debugger: Allow debugging of custom executables again
Amends c81efc39c.

Change-Id: I5f816371d8f08ffb127ba39891b2c5b8f7df7f20
Reviewed-by: Dominik Holland <dominik.holland@qt.io>
2024-01-30 08:16:45 +00:00
hjk
0ef72f3c6c Meson: Use setup functions for more plugin items
Change-Id: Ibbb2526d1db980389487e599ddf53e4785d97b5e
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-30 08:01:16 +00:00
hjk
9a44a543a5 Meson: Use setup functions for a few plugin items
Change-Id: I849698315cd8c03ab44317d90dd3754dcfe46146
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-30 08:00:30 +00:00
Eike Ziller
a9a5972a9f iOS: Add some autotests for devicectl error parsing
Change-Id: I641f0c86b30a11ca6321db88afbf2969b4863972
Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-30 07:56:31 +00:00
Christian Stenger
7e8aac5f3c Axivion: Take versions into account
Change-Id: I7011549f8ce7d0017f156529792e91292183560f
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-30 07:03:18 +00:00
Christian Stenger
2bc0572553 Debugger: Display length of quoted values
Reverts 6515f935d6 as this breaks
the dumper tests and moves the handling from the protocol to
the item, so this now only happens for the gui.

Change-Id: Ia15d5ead5c549585f4e90cc46d629961ea7d5974
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-01-30 07:03:07 +00:00
Orgad Shaneh
cf1a929916 CppEditor: Fix compilation without tests
Change-Id: I9a621871d9235652618fa2c295db7e39ca6118f1
Reviewed-by: hjk <hjk@qt.io>
2024-01-30 06:59:34 +00:00
hjk
8e071f6bd0 CMake: Use ActionBuilder for buildTargetContextAction
And remove now-empty CMakeProjectPluginPrivate class.

Change-Id: I2b0b28cddb84639a62f90ee1776674cc7808480f
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-29 17:19:10 +00:00
hjk
d016ef67b3 CMake: Use setup functions for more plugin items
Change-Id: I48ff764248f29ef2a8f46757cba84705983c7740
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-29 16:33:49 +00:00
hjk
a615b236e5 CMake: Use a setup function for CMakeBuildConfigurationFactory
The class itself is still used by IosCMakeBuildConfigurationFactory.

Change-Id: I9fd979fc8e24c9f032b35c1f3444c28d06f86d0a
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-29 16:29:53 +00:00
Christian Kandeler
7323c97ada RemoteLinux: Fix rsync fallback
Do not fall back to generic copy right away; try sftp first.

Change-Id: I6eb61c4644219facc81a518fb7726192575db630
Reviewed-by: hjk <hjk@qt.io>
2024-01-29 15:21:00 +00:00
hjk
ce1e565a10 Utils: Also rename parameteraction.{h,cpp} to action.{h,cpp}
Change-Id: I203909d9b2d460012b9347d507ac7a701700c48a
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-29 14:23:39 +00:00
hjk
d4635d4389 TextEditor: Use new setup pattern for markdown and json editor
And remove the now-empty plugin pimpl.

Change-Id: Ie00b747a4a41bc6efc84ea43db81a71e8364df3d
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-29 14:22:22 +00:00
Jarek Kobus
d2db92e248 LanguageClient: Avoid using QHash::keys()
Make updateEditorToolBar() a member of ClientPrivate.
Rename it to updateOpenedEditorToolBars() and operate
directly on m_openedDocument hash. In this way we avoid
2 calls to QHash::keys().

Change-Id: I0b1b9b89b20f9fdd185ea9a00d964514faeae0cd
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-01-29 14:16:42 +00:00
Jarek Kobus
02518deb7a CoPilot: Replace QMap with QHash
The key is a pointer, so use QHash.
Avoid double lookups.

Change-Id: Ib7b3039a3293a158aa4857bbf9913f7321b4ed83
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-29 14:16:27 +00:00
Jarek Kobus
820678e1a3 Various plugins: Replace QMap with QHash
The key is a pointer, so use QHash.

Change-Id: Iad633b9e599d653606d386371b71b002baac6371
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-29 14:16:17 +00:00
Jarek Kobus
b2bd69f679 Wizard: Remove unused map
Change-Id: Id38b20583349d708318d76e38c56dc25f7e8b397
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-29 14:07:52 +00:00
hjk
ec983a6462 CMake: Some code cosmetics in cmakeeditor.cpp
Mostly namespaces and 'final'.

Change-Id: Ifda9fe2af0b83b4ebb71c936a5ab6352d650ccec
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2024-01-29 13:42:40 +00:00
hjk
5646aae859 CMake: Use setup functions for a few more cmake related items
Change-Id: I7a1bbea9507d7d168584348a51d557f4a910de47
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2024-01-29 13:42:27 +00:00
hjk
cc64c84b5f CMakeProjectManager: Use setup function for CMakeToolManager
Change-Id: I66078250029f87d64b7b31aba9049a8b0b68f3a5
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-29 13:28:33 +00:00
hjk
5f90065ea9 Core: Merge ActionBuilder::context{Parameter,}Action
They are practically the same now.

Change-Id: I3bdf04388ce22830f4a84f58a36f037399684701
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-29 13:02:15 +00:00
hjk
524167a936 TextEditor: Use new setup pattern for the finders
The FindInFiles definition cannot go yet to the .cpp yet as there
are some exported functions.

Change-Id: I2d2f02ae80b560e3147f461fcbee0fa62b8085a3
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-29 13:01:39 +00:00
hjk
66b50438d8 Utils: Rename ParameterAction into Action
It became the defacto-type for action when ActionBuilder started
creating them as default.

Change-Id: I1008d60b78ea83919ce1c80a7ef828527fe9902c
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-29 13:01:29 +00:00
Leena Miettinen
fe35ee5c38 Doc: Split up Beautifying Source code
Describe the process in a how-to topic and the preferences in
a reference topic.

Task-number: QTCREATORBUG-29361
Change-Id: I9bf2b693590e0943a3bb6d5ed11dbc5a9d5cbd80
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-29 12:50:45 +00:00
Eike Ziller
fa55b29121 Core/Dialogs: Add privates and avoid inlines for exported classes
Makes it easier with ABI compatibility.

Change-Id: I6d51b7fe3425a292db8139604bb571eed5ec11ca
Reviewed-by: hjk <hjk@qt.io>
2024-01-29 12:29:45 +00:00
Eike Ziller
479f1f34ce iOS: Disable anything but running for iOS 17+ devices
We currently cannot support anything than running for devices with iOS
17 and later.

Make it possible for RunConfigurations to state that they are disabled
depending on run mode.

Change-Id: I13df4dd482f6381cda15168c38ede00d95e1d692
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-01-29 12:13:51 +00:00
Cristian Adam
76a8966739 CMakePM: Refactor CMakeLists|Cache.txt as constants
Change-Id: I7165fa1d219a0c59bc519a9af1cd194414c4311c
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2024-01-29 11:50:21 +00:00
hjk
b953735b22 Boot2Qt: Use QmlProjectManager::Constants::QML_RUNCONFIG_ID constant
... expanding to "QmlProjectManager.QmlRunConfiguration.Qml" instead
of the "QmlProjectManager.QmlRunConfiguration" literal.

This is no change for the "QmlProjectManager.QmlRunConfiguration.Qml"
case as the worker factory still checks the id with 'startsWith()'
I can't see other RunConfiguration matching that.

Change-Id: I328683b8da441683991bd586b3580a7efb985c0b
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-29 11:45:28 +00:00
hjk
a4de558e62 ScreenRecorder: Use ActionBuilder to create main action
Change-Id: Iceac6a287f2d5fc71617a67e89fcf7c59cdac31f
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2024-01-29 11:41:54 +00:00
hjk
9d63fdac64 CPaster: Remove unnecessary QAction members
They were set but never needed again.

Change-Id: I4805405c28c9635a8607487bcc6975cf179446a1
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-29 10:19:36 +00:00
hjk
544d68877c Boot2Qt: Use setup function for run worker creation
This is meant as a mechanical change, leaving intact the
"QmlProjectManager.QmlRunConfiguration" which seems to be wrong
("QmlProjectManager.QmlRunConfiguration.Qml" exists) and will
be addressed in a separate commit.

Change-Id: I0053ec66f43a2dd7d10bd21fcf3ef5e1534e7a1b
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-29 09:39:18 +00:00
hjk
5d8bf13e25 Boot2Qt: Use setup functions for two factories
Change-Id: I39fc69f5ab0b1e808631e73c0d238a8ebe55473e
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-29 09:38:59 +00:00
hjk
45a62e785a AutoTest: Use setupFunction for TestSettingsPage
Change-Id: Ib592b3fd92480a5e712cf7cd69d4b5c899a1f216
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-29 09:15:32 +00:00
Jarek Kobus
8b8e360ba8 CdbEngine: Keep multiple arg() for int arguments
Otherwise the second arg is interpreted as fieldWidth.

Change-Id: I6105386aa743bf172eaef4bafe6a350381c76ce5
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-01-29 08:44:13 +00:00
Jarek Kobus
d39f42c1f6 LanguageClient: Replace QMap with QHash
The key is a pointer, so use QHash.
Avoid double lookups.

Change-Id: Ia48109c909372b02727ce229974d721546766f50
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-01-29 08:44:00 +00:00
hjk
d373ff30d4 Conan: Use setup function for ConanInstallStep
Change-Id: I73f0555fb7310cc9d7f64d86c4a58d7075b6cc17
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-29 08:09:37 +00:00
Jarek Kobus
af0173b21f Valgrind: Keep multiple arg()
Otherwise the 2nd arg is interpreted as fieldWidth.

Amends cf2ea1b70a

Change-Id: I4ef199f1fc6bb204f603fb5cc0a813a33f3ba1a7
Reviewed-by: hjk <hjk@qt.io>
2024-01-29 07:49:06 +00:00
Jarek Kobus
11a8c55f38 Various plugins: Remove unused variables
Change-Id: Ie2e5eb38d81a7582c5715654f09f28deb4ab11c5
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-29 07:44:39 +00:00
Jarek Kobus
1ad61f8da3 Axivion: Extract fetching table into the reusable recipe
Get rid of public fetchIssueTableLayout() method.
Introduce tableInfoRecipe() which takes a handler as an arg.
This decouples the plugin from AxivionOutputPane's API.

Change-Id: Iae3ce83e132e0769b45ed3db911bd1046cc7bcb8
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-01-29 07:35:09 +00:00
Jarek Kobus
5c1ee4021a Axivion: Extract fetching issues into the reusable recipe
Get rid of public fetchIssues() method.
Introduce issueTableRecipe() which takes a handler as an arg.
This decouples the plugin from AxivionOutputPane's API.

Change-Id: I4a4e2fd14dfd4eed2d28648a227a1ed3a5fe90f3
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-01-29 07:35:02 +00:00
Jarek Kobus
2759266e84 Axivion: Make IssuesWidget occupy more space
Change-Id: I65397b4c0ff280c3bfe436d8aa2f42dc86fb301e
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-01-29 07:25:52 +00:00
hjk
675e8a4757 TextEditor: Use new setup pattern for PlainTextEditorFactory
Change-Id: Iad3b8574a51db3baf6db74353e58968a2f6a4315
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-29 06:41:41 +00:00
hjk
d81fb53b74 TextEditor: Use new setup pattern for TextEditorSettings class
Change-Id: I8980f21a3ea156d45ab68bad66b94fbc5bbad641
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-01-29 06:40:10 +00:00
Christian Stenger
c734012298 Axivion: Implement basic fetch more functionality
Scrolling to the bottom of the displayed issues should now
try to fetch more issues.

Change-Id: Ic01cdcb7e96d2d0be2f51096a70fbb2299a6722d
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-29 06:21:12 +00:00
hjk
0d4b3b5196 Utils: Add a FilePath::isResourceFile function
Change-Id: I281e91bc24f5c32a5d64c31e73b7fc2f31cbade2
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2024-01-26 16:07:38 +00:00
hjk
bb7a50e16e Utils: Promote a local conversion function to FilePath::fromUrl()
Change-Id: I748cceb50084a29b971f31a8bd2ad7159738d7fd
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2024-01-26 16:07:31 +00:00
Alessandro Portale
f1787812e3 Core: Introduce WelcomePageHelpers::drawCardBackground
Pulled out of the ExtensionManager. It will also be used by
the Welcomescreen pages.

Change-Id: Ic5c67759e7f3af6a3b51968b7ae072c7058109b3
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2024-01-26 15:21:14 +00:00