Commit Graph

57214 Commits

Author SHA1 Message Date
Orgad Shaneh
70b466b7d9 Debugger: Split expressions and locals and anchor Registers to Locals
The Locals view is the first tab, and the Expressions view is not visible
at all. If you grab a variable to the Locals view, it just "disappears",
and you need to know where to look in order to find it.

Return to the previous layout, when Expressions and Locals were both
visible in the same view.

Change-Id: I775fe88beb921c61c048ba7106d05ae08b8fe026
Reviewed-by: hjk <hjk@qt.io>
2018-11-07 14:52:15 +00:00
Eike Ziller
0b940f4e79 Debugger: Fix conflict of "Start and Break on Main" and "Step Over"
After the very first start of a debugger they were both enabled.
Make sure that the state at startup is the same as the state when
switching to "Debugger Preset" later, to make sure that the context is
correctly updated in EngineManagerPrivate::activateEngineItem after
first start of a debugger.

Amends 1c17ed6db8

Change-Id: Ib330f06c0f89853b61dc99db05ebe42007ffc48b
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: hjk <hjk@qt.io>
2018-11-07 14:38:25 +00:00
Robert Loehning
cc3591438b Update German translation
Change-Id: I867cea7f79f0fe0d4de679dd196426eb6a78f552
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
2018-11-07 14:26:00 +00:00
Leena Miettinen
645e26a338 Doc: Update language server info
Change-Id: Ie54e3cf4ea28ca62de7d86a891f96685e825b524
Reviewed-by: David Schulz <david.schulz@qt.io>
2018-11-07 14:00:56 +00:00
hjk
8feb11e102 Debugger: Silence breakpoint state transition warning
... for "alien" breakpoint that legitimately jump from New to Inserted.

Change-Id: Idb8b540a119f6dbd04d86b8ce3f15c2599d4b60c
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2018-11-07 13:43:40 +00:00
Ivan Donchevskii
0fabde31ab CompilationDatabase: Speed up parsing project file
Avoid expensive indexOf and check for the exactly same flags
before applying the full filter.

Change-Id: I6936b2022a2b439aad7bf0a65280c3db16d00c34
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2018-11-07 12:32:34 +00:00
hjk
9b324aaccf Debugger: Fix version parsing for LLDB
Ignore trailing newlines.

(cherry picked from commit a69ae41fbe)
Change-Id: I4d1a64f774ea633d2bcb683e7c834c8d2e814976
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-11-07 07:48:33 +00:00
hjk
a69ae41fbe Debugger: Fix version parsing for LLDB
Ignore trailing newlines.

Change-Id: I2d4a4ce67abd016fc0ce669fe5f51ba60885ccef
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2018-11-07 06:50:53 +00:00
Christian Kandeler
c7b30a2eb2 SSH: Remove nonsensical check
There is no minimum requirement for the per-channel maximum packet size.

Change-Id: Iced6e3bb1b77f7642d39d4a113ab4236af6b247b
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2018-11-06 16:22:04 +00:00
Orgad Shaneh
2e10f5b828 BinEditor: Support copying of hex value as a number
Useful when copying a pointer value from memory editor.

Change-Id: I8930e4ee1c7fd1df998e37ed65e4dff5dfa2ed2e
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2018-11-06 15:28:32 +00:00
Christian Kandeler
711ab6b749 SSH: Re-format the qbs project file
The "several files per line" style is no longer recommended, as
it's incompatible with the style used by the "Add File" functionality
offered by the qbs API (and used by Qt Creator).

Change-Id: I7333f957988986a0e63259a548b4cf5c1d7f1b59
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2018-11-06 14:05:11 +00:00
Andre Hartmann
077953b923 Git: Forbid local renaming for date column
Renaming the date doesn't make sense.

Amends a82dd10518

Change-Id: I2eea83572e3bf69633a6f154a3648b34cf93707f
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2018-11-06 11:52:36 +00:00
Marco Bubke
f644ea0a01 ClangPchManager: Add BuildDependenciesProvider
It is still unfinished but I want to add other changes first.

Change-Id: Ife7ac56576f85d800633ea1e8f1c3f4f16486d5f
Task-number: QTCREATORBUG-21377
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-11-06 11:52:11 +00:00
Christian Stenger
ace6708b88 Debugger: Fix display of null references
Fixes: QTCREATORBUG-21210
Change-Id: I529f38aad9b93707e09ffdd28885e46c2cfd158c
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2018-11-06 11:26:05 +00:00
Thomas Hartmann
687d24b290 QmlDesigner: Add support for per property record buttons
With this patch the per property record buttons are also
supported in the property editor and form editor.

Change-Id: I9bf122f473c9bd10dc7738a6610b9b41d4190a4a
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2018-11-06 11:23:45 +00:00
Thomas Hartmann
8afa245a32 QmlDesigner: Refactor record mechanism for timeline
If a timeline is recording or not is now stored in an auxiliary data.

Change-Id: Iad5cd3fa796b47f6990ddc2929ee843f129b669c
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2018-11-06 11:23:37 +00:00
Thomas Hartmann
0e2072cadd QmlDesigner: Add some functions to QmlTimeline
Change-Id: Ied2c097bd4bfbeb703d6c4a7f6553144d658b539
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2018-11-06 11:23:26 +00:00
Nikolai Kosjar
24543f7839 CodeAssist: Refine perfect match criteria
The perfect match is used to determine whether to show a completion list
window or not. Consider:

  int foo;
  int foobar;

  void f()
  {
    // Type "foo"
    // ==> Previously, the completion window did not even show up as
    //     "foo" was regarded a perfect match. This was annoying if you
    //     have actually intended to complete "foobar".
    // ==> Now, the completion window does show up and shows both items.
    //     The perfect match now considers other items for prefixes.
    //     Without "foobar", the behavior is as before - no window pop
    //     ups.
  }

Fixes: QTCREATORBUG-20857
Change-Id: Ifdafcf9304a7cb36d646f776755063a854a79a90
Reviewed-by: David Schulz <david.schulz@qt.io>
2018-11-06 10:01:53 +00:00
Nikolai Kosjar
44b71f7a16 CodeAssist: Avoid pointless completion request after accepting item
Previously, accepting an item from the completion pop-up triggered
another completion request, but the result of that request was never
displayed since the inserted text was a perfect match.

Now, trigger another completion request only if the inserted text
matches the activation characters.

Change-Id: Ic8ed4139efb10aadc8d41105634fcc856e0a15be
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
2018-11-06 10:01:25 +00:00
Orgad Shaneh
7cc1dc7d1a ProjectExplorer: Let the user override parallel jobs in arguments
Change-Id: I2cfe49686d3430cdd2087842936c3bf0f685d345
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-11-06 09:54:57 +00:00
Christian Stenger
3056105c66 AutoTest: Fix displaying XML content
CDATA sections that have line breaks at their line ends
within a multiline CDATA section should get handled
that these (inner) line breaks do not get lost.
This patch fixes displaying failed Qt tests when using
the XML output.

Change-Id: I3aa7100836613372ac5b2b409c5cfacfb34209ba
Reviewed-by: David Schulz <david.schulz@qt.io>
2018-11-06 09:40:18 +00:00
Christian Stenger
2cf2cebfc9 Avoid enabling all message types by default
Passing no QtMsgType parameter ends up in enabling all
message types by default.
Follow the common pattern of only enabling the warnings
by default.

Change-Id: Ic7ec0420089c95f716a86feb9791d9cb13f4dd90
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-11-06 09:40:05 +00:00
Eike Ziller
1473bc5891 Merge remote-tracking branch 'origin/4.8'
Conflicts:
	src/plugins/debugger/debuggermainwindow.cpp
	src/plugins/qbsprojectmanager/qbsbuildstep.cpp
	src/plugins/winrt/winrtdevicefactory.cpp
	tests/unit/unittest/gtest-creator-printing.cpp
	tests/unit/unittest/gtest-creator-printing.h
	tests/unit/unittest/unittest.pro

Change-Id: Ie9b80b87a8a4fa81baf72a2daa7919b21371c15e
2018-11-06 09:20:00 +01:00
David Schulz
e18cbad285 LSP: Inform user about an unexpected server finish without restart attempt
A message is already printed after an unexpected finish with restart attempt.
Without this last message it looks like Qt Creator still tries to restart
the server.

Change-Id: I47dd3e768d061a7d039ee3f125368c6e166ebf81
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2018-11-06 07:58:13 +00:00
hjk
2556d4b44b Debugger: Implement disabling/enabling subbreakpoints with LLDB
Change-Id: Iaad8716b98d632e5a933b7f5b26549c7cb885ea7
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2018-11-06 07:37:15 +00:00
Alessandro Portale
9d296cf1f1 BareMetal: Modernize
modernize-use-auto
modernize-use-nullptr
modernize-use-override
modernize-use-equals-default
modernize-use-using

Change-Id: Ia4e7f4e75a49357ca1b225f25af68a0480fba748
Reviewed-by: hjk <hjk@qt.io>
2018-11-06 05:50:35 +00:00
Orgad Shaneh
7d888d58fc Git: Add accelerators to branches context-menu
Change-Id: Ife79519fbd5b006838b09a3d45bd44461aec8d59
Reviewed-by: André Hartmann <aha_1980@gmx.de>
2018-11-05 19:55:11 +00:00
Orgad Shaneh
3e42841141 ProjectExplorer: Remove default value from userJobCount
It is set to QThread::idealThreadCount() by the application.

Change-Id: I63f5132513d94f184c34d1c9611ca882a5028995
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-11-05 19:54:58 +00:00
Eike Ziller
183cfb0772 Make the currently visible debugger UI define the behavior of F5
That fixes the behavior of F5 for the debuggers which were not started
directly with a run configuration (attach, debug external application).
It has the disadvantage that it is only possible to start another
application in the debugger after switching to the "Debugger Preset",
even after you switch the startup project.

Fixes: QTCREATORBUG-21261
Change-Id: Id4d4c81920939af2b34b462d87c815719bed6aff
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2018-11-05 17:44:04 +00:00
Ivan Donchevskii
06162c1aa5 CompilationDatabase: Use QJsonDocument for separate objects
It is pretty easy to split objects without QJsonDocument help.

Due to the QJsonObject data size restriction use it
only for the already split objects inside the database.

Change-Id: Ice7c7407ad00aaac151a767f4d943fdcecf6a6b8
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2018-11-05 15:51:28 +00:00
Ivan Donchevskii
7f67e987ea CompilationDatabase: Add folders to Project view
Change-Id: I4cd480535c203aa923b27596ea4ca74f83c12a9e
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2018-11-05 15:51:12 +00:00
hjk
595824d17b Debugger: Remove unused DebuggerEngine::handleCommand declaration
Change-Id: I0af285fa6284c31cbc5fc8d91ec4ab9a61aade5c
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2018-11-05 15:48:32 +00:00
hjk
e24335e8a6 Debugger: use requested file and line for pending breakpoints
Otherwise markers will not be shown. This fixes the visual aspect of
the referenced tasks. Choosing a specific engine if more than one is
running is still not possible.

Task-number: QTCREATORBUG-21361
Task-number: QTCREATORBUG-21330
Change-Id: I5e31adf43ca8a57add83166b307434122498f1e6
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
2018-11-05 15:46:03 +00:00
Ivan Donchevskii
6dc2da9413 ProjectExplorer: Parse macros when clang-cl exits with non-zero code
clang-cl still provides the list of macros even if it reports
some option being not supported. Try to parse the output
even in such cases.

Change-Id: I4fa070c7c465166fdf70c03944b2713478acba13
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2018-11-05 12:55:39 +00:00
Alessandro Portale
4979c384ce ClearCase: Modernize
modernize-use-using
Turn a parameter of ClearCaseSync::updateTotalFilesCount into a &.

Change-Id: I1ee95b64374c77abb228e586544c8675ec74433a
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2018-11-05 10:12:42 +00:00
Christian Stenger
c355379a01 Tests: Fix disassembler auto test
Output has changed with 06a78b6264.

Change-Id: I32d401bf1111fe037b04873ff223cb916b4f886e
Reviewed-by: hjk <hjk@qt.io>
2018-11-05 10:07:59 +00:00
Alessandro Portale
d66f459011 LanguageClient: Improve Options icon
Fits a bit better to the other icons.

Change-Id: Ie73740a858a0683acb18ecf30d01fb816d928db3
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
2018-11-05 10:07:07 +00:00
Christian Stenger
88a6276551 LSP: Avoid crash in shutdown
Having a corrupt language server might end up in a double
delete when closing the client.

Change-Id: I23e02d666d6c070a9f4b33605782fe875c5cabe6
Reviewed-by: David Schulz <david.schulz@qt.io>
2018-11-05 09:33:48 +00:00
Christian Stenger
02760eafc8 LSP: Fix auto tests for Linux and macOS
Some URI/URL functionality (especially file protocol)
is based on the underlying file system and operating
system respectively.

Change-Id: I6a0956bbef292ff964aec581c2555c54d6d0dbe3
Reviewed-by: David Schulz <david.schulz@qt.io>
2018-11-05 09:33:30 +00:00
David Schulz
52cfa8b6f8 LSP: forcefully close language server after 3 seconds on shutdown
When closing Qt Creator a message is send to the server requesting to
shutdown. Waiting an undefined amount of time for the response could
result in a never closing Qt Creator.

Change-Id: If09a32d34c546ae4702669d65e4921873e5658ea
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2018-11-05 08:00:44 +00:00
Orgad Shaneh
a82dd10518 Git: Enable renaming local branches by direct editing
Change-Id: I7edab94d949a6e48642f280af52fd156c803cafb
Reviewed-by: André Hartmann <aha_1980@gmx.de>
2018-11-04 20:37:44 +00:00
Alessandro Portale
adf5305af6 AutotoolsProjectManager: Modernize
modernize-use-nullptr
modernize-use-override
modernize-use-auto

Change-Id: I7abab567a6dab1bde93c520aa8746380ae24fda8
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2018-11-04 18:24:31 +00:00
Vikas Pachdha
1f1149bb58 Android: Update NDK documentation
Qt Creator now uses Clang tool chain and latest NDK can be used
to build the applications now so no need to recommend version 10e

MinGW dependency is not required anymore as make is also used
from the NDK

Task-number: QTCREATORBUG-11846
Change-Id: I535aeebc52fc67025a73b37bee4079ef7704cd7d
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2018-11-02 15:45:28 +00:00
Vikas Pachdha
de97b8cf3e Android: Auto detect clang toolchains
Remove GCC auto detection
Make Clang toochain default for Android
Remove auto detected toolchains from old NDK

Task-number: QTCREATORBUG-11846
Change-Id: I618e6f8eda4f24f498260b8de778ef543311acd1
Reviewed-by: BogDan Vatra <bogdan@kdab.com>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2018-11-02 15:10:50 +00:00
Vikas Pachdha
dabe72b7bb Android: Remove missing Qt version warning
Task-number: QTCREATORBUG-21421
Change-Id: I1442c574e6d9bcd7e407e07a6ce688ddf45e86f3
Reviewed-by: BogDan Vatra <bogdan@kdab.com>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2018-11-02 15:10:32 +00:00
Thomas Hartmann
c95b21ca17 QmlDesigner: Add some functions to QmlTimelineKeyframeGroup
Also adding some QTC_ASSERTS.

Change-Id: I7dcdac517e850b9b0c7ec9ba7a76effc31766ad9
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2018-11-02 14:44:54 +00:00
Thomas Hartmann
406cb164f9 QmlDesigner: Add const
Since ModelNodes are usually passed per const &,
member functions should be const.

Change-Id: I28fb015ab70978ddc10993585f9c73c3b962aa83
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2018-11-02 14:44:48 +00:00
Ivan Donchevskii
3c3b75cef1 CompilationDatabase: Fix command line parsing
Handle cased when -x{kind} is one option.
Skip -o output files.

Task-number: QTCREATORBUG-18402
Change-Id: Id8a8612bed2db2b35f17b0968a4ff529e7a66194
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2018-11-02 14:12:34 +00:00
Nikolai Kosjar
e49e32d2eb C++: Fix Token::spell()
In

  commit 86aab16ea4
  TextEditor: Highlight punctuators as Text

the order of tokens was changed, but the corresponding "spelling table"
token_names was not adapted. As a result, e.g. Token::spell() returned
"##" for the T_PLUS token.

Fixes

  FAIL!  : tst_Semantic::lambda_2() Compared strings are not the same
  FAIL!  : tst_Semantic::enum_constantValue4() Compared strings are not the same
  FAIL!  : tst_Semantic::enum_constantValueNegative() Compared strings are not the same
  FAIL!  : tst_Semantic::enum_constantValueNegative() '!expectedConstantValue' returned FALSE. ()
  FAIL!  : tst_Semantic::enum_constantValueNegative() '!expectedConstantValue' returned FALSE. ()
  FAIL!  : tst_Semantic::enum_constantValueNegative() '!expectedConstantValue' returned FALSE. ()

Change-Id: If4c676bdb963f53fbc57f7d92f3d68341dd51eda
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-11-02 14:12:15 +00:00
Thomas Hartmann
6e7ecdb4f1 QmlDesigner: Ignore certain auxiliary data names when saving
Properties with the postfix '@internal' are not stored in the
QML file. Therefore they are not persistent.

Change-Id: I1f726c029f9db8c00bc85dc11c276c098e9a2a3a
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2018-11-02 13:56:39 +00:00