+ fix display of install root with variables in equivalent command line.
Change-Id: I9f8ab6dba80afddd0ee5116947c11752ded8129f
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
... of the build step widget. By "special properties" we mean those for
which a dedicated UI element exists.
Fixes: QTCREATORBUG-21363
Change-Id: I8b136798340c1a2cdc178451247a9f1f77d91dd7
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
CXXMethod and CXXConstructor may have different priorities
depending ony their origin and attributes. To keep them together
in the sorted list we adapt their priorities to have the same
value if their names match.
To continue keeping ClassCompletion before ConstructorCompletion
change the order of the completion kinds for the sort purposes.
Change-Id: I36efe5d5dbaa77d604a54b1dafe07d67f44db4c9
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
In case isRoot() returns false, but cleanPath fails to find the parent
directory, return an empty string.
For example: QDir::cleanPath("D:/..") returns "D:/.." on Windows.
I'm not aware of any concrete case when this can happen, but let's be
cautious.
Change-Id: I0f4af5f5c11bb768d99d90290a4a1a6a1bda7c27
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
The debugger engine had actions for starting an engine, that were
created but never actually used.
Change-Id: Iaae534587514d98611c53dc649ddb537ed7f7053
Reviewed-by: hjk <hjk@qt.io>
Without the full name, moc will generate invalid code. This will happen
for any base class whose name exactly matches the namespace it is in,
because in
struct A : public B::B
inside class A, B is the injected name of the parent class, not the
namespace, which in turn means B::B is the constructor.
Change-Id: If7e743cf8476463880ccfffd155f3f51aa29e8b9
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
The name is better and we avoid problems if the default was
saved by wrong old code which is fixed in the current code.
(The fix does not save the path if it is the default path)
Change-Id: Ifd1d4fc7931fed976de12e3e256915458ffc762a
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
The file was edited manually, as the C++ file no longer seems to have
the duplication, and lupdate produced too much noise.
Change-Id: I96f186bee16fcd39711e6beaa9c375d5ce3d26f0
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@qt.io>
Opening a document (without typing in it), switching away and back to it
resulted in running UpdateDocumentJobs for that document for nothing.
As for documents we are going to reset, simply set opened documents
initially dirty.
Change-Id: I8edc2d1fb8f6f92950b4e2067f60609176bd5b26
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
This amends the obviously wrong
de975aca4f, which did not honored nameless
enum specifiers.
This fixes e.g. "Find Usages" for declarations following "enum {};".
Change-Id: Id98c074156f576b9a63e6c25dab38721ca34e496
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
Since we now ship clang 7 binaries, let's open the docs accordingly in
the browser.
Change-Id: Idfd8967fbbadfee87df6f7e721e1ee13ea15de87
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
... if we have to cut off the output because the maximum amount of
characters was reached.
Change-Id: I764c0a3ac555f30d5bce5f3a1b709eec5d2ae94b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Useful e.g. for Boot2Qt::PushToDeviceStep
Change-Id: I41f4a52ee7d3b0f18df8b2249232cfd0e4445ced
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Default to false, remove all no-op reimplementations.
And rename the getter to isImmutable according to the rules.
Change-Id: I8cce79d88fb59badfa1cffcf30a46f7ff3b09e8b
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Since
commit d61d29cf16
Introduce a basic client for the language server protocol
extra proprosals were requested in the fragile case on a change
notification, e.g. for function signature completion. Restrict this to
the language client proposal, as it was actually intended.
The language client does not support prefixes, so introduce this concept
for deciding whether to request new proposals or not.
Done-with: David Schulz
Change-Id: Ibc1ad82dbeeea93b85f279c59b8c7289fe6ec726
Reviewed-by: David Schulz <david.schulz@qt.io>
The extra inheritance level is not needed (and used nowhere else), and
all special default arguments can be determined from the kind of build list.
Change-Id: I5ab9987d7b1fd8e5999b7c4c8796c2c24db03821
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
...and remove pointless white space.
Change-Id: I2b737058ad6c598b8d8034a7a05c29a6d629dbac
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Word order might be different in other languages
Change-Id: If0f02ab768529887904a4cbed379d3061b9b659a
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
History completer has been used now in various areas
and storing 30 items for each of them inside the can
grow the settings quite a lot.
Limit the default to a sensible value - if one of the
history completer needs a higher maximum this can be
raised from the using code.
Change-Id: I5b0bdaa74c1be29f981593f840d5605b75bd17c5
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Currently we track connection of devices in the iOS plugin via USB,
using the USB serial number as a device identifier (iosdevice.h/cpp).
On the other side, iostool uses the MobileDevice framework to identify
iOS devices (iosdevicemanager.h/cpp).
The assumption that the two identifiers are the same seems to be no
longer true with the iPhone XS devices. These have a device identifier
that contains a dash that is not present in the USB serial number.
As a hotfix, just remove any dashes from the identifier on the iostool
side because we only use it for the lookup deviceId -> AMDeviceRef
anyhow.
The longer term fix should be to use MobileDevice framework for the
connection tracking of devices on the iOS plugin side as well, instead
on relying on questionable assumptions.
Change-Id: Iac3115a1c3f43a4f9e159aaa4ded1c671c55d888
Fixes: QTCREATORBUG-21291
Reviewed-by: Jason Hihn <jhihn@gmx.com>
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
We claimed to support the diffie-hellman-group14-sha1 protocol, but
forgot to actually handle it.
Change-Id: I3193997d7270328700486a15a6281ebf8528ed56
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
We use "Builtin" and "Clang" as prefixes, not suffixes.
Change-Id: I6926aeb8f005176ef420c4421c257e3df61ee0b7
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
We want to delay updating the crumble path, but we may not keep and pass
around the QModelIndex, since that can become invalid.
Change-Id: Id0c1ffb046dda1fb3bc09801fd1952787f9919fa
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
