There is no need to reset a reader when e.g. the build directory changes
when the server-mode reader is *not* used. So the one case where having
separate reparse-options for the case where the reader changes and the
case where it stays the same is bogus.
So unify the flags into one set and simplify the code accordingly.
Change-Id: I9bcfcc6333d574d49513ef1256a9a8597bda4ec7
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This combines two of the previous three paths to create run workers,
and refers to RunConfigurations by id, not by type where possible
to decrease coupling between the classes.
Only allow "type of run configuration" and "type of device"
as the only possible kind of restriction and require a uniform
RunWorker constructor signature.
Adapt user code to fit that pattern.
Change-Id: I5a6d49c9a144785fd0235d7586f244b56f67b366
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Add more logging of cmake parsing flags as cmake runs are requested
in the plugin.
Change-Id: I5231bd29dfeb6521218dc28c26a5b658ccb4059b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Xcode 11 changes the output of simctl slightly. At some point it
introduced a bool "isAvailable" in addition to the string
"availability". Now the latter has been removed.
To avoid listing all devices as available, we need to adapt our simctl
output parsing.
This already takes effect when installing Xcode 11 Beta, even when not
actually using it, since all Xcode versions share the simulator
infrastructure.
Fixes: QTCREATORBUG-22757
Change-Id: I1ef416f6c544db53d9ee99ccc3b0a2e97dfcc870
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
add_qtc_plugin now takes a flag "INTERNAL_ONLY". These internal plugins
will not show up in the project configuration nor in the feature summary.
This flag is used by the tests that build plugins.
Change-Id: I1912dd62221b2624ed7326df381fbbceccefbdac
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Move special CMake environment modification to CMakeBuildConfiguration.
Change-Id: I27f886db48d8c036f2f77f5ae8f239b405cb5721
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Use a single RunWorkerFactory for all cases.
Change-Id: I41d39d330ed69082d75ea891b11247eab01a5d19
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
These changes are required for the new Binding Editor
Change-Id: Ic1e833819c69831aa1a930ab668a644ae4ccdd6f
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Provide all wizards for Qt-based projects with the ability to set up a
skeleton .ts file and add it to the generated project.
Task-number: QTCREATORBUG-7453
Change-Id: I4dfb34c0101062edd0209173f83737e69063e27a
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Add into the text editor toolbar a combo box which allows to change
the line endings for an open document.
The supported line endings are LF and CRLF.
Change-Id: I029ba7867e0087b162edba7aba1bd1d1e966fd69
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
It is used in some other external qmldesigner plugin and
these are built against current dev packages, which
are not contain this cpp file.
Different solution would be to add:
r"^share/qtcreator/qml/qmlpuppet/types/enumeration.cpp$",
to scripts/createDevPackage.py which feels not that clean.
Change-Id: Ia1fb5c02f457d98474218689ebf6483706265dde
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
The annotation block on the bottom aggregated empty lines.
Task-number: QDS-377
Change-Id: I29806ce224717348b50258850bdc4a7bc6140eb8
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
... by two accessors to the only used field. General idea here
is to make the presence of a RunConfiguration in a RunControl
less prominent to be able to remove it at some time completely,
as the configuration's data might change while the control is
running.
Change-Id: I752540fadd135d6904fc9bf4e3506be074b0c003
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Use a "Add build library search path to (DY)LD_LIBARY_PATH" aspect
in all cases.
This was missing for CMake, and still not functional there.
Change-Id: I932bd712c7035af47cf0d60d8f9e10b8ed6608d5
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Use a QtSupport::QtOutputFormatter unconditionally.
CMake previously only added one when there was a Qt version selected
in the kit at RunConfiguration construction time, which is an odd
moment for such a decision.
Arguably, the adding of output formatters should not be done
unconditionally either, but deferred to RunControl runtime
in principle. But that'd be an indpendent global change.
Change-Id: I8365ccf194a896d4cba5d9148cc0b21d83de2f3f
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Create a DesktopRunConfiguration base class for QmakeDesktop/Qbs/CMake
and move all of the code there. Unify in obvious cases.
Change-Id: Ib2439fe6a636a4a79e849af49cd74aeacf76e747
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
First step, move {DesktopQt,Qbs,CMake}RunConfiguration{,Factory}
into the same new files.
This only moves down to QtSupport, not ProjectExplorer, as there
are in all three cases direct dependencies on QtSupport. Long term
I would expect them to move further down.
Change-Id: Ib16b19df7f3f642ed7f7db89a1f6904601d976ba
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
The QTest failure output was modeled after the compiler error
pattern, which contains file name and line number to point to
the precise error position.
Unfortunately, some compilers (MSVC) separate the line number
from the file name with "(line)", while others use ":line".
Let's handle both when parsing the application or test output,
as it was before 9a0ef8ac64, which explicitly separated both
parts in the regexp pattern.
This amends commit 9a0ef8ac64
Fixes: QTCREATORBUG-22800
Change-Id: I58154111612bbb452af19b34f7217afc6dd098df
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Samuel Gaist <samuel.gaist@idiap.ch>
This is now a global option in the constants.
Change-Id: I29c5a7bc78ca1256f4d4cb3ff3319498143d34be
Reviewed-by: Brook Cronin <brook.cronin@qt.io>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
