In order to not overwrite errors reported by clangd lower the priority
of clang tool marks if they only contain a warning.
Change-Id: Ida1c39ab11aaeb0c70f674c53762fa2707bec766
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Also, trigger build button re-check the hard way
This should not really be necessary, but the code paths on the
core side are still quite twisted. The extra notification here
is harmless in price, and removes the showstopper of not getting
a buildbutton.
Change-Id: If4bec892b4ebea533a95033629df60fa564985f3
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
... and other special toolchains not in PATH.
Amends cacc4aeede.
Change-Id: I300f7d719c9e101c24e3750dd7afd54dd338b58d
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
FilePath::searchInDirectories handles absolute paths on devices
better unlike Environment::searchInPath() which requires
a QString argument.
Previously the device:// part was dropped when trying to run
remote tests.
Fixes: QTCREATORBUG-29183
Change-Id: Idd04cdb8798d04abf88ab6cb4b68eb73d890a482
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
error: operands to '?:' have different types 'QStringBuilder<const QString&, QString>' and 'QStringBuilder<QString, QString>'
Caused by af8f9a2a6e3dbc8.
Change-Id: Ia3dfca2cb5f1cb1855f25d178f63898eb6745c46
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This is not a proper fix but prevents a crash and is otherwise
harmless.
Some tree traversal seems to be able to hit non-leaf KitNodes
that don't have m_kit set.
Change-Id: I4328069ba9b82bb66dfa2c1e0d148a717d594a4b
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Codesigning is done implicitly when using e.g. build.py
but sometimes doing it explicitly is convenient.
Add a main() to common.py and add arguments for triggering
codesigning:
python3 common.py codesign -s identity app_bundle
Change-Id: I8b0f766cfae0ea9d8173f331792a14964993d705
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
They are meant to be used from subclasses only.
For the private virtual TaskInterface::start() -
it's meant to be implemented from subclasses only,
but not to be called from them.
Change-Id: I526c40766c204c868b4b3c857a382b2b61bbadd0
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
Add some crude hack to make QC work correctly when started from
Squish.
Squish explicitly sets DYLD_* paths but preserves the original
content in separate variables.
The modification is necessary from Squish's side to be able to
hook into QC, but these modifications interfere e.g. when
executing qmake from a different Qt version.
Use the preserved values and set them internally if needed to
get a corrected run environment.
Change-Id: I2c1c8aa79ad37463e0b974ec3ce18ff32d8e12a9
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
It's only used as a return value from group's or task's
setup handler. It instructs the running task tree on
how to proceed further.
It addresses the 21th point in the bugreport below.
Task-number: QTCREATORBUG-28741
Change-Id: I25802c76b9e7bc044c6a38197935798d2da9ad02
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
Make non-Continue TaskAction returned by group's start
handler take precedence over group's workflow policy.
Call the group's done handler when group's setup returns
StopWithDone and the workflow policy is FinishAddAndError.
Call the group's error handler when group's setup returns
StopWithError and the workflow policy is FinishAddAndDone.
Add tests for these cases.
Change-Id: I98210a5d522daabc0986200e65b25986a8c0c440
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Various qml-related issues end up in the issues view since recently.
This change parses the output a bit more and makes the issues
"clickable".
Fixes: QTCREATORBUG-27762
Change-Id: Id6d2a0db8c49336125428488b75e96677f783342
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Currently it can happen that some qml files will not be picked in the
CodeModel Snapshot when the Semantic Checks are performed resulting in
wrong errors in the code editor QTCREATORBUG-29269
Triggering QmlJS ResetModel fix the errors.
This change will make triggering the Reset automatic.
Fixes: QTCREATORBUG-29155
Fixes: QTCREATORBUG-26655
Change-Id: I8a7fb4d3bca336fde9029fe3e7fb54e9281c44f4
Reviewed-by: Semih Yavuz <semih.yavuz@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
The check boxes are now combo boxes with several options.
Task-number: QTCREATORBUG-28996
Change-Id: Ib3ba3abb5c307b4fecffd267084bb2bd4057add9
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
It's a bit modified Utils::ProgressIndicator class,
used e.g. in tasking demo.
The Spinner is a QObject based class, which may be
attached to any widget instance.
Change-Id: I95fba52fe67e7eb7ee2ff3549847ce0ad97991d4
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Especially needed for templated boost tests to avoid
handling angle brackets as redirection.
Change-Id: If8c4ec87c542b6e5ba750d38e00fd6bcf0d3d952
Reviewed-by: David Schulz <david.schulz@qt.io>
Similar to what has been done for boost test - there is special
handling when the test applications process exits.
This was no more executed since moving over to use the task tree.
Change-Id: I982b7e4dfe6de4bbbe75c8d3ec0f62d0c3037f4a
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Previously ensureWritableDirectory would return true even if the
directory existed but was not writable. This patch fixes that.
Change-Id: I3c97ecb22eae7d77bf1d44b13b22d81ba2529062
Reviewed-by: hjk <hjk@qt.io>
The "Stage for installation" option in the CMake build step, which is
introduced with Qt Creator 11, relies on the presence of an "install"
CMake target.
The build systems of Qt for Android and Qt for iOS do not create an
"install" CMake target. Therefore, a pre-selected "Stage for
installation" option in the CMake build step would cause a build
failure.
This change deselects the option if the kit's run device is of type
Android or iOS.
Fixes: QTCREATORBUG-29293
Change-Id: I9755dea1564fbc2696f8bdd416f637c5b28e3761
Reviewed-by: hjk <hjk@qt.io>
Small overhaul of the layout and replace the former
text-only placeholder.
Change-Id: I0cee393f6aa7449b10b07f3daffa37f0b697d0af
Reviewed-by: David Schulz <david.schulz@qt.io>
..and finetune the layout of the issues count panel.
Change-Id: Id8efdb7047fadc999d3fd4c2736600d135d7b224
Reviewed-by: David Schulz <david.schulz@qt.io>
...especially for the case where the test output is suppressed.
Change-Id: I7294af9e941d800b8aae65f7c2c6f898f2ac4e46
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Moves macro expansion before assembling the command line
to correctly quote the resulting arguments on windows.
Change-Id: I62eded9376977ec6095e8648296cd2af53eb8e82
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
ClientPrivate::showMessageBox did not create new buttons for
each possible action.
Clicking "Close" would result in a crash as the box had
WA_DeleteOnClose set and we tried to call box->clickedButton()
after exec().
Fixes: QTCREATORBUG-29253
Change-Id: Icc5fff99686fbef928b8ef14449de646ff773b17
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
For builds on the local host, use the Qt Creator temporary directory as
the default "staging" directory. This is a "nicer" directory on Windows
and is also cleared automatically (at Qt Creator shutdown), which is not
true for "/tmp".
Amends 4753b658bb
Change-Id: Ia6dc0d76fb2d97eb7ec931981df057ec83553e69
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
We need to escape all regex relevant characters before using the build
directory as part of a regex.
Amends fc236d4534
Change-Id: Idfb9e5a1733e153943781888976de97aac4fb8cb
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Robert Löhning <robert.loehning@qt.io>
