Otherwise we may end up in crashes deep inside Qt code on Windows.
Fixes: QTCREATORBUG-26112
Change-Id: Iabdd544271a99b680adad3abb84341db2bf2c1f3
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Add a table that summarizes the buttons in the Alignment section
in Properties.
Task-number: QDS-4561
Change-Id: Ieeae56206cc5126eb519297fbe4d0e9043775a7d
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Brook Cronin <brook.cronin@qt.io>
Reviewed-by: Johanna Vanhatapio <johanna.vanhatapio@qt.io>
Fixed the navigation link targets to match the TOC.
Task-number: QDS-4561
Change-Id: Ieca619f7f5e8bd3110f774cc75dbe224216b96e1
Reviewed-by: Johanna Vanhatapio <johanna.vanhatapio@qt.io>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
According to the changes in the Properties view.
Task-number: QDS-4561
Change-Id: I1b75b5388350fc0dadb9f7b7c1532bdc6c97e32b
Reviewed-by: Johanna Vanhatapio <johanna.vanhatapio@qt.io>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
E.g. in case of CMake projects the command contains the build directory,
so it needs to update whenever the build directory (or build configuration)
changes.
Fixes: QTCREATORBUG-26103
Change-Id: I02ea3bd47f4a502adc485dfffbed6a14ebefb0bb
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Omit special and test data functions while collecting
as these cannot be addressed at all.
Change-Id: I3d79192cd07b4e7e2e76f04dfad36ef033593e71
Reviewed-by: David Schulz <david.schulz@qt.io>
* Fix a warning about injection of parameters into signal handlers being
deprecated
* Fix comparison operator
Change-Id: I33d0fe21f39feea69bcca82a57036594d28b039a
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
... in "Go to Slot".
The class can be referred to as Ui::<class> or UI_<class>.
Fixes: QTCREATORBUG-26013
Change-Id: Ib539855b0360ce5fe06fb3cac664af3967695206
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
If we keep the copy of the snapshot around while it's being modified, we
trigger the copy-on-write mechanism. That is expensive, and destroying
the snapshot afterwards is also expensive.
Task-number: QTCREATORBUG-25899
Change-Id: I9b7e26baf63a4b47c85457e5657fee971a6ce132
Reviewed-by: Fawzi Mohamed <fawzi.mohamed@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
All the uses of setStd{Out,Err}Callback in the codebase call proc.stdOut/
stdErr after the execution.
This triggered a soft assertion that was apparently not noticed so far.
It broke for example prompt for conflict resolution on Git pull/rebase.
Change-Id: Ib4b8301f1f50b2b66f02fc4dc6c14d93f895ea33
Reviewed-by: hjk <hjk@qt.io>
Fixes issues with CMake 3.10 and avoids CMake output noise when using
Qbs' copy of QtScript.
Change-Id: I7e50b91302b925e9d4a0b8f098760b90351145fc
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Amends 84befc2 which was too strict.
Fixes: QTCREATORBUG-26123
Change-Id: I3767ba0fb4723c77cfb0e8b1932ff6adfc8e9ac2
Reviewed-by: David Schulz <david.schulz@qt.io>
The singleton is of type QmlDesigner::Theme
and there is no reason for the QObject cast.
Change-Id: I352f3e455de8233c914f37ba93e2313a3a6357fe
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Running 3D particle systems based on their application set properties
is usually not desirable, so until we have proper solution for
controlling particle systems from UI, we disable them entirely.
Fixes: QDS-4773
Fixes: QDS-4801
Change-Id: I45682d8ac5a161a92be98fe9b0304ffb948f104f
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Even if we do not have to provide any data just send a null as the
result so the server nows that the request did not fail.
Fixes: QTCREATORBUG-26116
Change-Id: I9b965389bb197cdd81d0d3ffbac05f289cabda40
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
When reading a path from file chooser, settings or environment variable,
make sure it is portable and "clean".
Avoids extra compiler registrations, invalid Kits and similar issues.
Fixes: QTCREATORBUG-26092
Change-Id: I2a11563f40973d5f595bf00e37ff045a503aa9f7
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Fix a crash that was caused by ColorPaletteSingleton being shared among
multiple QQnlEngines. Each engine requires a unique instance of
ColorEditorSingleton.
* Rewrite ColorEditorSingleton to not be a singleton anymore
* Rename ColorEditorSingleton to ColorEditorBackend
* Add meaningful warnings
Task-number: QDS-4728
Change-Id: I1ed3315add33754b41870ad6f43c1365a899102b
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
The client will be either freshly created or if it was restarted
disconnected in LanguageClientManager::clientFinished
Change-Id: I647d0aaa918419c328013b2dc978d345f7e09c32
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
- removed direct usage of SessionManager
- replaced it with DesignDocument usage
- deactivated add image button for files without projects
- add hasProject method to DesignDocument
Task-number: QDS-4810
Change-Id: I77c74f3c6e9b5b9dcbda68f7937cfeda531d0309
Reviewed-by: Tapani Mattila <tapani.mattila@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
In this case, the text edit's scroll bar does not emit a signal, nor is
scrollContentsBy() called (Qt bug?).
Therefore, we now check the scroll bar position also on a selection
change.
Note that this will still misbehave for the edge case where you search
for something, then scroll back to the bottom, then search for the same
string again and find the same result, because in that case the selection
does not change. We live with that.
Fixes: QTCREATORBUG-26100
Change-Id: Ib5555d9119117dd95c68175c4094bb0fd904f6e5
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Adds an icon for Particle System Component making the component
visible in the editor allowing picking.
Task-number: QDS-4784
Change-Id: Ie6cffa9cfe3bb6a693372d7a7b4341e17f89911f
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
With Creator built on Qt 6.2, Squish considers the
data different although the contents look the same.
Change-Id: I281b7425d5b3f9a977456253e0299f452d75c1e2
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Squish 6.7.1 for Qt 6.1.x can't find the objects when using wildcards. The
same version of Squish for Qt 5.15.x works fine.
Change-Id: Ia378934af51cab2894a9df01e2391dbdb9cf32f9
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This was done for controls 1.
SplitView in controls 2 requires proper test and support.
Change-Id: I749ee072abb50256ad87002605e3064e0a066f29
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
For the tools es and locate, interpret space as AND operator.
Change-Id: I62692ee0d3afed096173bbb789ea1c6b93ce543c
Fixes: QTCREATORBUG-26064
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Fix HelperWidgets AbstractButton nested TooplTipArea blocking hover
events from the actual control.
Task-number: QDS-4828
Change-Id: Ibd390c98805a49f903663b6c38091f727c2b7ec9
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Fixes installation of .lib file on Windows
Fixes: QTCREATORBUG-26039
Change-Id: I593361d2852f589b4f31832d089ebc6af89e0a00
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
It is a stable base to run the precheck on.
Change-Id: Ie5e0699b9067dccba85a3ad4e1b9102799ca5d0f
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Since the last parser update the source location is valid
even if there is no semicolon. The length is 0 in this case, though.
Change-Id: Ie2ff425b54ef39d9db66119236d5e8f56677b748
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
The previous tighter check is actually good theoretically, but currently
ShellCommand::runFullySynchronous triggers it and disentangling there
is not trivial. So weaken it a bit for now to not annoy users.
Change-Id: Ifc6b5713b398db0af0f604834c37ff361c2a1ed3
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Opening a document in the language client while the server is still
initializing will postpone the opening after the server is fully
initialized. So if a document was scheduled for opening by
ClangModelManagerSupport::onEditorOpened while clangd is still
initializing, skip the superfluous opening in the ClangdClient
initialize callback. Clangd seems to have issues if files are opened
twice, resulting in strange diagnostics after editing the file. This is
reproducible for me when starting Qt Creator with a session that
contains open files.
Change-Id: I200d5c8afb685403f0435e0553f5a475f75e8ea2
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
The instructions are for using qmake, but qmake configuration files were
removed from the 6.1 branch.
Fixes: QDS-4722
Change-Id: I525c5042396576029d575c767dcaa37333b809f5
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
currently we use the least preferred toolchain when looking
through all possible toolchains
Change-Id: I520a21bf380c4d1550a62dd9174fd2b67e12bc8e
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
For the case that the installer specified the toolchain
ABI (rather than a concrete toolchain), we now let the user choose.
Note that we do not enforce the original ABI. In practice, this is
anyway redundant with the Qt version, which is still fixed.
Fixes: QTCREATORBUG-25839
Change-Id: Ifd800a736bde59091ce7d07e7a3db1776ad35879
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Remove the linking indicator and the mirroring buttons until the
functionality will be implemented.
Change-Id: I7d76209fc8c184001690b001cbb0e9a8255bde9f
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
