Commit Graph

69993 Commits

Author SHA1 Message Date
Eike Ziller
ced3a32f99 Welcome: Point Get Started button to Qt Creator's Geting Started page
Fixes: QTCREATORBUG-26054
Change-Id: I4fd9cc5d18bddc812a97cdbc4b757ba617fe7098
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2021-08-11 11:17:10 +00:00
Leena Miettinen
b852c8f0cd Doc: Update properties of Rectangle and Studio Components
- Check section captions and field labels
- Update screenshots

Task-number: QDS-4561
Change-Id: I4b2bbd8fc14ad659eb075e01b6e2d53e48b7e5fa
Reviewed-by: Johanna Vanhatapio <johanna.vanhatapio@qt.io>
2021-08-11 11:12:53 +00:00
Leena Miettinen
d66754b376 Doc: Update info about basic and text properties
- Move information around to fit the new sections in the
  Properties view
- Add screenshot
- Describe new fields
- Fix changed field names

Task-number: QDS-4561
Change-Id: Ia4ded8d7f7c6358e050fee8d92c5eebb5ff0d65c
Reviewed-by: Johanna Vanhatapio <johanna.vanhatapio@qt.io>
2021-08-11 11:03:28 +00:00
David Schulz
dc87947cb3 ClangD: skip automatic code action request
.. after receiving diagnostics since the code actions are already
inlined into the diagnostics.

Change-Id: I11ed1270344ff5119dd111503d173eef2f340c1d
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2021-08-11 10:34:17 +00:00
David Schulz
1a3b8bf0e7 Editor: Fix completion tooltip width calculation
Take the offset of the geometry into account when calculating the
available with for the tooltip. This can happen if you have multiple
monitors and the tooltip is positioned on the right monitor.

amends 30cdae912f

Fixes: QTCREATORBUG-26053
Change-Id: I4116547279f3c6708f55a1e1cf7d4ceb76028f9a
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2021-08-11 09:21:53 +00:00
Alessandro Portale
21cb0711c4 Tracing/QmlProfiler: Port shaders to Qt 6
For each shader in Tracing and QmlProfiler:
- Add a vert/frag variant in Vulkan style GLSL
- Include the shader via qt_add_shaders
- Implement RHI/Qt6-specific code for loading the shaders and for
  updating the uniform buffer
- Set the material's QSGMaterial::CustomCompileStep flag to affect the z
  value the same way as the Qt 5 code does

Building of Tracing, QmlProfiler, etc. with Qt 6 depends on the Qt
Shader tools being installed.

Fixes: QTCREATORBUG-20575
Change-Id: I9aba5a777da9a549da0cdd0a217dfcb346c72e58
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>
2021-08-11 08:05:22 +00:00
Alessandro Portale
84a0170516 Tracing/QmlProfiler: Prepare for porting of shaders to Qt 6
This change touches up the shader handling code in Tracing and
QmlProfiler in order to pave the way for the pending porting of
the shaders to Qt 6.

- Use QSGGeometry::Attribute::createWithAttributeType instead of
  QSGGeometry::Attribute::create
- Undefine some fields that are unused in Qt 6
- Add a couple of comments to document the relation between C++
  variables and shader attributes
- Extract some code into functions

Change-Id: I0e7119484b6190a415a5c2d2a0bbd6465088cf19
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2021-08-11 08:04:32 +00:00
Christian Stenger
f95d6c6009 Docker: Handle daemon globally
The daemon state is not a device dependent setting.

Change-Id: Ic972fdc5cbb06395e04709858312b4d336321577
Reviewed-by: hjk <hjk@qt.io>
2021-08-11 06:37:59 +00:00
Christian Stenger
bfe2a7b9d1 Squish: Fix suite_debugger
Change-Id: Ic0add36d2acfbf4c6de93d27f8651062ad9f1fb4
Reviewed-by: Robert Löhning <robert.loehning@qt.io>
v5.0.0-rc1
2021-08-10 18:55:43 +00:00
Robert Löhning
0a953d2412 Process_stub: Silence warning about unused return value
Change-Id: I7bc39728c0b7d34b48bb2bdef4295dc17a1e8bc6
Reviewed-by: hjk <hjk@qt.io>
2021-08-10 18:50:12 +00:00
Robert Löhning
867b006517 Squish: Update tst_APTW03
Change-Id: Id3b93b8e78b7797bd8c1cec5e6edb0b7cc966ea1
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-08-10 18:49:23 +00:00
Robert Löhning
5c2b00aaf7 Squish: Update tst_build_speedcrunch
Change-Id: Ie3ea3a06f36a540e1e96ed288af46e5e69e47997
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-08-10 18:49:04 +00:00
Eike Ziller
c36d55cef8 Doc: Add information on what to do if Silver Searcher is not found
even though it is installed.

Task-number: QTCREATORBUG-26044
Change-Id: I45056fcbdb5217c4f8e8534ca7fa24369e8290db
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2021-08-10 14:15:35 +00:00
Eike Ziller
0b7cd967a2 CMake build: Fix pdb file names (Windows)
They should have the same base name as the DLL/.lib, but were missing
the version number.

Fixes: QTCREATORBUG-25968
Change-Id: I30e39a62b94264bd5a4852f0b1100044fa47d811
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2021-08-10 12:23:16 +00:00
Eike Ziller
f1093ad70d Update change log for 5.0
Change-Id: I8f3468621252935b1d1d1163eb5678a30f6e4dd4
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2021-08-10 11:24:19 +00:00
Eike Ziller
92065bff0f Locator: Guard settings saving against filters with empty ID
When constructing the settings key, an empty ID would lead to writing
(in this case removing) the whole Locator settings category, which
overwrites all indidvidual Locator settings. Don't save settings for
filters with empty ID at all.

Introduced when introducing clangd support to ClangCodeModel plugin.

Amends ecafdb7543

Fixes: QTCREATORBUG-26101
Change-Id: I4ecb4f86fa8a0ef2bc2417206629c9e322addb12
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2021-08-10 09:53:35 +00:00
Tim Jenssen
27d414458e qmlpuppet: fix qt 5.15 builds
Change-Id: I6d19624537a3980252d43624ecf24e110638225a
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2021-08-10 09:07:41 +00:00
Christian Stenger
af357c47fb QmlJS: Downgrade default log level
Avoid flooding logging messages by default and let the user enable
them explicitly.

Change-Id: I9f8fe044a460309e4462a5d88bd12a0ab6088731
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2021-08-10 07:05:02 +00:00
David Schulz
30981f5ba2 LanguageClient: fix typo
Change-Id: Icb04ed3f444b443ea97febeadd2766bb62fdbb85
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2021-08-10 06:20:27 +00:00
David Schulz
bbb06a72ec LanguageClient: reapply semantic highlight after font changed
Change-Id: I609e26b7f85744fdffb8399e0d651691b7c39900
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2021-08-10 06:20:20 +00:00
Christian Stenger
a5aef91411 ExtensionSystem: Add settingspath to system information
This information is re-used inside the System Information dialog.

Change-Id: I71d2b9a1574ea1cd3f68349d974555ec5625f185
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2021-08-10 06:12:48 +00:00
Tim Jenssen
8d222e22d5 deploy tls plugins to fix ssl downloads
it fixes https example downloads in QtDesignStudio

Change-Id: Ib162e630ae3a66691bec6d8f32cee241614e01e6
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2021-08-09 14:56:30 +00:00
Miikka Heikkinen
2c7b2ad685 QmlPuppet: Fix incorrect initial render size/scene for edit 3D
The scene id was stored as array of QChars instead of QString, which
caused issues restoring the correct scene at puppet reset.
The intitial incorrect render size was caused by not changing the
render window size in addition to root QML item size.

Fixes: QDS-4586
Change-Id: Id6b16d778a9d886e8fdc40eab1e549d13091f8f4
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Samuel Ghinet <samuel.ghinet@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2021-08-09 14:00:19 +00:00
Eike Ziller
ffe03c7870 Fix Qt Quick Extension wizard's kit selection
Do not require kits to be Qt 5, instead require it to support QtQuick 2.

Fixes: QTCREATORBUG-26082
Change-Id: Icf34644eef704b28e80ef7b130fd2a68539347e7
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
2021-08-09 12:50:34 +00:00
Jarek Kobus
a2bc154ed0 Fix a crash when searching again for the last 12th item
Don't connect updateFilterButton() to the
QStackedWidget::currentChanged(). Call updateFilterButton()
explicitly by the end of setCurrentIndex().

Fixes: QTCREATORBUG-26099
Change-Id: I7cba97346e1f6c73171a9b83381e271750d50f25
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2021-08-09 11:55:31 +00:00
Christian Kandeler
6530a4fdc7 Fix some compiler warnings
Change-Id: I4eaf47bda086b83618f461ab19d1715c67e27ae1
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-08-09 11:52:07 +00:00
Leena Miettinen
f719ae57ee Doc: Update screenshots to improve their legibility
Task-number: QTCREATORBUG-25642
Change-Id: Ifb60ae63a2eea85d05a67dcfee7614ff3c256992
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2021-08-09 11:15:33 +00:00
Eike Ziller
7bae0b9d66 SilverSearcher: Fix crash in output parser
Neither parseFilePath nor parseText guarantee that index stays <
outputSize.

Change-Id: I087858cf6c1027fd04a7608c8ef10f4ce88348ef
Reviewed-by: Przemyslaw Gorszkowski <pgorszkowski@gmail.com>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2021-08-09 09:33:22 +00:00
Christian Stenger
400426ed9f Utils: Handle resolving paths and validation more appropriate
Manually editing the path inside a PathChooser will trigger some
validation and may end up in constructing some invalid paths
but still marking them as valid.
Beside this it will make the cursor jump to different locations
while typing which ends up in creating even more incorrect paths.
So, avoid creating invalid paths and mark the resulting path
as invalid if it is.

Change-Id: I27f55ae03745474fc6b91c44cdbc307c581fb2f8
Reviewed-by: hjk <hjk@qt.io>
2021-08-09 09:30:28 +00:00
David Schulz
c63d72a8e8 LanguageClient: default initialize log message member
Change-Id: Ife6e59a1ec391b58e1d3f19d25a7be81993b8868
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2021-08-09 09:27:06 +00:00
Orgad Shaneh
26be258bf9 Core: Fix crash on shutdown
ProcessReapers waits for all the processes to terminate, and in the mean
time, it processes events. This is done after Core has already been
terminated, but QObject dtor has not been called yet, so not all signal
connections are disconnected.

Crash trace:
1  QWidget::actions                                            Qt5Widgets               0x7ff93a662fe9
2  Core::Internal::MenuActionContainer::updateInternal         actioncontainer.cpp 482  0x7ff93158be03
3  Core::Internal::ActionContainerPrivate::update              actioncontainer.cpp 417  0x7ff93158bd72
4  QMetaCallEvent::placeMetaCall                               Qt5Core                  0x7ff939b9ac34
5  QObject::event                                              Qt5Core                  0x7ff939b995c1
6  QApplicationPrivate::notify_helper                          Qt5Widgets               0x7ff93a644990
7  QApplication::notify                                        Qt5Widgets               0x7ff93a643a13
8  QCoreApplication::notifyInternal2                           Qt5Core                  0x7ff939b72aca
9  QCoreApplicationPrivate::sendPostedEvents                   Qt5Core                  0x7ff939b74845
10 qt_plugin_query_metadata                                    qwindows                 0x7ff960422dff
11 QEventDispatcherWin32::processEvents                        Qt5Core                  0x7ff939bbba5a
12 qt_plugin_query_metadata                                    qwindows                 0x7ff960422dd9
13 Core::Internal::ProcessReapers::~ProcessReapers             reaper.cpp          134  0x7ff9317b54ee
14 Core::Internal::CorePlugin::~CorePlugin                     coreplugin.cpp      114  0x7ff9315a705c
15 Core::Internal::CorePlugin::`scalar deleting destructor'    Core                     0x7ff9315a8584
16 ExtensionSystem::Internal::PluginSpecPrivate::kill          pluginspec.cpp      1125 0x7ff95299a160
17 ExtensionSystem::Internal::PluginManagerPrivate::loadPlugin pluginmanager.cpp   1608 0x7ff95298e2ad
18 ExtensionSystem::Internal::PluginManagerPrivate::deleteAll  pluginmanager.cpp   1061 0x7ff9529885f5
19 ExtensionSystem::Internal::PluginManagerPrivate::shutdown   pluginmanager.cpp   1397 0x7ff95299463f
20 QObject::qt_static_metacall                                 Qt5Core                  0x7ff939b91d49
21 QCoreApplicationPrivate::execCleanup                        Qt5Core                  0x7ff939b71b25
22 QCoreApplication::exec                                      Qt5Core                  0x7ff939b71aaf
23 main                                                        main.cpp            762  0x7ff734b31bf7
24 WinMain                                                     qtcreator                0x7ff734b38407
25 __scrt_common_main_seh                                      exe_common.inl      288  0x7ff734b3716a
26 BaseThreadInitThunk                                         KERNEL32                 0x7ff9a8806fd4
27 RtlUserThreadStart                                          ntdll                    0x7ff9a8adcec1

Change-Id: I7cf32f57354ee9e2507a2883078f0818fc5d6116
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2021-08-09 08:34:50 +00:00
Thomas Hartmann
fa1d7958c3 QmlDesigner: Do not generate version number if invalid
This is a fallback to create components from source.
If the majorVersion is negative we should not generate
a version as part of the import.

Change-Id: I377b241e8e4c51141d560d7198e5906a9c963b54
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2021-08-09 08:10:01 +00:00
Leena Miettinen
2dfe37f1cf Doc: Remove description of obsolete Run field in Android Manifest
Task-number: QTCREATORBUG-25642
Change-Id: If70772a79f0aae5990ca962112e00da7b9c7f3ec
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
Reviewed-by: Rami Potinkara <rami.potinkara@qt.io>
2021-08-09 08:06:55 +00:00
Christian Stenger
3560d98cc1 PE: Be more restrictive in fixupDir()
Only modify device letter if it appears to be one.
Do not touch capitilization when fixing.
Amends b6dd53d4ed.

Change-Id: I55203eb14bc78d551dd4d88cd2a4e3efac3d816e
Reviewed-by: hjk <hjk@qt.io>
2021-08-09 04:29:30 +00:00
Christian Stenger
bd5c36530b Squish: Prefer 64bit debugger over 32bit on Windows
We nowadays build with 64bit Qt and need a matching compiler.
Especially when testing packages that ship both cdbext versions
the preference of 32bit breaks debugging.
As a drive by, fix tst_simple_debug by triggering rebuild via
locator as menu items are nowadays harder to distinguish.

Change-Id: I6f0c1083472713c48b4d558d6c6f9b8b0da2ca77
Reviewed-by: Robert Löhning <robert.loehning@qt.io>
2021-08-06 18:58:51 +00:00
Aleksei German
a9f90eea03 QmlDesigner: Fix for crash in puppet creation
Task-number: QDS-4811
Change-Id: Ib1f0b2a76d539e709bea821f4cf950f9b2e94e83
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2021-08-06 15:40:18 +00:00
Miikka Heikkinen
7211b7abf2 QmlPuppet: Fix crash on active scene change
Active scene change involves deleting and recreating the View3D
instance of the 3D editor that imports the actual shown scene.
In Qt 5 it was necessary to mark the deleted View3D instance as having
no content, so it wouldn't receive any more updates. This hack no
longer appears to be necessary and causes this crash instead, so it
was removed.

Fixes: QDS-4786
Change-Id: I848ac78dc2f951ba7e1bf4d3d6aa4244b1443309
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2021-08-06 13:43:27 +00:00
Christian Stenger
fec3ef202f AutoTest: Prevent potential nullptr access
Change-Id: I78eb4a5113d23273e9383c86fdefcffea05e0123
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2021-08-06 12:24:44 +00:00
hjk
4652ef286b Debugger: Show output of debugger detection
... in tooltip of debugger path lineedit.

Helps with cases where necessary libraries are missing.

The tooltip is a bit hard to recognize, but as such cases now also
are marked in red text there's at least some direct hint that something
is not ok.

Change-Id: Ic5da8dcb1921a98f91f6eed755fa87ce5feed698
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2021-08-06 11:12:12 +00:00
Robert Löhning
2f6c5db856 Squish: Update isMsvcConfig
Change-Id: Ia2042d32d0a41a8876ba6dfae960f48bca2b298c
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-08-06 09:29:17 +00:00
hjk
adf70fd8f2 Debugger: Don't add empty path components to solib-search-path
Change-Id: I417e5193749dae44d189fc0189a92899d738976b
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-08-06 07:18:43 +00:00
Jarek Kobus
82340dbf73 Fix the astyle version matching
In my case astyle returns "Artistic Style Version 3.1" and
it didn't want to match.

Change-Id: Ie3bee186cb39d29f11fa1add2f99c87d5fd67842
Reviewed-by: hjk <hjk@qt.io>
2021-08-05 18:52:59 +00:00
Cristian Adam
124dc2c6b6 Android: Add setup_android.cmake script to download JDK, Android SDK
Execute from command line with: cmake -P setup_android.cmake

Then in Qt Creator -> Options ... -> Devices -> Android point the
"JDK location" and "Android SDK location" to the directories
created by the script.

Change-Id: I59d1b39ec34a58dc54882c04d3f272c0baefcc7d
Reviewed-by: hjk <hjk@qt.io>
2021-08-05 16:54:14 +00:00
Cristian Adam
614c9a6cb6 CMakePM: Reference more CMake variables in auto-setup
This will remove the warnings for examples that setup only
the C++ compiler, or when configuring QML debugging.

Amends 1bf9900aed

Change-Id: Ica9361114be420b81f611f5d498d87949399e8b4
Reviewed-by: hjk <hjk@qt.io>
2021-08-05 16:24:50 +00:00
Christian Kandeler
11da66f768 ClangCodeModel: Adapt to new "virtual" modifier
... in clangd's semantic tokens.
See https://reviews.llvm.org/D107145.

Change-Id: Idf9fe327df3fb806697ab5b806e89bb62d43e706
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-08-05 15:00:42 +00:00
hjk
8e41a401b0 Utils: Fix pathchooser auto-search-in-path for remote cases
Amends 11a40e02f2.

Environment::searchInPath only works for local setups, the
remote replacement is FilePath::searchOnDevice.

Change-Id: I8a2ba51903d3308ca9198fbf1154779c78e69e63
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-08-05 13:58:00 +00:00
Christian Stenger
bf93998fb4 Docker: Fix filtering without a filter
If there is no filter accept all instead of nothing.
Fixes e.g. ABI detection on docker image running
on Windows.

Change-Id: I17588f71018952b1087b5b8f700b6c158bf5b89d
Reviewed-by: hjk <hjk@qt.io>
2021-08-05 13:35:26 +00:00
Christian Stenger
b039013d9a QtSupport: Fix display of non-local Qt version info
Paths should be displayed with their os-specific separators.

Change-Id: I7d60b3ba29ee990d3317791c46701d41614fbdca
Reviewed-by: hjk <hjk@qt.io>
2021-08-05 13:35:17 +00:00
Thomas Hartmann
da2ebada18 QmlDesigner: Fix error message
A negative index was ignored before, but ::slide
now throws more aggressive.
In any case -1 means there is no item and that no slide is required.

Task-number: QDS-4796
Task-number: QDS-4601
Change-Id: Ief7f597e4d430652c2b18e6af3bc187c4c4e28a6
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2021-08-05 13:11:22 +00:00
hjk
1490aeb0e0 CMake: Use FilePath operations to create error flags
Otherwise remote setups generate unrelated errors.

Change-Id: I11285048b1ac0424c45bed5b61779af6724a7a0f
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2021-08-05 12:23:28 +00:00