... to genericdirectuploadstep.cpp and inline its pimpl.
Change-Id: I50550ee4bbf4266fa191008c9db1696bae3f7f43
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
In case mktemp or mkfifo fails, the device shell script would
incorrectly print both success and failure messages.
Also cleaning State enum, removing unnecessary values.
Fixes possible crash if creation of master process fails.
Fixes: QTCREATORBUG-28928
Change-Id: I75fef54dc791b2b0a403bab19dab6813b62643ac
Reviewed-by: hjk <hjk@qt.io>
In order to avoid dependency of AbstractView on QmlObjectNode. Moreover,
it seems not in the right place anymore since it is not really part of
an abstract code.
Change-Id: I7a64122e6ab0a2e314c593f0f47dadaa07d772e2
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
From man deb-version: It is conventional to restart the debian-revision
at '1' each time time the upstream-version is increased.
Not really required, since "no revision" sorts earlier than "some
revision", but seems to be conventional.
Also add a maintainer string, that is shown in the package info and
marks this package to come from the "Qt Project" directly.
Change-Id: I417a8d14d82f9f8ccfbe791e767d4ffed8175604
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Fixes highlighting of matching parentheses or errors of the code model
in every line of the suggestion.
Change-Id: I223cb567ee8ce95badd91c4819417310a0e28cff
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Updates only the entries for the given source context (directory) ids
and skips everything else. It is enabling partial updates
for directories in a project.
[&, &ids = ids] the strange capture clause steams from a C++ issue.
Tak-number: QDS-9456
Change-Id: Id3abcd39ac429ba4483124f334d50c2999f5e6a8
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Use the real path cache. It makes the test some 100ms slower because the
database has to be created for every test but makes the test simpler.
Renames some variables too for better readability.
Task-number: QDS-9456
Change-Id: I3246a1859eae7b26b9e13a9d88d3c717748de43e
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
The Qml documents and Qmltypes files cannot added or removed if the
project data is parsed. So the can simply been added to the watched
files.
Task-number: QDS-9178
Change-Id: Iaa30425241ac7ad3c2434b9c6c5955e894ec6049
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Add a default close button and connect all language server defined
buttons to accepted, so the message box gets closed when the user
presses a button.
Change-Id: I846eadf5953e75441bdc7910c2587a2fa098a388
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Happens when dragging an invalid item on a state. The item is null
but the check check for undefined. Better approach is to always use the
! operator.
Change-Id: I036e0f2d5231b0b0eb67a8400551c93fa0654ecb
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Hide public DocumentLocatorFilter::updateCurrentClient()
method and remove
ClangdCurrentDocumentFilter::updateCurrentClient().
Connect DocumentLocatorFilter internally into a new
LanguageClientManager::clientInitialized() signal instead.
Change-Id: Ie74a112bda811525b7d226da1377e5624130e9ed
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Adds a new helper app "process_stub" that replaces the previous.
"process_stub_unix/win". The purpose was and is to allow processes
to be "injected" into other hosts apps like terminals while still
being able to control and debug them.
A new base class called "TerminalInterface" is used for both the new
Terminal plugin and the legacy TerminalProcess implementation.
Fixes: QTCREATORBUG-16364
Change-Id: If21273fe53ad545d1a768c17c83db4bf2fd85395
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: hjk <hjk@qt.io>
The combobox will break bindings on current index. Therefore
we cannot use a binding on the instances.
Change-Id: I5b4ede02b8b945429b37efa4fc3e1acc15b3fbe7
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Passing mandatory context object clearly suggests a special
care should be taken for assuring the passed function
may still run when the task finishes in the future.
Fix FileStreamManager so that it deletes the streamer
even when context object was deleted in meantime.
Fix 2 usages of asyncCopy so that we pass a context object now.
Side note: passing nullptr as a context object is still
possible and should work, but it's not recommended.
Change-Id: I464438db42ed9292c2f89ecb9d5dde7c78f77640
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
Test appending and prepending PATH.
Change-Id: If2ff84b24a8f961af0a3bb64ed77aaf37fe247fd
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
[ChangeLog][RemoteLinux] Target-side shell profiles are not sourced by
default anymore.
Change-Id: Ide5029d02a0d149c4e532ee523f1dd49e7080c7b
Reviewed-by: hjk <hjk@qt.io>
This effectively reverts 21c66ce5fd.
We are not aiming at using QUrl everywhere anymore, rather have Utils::FilePath.
Change-Id: I97ccc7ee6976c27e629b446bc4f3851532463213
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
This will make sure that code reacting on the document change signal can
get the final cursor position from the widget. More specificly this
fixes requesting copilot suggestions when automatic text is inserted
like closing parentheses when typing "if ("
Change-Id: I01a13e67e72b89010fe39de3d0def0622a9b08b8
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
- Text is elided in the overflow state.
- Text is aligned to the left in the overflow state.
Task-number: QDS-9402
Change-Id: If1cca917a42b8198729591506e8a886ea9a70814
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
General drag-and-drop is no longer supported for DesignModeWidget.
So every single module handles drag-and-drop events individually.
Task-number: QDS-5279
Change-Id: Ic6c1c3d8ab71279c99c88c8d5849d7b243fe2347
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>