The objects Repeater3D creates are created after handleInstanceHidden
is called for the repeater instance, so the _pickTarget of the created
children doesn't get properly updated. Added signal handler to
make sure handleInstanceHidden is called again after all objects have
been created.
Fixes: QDS-5643
Change-Id: I8b63614fca0be3956b6896028e3f3a0f49bfe397
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
We now check also the parent chain for pickability, because
a node is not pickable if one of the ancestors is not pickable,
as all properties picking depends on (visibility, locked state)
are implicitly inherited by descendants.
Rotate gizmo rings default to regular View3D picking when the angle
is so steep that the plane intersection is not reliable. With new
global picking enabled handling we need to check all hits instead
of just the first one.
Change-Id: Ib1aa604b06f7db1041f5d4c3019cc2badf29a20f
Fixes: QDS-5679
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
The default behavior is opposite from when using qmake.
Task-number: QTCREATORBUG-26616
Change-Id: I9ec0f1a961e8d0cb25957dddcceec79cffbf292b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Still trying to ramp down non-QtcProcess interfaces.
Change-Id: I6b4ae6788f5021959ff3eb35bbade2157a6d67fa
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
ICore::settings() lives longer than anything in TextEditor.
Change-Id: I67df38f291f43763bdd236ea611db614ac515c97
Reviewed-by: David Schulz <david.schulz@qt.io>
in the global settings.
Change-Id: I2f90388c138c92f03f78044e225574ded640d4b9
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Hopefully this will help with the macOS host which tends to fail
at running tests with:
The hosted runner: GitHub Actions X lost communication with the server.
Anything in your workflow that terminates the runner process, starves
it for CPU/Memory, or blocks its network access can cause this error.
Change-Id: I2ead1efd1526332cc2045fee7db4a76831f2e333
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
The built-in code model treats the "local uses" result state as an
indicator of whether to provide quickfix operations. It's unclear what
kind of side effects would result from removing this condition, so we
always run the built-in variant of the "local uses" code, and only
refrain from actually updating the selections in the clangd case.
Amends 0c53c2daef.
Fixes: QTCREATORBUG-26649
Change-Id: I9e1a3e3ad08bf13bcb35efe996a61aa34302b166
Reviewed-by: David Schulz <david.schulz@qt.io>
Snippets collection managed the snippets with persistent iterators to
the "end" of the active snippets. Qt 5's QList was nicely updating
iterators even on non-const operations, but that has changed in Qt 6.
Don't use iterators, simply work with the count of active items.
Fixes: QTCREATORBUG-26648
Task-number: QTCREATORBUG-24098
Change-Id: Icc13274daf0e87d0562d80d7bc763c863d5da075
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: David Schulz <david.schulz@qt.io>
Even though CMake was mentioned, the text could be made more
general.
Task-number: QTCREATORBUG-26616
Change-Id: I6ff59e96559579c773d8ae1313f96800597e0ccc
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
When using an NDK installation which was not installed via an Android
SDK manager, we cannot presume that the included lldb binary has a path
containing "ndk" or "ndk-bundle".
Looking for "/toolchains/llvm/prebuilt/" in the path should detect any
ndk-provided lldb.
Change-Id: Icbaab0915f5877ca37ee44cbca6cc37360363b5c
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
The location of the blocks to marked ifdefed out are not tied to a
specific editor instance, but just depend on the document content.
Change-Id: I837730dc00e1d6060dd46bbb2cfccbfa5f72e6ce
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Calling the msvc vars bat can take a considerable amount of time on a
loaded system. Since we cache the environment modifications from
previous runs it's okay to raise the bar here.
Change-Id: Icda91d6682396e6f73946ccd379b88631590536c
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
After modification of how fontcompiler is linking font binaries into
executale CMake project needs to have Microsoft Assembler language
option added (ASM_MASM).
Fixes: UL-5059
Change-Id: I593ca6230e8fbaf70a4061a12b6606843ab9bd46
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Previously qml files in selector paths would not properly locate directory imports,
now when an import in a selector path fails we try to go up to the next non-selector
directory and look for the imported directory there.
Fixes: QTCREATORBUG-25127
Change-Id: Ib9b364981b49068637aa97d6f75abf7f1f5878cc
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Added animation behavior for hovering. Also added top padding to the
search field so that the text is correctly aligned vertically.
Change-Id: I51273373aa43ceb3a3faca6a9f76b613fdd0be69
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
The code model will get the necessary bits so that it can successfully
parse the QNX code.
Fixes: QTCREATORBUG-23483
Change-Id: Id9488f644ace23952edf7a7cb5da7ca138182134
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Mostly, this is explained in CMake documentation. There is
currently no special support for this in Qt Creator.
Task-number: QTCREATORBUG-26616
Change-Id: I7981324e04be6fc716256754db9f2089eaffee73
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Fixed 2 issues with the context menu:
- Left clicking the area to the right of the states doesn't close the
context menu. The issues seems to be a bug in the ListView, solved by
limiting the width of the ListView to the states area width.
- Clicking (left or right) below the states area doesn't work. This is
because the height of the states view was fixed to the height needed.
Solved by not restricting the view height and do necessary changes.
Also some cleanups and removing unnecessary stuff.
Fixes: QDS-5324
Change-Id: Ic1e3f5d0776bb4770a3276c93ad1aee7a0049388
Reviewed-by: Samuel Ghinet <samuel.ghinet@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
If the cursor is right before the "." in a member access expression,
clangd interprets it as belonging to the member instead of the base
expression, which leads to unexpected behavior.
Work around this by sending a cursor position one to the left of the
real one to clangd in such cases.
Change-Id: I429ee9189760ccb02d231acfcb94ab6cfde3cd8d
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: David Schulz <david.schulz@qt.io>
Replace the own three overlays with those from ProjectExplorer.
Change-Id: I9eceef4b7b321a47d2b7bd3e86bd758395043a37
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Model bounds API changed with 25b757b7b0a286a392b3 so switch to new
API with version checks.
Task-number: QDS-5657
Change-Id: I6d880f179fc277f94ea9ac610ae682e9afbefe39
Reviewed-by: Antti Määttä <antti.maatta@qt.io>
Reviewed-by: Andy Nichols <andy.nichols@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Remove the custom audio convenience type which should mimic the QML
Video convenience type only for audio. The custom convenience wrapper is
not working, because MediaPlayer is a QObject and can't have children.
Change-Id: Ic8d06e6397d8b7bb3bc531d47c1cb0b92142a742
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
* Add VideoOutput
* Add ComboBoxes to MediaPlayer specifics for selecting audio and video
output ids
Change-Id: I52ea764b1301492754676a97d8d122275ba6dd81
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
