Allows nicer translatable strings.
Also remove the extra white space in the outer layout.
Change-Id: I9b7c82f932f8b0f0a7fc78a3aba6d2ea292dc670
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Otherwise some internal data might be outdated. For example inserting
text resets the QTextCursorPrivate::x which is used to calculate
positions when moving the cursor up or down.
Fixes: QTCREATORBUG-26635
Change-Id: I9fee7436a3648f9d3eab7b30f8a09a134c5be356
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Put BUILD_TESTING into the cache, so it doesn't get overridden by the
default option in a clean build via policy CMP0077
Fixes: QTCREATORBUG-26626
Change-Id: I8b90286c82a60ba30eb9b036dac8fca3be82cc2e
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: Youri Westerman <tetracon@gmail.com>
This was non-standard to begin with, and splitting it makes it
possible to have different designs for New Project and New File dialogs
that are more tailored for the different needs (as is done in
Design Studio)
Change-Id: Ie6246e3c3f3527702c4562ec6f8fcbf5fae6c6ad
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: hjk <hjk@qt.io>
Repeater3D instance instantiated by another Repeater3D got its
componentCompleted called twice because a repeater constructing a
child repeater already completes the component as part of the process,
and then we recursively complete the children again when completing
the parent. Added a check to avoid duplicate completions.
Fixes: QDS-5651
Change-Id: Iefc7deff4877df903f784396f2efd13468f604b7
Reviewed-by: Samuel Ghinet <samuel.ghinet@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
While maintaining the margins in the respective option pages.
Change-Id: Ia7c0e9f68ab196be0d68632117041eca9f4b15f5
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
- Do not automatically restart particle system animation when pressing the
restart button if the animation is paused.
- Use own QElapsedTimer in AnimationDriver and properly handle animation
driver pausing.
Change-Id: Ic2924fb66fddffb8878625be8fa766f06219ca61
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Complete with (hidden) UI. Doesn't do anything yet, because some
assumptions about projects need to be adapted on the LanguageClient side
first.
Task-number: QTCREATORBUG-26526
Change-Id: I34c92555e34c3d3ed98462261d47b35dfc015ce0
Reviewed-by: David Schulz <david.schulz@qt.io>
Splitting Examples and Tutorials to own separate pages.
Task-number: QDS-5495
Change-Id: I0014f1ab456298e9b5887b511f608725ec9d2455
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
* Make Project name text field have the same font size as the rest
* Use Titillium Web as the font family for the title
* Reduce the top padding of the dialog box
* Renounce the section "Advanced" from Details - we still have the items
in the section, just not the section itself.
* Add scrollbar for the details pane - to allow smaller size dialog
* Move the tab bar (Presets) out of the GridView component - so that
scrolling the view would not also scroll the header.
* The Project view now shrinks if the dialog box is shrinked too much,
also reduced the minimum sizes of the dialog
* Resize dialog on screens smaller than 1920 x 1080
* Increase the space between Presets, Details, Styles text and their
top margin
* Lower the project item width from 144 to 90, so that project items in
the view are not so distanced from each other.
* Align the Cancel button with the left margin of the Style pane
Task-number: QDS-5500
Change-Id: I340967941c5c56c89b8741079cb64e355a283e3b
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
... for adding the OpenSSL libs to.
For the typical Android case of a single application product, this will
do the right thing, and otherwise won't do anything worse than now.
Fixes: QTCREATORBUG-24255
Change-Id: I577f3cbd3fda086b8a7c7c5614d0ca79ff9d46f7
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
If the project has a .qmlproject, then this exposes the name
to file wizards.
Change-Id: I3522784bc5fb4d373072eb72e5881d7a6d1d2777
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
On macOS and Windows, we used the system icon for C/C++ source and
header files. This was probably done under the assumption that the
system would have sensible icons registered for these types via Xcode/
Visual Studio, but actually that assumption is not very well founded.
For example I have set emacs as the default editor when double clicking
C/C++ files, and then get the same little emacs icon on all .h and .cpp
files in Qt Creator, which is not useful. There seem to be more effects
on macOS 12 leading to a generic icon too.
Fixes: QTCREATORBUG-26586
Change-Id: I88616b28d51f1583324bac9c802c9cc5bbc8ee70
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
By default it's 30 per page and one page. Increasing to 100 per page
and trying out 10 pages should provide recent results.
Change-Id: I46d8e20a35f94d2ef81cc0bbead4bade66a17f5a
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
GitHub Actions cache action uses the branch name to scope the file
caching, which when using with a gerrit bot can lead to cache
misses.
By using the cache storage as an artifact we can always get the
artifacts if previous jobs created them.
By upgrading to v2 of actions/download/upload artifact we remove
the v1 problem of the upload action that creates a directory name
with the name of the artifact, which leads to failed release
uploads.
Change-Id: I8cb8c3242b58f709f51202852ad45d42b833fa84
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
We don't want litehtml tests, and downloading content during the
configure/build is not nice either.
The litehtml CMake files include CTest, which adds
BUILD_TESTING as an option (default ON), and if it is on,
litehtml downloads googletest with FetchContent.
Fixes: QTCREATORBUG-26626
Change-Id: I1e8d1cde8819d52e96a925a52392cdb8068701d5
Reviewed-by: Youri Westerman <tetracon@gmail.com>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
and the settings dialog, by quickly pressing escape (twice) after
closing the device setup dialog.
The device test dialog was created on the stack, and run with exec(),
which creates another nested event loop for it. If the escape keys got
into the event queue before the device test dialog was shown, the first
key event was handled by the device test dialog correctly, but the
second key event was delivered to the settings dialog _within the device
test dialog's event loop_.
So, while the stack still was within DeviceSettingsWidget::testDevice()
and the dlg.exec() call, the settings dialog was rejected, and
recursively deleting children, including the device settings widget and
even worse the device test dialog - which was created on the stack. That
leads to a crash.
Move the device test dialog to the heap and use show() instead of
exec(), which fixes the issue and is the preferred method anyhow.
Fixes: QTCREATORBUG-26285
Change-Id: I03a0d1b92e466e18b753cad11482afdae2da24d0
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Use QListView with its very capable icon view mode instead of QTableView
in order to layout items in a grid.
This removes the need for the GridProxyModel.
It also leaves the previously self-implemented calculation of columns
count to QListView. Only the ProductGridView still needs to calculate
that.
Change-Id: If6e7f033fc78883930794c1e261aea396ae25190
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
- Describe additional ways to open output panes.
- Add a screenshot of the taskbar.
- Add descriptions of related icons.
- Fix the Maximize Output Pane command keyboard shortcut.
Task-number: QTCREATORBUG-26278
Change-Id: I92712d1542871119e4402df18bd10c9563a335d3
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Also remove the pull_request support for github actions, since we
don't support the pull request workflow for contributions.
Change-Id: Ia0a1ab7c996f679195fde455c1f06911077d6deb
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Utils::Internal::Reaper class is doing graceful termination of
process. It tries in a loop to first terminate() then kill()
the process and at the end delete the object.
Utils::ProcessReapder::reap should not kill the process directly,
and now that the function works with a QProcess, the special
handling of QtcProcess::terminat() of qtcreator_ctrlc_stub.exe
processes needs to be handled explicitly.
Amends ace765c199
Fixes: QTCREATORBUG-26612
Change-Id: Ia109ec0737a8c605a84e93b6ee3691d843ed5da8
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: hjk <hjk@qt.io>
Also remove the specific mention of Shift key for enclosing
code because that requires Ctrl for curly braces on some
keyboards.
Task-number: QTCREATORBUG-26278
Change-Id: I7daa02392e9f405264bbc5960ad569ea2a4b281b
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This was needed in the early days of the CMake port when the list of
source files would change due to being added to the qmake project
files.
Change-Id: I7afd219b24ab7a0d87fce26ba35dac75cf8caa5b
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
