Commit Graph

57165 Commits

Author SHA1 Message Date
Ulf Hermann
aaab74e276 Tracing: Don't use "row" and "column" as IDs
Fixes: QTCREATORBUG-21478
Change-Id: I9bda68abc4980ab9bc4247e48f5bc8bfc788c2dd
Reviewed-by: Robert Loehning <robert.loehning@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2018-11-14 15:46:10 +00:00
Orgad Shaneh
fed9ac43f0 GDB: Enable adding expressions for core dump
Change-Id: I998bf3f3a7a719dc9b80492e55ffe5ace56ef461
Reviewed-by: hjk <hjk@qt.io>
2018-11-14 15:43:11 +00:00
Christian Kandeler
bb15dde8a7 Documentation: Fix qbs build
Amends 1e1c212090 and 54208113ee.

Change-Id: I1f15a118b40513382e4e1d5767781865d4458ce9
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-11-14 14:22:24 +00:00
Eike Ziller
69b111b3c7 More Qt Quick wizard fixes for Qt 5.12
Task-number: QTCREATORBUG-21476
Change-Id: Icadcf12dc59786a62205cccc917a13b42f55b782
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Robert Loehning <robert.loehning@qt.io>
2018-11-14 14:10:22 +00:00
Christian Stenger
3f42cd724e Tests: Allow dumper tests with Qt5.11 and Xcode 10
qmake brings up a warning regarding using Qt5.11 in
combination with Xcode 10. This seems to get handled
as error inside the tests - so, disable the warning.

Change-Id: I6d2918789580fd332048c85e0c4fc75a9635deb6
Reviewed-by: hjk <hjk@qt.io>
2018-11-14 13:50:24 +00:00
Orgad Shaneh
2f41f35952 Git: Make commit a bit less synchronous
If gc.auto is configured, commit can trigger garbage collection, which
takes time. Avoid completely blocking the UI on this case, and at least
show the output of the commit command.

Change-Id: Id301c878c26599bbc363928a6770c04369a62f2f
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2018-11-14 13:37:49 +00:00
Ulf Hermann
b8dcaa455e Tracing: Only call QFutureWatcher::setFuture() after connecting to it
Fixes: QTCREATORBUG-21485
Change-Id: Icc44cf0195775d31934a60cb064addc94b152d92
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-11-14 13:37:22 +00:00
Robert Loehning
efe30bc5a5 Debugger: Fix translation contexts
Change-Id: Id41ba15a4f0f5956148661e3c329cbb36a373f48
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-11-14 13:21:17 +00:00
Robert Loehning
6c267b34b3 CompilationDatabase: Don't translate qWarning
Change-Id: I5d7507fd05312e2d9b7ea57c94744aa311dc1104
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-11-14 13:16:01 +00:00
Eike Ziller
2bf9333e4c Fix Qt Quick wizards with Qt 5.12 / ECMAScript 7
The expression that we used either worked in ECMAScript 6, or only
accidentally worked in QJSEngine in Qt 5.11.

Fixes: QTCREATORBUG-21476
Change-Id: Id2ce0932ead24c8caef9a82b10a173dfdcf1e927
Reviewed-by: Robert Loehning <robert.loehning@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2018-11-14 13:09:07 +00:00
hjk
18e73a738b Debugger: Fix display of location marker when switching perspectives
Fixes: QTCREATORBUG-21362
Change-Id: I9bc1f0931ea902d04ab256774347b63c1fc64262
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-11-14 13:08:54 +00:00
Christian Stenger
deef478b38 Dumper: Fix activating frame for lldb
...when being attached to core file.

Change-Id: I4f8364285d756bae53b4a14ca8feb74f7fdaacfb
Reviewed-by: hjk <hjk@qt.io>
2018-11-14 10:09:05 +00:00
Oliver Wolff
a889f5021b winrt: Add categorized logging to device parser
Task-number: QTCREATORBUG-21366
Change-Id: I30dc7adc76a897fbed064123e5ef45d32bc552f2
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
2018-11-14 09:59:49 +00:00
hjk
4d3fe76796 Debugger: Add some labels to the preset views
In the hope to make it more obvious what the new views are all about,.

Change-Id: I3abde8a12cb5ac1f532f3b453c8d73f36498ff3d
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-11-14 09:47:52 +00:00
Ivan Donchevskii
e9d0083ccd ClangFormat: Do not format text but indent only
Provide the separate infrastructure for the formatting
but use it only when QTC_FORMAT_INSTEAD_OF_INDENT is
provided in run environment.

Fixes: QTCREATORBUG-21447
Fixes: QTCREATORBUG-21459
Change-Id: I1ad6fe23f5de17016c0c7b18749c6977fc03a22b
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2018-11-14 09:29:41 +00:00
Ivan Donchevskii
9a85ce88a7 ClangFormat: Use relevant settings for each file
Existing Clang Format settings may not follow the
project/global pattern but can be expected to be used
for the indentation/formatting.

So let's proceed with UI for global/project settings
but use global settings only if there's no configuration
found for the current file.

Change-Id: I87c25ab3feb7e2e3deb0290848088657783cf972
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2018-11-14 09:29:30 +00:00
Nikolai Kosjar
5b12ada2dc Clang: Fix completion icon for members in member init list
Change-Id: Ib02320dcf4de7cbb8ac6fbf29d1929edae77591a
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-11-14 07:38:19 +00:00
Christian Stenger
1bbac68e5d Designer: Fix crash on close
...when executing plugin unit tests for Designer.

Change-Id: Ic3252bfef4559de4e54f5c3c3fd1984ab6a00f9d
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2018-11-14 07:28:38 +00:00
Christian Stenger
aab60ee75c Debugger: Silence soft assert
Enabling or disabling a multiple break points that have
different states will trigger the soft assert for all
break points having the destination state already.

Change-Id: I61d859c0af548cb1dd9070a28c9aacee241e075b
Reviewed-by: hjk <hjk@qt.io>
2018-11-13 13:48:47 +00:00
Christian Stenger
c2422f4855 Squish: Fix using locator
Change-Id: Ifbc693439cbcd4146f1b18e67f1f1d6bc49162e5
Reviewed-by: Robert Loehning <robert.loehning@qt.io>
2018-11-13 13:48:39 +00:00
Tim Jenssen
406b84d246 reduce compression rate to save some RAM
Change-Id: Icc124948a5223294e90fa27b7c4cf5924bdab5e2
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2018-11-13 13:21:34 +00:00
Ivan Donchevskii
cc118a16e6 ClangFormat: Use the constant for the configuration filename
It is unlikely that this name changes but let's follow good
coding practices.

Change-Id: I12adbf155f26b1b3a02d07092fcc113e0c5157e6
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2018-11-13 09:21:30 +00:00
hjk
0ee07ae2ad Debugger: Make validateExecutable a validateRunParameters
Gets rid of the odd and otherwise unused
DebuggerEngine::mutableRunParameters() function.

Change-Id: Ib0861432e7c61072db2968acf2f36c7f2d56c89a
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2018-11-13 09:18:29 +00:00
Ivan Donchevskii
f876a71fa1 ClangFormat: Improve current style detection
Check first if the current project already has .clang-format
configuration file.

Change-Id: Ic8cb5d37c32cd5b0c04485589caea95de933c264
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2018-11-13 08:38:17 +00:00
Ivan Donchevskii
36f4ed54df CppTools: Simplify the currentProjectCodeStyle code
Use alias to shorten the repeating default return value.

Change-Id: I673fc1d293c1612c945c80d554c6667a756108de
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2018-11-13 08:29:36 +00:00
Ivan Donchevskii
cf816448ce ClangFormat: Set BreakBeforeBraces to Custom by default
If it's not set to custom some user settings are
continuously overridden which is not always expected.

Previously the default style caused some parameters
to be reset.

Change-Id: Ie0fedf6b9984116a86b7c588aed8c6b6cb35133e
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2018-11-13 08:17:54 +00:00
Ivan Donchevskii
41d68f469a Clang: Change dot <-> arrow if all completions require it
Return the behavior that existed before completion fix-its
were introduced. Apply it only for the cases when all
items require the fix-it.

Fixes: QTCREATORBUG-21367
Change-Id: Idc358255135f72353f3fd3204b653fc2fc55e7a0
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2018-11-13 08:17:19 +00:00
hjk
ad37ad1a86 Debugger: Fix cut-and-pasto
Amends c3f29684fab92a6b51dfaa59254a61c86ed4968a.

Change-Id: I19e7a9ce65780822f8a9718906acc68f6f7e7454
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2018-11-13 07:56:53 +00:00
Nikolai Kosjar
6cd6d8ef4e CppTools: Forward OpenMP extension flag
Fixes: QTCREATORBUG-21213
Change-Id: I986ab69bc44ece83a3b56f968cc3b6c3126e2c32
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-11-13 07:27:26 +00:00
Nikolai Kosjar
890b6e2540 Clang: Allow overtyping ) after completing function like snippets
Fixes: QTCREATORBUG-21166
Change-Id: I02e20a230012ce82aed668a46f5fd4a02796135b
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-11-13 07:27:19 +00:00
hjk
6a043d32dc Debugger: Fix handling of some actions after multiinferior split
The pattern used is some inactive/invible global action with a
command to put in the menus, and per-engine action "overloads"
to reflect the active engine's state once there is an engine.

Task-number: QTCREATORBUG-21454
Change-Id: I861a42994849ef9f0b51fb7b1608f14fa7fa9d7c
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-11-13 07:16:37 +00:00
Leena Miettinen
9dc8b4626c Doc: Change a link to a previous page
The page is now automatically generated, so the title
needs to be used instead of the filename.

Change-Id: I3363792466082a14a10b32ab9f98b2b24c0e856a
Reviewed-by: Brook Cronin <brook.cronin@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2018-11-12 15:19:03 +00:00
Christian Kandeler
dcd73452b5 Update qbs submodule
To HEAD of 1.12 branch.

Change-Id: I1711d2c5fb40f77858ce0bdac990822fbb568ef4
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2018-11-12 14:46:28 +00:00
David Schulz
12f4ff5e5b Debugger: Fix Qt version detection in the cdbbridge
broken by b2052561cc

Fixes: QTCREATORBUG-21446
Change-Id: I303bb943a3b39703a6c5898aab99b89d35d1d2d7
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2018-11-12 14:09:52 +00:00
David Schulz
dd350d1955 Debugger: Fix fetching memory
Do not dereference function parameter in async callback.

Change-Id: I9a6cebdc59579f230a5f570969c9cd1c6417edfc
Reviewed-by: hjk <hjk@qt.io>
2018-11-12 12:40:16 +00:00
hjk
402991498f Debugger: Fix assignment to QString etc with LLDB
Task-number: QTCREATORBUG-21353
Change-Id: Ie3655738c249240d9fbf17e054fc8f79a284efd4
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2018-11-12 12:31:46 +00:00
hjk
8fc3452e48 Debugger: Do not pretend
... the preset perspective had an associated debugger.

Change-Id: Icf4f07c5e184530e9c3cee920dcbff9b66066c31
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-11-12 09:52:59 +00:00
Orgad Shaneh
9c7ac5e26a SerialTerminal: Select text in input line after each command
Makes it easier to type a different command.

Change-Id: Ica152575f2f5130a8f2da75379403841aba89176
Reviewed-by: Benjamin Balga <balga.benjamin@gmail.com>
Reviewed-by: André Hartmann <aha_1980@gmx.de>
2018-11-12 09:37:22 +00:00
Ivan Donchevskii
8dc566e902 CppTools: Allow to check whether project code style exists
The calling code can anyways fallback to the global style
without extra help if no project style exists.

It is useful when you want to get the project style if it exists
and understand at the same time that it is not a global one.

Change-Id: I265de3f436f90623385427fc8a1abad09c8c3577
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2018-11-12 08:56:20 +00:00
Christian Stenger
1787eef68f Dumper: Fix handling of bitfields for MinGW
Fixes: QTCREATORBUG-19742
Change-Id: I8723da875607e00a833cd5a1ccb748e7f8ed4314
Reviewed-by: hjk <hjk@qt.io>
2018-11-12 08:51:49 +00:00
Orgad Shaneh
ea10f4d9da Increase QT_DISABLE_DEPRECATED_BEFORE to 5.9
Change-Id: I16b1fe72a9f9b87a8e7676a1591a5254d4005fad
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-11-12 08:29:24 +00:00
Ivan Donchevskii
868c8e31d5 ClangFormat: Fix crash on exit
Was introduced in 0e5c7f51fa with the page being deleted
to remove it from the global list of pages.

Change-Id: Ia13f7ab74d85b5b8c66f1b20e33d97c29ce3e8f1
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2018-11-12 08:09:00 +00:00
Orgad Shaneh
910724f963 C++: Add some missing overrides in Bind
GCC8 warns about hidden overloads.

Change-Id: I67582e2486741d4edaf600e84a71c8c926996d07
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2018-11-12 07:11:45 +00:00
Orgad Shaneh
423b7391dd Debugger: Remove unused function declarations
Amends 3b5ecac238
and 36b654567d.

Change-Id: I8e8b226f34297ec4d34edbcc63b93d0f5045bcf4
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2018-11-12 06:40:27 +00:00
Orgad Shaneh
0ccc1dbf8f Remove unneeded member initializers
Change-Id: Ie68b15079d93c48c5027871743c88d9e051e3fbe
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2018-11-12 06:37:50 +00:00
Orgad Shaneh
8ab67ef24e Debugger: Fix MSVC warning
sourcefileshandler.cpp:127: warning: C4573: the usage of 'QObject::connect' requires the compiler to capture 'this' but the current default capture mode does not allow it

Change-Id: Ic8ab7de11a91727dffac91d37b1b82e7ea933b65
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2018-11-12 06:32:38 +00:00
Orgad Shaneh
0f6fcd09de GenericHighlighter: Update from KSyntaxHighlighting
Change-Id: I0ec59359c7f8670a048dfc35264d6ab64bc62ceb
Reviewed-by: David Schulz <david.schulz@qt.io>
2018-11-12 06:30:34 +00:00
Robert Loehning
e6eb0bc032 Fix typo
Change-Id: I0bdf5a3d3313ee9eaf0967e054d5a6c4029eecc5
Reviewed-by: André Hartmann <aha_1980@gmx.de>
2018-11-09 16:29:51 +00:00
Eike Ziller
663d799166 macOS: Fix that Preferences do not work with german translation
By default Qt does heuristics on the menu item text, to decide the menu
role of an item, including whether the item should be used for the
Preferences entry in the application menu.

Now, "QML Profiler Options" is translated to "Einstellungen des QML-
Profilers" which matches the heuristics for the "Preferences" item,
replacing the actual Preferences.

For menu items we already force the menu role to NoRole if there hasn't
been a role explicitly set. Do that for the generated menus as well.

Change-Id: I4abb3f20fd51ef033e5ec68c2283af8b7b52927d
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2018-11-09 14:15:45 +00:00
Christian Stenger
3068bd3b80 Macros: Disambiguate short cut
On an English keyboard Alt+( and Alt+) are basically
the same as Alt+Shift+9 and Alt+Shift+0.
On Windows and Linux these are already assigned to
(more prominent) actions, so re-assign macro recording
related short cuts.

Change-Id: I1057a08a617adf8027e28936feeb6347fbeb2c4e
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-11-09 13:44:15 +00:00