Commit Graph

57165 Commits

Author SHA1 Message Date
Orgad Shaneh
7fdf1b84b7 Bazaar: Modernize
override, auto, nullptr

Change-Id: I052bc2759f61129c0185e3ae196de73bf22024c5
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2018-09-20 05:28:28 +00:00
Andre Hartmann
260750cc24 Git: Disable branch view if no git repository found
Also provide a proper label like the old branch dialog did.

Change-Id: I78490f66ccbc6bbc58117ea86030d7c1450f8329
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2018-09-20 04:42:32 +00:00
Orgad Shaneh
c415a03cea Git: Support move/copy detection for blame
Fixes: QTCREATORBUG-20462
Change-Id: Ib2ea14de6a60691a1ed27cd07aac282557d69015
Reviewed-by: André Hartmann <aha_1980@gmx.de>
2018-09-19 20:16:23 +00:00
Orgad Shaneh
202d40f256 Git: Modernize
* Use auto
* Use override
* Use some member initializers

Change-Id: I3ca000d1c8e4d02331d58b85e68e4d771c636b29
Reviewed-by: André Hartmann <aha_1980@gmx.de>
2018-09-19 19:47:07 +00:00
Orgad Shaneh
c83b5afa9b Debugger: Support core input in custom thread names
GDB doesn't provide thread-core on core dump debugging.

Give the user the option provide it.

Change-Id: I15eae0280243ce307b9045be33e4b28e9b9c64d0
Reviewed-by: hjk <hjk@qt.io>
2018-09-19 17:07:26 +00:00
Orgad Shaneh
296ae92853 Git: Change pull to run asynchronously
Fixes: QTCREATORBUG-13279
Change-Id: Idee6e64e5eebe729e7c1d0e0135a1d8b464187b7
Reviewed-by: André Hartmann <aha_1980@gmx.de>
2018-09-19 17:02:24 +00:00
hjk
8dfa977f2f ProjectExplorer: Move Base{Bool,String}Aspect to new files
Create projectconfigurationaspect.{h,cpp} for re-usable aspects.

Also pimpl the two exported classes.

Task-number: QTCREATORBUG-19985
Change-Id: Id1d44b551c5dc2cf6eb4fbc3a2a505d4a83ae53f
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2018-09-19 13:46:26 +00:00
hjk
d05e906bac ProjectExplorer: Replace virtual BuildStepConfigWidget::showWidget
... by a bool member.

One reason less for the need of custom derived classes, i.e. one
step forward to a setup where the then-generic config widget can be
created in BuildStepListWidget::init() and filled with aspect-
created subwidget, reducing the need of per-BuildStep boilerplate
similar to what was done in RunConfiguration recently.

Task-number: QTCREATORBUG-19985
Change-Id: I85d26bdb6b35d0d6715782214328a40eef87286e
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2018-09-19 13:25:06 +00:00
Ivan Donchevskii
641c9f7db9 Clang: Add compiler name to each compilation database entry
In all examples there's a compiler as a first argument.

Change-Id: I37ec4073254d68f29357e9b2447a035a1b15e02f
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2018-09-19 13:07:54 +00:00
Jarek Kobus
4669563836 Remove qDebug()
Change-Id: Ie951201ae2cea355e0118cc36c69fdf2cff5c26b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-09-19 12:44:20 +00:00
hjk
253f7e35af RemoteLinux: Use aspects in RemoteLinuxCustomCommandDeploymentStep
Change-Id: Idb25506c172f7300d3485fd8dcfda231e5351532
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2018-09-19 12:36:58 +00:00
Ivan Donchevskii
c99fb5d0bc Plugins: Add compilation database plugin
Introduce compilation database project support.

Pass the arguments list for each file directly to
ClangCodeModel via extraCodeModelFlags therefore
introduce a dependency from the ClangCodeModel plugin.

Change-Id: Iea5760d379de1ea246382dce56de0adf7ab5673d
Task-number: QTCREATORBUG-21115
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2018-09-19 12:11:36 +00:00
Eike Ziller
8195c60917 LSP: Fix lagging behind "documentHighlight"
We highlight the current symbol on cursor changes
(="documentHighlight"), but when the contents change the text editor
widget first informs us about the cursor change, then the content
change. This resulted in the highlighting being done on the old content.
Delay the symbol highlight by a short amount of time, so it always
operates on the new content.

Change-Id: Ic24b2a853697c588ae73b102868e8f74e4437606
Reviewed-by: David Schulz <david.schulz@qt.io>
2018-09-19 11:25:12 +00:00
David Schulz
ba5f93003e LSP: correctly shutdown client that is currently being restarted
Change-Id: I9fb0ccd9aa181515efc9368b0b369dfc39dffcd1
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-09-19 10:44:58 +00:00
Nikolai Kosjar
a376469eb6 ClangFormat: Add projectexplorer dependency for qmake
Change-Id: I5b1cc7ab62840e1bf070edd1ad95659555883317
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-09-19 07:55:21 +00:00
hjk
982a019bfb Debugger: Rename MainWindow::{set,add}SubPerspectiveSwitcher
We'll need another one for GammaRay, and it's practically already
working as 'add', not 'set'. So fix the mis-nomer.

Change-Id: I1713ced6c39082dae0121b8d670c4676807c1602
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-09-19 06:50:05 +00:00
Eike Ziller
6ea686faa9 Avoid accessing global font settings from syntax highlighters
Change-Id: Ic015f7449351166ec41a7745355ddc63504f6442
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: David Schulz <david.schulz@qt.io>
2018-09-19 06:36:55 +00:00
Eike Ziller
dd0347d1ee Merge remote-tracking branch 'origin/4.7'
Conflicts:
	src/plugins/qnx/qnxrunconfiguration.cpp

Change-Id: I6069e6a644c6d50c3d2821d51c368129b6957017
2018-09-19 08:27:51 +02:00
hjk
0137e2ace9 Debugger: Do not guess kit when attaching using the app output pane
We have access to the kit that was used to start the project,
use that.

Change-Id: Ie73129d4ee4451f272ba7539c950409b5d9636af
Reviewed-by: David Schulz <david.schulz@qt.io>
2018-09-19 05:50:08 +00:00
Sergey Morozov
31b595314c Cppcheck: Add cppcheck static analysis tool
Automatically checks currently opened documents and displays results via text marks/annotations.

CppcheckTrigger detects when to check files or clear results.
CppcheckTextMarkManager stores/clears text marks with checks' results.
CppcheckTool generates run arguments and parses output.
CppcheckRunner runs cppcheck binary.
CppcheckOptions configures CppcheckTool.

Task-number: QTCREATORBUG-20418
Change-Id: I8eafeac7af6137d2c9061ae75d4a56c85b3b5a2d
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2018-09-18 19:07:12 +00:00
Alessandro Portale
20f3c8d654 Wizards: Remove Canvas 3D application wizard
Canvas 3D is deprecated from 5.12 on.

Task-number: QTCREATORBUG-21078
Change-Id: Icfd4d3651bcc3a9e65fcf52297ec173330f7b0c0
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-09-18 16:25:35 +00:00
Ulf Hermann
517e954ff1 QmlProfiler: Avoid some compiler warnings
If size_t is 32bit wide, any comparison to qint64Max is pointless. And
in order to compare a size_t to intMax, we need to cast intMax to
size_t.

Change-Id: Ida1945ca0cd8865b8d8620c8b23b7e21a20dc43c
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2018-09-18 13:47:37 +00:00
Eike Ziller
755cc3680d Subversion: Fix missing override
Change-Id: I3f564f93afc94b2186794684356b82d2a16cf461
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2018-09-18 13:15:49 +00:00
Eike Ziller
922e506296 QmlJSEditor: Fix missing override
Change-Id: I617d7363779b30c882ce96b08e56c74f3cb1df96
Reviewed-by: Marco Benelli <marco.benelli@qt.io>
2018-09-18 13:15:31 +00:00
Eike Ziller
9a3fe812f9 CppTools: Fix missing override
Change-Id: I6ee424a844ce2657516258033764ef557a424830
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-09-18 13:15:17 +00:00
Ivan Donchevskii
9c7d546c14 Clang: Fix possible out of bounds access in ClangFollowSymbol
Change-Id: I80132dca9c26a54059f2c1ba872b102df8e6e0d7
Reviewed-by: hjk <hjk@qt.io>
2018-09-18 12:49:56 +00:00
Tim Jenssen
dbd7f4935b QmlDesigner: add const
Change-Id: I90da9c2222b42f7419f16bd285ba57dadb5a8a18
Reviewed-by: Knud Dollereder <knud.dollereder@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2018-09-18 11:24:49 +00:00
Eike Ziller
fa50153fc8 Qnx: Fix passing path to Qt libraries on device to run configuration
The line edit was gone.
Broke in 4b9945c329

Task-number: QTCREATORBUG-21100
Change-Id: Ib341df783d6b8060226863637c65f081635deaf0
Reviewed-by: hjk <hjk@qt.io>
v4.7.1
2018-09-18 08:30:26 +00:00
hjk
56e1849e94 ProjectExplorer: Remove some QLatin1String
Change-Id: I022cb89fac7932180eeea1e909816f22f5ba359f
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2018-09-18 07:23:44 +00:00
Orgad Shaneh
757c230f21 Clang: Fix "unhandled enums" warning
Change-Id: I5eb844b2599f3657b72f5f262b5d708f9fc593ac
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-09-18 07:16:32 +00:00
Ivan Donchevskii
658e308f68 Clang: Use built-in paths knowledge to better place clang include path
Clang include folder should be a part of built-in includes
and always come after user and system includes.

Change-Id: I22961ea3bbb018f41b49f42c6ff7d22eb591ad01
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2018-09-18 06:57:01 +00:00
hjk
760723f763 ProjectExplorer: Add BuildStep::createConfigWidget default implementation
This starts the same process as done for run configuration widgets:
Add an aspect based default implementation and base build step data
handling on aspects.

As first example use the RemoteLinux::GenericDirectUploadStep

Change-Id: Ia2d1fcd393e667094b7852371b893d8356c3eace
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2018-09-18 06:15:35 +00:00
hjk
83a8b8bf8f Debugger: Do not count not matching test as failed
Change-Id: I37a109915426d17b65ab0782e90f238a5da94a1c
Reviewed-by: David Schulz <david.schulz@qt.io>
2018-09-18 06:13:43 +00:00
hjk
d421bc2fe3 ProjectExplorer: Split IRunConfigurationAspect
... into items that can be used generically in project configurations
(ProjectConfigurationAspect) and items that have a choice between
global and project settings (GlobalOrProjectAspect)

Change-Id: I94831237bdbb18c339eb76eba131bf7f928933d6
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2018-09-18 06:13:21 +00:00
Orgad Shaneh
d9275913d3 Debugger: Fix crash when starting with expressions
Task-number: QTCREATORBUG-21087
Change-Id: I9d98bb045504d91964f4dd33ad042adba6a128ba
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2018-09-17 13:40:09 +00:00
Ivan Donchevskii
eeece5b5ad Clang: Skip built-in includes when exporting the compilation database
We don't want to have compiler-specific paths there.

Change-Id: If26434ea3760d4f2ca4c25bbcf0340f4ea781072
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2018-09-17 13:13:16 +00:00
Ivan Donchevskii
0bd095aa45 ProjectExplorer: Rename compiler includes from System to BuiltIn
System include are those used with -isystem keyword, built-in
includes on the other hand come from compiler and always
follow in the end of the include list (after system includes).

Change-Id: I95c2fec36d2e5b43f014fe0a88d59c6769edfa1f
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2018-09-17 11:24:32 +00:00
Ivan Donchevskii
3170d05087 Clang: Do not use -isystem in ClangCodeModel
Some other logic in the options builder is based
on the -I usage and also we don't want to lock any files
with ClangCodeModel.

Change-Id: I4338abed26e91ebb0a561d449328ea0954fe44ea
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2018-09-17 09:22:52 +00:00
hjk
e507abf6a6 Debugger: Use new CheckSet infrastructure in AnonymousStruct test
Change-Id: Ib3e2ea2ab8a70ebfe94d80a0b0bf4b57fdb9027a
Reviewed-by: David Schulz <david.schulz@qt.io>
2018-09-17 09:22:23 +00:00
hjk
0e1dcc2eb7 ProjectExplorer: Add default value handling to BaseBoolAspect
Will be useful e.g. for "Incremental deployment" in RL's
GenericDirectUploadStep.

Change-Id: Idb07db2d9f075cda8f4cbb905f1e04fc24342ce0
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2018-09-17 08:56:11 +00:00
hjk
c3433519a6 Debugger: Add an explicit QObjectConnectionList dumper
Mostly for sanity reasons when debugging the QObject dumper itself.

Change-Id: I7d6267625f091788e73b0b28695e9b99e33ab3e3
Reviewed-by: David Schulz <david.schulz@qt.io>
2018-09-17 08:53:43 +00:00
Andre Hartmann
1d933953a4 Git: Fix columns visibility in branch view
The date column was always outside the visible
range and could only be reached with scrolling.

Change-Id: Ia690a4276f1b489b1f05c0d7f251b575509c9854
Fixes: QTCREATORBUG-21081
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-09-17 07:33:21 +00:00
Orgad Shaneh
eee2245972 LSP: Fix MSVC warning
implicit size_t -> int conversion.

Change-Id: I92afe6c984bc07d27bf9cded00400b1a614c6b4f
Reviewed-by: David Schulz <david.schulz@qt.io>
2018-09-17 06:32:54 +00:00
Andre Hartmann
487e2f5d04 Git: Fix warning in branch model
Change-Id: Ia36c91bfc2cd738cf16548f5044b1535de39a88d
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2018-09-16 20:24:32 +00:00
Andre Hartmann
8c8f166535 Git: Add fetch to branch view
Allow fetching from a single or from all remotes.

Change-Id: I2e0e69a092c3a8bb58f65af877c9af8bb59c92d9
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: André Hartmann <aha_1980@gmx.de>
2018-09-15 19:05:23 +00:00
Andre Hartmann
62072903b0 Git: Remove unneded qualification to Core
Change-Id: Ide8e7010410fe8184d9ef4dd37ddbf77ff5f1edf
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2018-09-15 17:55:05 +00:00
Andre Hartmann
fc36a0b5bd Git: Switch to edit mode when branch view is requested
The branch view is shown in the right side bar, which is
not visible in debug mode, for example.

Task-number: QTCREATORBUG-21088
Change-Id: If8fcab7a0b21d82534935bc555b79d1571d37633
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2018-09-15 17:54:52 +00:00
Andre Hartmann
758f9cfef7 Git: remove superfluous curly braces in branch view
Change-Id: I649c8835d5a4eb30d1f77cfd3e9da33fe017ec9f
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2018-09-15 17:31:00 +00:00
Andre Hartmann
673d22b8e3 Git: Improve branch view reload icon
Change-Id: Iaef65946130ab35f4c9b25deabc5b8829975c8cf
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2018-09-15 17:29:15 +00:00
Thomas Hartmann
417f020466 QmlDesigner: Do not show errors if clipboard contains invalid QML
* Do not show errors if clipboard contains invalid QML
  * Reduce updates of actions

Task-number: QDS-198
Change-Id: I072b197d44637b0545e509af03cc75a46f90150a
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2018-09-14 12:58:35 +00:00