As it already exists in the qmake project manager.
Task-number: QTCREATORBUG-20411
Change-Id: I8673e091b3f5772fdc1ddcac0e567f690960f1dd
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
The patch that removed Qt4 completely from the widget app wizard
has been reverted.
Adjusting the tests now.
Change-Id: I0af1eb2102caa22022658d1189794c7757c7628f
Reviewed-by: Robert Loehning <robert.loehning@qt.io>
Each completion coming from libclang now has it's own
list of fix-its which are required to be applied before
completion itself.
This saves one extra reparse cycle and gives an ability
to provide both kinds of completion (initial and corrected
one) for cases like shared_ptr, unique_ptr or any other
class with overloaded arrow operator.
Each of these extra fix-its is applied together with
corresponding completion dircetly before completion itself.
Change-Id: Ide37e45bb15fa2f1375cd6b86ecd43ced3593046
Reviewed-by: David Schulz <david.schulz@qt.io>
This reverts commit 1a6522b47c
which leaves people wondering about their kit setups.
Creating a project that possibly does not compile due to the
use of C++11's nullptr in the generated code is lesser evil.
Apart from that this potential mis-compilation does not
happen in practice on e.g. Ubuntu 18.04 with system Qt 4
and system compiler.
Change-Id: Iaa90f225d5317dc48428aa2d3fcf3ec051ef2018
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Fixes the following warning, and connections to these signals:
QObject::connect: Cannot queue arguments of type 'FileName'
This amends commit 7cee991c70.
Change-Id: I95e81fd9c328759daec29bf35c4b953983387d30
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
A empty path segment in LD_LIBRARY_PATH is *not* ignored and treated
as '.' IIRC.
So make sure to not leave a ':' in first place of LD_LIBRARY_PATH or set
an empty LD_LIBRARY_PATH on Linux.
Change-Id: I99ec2e333c6c0205334daf14ac6a2373c6e465ad
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Instead of qobject_cast use the reacently introduced virtual function
BuildConfiguration::regenerateBuildFiles() to trigger the necessary
work in the qmake case.
Change-Id: Ie5fd36550b5bad8c5f3f8bb1e2a3a16843f8f5b7
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
Always save on exit, but do not expect a valid perspective name
on restart. The settings could get corrupted in the mean time etc.
Change-Id: Ic0181607f46c3350a4193240d795d4c0d7c6815b
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
The code there does not build anymore, so remove it.
Change-Id: Iff3f6c334e9a72e1764e3431b93cfd5b8a4ae98c
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Cancel processing the environment diff only if the setenv scripts return
a non zero exit code. Just checking the presence of standard error
output seems to be a to aggressive error checking in this case.
Task-number: QTCREATORBUG-18328
Change-Id: I9243932cd5721cfbfec5a980a2fab6e69f4c31c7
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
They are triggered a lot in Clang headers.
Change-Id: I31f31a4f52e269d773cf1b41ad52f279ee368c2e
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@qt.io>
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
This essentially replaces saveCurrentPerspective by some
savePerspectiveHelper(m_currentPerspectiveId)
This is in preparation of the change introducing multiple running
engines, and per-engine perspectives.
Change-Id: Ibdbdac019bb5d47936ba4ab5de08711f2c16ea99
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Judging from the code it either never worked, or LLDB changed
syntax at some time. In either case, having it in a usable
state with current version is an improvement.
Change-Id: I88b15969bf28b92735d860544dedcbd1d9689765
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Many issues, mostly in headers, were not addressed in
e38410b76c
modernize-use-auto
modernize-use-nullptr
modernize-use-override
modernize-use-using
modernize-use-default-member-init
modernize-use-equals-default
Change-Id: I320a51726db881e582b898948d53735ebb06887a
Reviewed-by: hjk <hjk@qt.io>
It will be needed later to show/hide the buttons depending on
engine-specific abilities or other circumstances.
Change-Id: I029012e01929e5e96e2af87da2cf3580a8d82b3f
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Newer versions of QML will support proper changing of break points, we
won't need to work around it anymore.
Task-number: QTCREATORBUG-20795
Change-Id: Idb5aaeb8ea59c7d2fd7c924e336ea259d3573d3d
Reviewed-by: hjk <hjk@qt.io>
Call make qmake_all in the same directory that qmake was run in.
This fixes long build times when doing builds of individual targets.
Qmake is run in a child folder there, but make qmake_all used to be
run in the top-level source directory instead.
Task-number: QTCREATORBUG-20823
Change-Id: I42e77738b0a92469efb97720cabea26484fb4852
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Use unique_ptr to manage m_writer in KitManagerPrivate.
Change-Id: Icc58728feb57a88a229d6da8b2d29bac53c2f6cc
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Use unique_ptr for all *Private classes, except for those
in singletons.
Change-Id: Ib56c31ddedc6e9cf321f15de1f1e697a27ad4089
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
This allows to run any command without knowing the current state of the
debugger engine. Replacing the old special stop mode for any command
that may be triggered while the engine is running, with a check in
runCommand. If the engine is running while a command is triggered a
callback is added to the interrupt that will execute the command as soon
as the engine is accessible again.
Change-Id: I8bb1914b92da2b03e76c2c2ec8293d13041c72fd
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
