Store the kits on load in the order expected when trying to pick a
default kit and get rid of the code that garanteed that via two
temporary lists.
Change-Id: Ib823263c6070d0524885e5bb7f168cc479d98e0b
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Add a quick check whether the variable is set and return nullopt
in that case. Flip the check in the below code.
Change-Id: I655662f2940946150165107a66c003a3a4bc025d
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
With newer Qt versions. These want to run cl.exe on Windows, which
usually is not on the PATH except for the build environment.
So, use the current build environment's PATH if that is available
(falling back to the system environment's PATH).
Task-number: QTCREATORBUG-19892
Change-Id: Ia512b3599d2cca7a0d1169b0d673f32158cb701f
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
By reducing the width of the individual items.
Otherwise first startup looks a bit stupid with a large empty column to
the right.
Change-Id: Iff7fa343a5c36181f09e1e3c18307dc55bd11abc
Reviewed-by: hjk <hjk@qt.io>
The debugger will treat any value you put in there as string, and then
fail to update the item because it doesn't expect the type to change.
Proper editing of JavaScript objects requires quite a bit more UI than
this, so disallow it for now.
Task-number: QTCREATORBUG-20736
Change-Id: I7bf6e7a3747cde3c6682b66aaa810291f753e85d
Reviewed-by: hjk <hjk@qt.io>
If an expanded object is updated we typically just get the ref for it.
If we leave the tree item at "wantsChildren", the debugger will think
that the update fails and "adjust" the "child expectation" to none.
Fetching the children right away takes care of this.
Task-number: QTCREATORBUG-20736
Change-Id: I1b3725e7106a563198962915cbcab8f68ef741a6
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
The built-in code model also proposes "void_t".
Change-Id: I2462e47d5b1a69065f998244fc8372011e37a0c8
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
%1 contains line breaks and bullets. Having quotes around it is pointless.
Change-Id: Iced4bd6efcf60b1005fcd560ea773e208a0df997
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Do not send endRemoveRows if we never sent beginRemoveRows.
Fix up of 702d6a6914
Task-number: QTCREATORBUG-20741
Change-Id: If22a18e6426c8b4041924a170d5927ab9d11ccdf
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
When adding existing untracked files to a project, and choosing to add them
to Git, error messages appeared in the output pane.
Change-Id: Iba639a678d2ca424fb32b34b218fca1c4b99971d
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
Append methods and class members with the scope they belong to
extracting the parent name. It was like that in old code model.
Example:
namespace Foo {
void Bar::function() {}
}
Old result:
Foo
function() -> void
New result:
Foo
Bar::function() -> void
Change-Id: I9dad86a6738baafb1a210c5e1146d8de33828c44
Reviewed-by: David Schulz <david.schulz@qt.io>
They do not bring any value.
Task-number: QTCREATORBUG-20716
Change-Id: I2876f0e1e3918cb33d133b4a65ccaefd9bd30ac8
Reviewed-by: David Schulz <david.schulz@qt.io>
Fix the order of signal handling, which was changed in
a5935cb27a
but leads to this crash.
The connection to the DesignMode instance still needs to be
delayed to after it has been created in Core plugin's
extensionsInitialized, so do the final initialization as a reaction to
ICore::coreAboutToOpen.
Task-number: QTCREATORBUG-20495
Change-Id: I92d9a4ff689d2f191d2fd368966ca582bf8af2f7
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Save the state before child widgets are affected.
Task-number: QTCREATORBUG-20721
Change-Id: I1d0d1ca610b0a8e8904585953ecbb42dddee4827
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
IPv6 enabled systems can have IPv4 and an IPv6 entry for localhost
and macos seems to prefer IPv6 for localhost and IPv6 is not
supported by adbd
Task-number: QTCREATORBUG-20730
Change-Id: Ia0823fa04581afc6297e5e8d57a8034ba1b5749c
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
It is unused and can not really be used in a safe way, so let's
just remove it.
Change-Id: I7926d1781f8f61d00fc3c516b8d1e2a01164a85a
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Make runBlocking handle the case where the process starts up too fast
for waitForStarted.
Change-Id: Id8f3522c7c23bc8d7cdbbc94da6fa6c0b8e45454
Reviewed-by: David Schulz <david.schulz@qt.io>
Currently we only check if it's in the registry which
is not the case when you have a custom build.
Change-Id: I20ec25378d16996f790726ed14238861bc220004
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
The build directory can be "empty" if there is no build configuration,
or if the build configuration's build directory is empty.
Handle both cases in the same way.
This avoids passing an actually empty build directory to the parser,
which the parser does no longer handles gracefully on Windows.
If the build directory is empty, use the project's source path (instead
of QDir(QString()) which is the current working directory), which makes
it consistent with the behavior when actually building in that case.
The parser does not actually write files to disk, so there is no issue
with temporarily using that directory and later switching to a shadow
build directory.
Task-number: QTCREATORBUG-20121
Change-Id: Ia454085edae6b55b445cc5cf0ec3ae1c85464b0c
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
By accident uncrustify's option page got kicked during a refactoring. This amends 9a7e7f7d4.
Change-Id: I27aba7bcf689b20763446fd445f4855050669865
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Do not rename documentation qhp file. The documentation qmake files
currently depend on the files having the same base name as the qdocconf file.
Also do not change the documentation namespace. There are places where
these are mentioned in translated strings.
Fixup of 54208113ee
Change-Id: Iace171535ea5be6e22fec9760a5d96722b052341
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Shift is a common modifier and we should use it
to limit changes to one axis (e.g. x), since this
is a useful and typical usage.
We moved reparenting to CTRL+SHIFT. It has issues
and can trigger crashes. Still it can useful
and it is unlikely to be triggered randomly/by accident
on this shortcut.
Task-number: QDS-7
Change-Id: Ieeac6323659d5bd95bd27a05b8e18808ecdf390b
Reviewed-by: Brook Cronin <brook.cronin@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
This reduces noise in the source control system.
Task-number: QTCREATORBUG-20686
Change-Id: Icf7d0d5b1af288f3518594233086917f039a47a0
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
