The color was not renamed in this inline css.
Change-Id: Ib23977fcc9f3c5925ef5183dba0fc2c0216ab465
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Margins and layout style widely differ so far. Start moving everything
to a QFormLayout with the same margin and growth policy.
Change-Id: I0bd1d8b2ec9830be56354be1376a2a24eebb8845
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Since all resources in Qt Creator get merged together at runtime, they
should be prefixed with the library/plugin name.
Change-Id: Iacd2aa748e68ac9f8c61b77a4af1db9d03f3f9d2
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Some entries were duplicated. Fix fallout in gcc toolchain test
caused by this change.
Change-Id: I63c7a5fdba93e903888b2daa99a87e0a07c28acd
Reviewed-by: hjk <hjk@qt.io>
Though it should not happen that a toolchain is missing the triple
but in case the detection fails a new toolchain shall be created and
the misbehaving toolchain should be deleted
Task-number: QTCREATORBUG-20217
Change-Id: Iaa86331730f82b8e5abd37f1184a53d1e1312979
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
Rendering disabled nodes using the disabled state in the painter
breaks themes as it introduces a discrepancy between the actual
state of the node and its graphical representation.
IIRC this was introduced since there was no easy way to find what
color was supposed to be used for disabled items. That is no longer
the case, so let's clean this up.
Change-Id: Ic5653cd970e07eb680cb1d28d1feefd70aded540
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Use ArgumentAspect and WorkingDirectoryAspect.
Use base convenience functions to set up configuration widget.
The RunConfigWidget base is not needed for the main frame.
Make the run config display names consistent.
Display remote exe (which is the main thing) above the local
exe (which is only a helper to get debug info).
Change-Id: I9a47dc9ea27e6abd96bb75a3103ebc8ba35069c0
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
We were not reset a statement if we got an exception. There are now test
for it.
Change-Id: Ife7b4437fece9369767605ba7387bd0564c1bb8d
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
An unique index is prevent double locations in the database.
Change-Id: I167cafe1a707dd8a8a9754b8d69790a8382f4eea
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
we must not add the llvm libdir if it's a system path. this was already
done in some places, but not in others.
while we're at it, re-shuffle some pre-existing conditionals to make
things consistent.
Task-number: QTCREATORBUG-20178
Change-Id: Ib7e5a81705494e4cf2f83a4782ecd0832b91e511
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@qt.io>
The icon is not used anywhere and the :/utils/images/darkclose.png it
depends on does not exist.
Change-Id: I3f2bd5e4cd13ad4d19baf9e691897b81cd3b0629
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
In case such icon will be needed at some point, we will recreate it
themable and HighDPI-able.
Change-Id: Icf34617fa71eb35406bbc10daaa700a823671061
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Some translations moved over to the corresponding RunConfigurations,
one setParent() replaced by direct deletion.
Change-Id: Ib5e527b71353a6be70b332ac2dfd2f5cd2499a60
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Depending on the underlying project manager it can be
pretty expensive calling PE::canRunStartupProject().
AutoTest plugin used this to determine whether its
global actions should be enabled or not and updating
these actions is triggered for too many causes.
Replace this function call by some simple checks that
have almost no cost to avoid blocking UI.
Task-number: QTCREATORBUG-20175
Change-Id: I0e3cce683f33abe82bf1354ec5276250f5e30068
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Let the users forge a user file without injecting their environment.
Task-number: QTCREATORBUG-20097
Change-Id: Ia481f0f6d7c704d26b5f7d0f985f38dd39027f95
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
Otherwise when "this" instance
gets deleted and the sender still exists, the lambda
expression is still invoked for the deleted object.
Task-number: QTCREATORBUG-20223
Change-Id: Ifd5c9e6ce1fe7fde71698c6683cdfcd7566e8d35
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
No need to have a dozen lines of code in a separate translation
unit and more in line with what others do nowadays.
Change-Id: I765535d1484805bc3005fe23bfd4992a96a80e9c
Reviewed-by: hjk <hjk@qt.io>
No need to have a dozen lines of code in a separate translation
unit and more in line with what others do nowadays.
Change-Id: I029cac3d96b6a318be2cc4efad08badfae68fc20
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Try to minimize differences on sync
Change-Id: I9af325911b1a6a7635099cb3a5c778305e5e6223
Reviewed-by: Marco Benelli <marco.benelli@qt.io>
Reviewed-by: hjk <hjk@qt.io>
Detected by GCC8.
messageenvelop.h:83: warning: type qualifiers ignored on cast result type [-Wignored-qualifiers]
out << static_cast<const quint8>(messageEnvelop.messageType_);
^
Change-Id: I46ee5fb45b6ebc3c75475faa16cba66243a38fb3
Reviewed-by: hjk <hjk@qt.io>
The patch is mostly mechanical, but contains also a few spurious changes
from values references for some local variables, foreach -> ranged for
etc that I coulnd't resist.
Change-Id: I58f0bd972546895eb318607cbfbd7ac35caf3f23
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
This partially reverts 6e419d642a as the restriction is not need.
QNX + CMake is working fine.
Change-Id: I430c6e8c25f8975201892759abb20a52cb04e4a4
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
No need to have half a dozen lines of code in a separate translation
unit.
Change-Id: I7b611f3404d3db4a1f731b4bfa79bd560a2bf9f3
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Setting up the qbs run environment is not free, and the respective code
gets triggered from other plugins much more often than expected.
Task-number: QTCREATORBUG-20175
Change-Id: I6529718d20738140963486caef103d6d17958d50
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Purely mechanical, no visible/functional changes intended or expected.
- have one file pair for each set of config/factory/widget
- de-pimpl BareMetalRunConfigWidget, it's very local now
- use new wrapWidget convenience function for run config widget setup
Change-Id: Icd0df2bc7e206d6bf15d722f7eaa3b9fbee0b0fa
Reviewed-by: Alexander Drozdov <adrozdoff@gmail.com>
Reviewed-by: hjk <hjk@qt.io>
... in preparation of upcoming OutputFormatter creation reorganization.
Also, replace a raw string literal by a normal one to accommodate moc
and remove an unused member.
Change-Id: I416bb20afd891717fcb4f449955b4e46e5c05590
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
...to be able to parse type_traits of libstdc++ 7 without errors.
Task-number: QTCREATORBUG-18757
Change-Id: Ib76e233e77a58a9fb6761c733057dcc1d6c42ead
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
Register code/name combinations together.
Also make the otherwise implicitly preferred first entry
explicit in the API.
Change-Id: I80f68b01d53e2672480365d4efcb9d790b8363fd
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Double clicking an item will now rebuild the flame graph with that item
as root. Double clicking on an empty area will reset the root.
Change-Id: I16dd4b00d0dd09ff922a01acee67f0d553da6323
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Milian Wolff <milian.wolff@kdab.com>
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
It should not make a difference if an item is created in a state.
Change-Id: I788cb2aec758a42418a5939c2430074803a662db
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
