Add a "OK" button to the message box informing about a failure to find
any project file in the freshly checked out directory. That way the
user has a way to close the message box on Mac.
Task-number: QTCREATORBUG-10429
Change-Id: I9e1a4a2f368982dea2b0060f3f35dcb97d8936a3
Reviewed-by: Christian Stenger <christian.stenger@digia.com>
Remove timeout check (part of DeviceProcess now), react to the
DeviceProcess' error() signal, remove unneeded members, improve
messages.
What's left is a light-weight wrapper around DeviceProcess suitable for
run controls. Removal would result in identical boiler-plate code in
several places.
Change-Id: Ib306369df8dbf72dddb8ca305d256870a121dd63
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
This reverts commit 5be56c0 except for its tests. While it fixed the
problem described in the bug report, it also introduced regressions.
For now, we use a hard limit.
Change-Id: I19a85be454e3d7969371707e3eb1c3d42a16ecee
Reviewed-by: Przemyslaw Gorszkowski <pgorszkowski@gmail.com>
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>
People do not expect directories to be created as a side effect of
opening a project.
Task-number: QBS-304
Change-Id: I820a1311d534a4a76a4660588c4e9d71cc03f153
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
Those return a invalid QVariant, so handle that explicitly.
Change-Id: I50726552aeb76d21032c119c5ea2db48e6d88e8b
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
Invalid Ids are used to for "No Debugger", so do not try to fix
those values.
Change-Id: I141f969524e1faffa66a22c2a08ef18ec4d7fc23
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
Otherwise, qmake properties can be wrongly read as empty.
Change-Id: If63a306664758c01529b437fca30f5222b75f02f
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
This is a low level method which is not useful for normal usage.
Change-Id: I5fd1c019856a8a84299f5b11c159ea6b0f5131a9
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
While Qt Checkbox has a convenient api for setting a icon and a text, for
labels we need to do it the hard way.
Change-Id: I9e653b76b08357083a58b558afee5a2c74f1625b
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
The logic was reversed, fix it by calling updateControls() instead
Change-Id: I5433669c8fc5821b73aae0ab4b8e569571bc9b18
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
Also rename/change highestAvailablePlatform to highestAvailableSdk.
This fixes a bug reported on irc, where the lists for sdk and ndk
were different and the highestAvailablePlatform was not available
as in the sdk.
Change-Id: I17fec9e8ce1913e933ddcf8eaa21d6bb6e14c5be
Reviewed-by: BogDan Vatra <bogdan@kde.org>
The available platforms in the ndk might not be the same as in the sdk.
This patch is renames everything using the ndk platform list to
ndkPlatforms, except the highestAvailablePlatform which wrongly uses
the ndk platform list.
Change-Id: I02d9b68bbc27b0c748281678fe654d5f4244578d
Reviewed-by: BogDan Vatra <bogdan@kde.org>
besdtMatch finds a ndk version that is at most the targetApi passed into it.
Since we are passing in the fallback and lowest possible api level that qt
supports, the function would return at most the lowest supported version.
That's not very useful and cannot have worked, so simpy return the fallback
version directly.
Change-Id: I5e4757639099af4d207f928b0335d28efd75a02b
Reviewed-by: BogDan Vatra <bogdan@kde.org>
The snapshots at the moment of search were held as long as the
corresponding search result panel was kept, to allow mapping of the old
symbol to the corresponding symbol in the new snapshot.
Now we just save the file name and ID of the old symbol.
Change-Id: Iaf3c9ca27ec2b788f142bd0dd6b86e34e66d5c8b
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>
... use the current kit name instead (in case it was renamed since
saving the project).
Task-number: QTCREATORBUG-10401
Change-Id: If329d3441eb27a4322cb346849e4b73296d5bf88
Reviewed-by: Christian Stenger <christian.stenger@digia.com>
It introduced a warning:
SOFT ASSERT: "QFileInfo(m_settings.ccBinaryPath).isExecutable()" in file .\clearcaseplugin.cpp, line 382
on machines that do not have clearcase installed (which is the
majority).
This reverts commit d3bef1b088.
Change-Id: I7c5c599a9b2af175fd4d4c8d81b5c59dcbdffdba
Reviewed-by: Knut Petter Svendsen <knutpett@pvv.org>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Since the changed signal was moved from the editor to the document, we
now need to set up all the connections in the setupDocumentSignals.
Otherwise split editors, which get a different document after creation,
do no longer set up the right connections.
Task-number: QTCREATORBUG-10301
Change-Id: Ifc7b426abf87ab73ea37379c1a55e5af2005fc43
Reviewed-by: David Schulz <david.schulz@digia.com>
To solve displaying error of commit log with non-latin characters
in the commit description editor.
Change-Id: I8fd4ccdd82c0e5a286fe7d9f694b80915ef477ff
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
Paths passed to Qt Creator API must be cleaned. Make sure that the file
path that is opened from stack view and when stepping etc, is cleaned.
Task-number: QTCREATORBUG-10119
Change-Id: Iaac9b15e76cf8dff514889f201c4f65330145d16
Reviewed-by: hjk <hjk121@nokiamail.com>
Instead of actual file.
In case currentFile is a directory, it is cleared, and project top level
is used instead. This leads to unexpected results.
This patch corrects repository resolution in stash dialog when opened
inside a submodule.
Task-number: QTCREATORBUG-10397
Change-Id: I070cc7f9cbebe3be800dbbb9569cf73f540a6d14
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
Change the preprocessor popup to a dialog.
Save the additional preprocessor directives to the session instead of the
.pro.user file.
Change-Id: I0d08c5684cfb21e822cde0a965c9cf14e5d6d47d
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@digia.com>
This is the first phase of fixing bug QTCREATORBUG-10320.
This change resolves typedefs of template parameters(and resolves
problem with endless loop).
The next step will be matching appropriate template specialization
(this is needed to solve problem with missing code completion).
Missing matching: template specialization with the same parameters,
e.g.:
template <class T1, class T2, class T3>
class T
{
};
template <class T1, class T2>
class T<T1, T2, T2>
{
};
Task-number: QTCREATORBUG-10320
Change-Id: Icb6b539c021b2a67a66db9011a2e627f7d96526b
Reviewed-by: Przemyslaw Gorszkowski <pgorszkowski@gmail.com>
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@digia.com>
Do not trust kits with an invalid id, as there is no way those
could have ended up being saved out by creator. Safe all other kits
that were constructed using Kit(const QVariantMap &).
This new constructor uses the code that used to be in fromMap(...),
with some simplifications.
Remove fromMap(...) method from kit as it is no longer used.
Change-Id: Iac28ea9b85670e03088a4b7c5283af6b4b70c0fc
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
* show() is called with a QString reference to the model
* And editor is opened, which triggers stateChanged()
* stateChanged() updates StashDialog, which refreshes the model with an
empty directory (another bug)
* The QString name reference is invalidated => crash on access
Task-number: QTCREATORBUG-10397
Change-Id: I0c4077f8c4fc90905568f80d1cd89f61c4cd2cba
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
We cannot technically enforce a remote process to actually terminate,
but we don't want the associated DeviceProcess to "hang" forever.
Therefore, we now
a) check whether the kill operation reports an error and
b) start a timer after starting the kill operation.
If the kill operation either "officially" fails or does not have the
desired effect of actually terminating the process within a given time
frame, we set the DeviceProcess to "finished" manually. This is the same
thing that already happens when the connection gets lost, where we also
report the DeviceProcess as finished, even though the remote process
might still be running.
Change-Id: I5620f90453463c64d3a84abd30f1ec7eec9d492d
Reviewed-by: David Schulz <david.schulz@digia.com>
