We are saving anyway in extensionsInitialized()
Task-number: QTCREATORBUG-10455
Change-Id: I6cdc0f11a3f0f9db5061ef1c00646de4c3251d05
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
Removing the light border so it blends better with the rest.
Change-Id: I7fe5647b46fc20b960ae66fef5ade1ce7e4a2311
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@digia.com>
Moving the controls slighlt to the right.
Change-Id: I09a3599d88830367abd9caa6c1b62504c573b813
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@digia.com>
Until now std::vector::at() was used to access the elements. This is
handy for debugging since an exception is thrown for invalid indices,
but it does not stop Qt Creator from crashing because exceptions are not
caught.
This is especially a problem for the parser, which has to look ahead via
LA(n), which accesses TranslationUnit::_tokens.
With this patch, explicit bounds checking is done before accessing the
elements and thus calls to
std::vector::at() // bounds checking, throwing out_of_range
were replaced by calls to
std::vector::operator[]() // no bounds checking, not throwing out_of_range
Measuring the parse time for the Qt Creator project shows that there is
no slowdown. In both cases, with and without the patch, about 15s are
needed on the authors machine.
Task-number: QTCREATORBUG-10453
Change-Id: I32b12a526ff7199bcadfc21a3deb5354063a3e3b
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>
* Adding blue highlight for modified values
Change-Id: I8d68dc2e23a7c1c3d2055a5be13d7f57e94860ed
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@digia.com>
* Adding the ExtendedFunctionButton
* Adding blue highlight for modified values
Change-Id: I44f7d3bfbf58f0fe60321b5c696d3e3ba9c6578f
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@digia.com>
* Adding the ExtendedFunctionButton
* Adding blue highlight for modified values
Change-Id: I2035ebba61b27ec5c75f02abc3a435709cc69f43
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@digia.com>
Moved Document::Language, Import::Type and StaticAnalysis::Severity
enums to qmljsconstants.h and renamed values removing the redundant
part.
Thus the effective length changed little or improved
(Document::QmlLanguage => Language::Qml).
The separate file allows better reuse of enum values without introducing
circular dependencies.
Change-Id: I5186d7c04f5d3f6c289068b919be5ff1ff118326
Reviewed-by: Fawzi Mohamed <fawzi.mohamed@digia.com>
DebuggerItemManager::registerDebugger() should return the id
of the added debugger in order to use it when setting a kit's debugger
(addDebugger() creates and adds a copy of the passed
debugger object with a unique id).
The DebuggerKitInformation::setDebugger() method should set only already
existing and registered debuggers.
Task-number: QTCREATORBUG-10436
Change-Id: Icdcd1ed92aafe9eda44abf831aa9983dd6801980
Reviewed-by: hjk <hjk121@nokiamail.com>
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
This won't work without inferior calls (e.g. when loading core files),
so the old code is needed as fallback.
Change-Id: I1c9efc06374b00bc391bf55528546ccefc60349b
Reviewed-by: hjk <hjk121@nokiamail.com>
... and work around the pecularities on the dumper side instead.
Change-Id: I0c2703aae13dabc0f3f45efb46bd556c8741a15f
Reviewed-by: hjk <hjk121@nokiamail.com>
Contrary to the documention, using the default (i.e. 'on') it seems to _require_
xplicit casting of function pointers:
(gdb) p &Myns::QMetaType::typeName
-> $1 = (const char *(*)(int)) 0xb7cf73b0 <Myns::QMetaType::typeName(int)>
(gdb) p Myns::QMetaType::typeName(1024)
-> 31^error,msg="Couldn't find method Myns::QMetaType::typeName"
But we can work around on the dumper side. So let's use the default from now on.
Change-Id: I3e2a87df797c6abab6183b4c121b843e5035cd47
Reviewed-by: hjk <hjk121@nokiamail.com>
Prefer 32bit debuggers if possible though. In the setup Robert
used there is only a 64bit CDB and thus the debugger of his
64bit Qt was unset.
Add unit tests to make sure changes will not effect currently
working setups.
Task-number: QTCREATORBUG-10463
Change-Id: I4afae314bc75d4465dbc8de5b2a4267a521a4ea1
Reviewed-by: hjk <hjk121@nokiamail.com>
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
Note, that we don't know the names of the started avds, so we look
for a avd that has the same abi and apiLevel.
Task-number: QTCREATORBUG-10411
Change-Id: I5f6ff3ee0dddcf2bb8fca981ccedf437e32da677
Reviewed-by: BogDan Vatra <bogdan@kde.org>
Dumper was working, but the default constructor doesn't do
the parsing already nowadays.
Change-Id: I098b0a03ad7d994b5746f3a4a6c39d29133509b0
Reviewed-by: hjk <hjk121@nokiamail.com>
Since we don't actually need it anymore, just remove the code.
Task-number: QTCREATORBUG-10452
Change-Id: I59f55f3a319240826569de308491cac697c4f045
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
... when invoked on a macro that is defined inside that dialog.
Change-Id: I419c6675d70cfb8dd174f6a33f502b4c584baa3a
Reviewed-by: David Schulz <david.schulz@digia.com>
Now its more consistent with the other text in this dialog.
Change-Id: I424428a6fb892a2f0be2a3c6b11ae652ea39c679
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@digia.com>
The Debug Information, Debugger Runtime, and Deployment
filters were added.
Change-Id: Ifc22e1dfb1d1a9b0b72e371bfa7963c646d3ff2f
Reviewed-by: hjk <hjk121@nokiamail.com>
