Commit Graph

47434 Commits

Author SHA1 Message Date
hjk
919dc86c37 RemoteLinux: Compile fix with Qt6
QMap::unite() is gone, the replacement insert() came late, so ask
the preprocessor for help.

Task-number: QTCREATORBUG-24098
Change-Id: I2f596f9a998fa795fe0df378a39c4f1267f4e6e7
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-08-20 10:23:26 +00:00
Michael Winkelmann
44a3c092a0 QmlPuppet: Refactor ChangeIdsCommand
Change-Id: I75de863121b66a5050226dd5c8914229cb1af608
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2020-08-20 09:33:30 +00:00
Michael Winkelmann
d39a6f656f QmlPuppet: Refactor ChangeFileUrlCommand
Change-Id: I900f530109b6cdbb22d8138094443b48834d16cb
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2020-08-20 09:33:13 +00:00
Michael Winkelmann
95aa7f42de QmlPuppet: Refactor ChangeBindingsCommand
Change-Id: Id3020a73f59a1adfd25066a37d083d923e77956b
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2020-08-20 09:33:04 +00:00
hjk
5d820b79e6 Debugger: Compile fix for Qt6
QMap and QMultiMap are distinct types in Qt6

Task-number: QTCREATORBUG-24098
Change-Id: I959012739231fb3b184dcc13cebd119c83059a99
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-08-20 09:27:55 +00:00
Christian Stenger
76c872f633 GlslEditor: Display tool tips for errors and warnings
Change-Id: Id5f6e555599e479a83cc565966653b9e44b85772
Reviewed-by: David Schulz <david.schulz@qt.io>
2020-08-20 09:07:53 +00:00
Christian Stenger
52eea4c021 PE: Make TextDisplay a pure text display
Remove the pixmap part as pixmap and label text are
mutually exclusive and currently not used.
Beside this we must not call setVisible() before adding
the label to an already existing widget or layout or it
will be temporarily pop up as separate widget.
Amends 9e54e1776e.

Change-Id: Iaa57bfd1ca105d7360eaa360d68dbde38eaf0aeb
Reviewed-by: hjk <hjk@qt.io>
2020-08-20 09:07:42 +00:00
hjk
7ebd7a2213 Nim: Fix use of non-default arguments for Nimble build step
Amends 200d81d3, which mis-placed the call for argument setup,
effectively resetting it to default on each run.

Change-Id: I4b4f3ab90570d14e7ffc41346eb4f06241eb4f4c
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-08-20 08:33:31 +00:00
Christian Kandeler
ddf7f5f232 CppTools: Do not indent within string literals
Multi-line strings must be kept as the user wrote them.

Fixes: QTCREATORBUG-20180
Change-Id: I141eff52b55d31215e6f5c6c5a0e026689db877a
Reviewed-by: David Schulz <david.schulz@qt.io>
2020-08-20 08:10:22 +00:00
David Schulz
158fd92558 SCXML: fix magnifier not hiding
Fixes: QTCREATORBUG-24463
Change-Id: I835550e32467992ea7ad2555c546d810e6e0bbad
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-08-20 06:20:40 +00:00
Christian Stenger
790757a8e8 AutoTest: Fix persisting of check states
Persistent settings cannot handle QVariantHash and when
reading the check state the meta type system seems to have
the need to have used the check state already before,
otherwise it will fail to convert until it uses it.
This happened e.g. when re-opening a project that had
former check states stored inside the project settings
directly from the Welcome page after starting QC.
Amends df49d6e40d.

Change-Id: Id2b85373c151efb5890fe5fb7392bdbc11adda50
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
2020-08-19 13:55:29 +00:00
Michael Winkelmann
a638c25252 Annotation: Add export macros
Change-Id: Ieebc2750462bc6266e11318ea96c031b2ea6ef9f
Reviewed-by: Aleksei German <aleksei.german@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-08-19 13:36:14 +00:00
hjk
eb0d2518f9 Incredibuild: Use new AbstractProcessStep convenience functions
Change-Id: Id741ed68f146bbe6473925bc6bcdaa2f330f3ea6
Reviewed-by: <nir.bar@panel-sw.co.il>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-08-19 13:19:48 +00:00
David Schulz
150d29a8fd TextEditor: Fix remembering highlight definition
Amends 6989c9bbea

Since the change above the filename is checked before the mimetype, so
we have to save it in the same order.

Fixes: QTCREATORBUG-24505
Change-Id: Ib974dc0f69ca56cfd6ee9e34bec238e62f800598
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-08-19 12:40:51 +00:00
Michael Winkelmann
dbf00e63e5 NodeInstanceView: remove white space for initializers
Change-Id: I001ade2bb44b771661996e5103a37213a779fd74
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2020-08-19 11:33:24 +00:00
Alessandro Portale
aba3ac391c Core: Fix deprecation warning regarding QTimeLine::CurveShape
Since 5.15: "Access easingCurve directly"

Change-Id: I75a9f6c898dd2829e1d2a639bd9188c4aeeccc2d
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-08-19 10:58:03 +00:00
Eike Ziller
c92999dc0d CMake build: install application icons on Linux
Fixes: QTCREATORBUG-24355
Change-Id: I221d753f96144ef60ba755d2489eed1ed91b3b36
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-08-19 10:40:24 +00:00
Alessandro Portale
90f050b2a1 McuSupport: Fix warning about missing field initializers
Change-Id: I466f679a5cb583c351e0231a60cd9ce766d58f5e
Reviewed-by: hjk <hjk@qt.io>
2020-08-19 09:59:14 +00:00
Eike Ziller
98bf1a666a Fix more license headers
Fixes: QTCREATORBUG-24501
Change-Id: Ie7604f2b977f945744891b3c78e56a7818782a1d
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
2020-08-19 08:08:38 +00:00
Christian Stenger
e9c27cca34 Utils: Fix persisting of QRect
And pass explicitly a QVariant to the writer to avoid
unexpected behavior when trying to store the geometry
of a widget.
This resulted in a warning for any session where the
user had used the debugger at least once.

Change-Id: I5cb2352ab29ff7d2a64c84ffcdf040efe6d04b94
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2020-08-19 07:39:43 +00:00
Christian Stenger
2ac60ac66e Core: Fix filter of variable chooser
Fixes: QTCREATORBUG-24499
Change-Id: I787fc4342556d7062a1de5e7cb52d9d48532e719
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-08-19 07:38:57 +00:00
hjk
b0fb06b8ef iOS: Use a constant from iosconstant.h as deploy step id
Not really a big win here, but in line with what most others do.

Change-Id: I19f100084c8ca4cc7d0de97125efdc519bdfc972
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-08-19 07:07:43 +00:00
Eike Ziller
058f1e6918 Fix some license headers
Missing the GPL part.

Fixes: QTCREATORBUG-24501
Change-Id: I9e8e033399c050af29927d0ee735f9bcd05345bf
Reviewed-by: hjk <hjk@qt.io>
2020-08-19 07:05:55 +00:00
hjk
fb262ce24d ProjectExplorer: Streamline build step creation via menu
Change-Id: I801031d5a3d3ad8d8e5cf61766ca4e9791d7a96c
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-08-18 17:03:59 +00:00
Jacek Nijaki
4f595be64a McuSupport: Read RGL configuration from json
Previously whole SDK configuration for Renesas RH850 was hard coded.
Now configuration is read form the json file - same as for the other
SDKs. This changes adds new boardSdk params:
- name: sets the name for the SDK. If not set existing logic for
        generating name as "MCU SDK()" is used
- defaultPath: path where to look for the SDK if env variable is not set

Change-Id: Ia4b92c95bdc3302309cea4b935afbdd2e0bcadbe
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-08-18 14:35:28 +00:00
Jacek Nijaki
c3641b02e4 McuSupport: Update wizard entry point generation
Use app_target_default_main() macro and default entry points that come
with Qul instead providing own main.cpp templates.

Qt for MCUs has own default entry points implementations that may vary
for release to release. OS cmake variable is also removed in Qul 1.4.

Change-Id: I729b28250671c1a873d30d8c6c4f8d12306435d2
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-08-18 14:32:01 +00:00
Jacek Nijaki
8c227dea1d McuSupport: Update json kit processing to match Qt for MCUs 1.4
FreeRTOS backend is now a separate platform and requires dedicated json
kit file. Starting form Qul 1.4 there is no option to produce BareMetal
and FreeRTOS kits out of one json file.

This change is backward compatible with Qul 1.3.

Change-Id: Ic50b566a7f1a01fad4b00c07e723dfe1343fc2b0
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-08-18 14:31:49 +00:00
Michael Winkelmann
888cbe7f8a QmlPuppet: Refactor ChangeAuxiliaryCommand
Change-Id: I32eb04db96322883aa908e22724756f5e25ded09
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2020-08-18 13:25:59 +00:00
Eike Ziller
9df06af9bd CMake: Fix comparison of source paths when importing
We need to check canonical paths with canonical paths.
Otherwise we get a mismatch when using e.g. a linked directory for the
source path on the command line and then try to import the build in Qt
Creator.

Change-Id: I153be74b6cfdf5070e023780604ce64c92df0e6d
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2020-08-18 12:24:15 +00:00
Marco Bubke
22fcfb0d6f QmlDesigner: Fix compilation of coretests
This reverts commit 7856c2c2f0. There were files
compiled which are not used in the tests but have external dependencies.
So instead of using the preprocessor we simply don't link the source
files in the project.

Change-Id: Ibba4a1dace1868b016af7135262c795bb29af204
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-08-18 12:14:06 +00:00
hjk
6db2631ff3 Nim: Use new AbstractProcessStep convenience functions
Change-Id: I48828392012e6a3a794473d4d32f0d2de2b52345
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-08-18 11:34:48 +00:00
hjk
89e7e5ff7f Meson: Use new AbstractProcessStep convenience functions
Change-Id: I6583a4b83f638d30cab72f395a1300aead1e38e7
Reviewed-by: Alexis Jeandet <alexis.jeandet@member.fsf.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-08-18 11:33:53 +00:00
David Schulz
2dddc8520b Debugger: use additional cdb arguments
amends 2942ae876c

Change-Id: Ie1c2eb75300382ff8f350c8a66b893c6bfa21996
Reviewed-by: hjk <hjk@qt.io>
2020-08-18 11:24:03 +00:00
hjk
f0d0591015 Qbs: Start using aspects for some bool items in install step
Change-Id: If5e702ba6cf9727fe209c96988701d76f373a78d
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-08-18 10:37:18 +00:00
Eike Ziller
f0f1775fd5 macOS: Zoom action should "unmaximize" if already maximized
Task-number: QTCREATORBUG-24495
Change-Id: I94273f6aa9b425b57e328cfdb052dc171718a97e
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-08-18 09:43:32 +00:00
Thomas Hartmann
95e0b71b88 QmlDesigner: Do not assume MCU as the default
Fixes the sympton of QDS-2554, but not the real issue.

Task-number: QDS-2554
Change-Id: I8e0aca0b843bcb2befdc2d9a85b2dbfdb468ffb2
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2020-08-17 16:07:54 +00:00
hjk
0cfe11a960 Ios: Use new AbstractProcessStep convenience functions
Change-Id: I8a20690b679a4f2205295be48e4e5e99dee94d79
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-08-17 14:39:42 +00:00
hjk
e1d0b4cf48 CMake: Use new AbstractProcessStep convenience functions
This is actually a slight change in behavior insofar as
the summary now uses the same environment as the build
itself. This should not matter, or even be more correct.

Change-Id: I48e5be6cb7b97606f80f563ba399c4b6ff61c3bf
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-08-17 12:21:04 +00:00
Thomas Hartmann
96f0d2517f QmlDesigner: Add missing include
Change-Id: Ib521eab639f416fcacece6d396bc90c2fa473235
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2020-08-17 11:10:21 +00:00
hjk
1d6779f185 AutoTools: Use new AbstractProcessStep convenience functions
Change-Id: I994343d3d5cccf7ced6f2e576bd1c1cd5055fc47
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-08-17 10:54:30 +00:00
hjk
69ff17aa2d Android: Use new AbstractProcessStep convenience functions
Change-Id: I3fa4dcdd210f4c5d492217f2e3f1ceca353a4161
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-08-17 10:28:50 +00:00
Thomas Hartmann
7856c2c2f0 QmlDesigner: Fix compilation of coretests
Change-Id: Idd0c717078ac8d4fed9a8d4dfe000091ee2384c5
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-08-17 09:33:55 +00:00
Eike Ziller
1e447e133e Merge remote-tracking branch 'origin/4.13' into master
Change-Id: Icfff925574d735f371dde4f554736865fb4af27f
2020-08-17 09:26:45 +02:00
hjk
9e54e1776e ProjectExplorer: Introduce TextDisplay for simple display tasks
That's effectively a beefed-up TextDisplay previously used only in
Incredibuild.

Change-Id: I0cedef24cede8b8513e80b64f589abe62a68814e
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-08-14 16:06:56 +00:00
Antonio Di Monaco
6e4ca8b6af MainWindow: ask confirmation before closing Qt Creator
When working with multiple windows, pressing the close button multiple
times can close Qt Creator too.

This patch adds a system option, asking for a confirmation before
closing the IDE. By default it's not enabled.

Fixes: QTCREATORBUG-7637
Change-Id: Ifc5e8c97511f9227ce0634c8a7064d95775c76c2
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-08-14 14:19:45 +00:00
hjk
70b226144f ProjectExplorer: Start to consolidate AbstractProcessStep setup
Add some convenience functions to the base class to avoid repetition
in the derived classes.

Will be used immediately it in some derived classes.

Change-Id: I8fd6aa4f8351720cdc8f63f7fa5f506e32a8143b
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-08-14 14:15:23 +00:00
hjk
53abd750bf ProjectExplorer: Introduce an AspectContainer class
For further use in conglomerates like OverrideMakeFlagAspect.

Change-Id: I845ff085d15779e43431ab3858c5c1b55824f694
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-08-14 13:53:39 +00:00
hjk
a0067e9444 Autotools: Fix initial build configuration setup
Trade a duplicated 'make' for a 'make clean' step.

Amends 571fb04d.

Change-Id: I06dca803715a5c0a1a0917e4a4d5bac5704e8a43
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-08-14 13:29:27 +00:00
Christian Kandeler
414561e4cc CppTools: More consistent fuzzy matching behavior
There were annoying inconsistencies, for instance:
    - A not fully matching declaration was found from the definition,
      but not vice versa.
    - An implementation MyClass::foo(int) would fall back to a
      declaration foo(), but an implementation MyClass::foo() would
      not fall back to a declaration foo(int).
These cases behave consistently now. To this end, the clang code model
now forwards to the built-in code model if a function lookup has failed.

Fuzzy matching for free functions has been limited, as the cons appear
to outweigh the pros. For instance:
    void foo(int);
    void foo(double) {}
Following the definition would lead to the non-matching declaration,
which the user most likely does not want.

As a side effect, redundant code has been removed in the SymbolFinder
class.

Fixes: QTCREATORBUG-20279
Change-Id: Ib97d6710c7e12fb0fdbc30b51a0067e09bfc2190
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-08-14 13:21:36 +00:00
Eike Ziller
84e2814ef0 Do not propagate dark theme to widget designer
Fixes: QTCREATORBUG-23981
Change-Id: I63c362b2ec87e02e7d6828ee4c143f54d113bef2
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-08-14 12:54:36 +00:00