After removing the delegating constructor the code in the body of the
called constructor was not executed anymore. Move that code into a
separate function and call it from every constructor to make sure that
the text mark is properly initialized.
Amends d7ed05ae14.
Fixes: QTCREATORBUG-31153
Change-Id: Ic320d470d39a927c3f7027a0041e843cdea5aa9c
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
For seamless UX, the transform gizmos need to be visible and responsive
on all splits without first activating the split.
Fixes: QDS-12383
Change-Id: I7760fc35c06083b2939f7dff48e79e52f273ba97
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Asset name sanitizing logic is more complex on quick3d importer than
we have on designer side, which leads to asset name sometimes differing
from actual generated qml file name. Since there's always a risk of
sanitizing logic changing, added qml name as separate data item from
asset name so that preview generation knows to always load correct qml.
Fixes: QDS-13168
Change-Id: I1705619a6b30ebbe8ca44a00cfdad1a5122ca964
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Having multiple modal dialogs open can sometimes crash the designer.
Fixes: QDS-13142
Change-Id: I21a424f64f552c27b6b9e99009770d570feff84b
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Design Studio examples entries come without version numbers. The
lessThan implementation was called twice with the same two QDS items.
To my understanding lessThan confused the algorithm by returning
contradicting results.
With this change only different QVersionNumbers are lessThan-ranked.
Change-Id: I24fed43457c1f53c3fea693b20bdf2fd4db44b7a
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
The storage is now only set, never read -> thus remove it.
Amends 3cd0dad3d4
Change-Id: Icf95c03b923b07ed1a734fe522567d1851231960
Reviewed-by: hjk <hjk@qt.io>
Also de-Q_OBJECT-ify and drop two unnecessary casts.
Change-Id: I8113fc52e96226c3bdd72b36a904775c2fa5f1e6
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Instead of always deriving from global settings store the
settings for the manual run into the project settings.
Fixes: QTCREATORBUG-31092
Change-Id: I7854cff4e71b58225c7e9c1198c4e60128ed07e4
Reviewed-by: hjk <hjk@qt.io>
Silences a warning regarding ISO C++20 considering the
overloaded operators as ambiguous.
Change-Id: Ie27a8567899a91ab064a58694105af260addb74b
Reviewed-by: hjk <hjk@qt.io>
This reduces the complexity of the beetle, which should make it better
recognizable in various pixel densities.
Change-Id: I1021e497366881847984e32e31c3523207f6498f
Reviewed-by: hjk <hjk@qt.io>
- New house/Welcome
- Pen/Design points to bottom left
- New wrench/project without circle
- New hammer/build with attached handle and rotated 45 degrees
Task-number: QTCREATORBUG-31080
Change-Id: I97499ead9e097d523c36d9b08a4b65240e3a5042
Reviewed-by: hjk <hjk@qt.io>
Move implementations either to the TextEditorWidget, TextDocument, or to
the caller side. This makes the TextDocumentManipulator basically a
repeater so we can easily replace it with a TextEditorWidget in the
next step.
Change-Id: I04de3cb295b56fbaae99145f8e579fe405b065a5
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Let Design Studio directly change the location where the pre-installed
wizards are located
- clearing wizard paths to set a new one is call order dependent and
therefore fragile (as can be seen)
- it doesn't really make sense to prevent user templates
Also fix addWizardPath, even though it is then no longer used in our own
code.
Amends 3249b106e5
Change-Id: I404387aea1bc85aef5f229e6699bd9802b218e65
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
... and not for each cursor in a multi text cursor when handling the
backspace key.
Change-Id: I1e6b9409163306ee665f4519afe11cb87997c270
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Play icons usually are equiangular, i.e. not squeezed. This unsqeezes
the new play triangle.
Task-number: QTCREATORBUG-31080
Change-Id: I7243253255a015e78bf87bce273c2381dd96ee1b
Reviewed-by: hjk <hjk@qt.io>
There are two sources for examples: Qt versions directly, and "example
sets", which are just a tuple of display name, documentation path,
examples path.
The Qt installer registers an "example set" for Qt versions, so to avoid
duplicate entries we match Qt versions to example sets, if found. This
destroys any order the Qt versions might have been in before.
Order the results by Qt version (and other sets last) by first creating
all the items regardless of origin (noting their Qt version in the user
data), and sorting them before adding to the model.
Also use constants for the different user data fields.
Fixes: QTCREATORBUG-31108
Change-Id: I827be892a3abe17fa6afcd3c6f39bf225f7af494
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
The used QSysInfo::productType() provides various code/distribution
names which in some cases have little to do with the "host_os" that is
expected by the extension service API.
This change involves osTypeToString to instead return plain OS names.
Change-Id: I24b8070342c1de9de9040adcf5e06be967b6a180
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Qt Creator will always use newer Windows SDKs, as we require at least
Windows 10 1809.
The define for TOO_OLD_WINSDK was done arbitrarily and broke
(LLVM-)MinGW builds.
Change-Id: If8e1fd4e0e3615bda23483877e67988ca04ea9f7
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Import removal is done asynchronously as false node deletions can be
triggered by node reorganization that happens sometimes e.g. when
undo/redo is done.
Fixes: QDS-11741
Change-Id: I1d33e43ee205408c6a0fb2a45347ede13c02c4ed
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Calculate the correct node length if nodes are enclosed.
We cannot just look for the next closing brace, we have to
ignore opened and closed braces.
Task-number: QDS-12543
Change-Id: Ieee232777637f4bc022e65af5d8cb437e025a146
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
... rather than just building them.
Fixes: QTCREATORBUG-27406
Change-Id: I5ddbb9ee4a05c6843bd78cf01746c57c6cacda3c
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
When checking if an uri in a qmldir file is valid,
the cmake generator did not take the importPaths given in
the qmlproject into account. This is now fixed.
Change-Id: I403665f0c9c57bd41f644cd7c7e19349820b1824
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Collecting relevant pieces in preparation of settings aspectification.
Change-Id: Ia221de3babf301f4f5d3583d346eeb9f91046aa4
Reviewed-by: Sami Shalayel <sami.shalayel@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Where they were missing. The text is shown as a paragraph in the
extension manager.
Change-Id: I6e15c89fe4023b222e9c476f4312e13fcb0905c0
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Ctrl+C events are only handled properly for console applications. When
gdb debugs a GUI application the CTRL+C events are not handled. This can
be even reproduced with a plain gdb started from CMD.
This partially reverts commit 9d88da6c2b
and 670b4ec729.
Fixes: QTCREATORBUG-31131
Change-Id: I11c9d9dc08b4dbe450f38e27559b130dd317b675
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
