A failed CMake run configuration could be the result of an compiler
update which then would cause CMake to fail.
Make sure to offer an upgrade path to the new Kit compiler values.
Change-Id: Ibabeb853259e23fe012d8b00e3d48979deee61a5
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Visual Studio is getting a fair number of updates. This involves also an
update of the Visual C++ toolchain.
This implies changing directory paths from "MSVC/14.39.33519" to "MSVC/
14.40.33807".
The linker "link.exe" is also stored in the same directory as the
compiler "cl.exe".
This commit makes sure that the linker also gets updated, not just the
compiler.
Change-Id: If8cd6e716604bc948ec8990921a14425ebcc7c30
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Do not apply the changes directly to the model, cache and then apply at
the right time.
Fixes: QTCREATORBUG-27005
Change-Id: Id099f21196900cd0e9787ac27887f2eec36f8045
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Qt SDK is setting "Ninja" as default generator, make sure to get a
working generator when CMake is newly registered as a default tool.
Fixes: QTCREATORBUG-31129
Change-Id: I6b93a8904696eedadec04c882495c644db7ddce7
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
This was for some reason working before, but should not have worked.
Qt 6.7.2 does require this.
Change-Id: I599e5d8ee3535eb633a08bb0d5605e70cbf42097
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Since recently, the green background is used for enabled plugins and
grey is for disabled ones. With that change comes the requirement to
draw the icon for disabled icons with less intensity, to make it really
appear disabled.
I took this opportunity to unify the drawing of small/big enabled/
disabled pack/extension icon variants in a central helper function.
Change-Id: Ia68218c774ccb8e9e7ed48620ac36f4bca0724fd
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Importing 3D assets doesn't need to create Qt5NodeInstanceClientProxy,
so skip that in puppet initialization as it may lead to misinterpreting
some command line parameters given to the puppet.
Fixes: QDS-13123
Change-Id: Ifa6601dfa7da1a613b2c897a287a7baeb07dd712
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
This patch replaces the blind traversing in the project root to find
and parse the additional qmlproject files which are used by MCU
projects. Instead it's now using the qmlProjectModules() function to
reliably get the valid ones for the MCU projects.
Task-number: QDS-13068
Change-Id: I4e5e1791714345b69c0b2ac7929ae39c30521224
Reviewed-by: Knud Dollereder <knud.dollereder@qt.io>
about missing fields in initializer
jsonprojectpage.cpp:142:84: warning: missing field 'projectFile'
initializer
Change-Id: I1fe8b937100ac026eb602a65ad7ccf5077430a52
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
At least on Apple Clang there is no default constructor
For Text::Position taking two numbers.
Amends 39a448c62e
Change-Id: Ife3630f53d66be38a52ffeb8693bf7574038d083
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
... when the respective location would be in a different project.
Task-number: QTCREATORBUG-19636
Change-Id: I39a93f030b46ca2f422166ce1e4740e05ff90877
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
And de-pimpl. Smaller overall interface and less indirections.
Change-Id: If6a5c0824581a6478ad6e88410d97e23cc517a53
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
... when doing completion for header includes.
Fixes: QTCREATORBUG-31103
Change-Id: Ic2d4eb4abce4f6d0f7d08b0ff0f5e0f54669eb65
Reviewed-by: David Schulz <david.schulz@qt.io>
We want to sort by type and then alphabetically. That requires a custom
lessThan() implementation, thus a custom QSortFilterProxyModel.
Will come handy for further filtering/sorting requirements in the
future.
Change-Id: Iaacd955015d56026e41d404dcf4781a1715dc55a
Reviewed-by: hjk <hjk@qt.io>
Recursion for possible imports was interrupted when an incompatible
folder was detected, even though that folder could have compatible
subfolders.
Fixes: QDS-13067
Change-Id: I61f0ac6265e922c515dcd380a481434a1ddfcc93
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Word arithmetic does not work across languages. Provide explicit strings
for the combinations.
Change-Id: I95399f5d528405971d630a464e67a89766351162
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Trigger a fetch from the can fetch function in order to get whether the
item has children. This information is used to show the expansion marker
for items that have children, and not for items that have not been
fetched yet.
Change-Id: Ifc20588aa805368369e72fc8501244f64bbbc91d
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
The TextDocumentManipulatorInterface was introduced to decouple
modification operations from QTextDocument. But nowadays all tests and
production code usages are backed by a QTextDocument, so we can remove
this abstraction layer again. The first step is to merge the interface
and all manipulator implementations.
Change-Id: Idd1609df549d3b120dd516d5161af9aa8aa571ca
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Sometimes the mime detection returns unexpected results and defines a
textfile based on the ending as a binary file. We should at least make
it possible for the user to open those files in the plain text editor.
Fixes: QTCREATORBUG-31116
Change-Id: I3139a1013be9fa6f28654434229c62f7a8e79d21
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
QStringView is easily convertable to std::u16string_view, because data()
is returning QChar* and not char16_t*.
Change-Id: I4dcdceca0c1ee82ea02494d8a45e9ab3011e4dcb
Reviewed-by: Ali Kianian <ali.kianian@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
The fetching is postponed until the extension manager is shown.
This also adds a spinner which is shown during the fetching of the data.
Change-Id: Id24ae772bcdfdf885ecfd5341d9a8d02f398c1a0
Reviewed-by: hjk <hjk@qt.io>
- Add dots to ends of messages
- Replace "plugin" with "extension" in translatable text
- Fix capitalization of headings and button labels
- Change wording
Change-Id: I24a3ca6de6a5a0a4509bab34ad2f50cbcf40c73a
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Make the code a bit more readable at the cost of verbosity.
Change-Id: If6d83a441b863a027b91e486b676183af6e5a8ea
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
The default impl of Process::startDetached() forwards
process channels. Make it optional by providing an additional
argument of DetachedChannelMode type for Process::startDetached().
Change-Id: I6cb55377c21dfedacd53117756894d07e354e0fe
Reviewed-by: hjk <hjk@qt.io>
This change sets green vs. grey background for extension icons depending
of enabled state.
Change-Id: Id99419544a00acca897aa0ad6c98d2598e4b2210
Reviewed-by: hjk <hjk@qt.io>
Didn't notice the `toStringList` member function of `Environmen`. The
code now is now also nicely indented.
Change-Id: Id570ddc48e915d9090f9975d05761aa908311f0d
Reviewed-by: hjk <hjk@qt.io>
Log the network request, incl. result and response. And how many
extensions were fetched remotely and added locally.
Change-Id: I634d72462c8076c2fa01e88a1918163f76d28aff
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
The extansion query service is currently only reachable from within the
internal network. So far, if the request failed, and if Qt Creator was
configured with WITH_TESTS, a set of test json got loaded.
That test data confuses people in the team.
This change makes loading of test data explicit, and comments it off by
default.
Change-Id: I89236064b6af32be7559bb6d36cbf0d42982085d
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
This change enables the Qt Creator Extension service data to override
data of locally installed plugins (so far it was the other way around).
We might want to add more description text, links, images or tags to
plugins. And we want to be able do that independently of Qt Creator
releases.
This change also allows for substantial simplification of the "data
merging" code.
The parsing of extension plugin dependencies from the json data needed
to be fixed. See dependenciesFromJson()
Change-Id: Ia0433f0e0c7a0f13c43e0569c0915b7d08f7370a
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
This way if we pass arguments to the Run configuration, they will reach
the inferior whilst being debugged.
Change-Id: I93d99ff0d69b4ec710887097efc643fb48c8acca
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
If a class is being added to a target that has a variable resulted from
a `file(GLOB|_RECURSE)` call, we skip adding the files to the target.
Do not add the files, just run CMake which would gather the new sources
into the project.
Adding sources to a globbed target will no longer open the
CMakeLists.txt file, since nothing has changed.
CMake will be run after adding, renaming and removing of sources files.
Fixes: QTCREATORBUG-30445
Change-Id: I82e126737789f215a6400f5a43f303dcc57de005
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
