Get rid of onLicenseCheckResult() and runPendingCommand().
Gather all the continuations inside the packageFutureFinished().
This clears up the picture of what is happening.
Change-Id: I7d63fa7a628a0bdefb26677f04df97a0491668ab
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Otherwise it's a nightmare to track it.
Change-Id: I6d9ddc1d5e7046307b0aa66ded05023cf884f37b
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Recent project structure changes invalidated material bundle metainfo
files, as we can't support both new and old structure with them.
They were only used for populating possible types in material editor,
so adjusted this functionality to only allow changing the type between
basic types. If the material is a custom component, then the only the
current type is displayed and the type combo box is disabled.
Fixes: QDS-12628
Change-Id: I07b1a482977f0ecc94c35f3d485302c85c6153f9
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
i.e. when opening a project that has a different import folder style
from the currently open project.
Fixes: QDS-12639
Change-Id: I8d341c38ec771dc5e28c4436cd9ad191e27c38a8
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
So far the defaults were false but some of the are true.
Task-number: QDS-12663
Change-Id: I710913ed371d6e094cf68c154bb9353c21ee0c16
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Rope is not part of the default installation of the python-lsp-server
pypi package and enabling it by default results in an error at startup.
Fixes: QTCREATORBUG-30757
Change-Id: I975ac98d9f4c5b25f5be085461e5b626d3a93fbc
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
The delegate for GridView is different from ListView.
Also cellWidth and cellHeight should be specified for the GridView
Also the delegate for the listView is modified to clip and elide the
text.
Task-number: QDS-12306
Fixes: QDS-12386
Change-Id: I7e75b9e7f234c5e021637e703088539886a8f25f
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Type annotaions are now saving the type name and dropInFormEditor is by
default true.
Task-number: QDS-12450
Change-Id: I757f59b296de321c4d0190a36ec581379f646735
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
On macOS. Make sure to use an absolute path for the file dialog.
Fixes: QTCREATORBUG-28832
Change-Id: I75f4166ee2bc3238a01089231bde4cf990269024
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Closing the tip label indirectly calls ToolTip::hideTipImmediately via
its eventFilter that closes the tool tip on any FocusIn/Out event on the
application. Since m_tip is reset in hideTipImmediately the outer call
crashes when this nullptr gets dereferenced. Avoid this crash by
resetting m_tip before closing the tip label.
Fixes: QTCREATORBUG-30738
Change-Id: Id3e690141be196db8ac6c4dab3d97627c0657140
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Expanding items in the locals view results in replacing the original
tree item with a newly created one. This ultimately resets the selection
and the current item of the view, which in turn makes it cumbersome to
navigate by keyboard.
Save a list of selected inames and the iname of the current index when
requesting the update and try to reselect them after the update
finished.
Fixes: QTCREATORBUG-27569
Change-Id: I9d8f51631e4ee490e19307877cbef44798506016
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Enables to limit the scanning for tests and respectively any
further action to a list of user defined patterns.
If limitation is enabled and any of the filter patterns does
match the file will be processed.
If no filter pattern matches the file will be ignored.
Change-Id: I6a6de8f4137485e83b750997fb3c948dc6e79c68
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
Some (Fedora) OS/Distros set a default value for TERM such as "dumb", which then breaks
command line tools such as "clear" which try to figure out what terminal they are
running in. Therefore we have to force-set our own TERM value.
Fixes: QTCREATORBUG-30737
Change-Id: I50ac86f17c92dc7bc477cc59ed43ec22025593fb
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
The code was not taking into consideration an empty QStringList.
Fixes: QTCREATORBUG-30755
Change-Id: Ifb9f5dc3ffefd94d44b16b161bc04d381f3f6786
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Remove the useless round trip from model to view and back
Change-Id: I38a5826e165014f64d7855139b58e9691b0f6310
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
so that it can be shared by more than 1 bundle. Also some relevant
tweaks.
Change-Id: I421648c26ac4a0d51612f21a5475f0938dfff331
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
If an editor area is hidden, for example by unchecking the "Editor" view
in Debug mode, this might hide the current view. This is ugly, because
opening an editor in that state either opens the editor in an invisible
view, or in case of Debug mode with hidden "Editor" view it switches to
Edit mode. Which is detrimental if the user has a separate editor window
open that could be used instead.
When an editor area is hidden, try to set a current view that is visible
(which might be the same as before).
Fixes: QTCREATORBUG-30408
Change-Id: I0eb65fddbc857b6efb12972b861b9f44204bd715
Reviewed-by: David Schulz <david.schulz@qt.io>
And remove the "GTK_THEME" hack
Even though Qt Creator now looked fine when started with a
light/mixed theme on a dark system theme, we still had to force
a light default palette on the application at startup.
The issue is that when the user switches the system theme
to dark during Qt Creator's runtime, Qt notices that and changes
the default application palette to dark.
Prevent that by setting a detached default palette on the
application on startup, even if we do not intend to apply custom
colors to it.
Task-number: QTCREATORBUG-28497
Change-Id: I7a43f108c2299967a14f382e52b62c31491e673d
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
The withCancel() method takes a function returning the sender
and its signal pair. When the signal is emitted, the queued
call to the running task tree is scheduled, and when dispatched
the *this group is canceled and the returned item finishes with an
error.
Change-Id: I898a7221d91a78225c73abc6885a18a2e7c2ae45
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
This used to not build on linux. Doesnt seem the case anymore.
Change-Id: Ia58d388bfe4f5cc794b29f8e25a9a8d6b3f229c3
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Successfully restoring auxiliary properties requires scene model to be
complete, so we must wait until model is attached.
Fixes: QDS-12615
Change-Id: I906e9b50df14fcdbc0cad8370c5466db5c1aab02
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Mouse wheel no longer zooms 3D view when done in fly mode. Instead,
it adjusts the camera speed value.
Fixes: QDS-12291
Change-Id: I0bb5960d67cb25d545d3ac2ce2567c75f057ea72
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
