Previously the LuaEngine::loadPlugin() function tried to fully setup the
lua interpreter. This was called before the dependencies of a lua plugin
were fully soft loaded. Therefore the dependent lua packages had not
been registered yet.
This patch changes that to where the packages and lua libraries are only
loaded right before the actual setup call is done. This also allows us
to safely load the plugin spec without giving it access to all the
functionality directly.
In the future we could show and ask the user before we load the plugin
whether he agrees to give it the requested access.
Change-Id: Ibf3e81db54e2ba94473e8ecf2650dcf2e97f1360
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Get rid of AndroidSdkDownloader class.
This will enable easy chaining of recipes for different workflows.
Change-Id: Ia048597148a2a1e7573fc0d4192cf7e678f39c4f
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Also some cleanups in same files.
Fixes: QDS-12506
Change-Id: I0c211206b6b7c29857a30f18d6077c2ddd76849c
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
That can improve compile times, so it takes less time to develop new
functionality.
Change-Id: I94170674e1bf5178020389bcb3623dbbf87eb7a3
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
There are now other ways to prevent locking bugs. So we don't need the
template parameter anymore. That makes it possible to move much of the
code to a cpp file. Maybe later we have to move some functions back for
performance reasons.
Change-Id: I01269912618d7cf5e070219e7edaa3a00623b7cf
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
property is a keyword and a bad default.
Change-Id: Ieb38f08f5f049fe6b540304945ce95ae6c18b55e
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
The name "UpsideDownCake" for Android 14.0 has been revealed a while
ago. Align its package presentation to Android Studio.
Task-number: QTCREATORBUG-30711
Change-Id: I7ca42ca73c7bdf5b7732bab2d2bd36f7a730ccb7
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
That makes it possible to locate the files in the project tree.
Change-Id: Ib7208e91b48be865aa22851d6786e39cf293b2b7
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
This shwos the same editor toolbar as in the python editor that offers
to install pyside, if the qml file can be associated to a python project
and the configured python for that project does not contain a valid
pyside.
Change-Id: Id05a2621aec9d78c4a22e61830813cd261eda4fc
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
We want the plugin manager to support the -test option etc even if
Qt Creator is not configured with WITH_TESTS, so 3rdparty plugins can
still be built and tested with a released Qt Creator.
But we do not want to export functions/classes that are only needed for
Qt Creator tests in that case.
When Qt Creator is configured with WITH_TESTS, the QtCreatorAPI adds the
WITH_TESTS define, and we used the same define for the first case above,
where we only want to add the -test option and corresponding API. Use a
different define EXTENSIONSYSTEM_WITH_TESTOPTION for this. The
EXTENSIONSYSTEM_TEST_EXPORT keeps checking the WITH_TESTS define.
Amends e5a4fdaa1b
Change-Id: I547f1fa7413e3bc452f71ae920c310a05e0193ae
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
If selection context contains valid scene position, use that to select
the model under cursor.
Fixes: QDS-12346
Change-Id: I55c58ed303e1746b7b234fa6ac31272fdfafb40d
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
This presets better results, and is in sync to what other locator filters
are doing.
Fixes: QTCREATORBUG-30452
Change-Id: Ia77d2a5f22b33b55aa081d09372ab5cf297bb065
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Only remove more than one character when the cursor is inside the
indentation in the beginning of the line. In all other cases always only
remove one character.
Fixes: QTCREATORBUG-30725
Change-Id: I973101a95768cdd8b1a318972f53423eb72eb157
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
When in fly mode in 3D view, crosshairs are shown in the middle
of the active split. Pressing space in fly mode when there is
a model at the crosshairs will move the camera close to the
model.
Fixes: QDS-12292
Change-Id: Id15c13458af3763f4e0712614cf9cf3ed695fb5d
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Assert that we don't call it recursively. If so, the waitForSignal()
returns false immediately.
Fixes: QTCREATORBUG-30715
Change-Id: I7195b2b1347f67262cc8ae6db5439f5ddd38b5bb
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Users can rely on the order of test function execution as
there is a fixed running order.
Fix the order by using location information we have instead
of the display order inside the tree view.
Fixes the order for running selected tests, failed tests or
tests inside the current file.
Fixes: QTCREATORBUG-30670
Change-Id: I5229424c3c8a2a7e030ef95c98d6fb602e54cc87
Reviewed-by: David Schulz <david.schulz@qt.io>
Since we now have multiple classes inheriting from PluginSpec it makes sense
to rename PluginSpecImpl to the more accurate CppPluginSpec as it deals with
compiled plugins only.
Amends b39b192518
Change-Id: Icae9daed2be5a258a9918731a881c72cbe4f0fa4
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
PluginSpecImpl::read is used outside of tests, but PluginSpecImpl itself
is only exported when WITH_TESTS is on. So compilation without
WITH_TESTS would fail. To circumvent this the ::read functions are moved
outside of the PluginSpecImpl and friend'd to it.
Amends b39b192518
Change-Id: I4bd8ce087267ab4e059cff2470ff882c7db6fd78
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
and suppress warnings about .hints files not being part of the project
Fixes: QDS-12507
Fixes: QDS-12508
Change-Id: If3c2f5ce716b8744dd4fee91ec7bba5293163a97
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
