Commit Graph

72811 Commits

Author SHA1 Message Date
hjk
9747564bab Core: Use more layoutbuilder in mime settings dialog
Change-Id: Ia5729cbd5ed578dd2488ec2864722be0e8dae4c0
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2024-07-29 13:49:09 +00:00
hjk
41b5ce35f6 App: Force QString return for getPluginPaths lambda
Change-Id: Ib52f003e1918366813bba840eb5d0658f9ec37be
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-07-29 13:00:42 +00:00
Christian Kandeler
b7baf5a736 Lua: Fix include
Change-Id: I48cab5517d2f5358b88b1d97a8e3f5d92452ab85
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-07-29 13:00:03 +00:00
Christian Kandeler
09322f4014 Update qbs submodule to HEAD of 2.4 branch
Change-Id: I8d1ae9cc997fb73d241274c8a4f13d62cebd049a
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-07-29 12:58:55 +00:00
Alessandro Portale
18f0e3d4d0 main: Fix nullptr access on Windows
The SharedTools::createApplication changes the last
Options::appArguments element value to 0.

Amends c811b93ece

Change-Id: Ie0d220ab45b25fee65f82410195095fd074cdf39
Reviewed-by: hjk <hjk@qt.io>
2024-07-29 12:16:52 +00:00
Eike Ziller
789872a0f9 macOS: Support gestures for going back and forward
in the editor and help viewer, when setting macOS Trackpad preferences
to "Swipe between pages: Swipe with Three Fingers".

Fixes: QTCREATORBUG-7387
Change-Id: I1c2684f846d72bb98ba6626c3a04f01fb57b8e24
Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
2024-07-29 11:42:44 +00:00
Alessandro Portale
6ad569c264 Fix QApplication::fontMetrics() deprecation warning
Change-Id: I9de6ccef8f6178b3344ab862b6f7506a10895722
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2024-07-29 11:30:07 +00:00
Marcus Tillmanns
be2e5262c7 ExtensionSystem: Move Installation logic into PluginSpecs
Change-Id: I5b6d284179bf62be89d6e5157fd7e14df5e65817
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2024-07-29 11:21:56 +00:00
Eike Ziller
2373c4c0a4 iOS: Do not enforce architecture for CMake builds
Do not set CMAKE_OSX_ARCHITECTURES, the defaults are fine.
It builds for x86_64 for Qt/Simulator/x86_64 and for arm64 for Qt/
Device/arm64 automatically, and then also for custom Qt/Simulator/arm64
builds that didn't work before because we enforced x86_64 for Simulator.

Task-number: QTBUG-101276
Change-Id: Ic33eab6d418210ad6384951e0b0f1972a2287a6b
Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
2024-07-29 10:50:41 +00:00
Eike Ziller
81f7325a0c macOS: Remove code handling Qt Creator running under Rosetta
Remove code that was added to handle the case of Qt Creator running as
an Intel binary on ARM Macs, which required some passing of flags to
qmake/CMake/LLDB.

Nowadays, Qt Creator can be built for the corresponding architecture
(and by default we provide universal binaries).

Partially reverts a71d725e46

Change-Id: I842f85b85a26d09cff72199ae86c602fd8f14e33
Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
2024-07-29 10:50:28 +00:00
Lukasz Papierkowski
bd731d213d Lua: Add enableToolTipOnSuggestionHover() to TextEditor bindings
Change-Id: I2e7fd6d6b152cb2d5c39d5141b0fee39e78083a7
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2024-07-29 10:27:33 +00:00
Eike Ziller
b463c7e049 Add const char overload for Id::withSuffix
Otherwise `withSuffix('.')` adds `46` to the Id.

Amends 87280f25ce

Fixes: QTCREATORBUG-31325
Change-Id: I95b85220e319812886f4b648286e76f48f43a49b
Reviewed-by: hjk <hjk@qt.io>
2024-07-29 10:13:25 +00:00
Vikas Pachdha
2b3d0b9dbe Fix generateId accepting non-latin characters as valid characters
Task-number: QDS-13269
Change-Id: I46a3bc193e35f4a93c8a0fa48de26891dc9d098a
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2024-07-29 10:04:11 +00:00
Jarek Kobus
a26ed2e12e Android: Move pid recipe into a separate function
The task tree runner is going to run more tasks.

Change-Id: I342d041134968286a2cf1b20cabe2b4c01ce02b0
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2024-07-29 09:53:07 +00:00
Eike Ziller
2bb42bed1c Merge remote-tracking branch 'origin/14.0'
Change-Id: If26b4607afe758e81feb334b7628797f8fd9c016
2024-07-29 10:15:58 +02:00
Alessandro Portale
a0e37a76fa Plugins: Add URLs to manual page to plugin metadata
Fixes: QTCREATORBUG-31199
Change-Id: Ideadc75499f32a8f1d1c95cd38dc4669a3d422c3
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-07-29 07:27:29 +00:00
Alessandro Portale
b24492c6e9 ExtensionSystem: Add field "DocumentationUrl" to PluginSpec
Task-number: QTCREATORBUG-31199
Change-Id: Ieb20d35cc9b4fe976207491bd201750fa4ca0032
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-07-29 07:27:03 +00:00
hjk
3859b2d8f2 Core: Save mime settings changes directly on apply
The only time it actually changes.

Change-Id: I78e6e9d61a3dfbd19bd4b422d6696df75dfd50a4
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-07-29 07:16:59 +00:00
hjk
ffae39f425 Debugger: Purge dead tooltips before accessing them
Fixes: QTCREATORBUG-31323
Change-Id: I58a4235f40fa7976dd0f18edeb4c3b0954283af9
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-07-29 07:05:23 +00:00
Marcus Tillmanns
2decdd7955 App: Add user lua plugins folder to plugin search path
Change-Id: Id59c0a6bf47887affec862577d78b7f324c20abf
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-07-29 06:50:39 +00:00
Marcus Tillmanns
165ad2784e App: Use appInfo().paths
Change-Id: I4e23a1187ad7c13a60692917a21455b95adcbe98
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-07-29 06:50:16 +00:00
Marcus Tillmanns
be93bb643b Core: Use AppInfo.Paths
Change-Id: Ic4aff7e2b8957ab125560eefe1cff4d9df5ffd0a
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-07-29 06:49:55 +00:00
Marcus Tillmanns
01b2938043 Utils: Add commonly used paths to AppInfo
Change-Id: Icfd7e549a1589aff13bfacfe6abd85e7e780b3c0
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-07-29 06:49:37 +00:00
Christian Stenger
c325777477 Lua: Fix build
Change-Id: I908495a3e0f3ebb03291aed9256a50678320b4ee
Reviewed-by: hjk <hjk@qt.io>
2024-07-29 05:52:25 +00:00
Christian Stenger
d487237b6b QmlPreview: Fix missing include for older Qt
Otherwise the meta type system complains.
Amends bbed189656.

Change-Id: I7cd4a2b244d7b3920029a47a706be89735f67cd4
Reviewed-by: hjk <hjk@qt.io>
2024-07-29 05:52:17 +00:00
Andre Hartmann
50a9fc3cb8 Git: Instant Blame: Improve porcelain blame description
Change-Id: I74464928483da33c7bc56b659d581debcb2ec7f0
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2024-07-28 18:49:34 +00:00
Andre Hartmann
f005f2c4be Git: Instant Blame: Use original line number for blame
The line might have been moved and therfore using the
original line number asures the full blame is scrolled
to the correct position.

Change-Id: I07478d499af3509670a7d91771b2ee9777a06b3c
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2024-07-28 18:49:17 +00:00
Cristian Adam
bfe1258d1b CMake: Bump minimum CMake version to 3.20
In order to get the policy CMP0116 set to NEW.

See https://cmake.org/cmake/help/latest/policy/CMP0116.html

This should prevent rebuilds due to AUTOMOC.

Change-Id: I242c44b2969c6caccf61b7d5ba5c3a0335744ee7
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-07-26 15:07:09 +00:00
Mahmoud Badri
0bb0a465b8 QmlDesigner: Handle adding an item with a bundle material to content lib
Fixes: QDS-13072
Change-Id: I8406855c93b9ac521c92d1cf688692d0a4c8e85c
Reviewed-by: Ali Kianian <ali.kianian@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2024-07-26 13:52:05 +00:00
Marco Bubke
da5ee902e6 QmlDesigner: Remove AbstractView::nodeInstanceView() call
AbstractView::nodeInstanceView() is breaking capsulation and should be
removed in the future.

Change-Id: I3ca7be79debfb4cc711a84425002e9d3eac81f9e
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2024-07-26 13:36:03 +00:00
Marco Bubke
d309163c94 QmlDesigner: Remove workaround code for PropertyName
Since we now use PropertyNameView, we can remove this workaround.

Change-Id: Id7c46857ee60579f8b27e8e4cbc4d189dc928bd0
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2024-07-26 13:35:57 +00:00
hjk
fa0bfa8660 Lua: Dissolve LuaEngine class
It was mostly used as namespace.

Change-Id: Ice6cdd1581d7dd70b09f6d82891b874a206a1ca0
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2024-07-26 13:25:14 +00:00
Marcus Tillmanns
e429a11fd7 ExtensionBrowser: Warn on error
Change-Id: Ie7ceb888593563cd8d50c60d052a855417045b26
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
2024-07-26 13:21:42 +00:00
Alessandro Portale
134e291b61 Utils: Fix struct vs. class declaration of RunResult
Change-Id: I111a997d4883041d4c70868e1c63baa5cde9e884
Reviewed-by: hjk <hjk@qt.io>
2024-07-26 13:15:37 +00:00
hjk
8af2f68493 Core: Allow plain widgets in IOptionPage::setWidgetCreator()
They were internally stored as QWidget anyway and only used as
IOptionsPageWidget after qobject_cast, with a sane default
implementation if they are not.

Change-Id: I98c73fb1221ba6f05e52d9f79ccd0f4c2fc7fa69
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-07-26 13:04:39 +00:00
hjk
0ace1802a1 Core: Make the global printer a function-static object
QPrinter does not do anything strange in the destructor,
so the change in lifetime is harmless.

Change-Id: Iaa255c8809e977dc480b3e23810f3c11b99fad28
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-07-26 13:04:31 +00:00
hjk
aaa9e0d8b9 Core: Use setup* pattern for ShortcutSettings, SystemEditor
... and ExternalTools.

Change-Id: Ib39cb477693f6ba6903dd6475ffd1d80cf70828f
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-07-26 13:04:18 +00:00
Marcus Tillmanns
e4e4ef2629 Fix warnings
Change-Id: I142453a6707c252ab9c311573c329d24d85cf2ab
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2024-07-26 12:56:52 +00:00
Jarek Kobus
1c15ca95a7 Android: Get rid of unused arg from runAdb()
Change-Id: Ie80fd26b0b148c744d5ff0083fddad402405fb38
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2024-07-26 12:56:23 +00:00
hjk
a6908fa2d6 Core: Rename MimeTypeSettings to MimeTypeSettingsPage
More similar to the other classes.

Change-Id: Idb23cb5e43560132600158c5ba4d71e83a6a92ba
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-07-26 12:49:13 +00:00
hjk
4c8398f7ef Core: Remove unusual life time handling for MimeSettings
Change-Id: Ibbd1e12a1203ded7b63bdef39be1477911de50d9
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-07-26 12:49:04 +00:00
hjk
4535677c89 Core: De-pimpl MimeTypeSettings
It's now all in the .cpp.

Also, make all the global statics members of MimeSettings, which is
a singleton anyway, and de-indirect the models which have identical
lifetime.

Change-Id: I0e9b485804e569b95526d1610821cd9c12dd1322
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-07-26 12:48:12 +00:00
hjk
e69ad77d3b Lua: Code cosmetics
The initialization/setup/... methods are typically called 'setupX...'
nowadays.

Change-Id: Iecdca160a54f60fbeb3dbffcc6d7aca20bc68682
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2024-07-26 11:58:50 +00:00
hjk
f49523029a Remove #include <utils/fileutils.h> from most header files
It has some platform specific warts, filepath.h is somewhat
cheaper and less ugly overall.

Partially clean up surroundings

Change-Id: Ida1fd470ec020f69c446109427f92a08e879789f
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-07-26 10:41:16 +00:00
Ali Kianian
dda294f16e QmlDesigner: Remove PrincipledMaterialEx from basic material types
Change-Id: I290b1c3fb8ce12b6d0319d2ce2dee6cb71fd0a57
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2024-07-26 08:51:36 +00:00
hjk
09a999302c Core: Remove unused MimeTypeSettingsPrivate::m_filterPattern
Change-Id: I55fcb9e66c2234cd5179ccb973fe4e57f6eb2de9
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-07-26 08:22:56 +00:00
hjk
0ee5786e43 Core: Move some widget related things to MimeTypeSettingsWidget
From MimeTypeSettingsPrivate.

Change-Id: I293ead85cfaf3950daed975c9301b4296eda7dbc
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-07-26 08:22:27 +00:00
hjk
bd06023f9f Utils: Remove Id::uniqueIdentifier()
Not needed since qHash is made a hidden friend.

Change-Id: I4dc4b302f6708aa98fd4733a13a2efa3297e426b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-07-26 08:03:27 +00:00
hjk
87280f25ce Utils: Use more views in Id setup
Since this means that StringBuilder expressions are not usable
as arguments anymore, use .withSuffix() more extensively.

This makes this "unusual" construction also a bit better findable.

No measurable performance gain or loss in either direction.

Change-Id: I04508e77764455bd9d3a21eda63bc6de01508e4b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-07-26 08:00:00 +00:00
Jarek Kobus
f64440e4b8 QmlDesigner: Fix warning about deprecated operator+
Use operator| instead.

Change-Id: Iee76ec3429f33b07c060de8d98451edd9c97a701
Reviewed-by: hjk <hjk@qt.io>
2024-07-26 07:34:02 +00:00