We do not need different code paths for Xcode < 9 nowadays.
Just tell simctl too boot the requested device and make sure the
Simulator app is running.
This also fixes an issue if for some reason a different device is already
booted without the Simulator app running, e.g.
1. make sure Simulator is not running
2. boot a device from the command line with
`xcrun simctl boot <deviceID>` (get the device ID from the Devices &
Simulators window in Xcode)
3. start Qt Creator and run an application on a *different* simulator
device
Without this patch Simulator app opens with the device from (2) and
deployment of the application fails for the different device.
With this patch the device for (3) is booted and the application
deployed and run.
Change-Id: Ifce8c470f2d4d646295ca4e47fbd92308f87adf8
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
If simctl fails, always include its stderr output in the error, if any.
Change-Id: I7a5643ac81befc9d0595e9c3bd4fa009057ff85b
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Allows a LSP plugin to dynamically configure the initializationOptions
Change-Id: Idc5d6526a732512b2e4e7394fb1c8b5749cde25d
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
It was set, but nobody was actually using it.
Change-Id: I99c6fcd4605591d65e5f3fb3f489a3de0c61fb24
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Remove line increment in jumpToModelNode code as it erroneously puts the
cursor in the text editor to the next line of a selected item.
As the NavigatorView and others currently using the context help
function of the text editor, which internally depends on the cursor
position, and hence on the assumption that when selecting an item via
any view the cursor is placed on the item an not inside the item,
pushing the cursor down by one line breaks that assumption. As a result
the context help searches for nothing or a property (e.g. id) and not
the selected node.
Task-number: QDS-13252
Change-Id: I00810a0ff8ddd49177ebf18e3eea7b6b05cc0af3
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Instead, emit remoteProcessFinished() directly from the
startDebuggerServer() function. Make this function void.
Change-Id: Ibeeb2a1e3aabb9b3021203003e31a7b44eef573e
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Import versions as well as versionless imports can confuse
the help engine when performing context help lookups, which
leads in some cases to falling back to the wrong help items.
Remove the version for looking up help items.
Fixes: QTCREATORBUG-31280
Change-Id: Ida765369f52804186ca005ceec23cd9d795220c5
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Reviewed-by: Semih Yavuz <semih.yavuz@qt.io>
Make the getconf process a yet another task in the recipe.
Change-Id: I4c25cb512740471fa603ee0b9a46a41879ba90cd
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Setting up a working emsdk requires a couple of steps:
1) Installation/clone of emsdk
2) Installation of an SDK
3) Activation of an SDK
If the setup is incomplete, Qt Creator cannot use the emsdk. Until now,
users got no explicit indication of an unsuccessful emsdk detection and
no hint of what could be wrong. This change adds visual diagnostics of
potentially missing emsdk setup steps.
Fixes: QTCREATORBUG-30057
Change-Id: I2dc2d3388be75e8586dc18d24b0a5b57bcffaadb
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
This removes the need for a delayed call of
WebAssemblySettings::updateStatus(), and a possible visual glitch where
too many widgets are visible for a split sencond.
Change-Id: I2b4b39f6576d16d4fde6b3e3df1ce09e6805086d
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Inline variables have weak linking. So the linker will reduce them to
one instantiation.
Change-Id: I8aa02aa1181a59faf955f31d2683a76e8aef2df6
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
So people can at least add a custom build step
Change-Id: I78f3601233c776501bdc73fb7d67cbfeb886ced2
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
If someone wants to switch to a language because it is their native one,
it makes most sense to show the option in their language.
Nevertheless the english name is useful too, so keep it.
Change-Id: I3afb81202e6799525c1c9c503ac3a97c608c3c8a
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Robert Löhning <robert.loehning@qt.io>
Avoid sharing the workers with the engine creating the
snapshot to avoid closing both when stopping the debugger
engine for the snapshot.
Correctly detach at finish to avoid having a runcontrol
appearing still running.
Fixes: QTCREATORBUG-31220
Change-Id: Iccb54b0fc2d7f5bf54b42a116e56c1a840b1f46e
Reviewed-by: hjk <hjk@qt.io>
NDKs usually ship the python libraries required by the NDKs LLDB.
However, these libraries reside in a different location.
DebuggerItem::addAndroidLldbPythonEnv takes care of finding that
location.
This change re-adds the recently remopved
DebuggerItem::addAndroidLldbPythonEnv call, so that LLDB can again be
detected.
Amends: b56a447a83
Fixes: QTCREATORBUG-31279
Change-Id: I78cb7dfd1abd96f7bc52e4adff9dddd054f8ac0b
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
If a plugin was selected in the ExtensionManager, and meanwhile, the
"load" status of that plugin was changed via the plugin dialog, the
change was not reflected in the ExtensionManager.
This change connects the "Load on Start" checkbox in the
ExtensionManager with the PluginManager's "changed" signal to keep the
state in sync.
Fixes: QTCREATORBUG-31177
Change-Id: I6946e23e8491e9c896026b55315acf76bb50cb92
Reviewed-by: Cristian Adam <cristian.adam@qt.io>