Commit Graph

72811 Commits

Author SHA1 Message Date
hjk
605aace7d7 BinEditor: Remove BinEditor::modificationChanged() signal
Was only used to trigger IEditor::changed(). Do that directly instead.

Change-Id: I6cc659ac9be9496dbf8b463660754dd8779db94c
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-07-19 06:00:13 +00:00
hjk
a1eaaadbe9 RemoteLinux: Prevent step factory sharing by inheritance
This was the preferred way for a while, but has been superseded by
creating the steps by ID.

Not exposing the factory classes in a header prevents following
the old approach in downstream plugins.

Change-Id: Iaa89458a87602006f1a05fa142a34cc1f9d63c64
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-07-19 05:59:49 +00:00
hjk
60206de94f BinEditor: Simplify address field updates
Change-Id: Ia57348b25a28164061bca4f7cf336a9e9a555abb
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-07-19 05:56:42 +00:00
Christian Kandeler
484d63ffad Lua: Fix qbs build
Change-Id: Ia05a814838e98d5305dc6ddbffad2abc12aa75ad
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-07-19 04:30:14 +00:00
Jarek Kobus
0051d273d3 Various plugins: Remove unused variables
Found by Axivion plugin.

Change-Id: I628b00e4525b004c702dd8753af31cb3fedf1739
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-07-18 15:08:48 +00:00
Marco Bubke
a29ff454a6 QmlDesigner: Adding missing property error notifier
Alias properties are quite often broken. So we have to handle that
broken aliases.

Task-number: QDS-12761
Change-Id: Id9b53b98080733e5939de6b3761c923fa35e1dcf
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2024-07-18 14:56:10 +00:00
Jarek Kobus
4249bb56a3 ProjectExplorer: Remove redundant signals
The enabledChanged() signal is already a member of BaseAspect,
so no need to repeat this signal in subclasses.

Found by Axivion plugin.

Change-Id: Ifc12dc97e134ff1f873df2e5fa5830be55777b81
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-07-18 14:53:39 +00:00
Marco Bubke
6daee01869 QmlDesigner: Sort keys
Instead to trust programmers to add the entries sorted, we us an
constexpr to sort them.

Change-Id: I9129d3771d0451def726b230f8cd58e556c6b4be
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2024-07-18 13:08:24 +00:00
Ali Kianian
77ac3392bb QmlDesigner: Add texture name on creation
Fixes: QDS-13140
Change-Id: Icb5ef4a5f3d82ec9e21231c1cacebcf0f04d234e
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Shrief Gabr <shrief.gabr@qt.io>
2024-07-18 12:24:22 +00:00
Marcus Tillmanns
42e57d60ae Lua: Change TextDocument to TextEditor
Since there may be many editors editing a single TextDocument
it is more useful to start at the TextEditor level.

Change-Id: Ic1c4ea76f22ab0d0741edd6f6ecc24d6befa17e6
Reviewed-by: hjk <hjk@qt.io>
2024-07-18 12:06:34 +00:00
Marcus Tillmanns
2bcc21d598 Lua: Guard Hook connections
Change-Id: Id30c75093879b92321af864273c6d4ef390cf71a
Reviewed-by: hjk <hjk@qt.io>
2024-07-18 12:06:28 +00:00
Marcus Tillmanns
080713e872 Lua: Add change information to textdocument hook
Change-Id: Idc3eeae6881f8d8eb8a1547807489e86c201404c
Reviewed-by: hjk <hjk@qt.io>
2024-07-18 12:06:15 +00:00
hjk
07df45cdeb ProjectExplorer: Remove id/buildkey mangling support for runconfig
This was used for qmake and cmake up to Creator 4.11 (Dec 2019).
Projects created or touched afterwards are unharmed.

Projects created before that and not touched since then will lose
runconfigurations.

Change-Id: I745aa3641749462a0420df6f658055a78fd52c8e
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-07-18 11:50:01 +00:00
Jarek Kobus
6b31ff2960 Android: Make installQASIPackage() asynchronous
Reuse existing avd recipes and run a task tree instead.

Change-Id: Ieaeb84eee299d7f75101a3076027d4185533b897
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2024-07-18 11:47:18 +00:00
Jarek Kobus
cd7b635910 Debugger: Introduce createRegisterDelegate() helper
Merge RegisterDelegate with PeripheralRegisterDelegate
and use it in RegisterHandler and PeripheralRegisterHandler.

Change-Id: I55088bafa5701ef828095c9889d333d282848ab4
Reviewed-by: hjk <hjk@qt.io>
2024-07-18 11:39:40 +00:00
Eike Ziller
43a2974baa Sort language setting options
It was arbitrary from the file system.

Fixes: QTCREATORBUG-31262
Change-Id: I3b5a0940a59be85a61468b7fe7336ca481ffcc7a
Reviewed-by: hjk <hjk@qt.io>
2024-07-18 11:38:46 +00:00
hjk
d0cad6fff3 Debugger: Attach Context(CC::C_EDITORMANAGER) in main widget constructor
... when it is created, but don't force widget creation to be
able to attach the context.

Change-Id: I62a7610241e68d658f2b31fb98666d94fe6061d7
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-07-18 11:33:29 +00:00
Christian Kandeler
56e239988d Lua: Fix qbs build
Change-Id: I6f71619a067806a86c71f94fa61e76d08fcec7cf
Reviewed-by: hjk <hjk@qt.io>
2024-07-18 11:30:48 +00:00
hjk
d473a356e7 Utils: Remove unused TreeWidget class
Static QTreeWidgets are often clumsy to use and typically not what
we want to promote.

Change-Id: Ib7fa8172a60aad61508e118a93c0317b726efc13
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-07-18 11:27:03 +00:00
Leena Miettinen
b160b367d1 Doc: Fix QDoc warnings in Extending Qt Creator Manual
Change-Id: I278ae2338427a7d65253d579d0a1ff7d53245c45
Reviewed-by: hjk <hjk@qt.io>
2024-07-18 10:56:40 +00:00
hjk
35bc86d1a7 DiffEditor: Hide DiffEditor definition in .cpp
And use the new factory setup scheme.

Change-Id: I9b220e9995f82edc25e7cc43dbdbbbbcdac3cfd3
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-07-18 10:33:21 +00:00
hjk
41046c0d44 LayoutBuilder: Initialize BuilderItem::apply more directly
Also, add some timing information.

Change-Id: I5d38cac9e7ad0afb24504ff521f31d5202268462
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-07-18 09:59:01 +00:00
hjk
3e1da5b398 Core: Update IMode documentation
Change-Id: I1b663d38e964ecd7bb94c32edf00132385d8db2e
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-07-18 09:54:28 +00:00
Jarek Kobus
a8316ec372 AspectContainer: Remove redundant signal
The changed() signal is already a member of BaseAspect,
so no need to repeat this signal in a subclass.

Found by Axivion plugin.

Change-Id: I1376d494d8d308b41b42628c96278613d0b35837
Reviewed-by: hjk <hjk@qt.io>
2024-07-18 09:50:23 +00:00
hjk
9ca10fadb8 Utils: Add a simple way to make a Utils::TreeView searchable
Call setSearchRole(...) to create a suitable find aggregate.

Use it in a few places.

Change-Id: Iaa663d13bbc7776019e7b18ea720cc2411e0b691
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-07-18 09:37:53 +00:00
Eike Ziller
dbce96d888 CMake: Fix endless recursion if context help doesn't find anything
Amends baf20b8491

which removed the inheritance from the contextHelp method.
CMakeEditor now registers a context help function, which called
BaseTextEditor::contextHelp if no documentation was found, which was
correct when contextHelp was still virtual. Now
BaseTextEditor::contextHelp is the same as IContext::contextHelp which
calls the function that CMakeEditor registered again, leading to endless
recursion.

Change-Id: I912f69e0d0d3285c9fa77194f84b0819085c99b7
Reviewed-by: hjk <hjk@qt.io>
2024-07-18 08:23:12 +00:00
Marco Bubke
67c7beeffe QmlDesigner: Use Qt 6.7 for project storage
Change-Id: Ibf0df9a05dda2c3bbd2a55935e9471ebf40dcf64
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2024-07-18 08:03:07 +00:00
Marcus Tillmanns
ed6228fd95 Lua: Fix lsp meta files
Change-Id: If4c9b47164e642f084b4b27820cd867922e28ad1
Reviewed-by: hjk <hjk@qt.io>
2024-07-18 07:19:27 +00:00
Marcus Tillmanns
d2e14ffe86 Lua: Cleanup Hooks
Change-Id: I8e3a1d66ea6125d2cc5ee9c8f8442cca0913fec6
Reviewed-by: <lie@spyro-soft.com>
Reviewed-by: hjk <hjk@qt.io>
2024-07-18 07:19:15 +00:00
Marcus Tillmanns
0e75f3f4f3 Lua: Add LocalSocket
Change-Id: I6601914176667100ad9007fa5e54f6d6c3f445a0
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2024-07-18 07:04:14 +00:00
Marcus Tillmanns
3dfd1dd1a9 Lua: Add Json module
Change-Id: I533dc63b5147f00ac377e80a338cc4e2e3d0e8d9
Reviewed-by: hjk <hjk@qt.io>
2024-07-18 07:03:59 +00:00
Jarek Kobus
59c10c1274 Android: Make AndroidDeployQtStep::runRecipe() thread safe
Reuse existing avd recipes and run a task tree instead.

Change-Id: I515e15aac8e047b6da72d7604a033824e1b99107
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2024-07-17 16:49:38 +00:00
Jarek Kobus
33e548d52b GitGrep: Remove unused field
Change-Id: I362f84401ce0bd64a39fc32e5877b9f642c0f616
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2024-07-17 16:38:36 +00:00
Jarek Kobus
662e5bce2d DiffEditor: Remove unused methods
Change-Id: I9e0d1fc5d75688a636208774be90a9c0d1ad502f
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2024-07-17 16:23:53 +00:00
Jarek Kobus
eca1fa3b2f Android: Fix a crash on Creator shutdown during app startup
The AndroidRunnerWorker lives in a separate thread created
by AndroidRunner. Thus, we can't delete it directly from
the AndroidRunner's d'tor. Instead, we connect to QThread's
finished() signal and delete the worker later.

Make m_pidRunner a child of AndroidRunnerWorker so that
it's moved together with its parent to the other thread.

Change-Id: I5c3723315ee5183fa8451f0706311b14f173dca1
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2024-07-17 16:15:47 +00:00
Jarek Kobus
77fa73c524 Android: Fix potential process leak
Make process a child of Target.

Change-Id: If77a54120044829b6551cd0f6446e3edffa28558
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2024-07-17 15:46:25 +00:00
Jarek Kobus
2b620aca7e Android: Fix installQASIPackage() command
Currently the installation always fails with the following
message on std err:
No argument expected after "-r ".

Removing the space after the -r arg seems to fix the issue
and process finishes with success.

Change-Id: I035442da0168580939f9b851554e8ec96713f99e
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2024-07-17 15:46:16 +00:00
Jarek Kobus
2db96fcbca Android: Be more verbose on installQASIPackage()
Change-Id: I661b94114e912087b1fd8d15db7cd86088a4749e
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2024-07-17 15:46:05 +00:00
Alessandro Portale
3fe4928626 Use QObjectList alias
Change-Id: I11d4071088e2b44c37d4a8ac59945fe49fe68351
Reviewed-by: hjk <hjk@qt.io>
2024-07-17 15:14:33 +00:00
Cristian Adam
bef8cf703d CMakePM: Mark CMake presets registered toolchains as Manual
By default are marked as Autodetected, which is not the case for CMake
presets.

Fixes: QTCREATORBUG-31255
Change-Id: I5c3da7c6e7c68a8a2e80e415393010121b33efb4
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2024-07-17 14:53:50 +00:00
Jarek Kobus
c343e9b8f7 TaskTree: Fix For loop with empty body
Ensure the For loop iterates even when the loop's body is empty.
Simplify internals a bit.

Change-Id: I4a269d61fa324a9c36109e95e74a992e915a72b0
Reviewed-by: hjk <hjk@qt.io>
2024-07-17 14:48:03 +00:00
Alessandro Portale
d4819fa01c ExtensionManager: Don't strip empty lines from description text
Empty lines play a crucial role since we now interpret the description
text as Markdown.

Change-Id: Idad3996bde4183145d6ba1c092536c4c52fa6457
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2024-07-17 14:34:30 +00:00
Marcus Tillmanns
26d91b3ead Lua: Add Utils.pid
Change-Id: I2f598639b0ebc77216e0286b59445e91967fabe0
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-07-17 14:17:11 +00:00
hjk
4a7c8d9ec5 BinEditor: Clean up Widget setup phase
Change-Id: I91ef2968416a8629046992664e8bea7d79c109ca
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-07-17 14:11:59 +00:00
Tim Jenssen
19f5099c93 StudioWelcome: fix crashes when setupWizard fails
Task-number: QDS-13209
Change-Id: I5751de9d5a5c8065a7cbad91c048d7d4d60de238
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2024-07-17 14:03:43 +00:00
Alessandro Portale
3ea8c7808e ExtensionManager: Interpret description text as MarkDown
Task-number: QTCREATORBUG-31199
Fixes: QTCREATORBUG-31182
Change-Id: Iff0ec94db67b3afcad024b2fec4797805f1123e8
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2024-07-17 13:36:45 +00:00
Christian Stenger
49bb87287c Core: Fix include
Amends 0fba429032.

Change-Id: I47063d820ca65a852bc4ef9b5c96f380421e3c41
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-07-17 13:20:58 +00:00
hjk
3fd60717eb Utils: Remove unnecessary export macros in builderutils.h
All templates/inline here.

Change-Id: Ib5770f6e700e5368bb23cae3dcf57bdf8a372897
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-07-17 12:50:33 +00:00
hjk
552b839a49 BinEditor: Make BinEditorDocument independent of BinEditorWidget
Change-Id: I9f7b9f322a8c1b4757c5932262019b1e26150339
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-07-17 12:50:21 +00:00
hjk
1a425ee79f Utils: Dismantle ArgTuple
Change-Id: I5810beef15956fb067dece35f59aecaa26149dea
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-07-17 12:40:00 +00:00