On some platforms, after pressing Ctrl+Tab to switch files and then
releasing Ctrl, the chooser didn't close because the key event claimed
both that Ctrl was the released key but Ctrl was still pressed. Add a
workaround.
Fixes: QTCREATORBUG-31228
Task-number: QTCREATORBUG-27378
Change-Id: Ifd83e655f0d3dca7e15dfbd822ec1893045b304c
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
activateView / setCurrentView will already have send
currentEditorChanged(nullptr) and called updateActions
Change-Id: I72c2d3befe207f3ec4a9718ce52a31a967f698b0
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
QFileDialog::saveFileContent opens a non-modal file dialog which can
disappear in the backgtound. Also, on Windows, the dialog is non-native.
Use FileUtils::getSaveFilePath and FileSaver, instead.
Task-number: QTCREATORBUG-31099
Change-Id: I0c84e149183f632e325b2e62ee9b1c7d7726f207
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
After 83111bb3, the path validity result was coming in later and
was not considered for the page completeness check any more.
Fix that by running the check again when the path result is ready.
Change-Id: I2aab6b2130896d63f7e0359ced39e758393a2644
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Avoid making the dialog larger than the screen.
Also remove the special handling for single files.
Fixes: QTCREATORBUG-31161
Change-Id: I5a85834505351493c51ee708c81527147d1a1270
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
The settings can be deleted by the LanguageClientManager
so we just use the settings id instead.
Change-Id: I03f0d4184a12c69f6cd8c74705ab8e1d01b15ec6
Reviewed-by: David Schulz <david.schulz@qt.io>
It seems the keypad modifier is almost always set, but the alt modifier
blocks usable shortcuts.
Change-Id: I09e5d3a07bdc7ca2f81c3822097c412db2e212bd
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
This doesn't use any of the extra features.
Change-Id: I5533f567568755a04a9cf80dd32cdda475abf738
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
GCC 14.1.1 claims a dangling reference when using make_pair(). Using the
constructor instead makes the warning go away.
Change-Id: I10b4af781c36a6ae4d5a525e875cd369d2a051b6
Reviewed-by: hjk <hjk@qt.io>
Due to the removal of the widget where users could generate settings
using BasedOnStyle and see all available properties, users now need
to have the ability to load their files or generated files.
- Implemented functionality to export internal .clang-format to an
external file
- Added import capability to load ClangFormat style from an external
file
- Added to the ICodeStylePreferencesFactory function
createSelectorWidget for the possibility of reimplementing the
functionality of export and import buttons
Change-Id: Ib5f00a0fb58a983d0e7c6dc55128e93d0205d3ca
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Later to be renamed to GerritSettings, and possibly using aspects.
Change-Id: Idd3d9d3de4f9827478129fe210abfa7b80cff84d
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Use a singleton for the main settings, don't pass it around as
shared pointer.
Change-Id: I5c32679452ad631998a688afc9a6e2b154bf3a5d
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Don't create a permanent thread for just one parsing.
Use TaskTree with async recipe instead.
Change-Id: I8eef0082c5d39a45fb0d8751c632ba02a955faef
Reviewed-by: hjk <hjk@qt.io>
Combine files; remove pointers Q_ASSERT that effectively don't check anything
as they are dereferenced immediately; using namespace Utils, ...
Change-Id: Iefbc4c9e9de3ac6e499bf6caea04503b8c796e3d
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
CMake Project Manager is using a small CMake project as a compiler probe
when a CMake preset is being setup. Now this CMake project is saving
more variable as cache variables.
These CMake variables could be only visible inside the CMake preset
probe project via a CMake toolchain file.
CMAKE_SYSROOT was important to be set in the Kit. The CMAKE_C|
XX_COMPILER_TARGET variables are set to override the original triplet
for the code model.
Fixes: QTCREATORBUG-31249
Change-Id: I3c3294b839629c22ce760596b92b2b393eed6a8b
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
This was not in use since 2fe69b60 in 2015 without anyone complaining.
Change-Id: Iccc4a230a008b8dff5b08faa5cb1ae513c4c0360
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
... that are started by an indented preprocessor directive.
clangd potentially sends regions not starting at line boundaries (in
this case erroneously, but potentially also on purpose), which
TextDocument::setIfdefedOutBlocks() does not expect.
Fixes: QTCREATORBUG-31204
Change-Id: I9126263b9501edbbab1fbc22cc59c5ee1ae814c2
Reviewed-by: David Schulz <david.schulz@qt.io>
