When scheduling a new async run (via FindUses::find()), keep track
for the canceled futures, otherwise they may still be running
after the shutdown. So, add all new futures into the future synchronizer
(without canceling them).
Task-number: QTCREATORBUG-30401
Change-Id: I83a82f706175060f7f29886b57c69c77667a0805
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
As it's not clear whether canceled future may continue to run
when the SemanticHighlighter instance is destructed,
add internal FutureSynchronizer that ensures that all old,
canceled futures are finished from the SemanticHighlighter's
d'tor.
Change-Id: I3128999f1250d666fcc3aa04599bb4a9c675ca3e
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Adds a setting to enable highlighting issue markers on the
highlighter scrollbar.
Change-Id: I173510ccb75e684325135d8e587e8920ad22bd86
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
As all dtos are json objects (or at least json arrays), the
std::domain_error shouldn't appear in the wild either.
Change-Id: Ib926e0c454f9eacabf8546fb0a4038fcd153715b
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
These components are autogenerated and overwritten by effect composer,
so a regular user has no reason to modify them manually.
Fixes: QDS-9020
Change-Id: Ida6706f123a8304944a19364c59620b8d9b4adbb
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Remove trailing spaces. Ensure the address ends with '/'.
Change-Id: I5f51e89183e0e62c8d7d5c0cb7871477542e37d5
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This might be useful for checking the integrality of tasks'
invocations and detecting the unwanted asynchronity in the task tree
execution.
Example: we may want to ensure that the setup handler of the 2nd task
was executed synchronously after the done handler of the 1st task,
without returning the control to the event loop.
This addresses the 34th point in the bugreport below.
Task-number: QTCREATORBUG-28741
Change-Id: I7213ee62a7555818cbe18fd7bb8362353a3be8ae
Reviewed-by: hjk <hjk@qt.io>
* Creating ListView will be postponed when the dataStore is just created
so that the model manager can update the information of DataStore.
* The initial delegate and model for the listview are faked in order to
show the same shape before and after the assignment.
Change-Id: I45ac7486890556136ca98fc131f90896efc3b839
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
* A default color model will be created and assigned to the ListView
when a ListView is dropped to the view.
* The user can edit the assigned collection of the list model by having
access to an action in the context menu of the form editor.
Task-number: QDS-11671
Fixes: QDS-11792
Change-Id: I70252f6e34ccbc95d8b700459f45a11a76c81c50
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Although it is not a navigation widget as such, it is
expected to have this separated and beside the editor.
This patch moves the widget to the right side bar by
default.
Change-Id: If46bedaf7bf475a46dbfd8bee1e121c659740856
Reviewed-by: hjk <hjk@qt.io>
Instead of scrolling to the first element in the selection, scroll to
the last. This will keep the existing behavior for single selection
and will fix the behavior for multi selection.
Task-number: QDS-9794
Change-Id: I846c6ea6b967ef76a77d4ea0fc819d06772eca01
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
ExecutableItem is a common base for Group, CustomTask and Sync elements.
Move withTimeout() here, as this is relevant only for executable items.
It's going to be a place for additional API, e.g. withLog().
Task-number: QTCREATORBUG-28741
Change-Id: Ibcd6b34c389af4f41f56fd242b14fad6c0c579b2
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
Introduce dtoRecipe() function which replaces both getDtoRecipe()
and postDtoRecipe().
Change-Id: Icbf97779869598c4fcc9bc19a520c9bd67df75d4
Reviewed-by: hjk <hjk@qt.io>
Remove it also from aspect container.
Change-Id: I0af093bbd5654083dac581e5793ec57e1c7a7b3d
Reviewed-by: Andreas Loth <andreas.loth@qt.io>
Reviewed-by: hjk <hjk@qt.io>
The ApiToken is stored locally safely by using QKeychain lib.
If the local store doesn't contain the ApiToken,
we show the password input dialog to the user.
If the user pressed OK, we send a network query to axivion
server to retrieve the ApiToken for the username + password.
Change-Id: I0dc19aea67750cd674ae4db9a9f469e4621c713b
Reviewed-by: hjk <hjk@qt.io>
Don't report an error on non-existing key read.
Finish with success and provide empty optional data in this case.
Change-Id: I7c4ea50c0f05e13ce793384ec57d50dfff600c9a
Reviewed-by: hjk <hjk@qt.io>
Use std::unique_ptr instead, as QScopedPointer doesn't offer release().
Change-Id: I8e885e477d1aeb8ce9462e8fd249a5196424df18
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Selecting a window from the Window menu didn't bring up minimized
windows from their minimized state, and resulted in two items being
checked in the window list (because the active window did not change, so
the checkmarks where not updated).
Change-Id: Ie89b87fa1273378bb99f69026a58ee92ea0b8f50
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: David Schulz <david.schulz@qt.io>
After a window is closed we don't only have to update the texts of the
action, but also update their visibility state and the checked item.
Fixes: QTCREATORBUG-30381
Change-Id: Id0c343b8a5930ec2e3de03f71bdc8f2628b492b3
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
When opening new editor windows, we want the _window_ to have the
EditorManager context as well as the individual window context, but the
window _actions_ (close, etc) may only be registered for the individual
window context.
Add the corresponding option to ICore::registerWindow et al.
Change-Id: I67d0a6b386603e0047a77dfb357c207e7ffe99e6
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
This does not yet fix the reported problem but at least attaches and
gives a working QML inspector in a QML-only debugging session.
Task-number: QTCREATORBUG-30263
Change-Id: Ieac517c2b7c5dde24792f3bbcffe0058073ddbd1
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
So if the device turns out to be unresponsive, users will not be
confused about the temporary freeze.
Task-number: QTCREATORBUG-30319
Change-Id: If65d6ea2777232239c8fb324b06352d92ad451c6
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Calling QToolButton::setCheckable on a button with a defaultAction
doesn't work as expected. It needs to be called on the action itself.
Amends acedf93ba3
Fixes: QTCREATORBUG-30382
Change-Id: Icbddb1d331fe6547622bf0428d890012fef0d9c5
Reviewed-by: David Schulz <david.schulz@qt.io>
